[BETA] PQRotation - an automated ability priority queue.

[Xelper]

So the difference is 0.25 and in the long run that a rather big DPS decrease.
I dont know if this happened from last PQR version or was earlier.

What is your latency?

EDIT: Oh right, if you just had a blank profile that spammed fireball and are using v2.0.3, yes... that would have been part of the bug that I fixed in v2.0.4 where a recast delay was incorrectly being applied to a spell. It wouldn't have casted that spell until the cast had finished which means no pre-casting prior to being off GCD.

[MastaRage]

PQR v2.0.4
Download Here

-Bugfix that caused a recast delay to be applied to a spell without a recast delay. Was comparing "0" to 0, which was returning false.

Say what, 0=0, at least not 0/0 or it would have been the end of the world. Thanks for quick fix.

[Xelper]

Say what, 0=0, at least not 0/0 or it would have been the end of the world. Thanks for quick fix.

string "0" is not the same as number 0.

/script print(0 == "0")
vs.
/script print(0 == 0)

[bu_ba_911]

Thank You Valma/Bu_ba/Kickmydog/Xelper/Firepong/MENTALLY!!!!!. The profiles you guys made are outstanding. If it would allow me to give Rep i would give you guys all the rep i could give. Thank you again for all the hard work you guys put into these.

lol saw u edited this...... but no offense.... you did still leave our Sheuron

[fluxflux]

@fluxflux: I don't think that's possible through LUA alone. What you could do is setup a table and call the TargetUnit function, e.g. something like this as a possibility:

local myTable = {
	-- Set autoTarget to true or false, to allow automatic targeting of the unit
	-- All names are strictly case-sensitive!
	{unitName = "Twilight Assault Drake", autoTarget = true},
	{unitName = "Twilight Assassin", autoTarget = true}
	{unitName = "Raider's Training Dummy", autoTarget = true},
	{unitName = "Arm Tentacle", autoTarget = true},
	{unitName = "Wing Tentacle", autoTarget = true},
	{unitName = "Mutated Corruption", autoTarget = true},
	{unitName = "Mana Void", autoTarget = true},
	{unitName = "Elementium Bolt", autoTarget = true},
	{unitName = "Burning Tendons", autoTarget = true},
	{unitName = "Warmaster Blackhorn", autoTarget = true},
	{unitName = "Goriona", autoTarget = true}
}
for i=1,#myTable do
	if myTable[i].autoTarget == true then
		if not UnitExists("target") then
			-- Fetch a target
			TargetUnit(myTable[i].unitName, true)
			return false
		else
			-- Are we in range?
			if IsSpellInRange(GetSpellInfo(8092), "target") == 1
				and not UnitIsDeadOrGhost("target")
				and UnitCanAttack("player","target")
			then return true else ClearTarget() return false end
		end
	end
end

This should try and automatically target a unit matching the exact name (I can't stress that enough), closest to you. I added in Raider's Training Dummy for convenience reason, if you want to check it out, paste this code into an ability with ID 0, set the delay to 100-200 and place the ability at the top of your rotation. Then start it up and test to see if it targets anything.

Update:
Updated the coding a little bit.. Should help validate a target in case of multiple entries.
However, I probably won't ever support this kind of targeting and probably won't use it within my own profiles because I feel and want the people using it to learn from it, while actually actively playing their class, rather than PQR doing everything for them.

i have this error

Message: [string "..."]:541: attempt to call field '?' (a nil value)
Time: 03/15/12 17:13:14
Count: 290
Stack: [C]: in function `?'
[string "..."]:541: in function `PQR_NextAbility'
[string "..."]:363: in function `PQR_ExecuteRotation'
[string "..."]:137: in function <[string "..."]:72>

Locals

[Kinky]

@a9058727: Fire away. :P You can speed that code up quite a bit though!

local BleedDebuff = BleedDebuff -- Localize the function variable first and foremost
function BleedDebuff(t)
    local Bleeds = { 
		16511, -- Rogue, Hemorrhage
		33876, -- Druid, Cat: Mangle
		33878, -- Druid, Bear: Mangle
		35290, -- Hunter Pet: Gore
		46857, -- Warrior, Trauma
		50271, -- Hunter Pet: Tendon Rip
		57386, -- Hunter Pet: Stampede
    }
    for i=1,#Bleeds do
		if UnitDebuffID(t,Bleeds[i]) then return true else return false end
	end
end

-- Now BleedDebuff() returns either true or false which speeds things up a bit
if BleedDebuff("target") then return false else return true end

It doesn't speed it up by anything noticeable, but, over-time it will make it a lot faster if you have a lot of code in the same ability this is called.
If you split it up and put the function into another "ability", by all means, localize the function first. :P

Take it like this. All global variables are like stars in the universe. Trying to pinpoint every single global call is gonna take some CPU power, the more globals, the more power it draws, if you localize the global variable you want to use (you essentially create a "local" copy of the global variable) it tells the program/addon exactl where/when/how to grab it and pinpoint it exactly where you want it, optimizing and speeding up your code considerably.

Just send me a PM if you are ever wondering about anything, you can pretty much do the same with Valma and Bu_ba iirc as well.

- Elizabeth

Edit:
@fluxflux: As bu_ba_911 pointed out bellow my post, try removing the part marked in red! (Unsure how it calls the exactMatch setting.)

[bu_ba_911]

TargetUnit(myTable[i].unitName, true)

i think that's the issue

[bu_ba_911]

I know bu_ba and I have already exchanged an email or two in the past, but I know everyone is busy (especially mentally) which is why it's kind of an open call. :P

lol feel free to email me again any time or in game pm, i'd probably see pm faster, but email gives me more room to maneuver code with haha

[ziggar]

Hey cokx your inbox seems full.

Also bubba the holy profile seems to be working fine , did some pve with it yesterday and no problemos that i could see .

[bu_ba_911]

Hey cokx your inbox seems full.

Also bubba the holy profile seems to be working fine , did some pve with it yesterday and no problemos that i could see .

sweet

next version hopefully will be more mana efficient for raiders (it spammed HR way to much imo )

and it will also show level 85's how they can customize it from dungeons, and how to customize it for raids XD

[Kinky]

@Xelper: Absolutely awesome. Thanks for the quick fix!

[fluxflux]

local myTable = {
-- Set autoTarget to true or false, to allow automatic targeting of the unit
-- All names are strictly case-sensitive!
{unitName = "Twilight Assault Drake", autoTarget = true},
{unitName = "Twilight Assassin", autoTarget = true}
{unitName = "Raider's Training Dummy", autoTarget = true},
{unitName = "Arm Tentacle", autoTarget = true},
{unitName = "Wing Tentacle", autoTarget = true},
{unitName = "Mutated Corruption", autoTarget = true},
{unitName = "Mana Void", autoTarget = true},
{unitName = "Elementium Bolt", autoTarget = true},
{unitName = "Burning Tendons", autoTarget = true},
{unitName = "Warmaster Blackhorn", autoTarget = true},
{unitName = "Goriona", autoTarget = true}
}
for i=1,#myTable do
if myTable[i].autoTarget == true then
if not UnitExists("target") then
-- Fetch a target
TargetUnit(myTable[i].unitName, true)
return false
else
-- Are we in range?
if IsSpellInRange(GetSpellInfo(8092), "target") == 1
and not UnitIsDeadOrGhost("target")
and UnitCanAttack("player","target")
then return true else ClearTarget() return false end
end
end
end

the red marks change?

i dont unterstand is not working

[cukiemunster]

Ok, my next question is does anyone know how to incorporate the use of Healthstone into a profile? So it uses it at x% health? I quite simply fail at remembering to use lock stones in the heat of battle lol.

[Kinky]

@fluxflux: Here

local myTable = {
	-- Set autoTarget to true or false, to allow automatic targeting of the unit
	-- All names are strictly case-sensitive!
	{unitName = "Twilight Assault Drake", autoTarget = true},
	{unitName = "Twilight Assassin", autoTarget = true}
	{unitName = "Raider's Training Dummy", autoTarget = true},
	{unitName = "Arm Tentacle", autoTarget = true},
	{unitName = "Wing Tentacle", autoTarget = true},
	{unitName = "Mutated Corruption", autoTarget = true},
	{unitName = "Mana Void", autoTarget = true},
	{unitName = "Elementium Bolt", autoTarget = true},
	{unitName = "Burning Tendons", autoTarget = true},
	{unitName = "Warmaster Blackhorn", autoTarget = true},
	{unitName = "Goriona", autoTarget = true}
}
for i=1,#myTable do
	if myTable[i].autoTarget == true then
		if not UnitExists("target") then
			-- Fetch a target
			TargetUnit(myTable[i].unitName)
			return false
		else
			-- Are we in range?
			if IsSpellInRange(GetSpellInfo(8092), "target") == 1
				and not UnitIsDeadOrGhost("target")
				and UnitCanAttack("player","target")
			then return true else ClearTarget() return false end
		end
	end
end

[fluxflux]

yes i have test it but not working