[BETA] PQRotation - an automated ability priority queue.

[onion88]

Hey xepler, quick question.
Earlier in the thread Firepong suggested making your custom lag tolerence home + world + 250. I was wandering if this applies to all profiles, or just his. Because my home and world are both 21, almost always, and when i added 250, it seemed a little buggy.

[firepong]

Hey xepler, quick question.
Earlier in the thread Firepong suggested making your custom lag tolerence home + world + 250. I was wandering if this applies to all profiles, or just his. Because my home and world are both 21, almost always, and when i added 250, it seemed a little buggy.

all this really does is let the spell queue up on WoW's server ahead of time. That way, when the current spell being cast is finished, the next spell is already in queue and ready to go. It minimizes downtime of the rotation. A lot of the rotations here on the site work better when you do this.

With that being said, it's best to mess around with the lag Tolerance to find the best that works for you. Just that for most people, world + home + 250 works fine.

[me28791]

all this really does is let the spell queue up on WoW's server ahead of time. That way, when the current spell being cast is finished, the next spell is already in queue and ready to go. It minimizes downtime of the rotation. A lot of the rotations here on the site work better when you do this.

With that being said, it's best to mess around with the lag Tolerance to find the best that works for you. Just that for most people, world + home + 250 works fine.

unless you live in australia where wow doesnt have a lag tolerance high enough to cover that

[cokx]

Was wondering if you could explain how ret smart cleanse is different than regular cleanse? I just want fears added to it's cleanse priority.

Anyways, good work I am at 2kcr in RBG's with your profile.

you cant dispel fear as a ret (cause its magic)
ret has two cleanse abilitys in my profile
first is when you are slowed an cant reach your target
second is when you have nothing else to do it will cleane your whole raid from poisons and diseases

[Gabbz]

Noticed something strange with the 2.0.3 version.
It skips spells sometimes.
I have Fireball setup like this

if PQR_IsMoving(1) == false 
then return true end

And after that in rotation Scorch

return true

But everyother cast it cast scorch instead of fireball when standing still nuking the Dummy.
Started happening after i DL newest version

[cokx]

Noticed something strange with the 2.0.3 version.
It skips spells sometimes.
I have Fireball setup like this

if PQR_IsMoving(1) == false 
then return true end

And after that in rotation Scorch

return true

But everyother cast it cast scorch instead of fireball when standing still nuking the Dummy.
Started happening after i DL newest version

change your latency to a higher number or add a delay to your casts

[Gorthok]

@Xhelper,

Question, if 2.0 was a basic rewrite why not supporting 64 bit yet? or both versions in one would be amazing.

Edit: and on a side note, My profiles are working without any modifications. I guess call me a purest -.-

[Kinky]

@Gabbz:

if not PQR_IsMoving(0.3) then return false
else return true end

Set the Delay in the ability editor to 200-500 and you're gold.

[Gabbz]

So instead of fixing the problem i need to do a workaround?

PQR_IsMoving is a function that should check if i am moving or not. Why should i need to change my latency or something else when the function just need to check if i am moving or not.

[Valma]

Actually problem is not in this function,but in new setrecastdelay of 2.03.

Xelper mistaken somewhere and program sets recast > spellcasttime.

Seems like he is adding latency to casttime instead of substracking it.

This is the breakpoint that I've stated to him many times.Chaincasting spells will fail.Thats all.

[Kinky]

@Gabbz: Actually, it was never a work-around, it was simply a change in your logic and the sensitivity of PQR_IsMoving. (from detecting every second to 0.3 seconds) Why you say that is beyond me. All though after some testing, it turns out that Valma is right on the dot for what the problem is.

[fluxflux]

@ mentally how i can set autotarget(focus) like assault drakes sapper etc from ds into your profiles?

the idea iss that the script switch automatic to different targets like blackhorn the drakes in the air?

NEED MULTI DOT BOT ^^

/tar arm tent
/tar wing tent
/tar mutat
/tar elementium bo
/tar mana void
/tar burning tend
/tar warmast
/tar goriona
/tar twilight assa
/tar twilight sapp

and many more^^

[Xelper]

Actually problem is not in this function,but in new setrecastdelay of 2.03.

Xelper mistaken somewhere and program sets recast > spellcasttime.

Seems like he is adding latency to casttime instead of substracking it.

This is the breakpoint that I've stated to him many times.Chaincasting spells will fail.Thats all.

I do not add a recast delay for any spell that does not have a recast delay, chaincasting spells will not fail. If the recastDelay is 0, I do not even add the cast time. SetRecastDelay also has nothing to do with latency, it is only the time before that ability can be reused.

Lets take Unstable Affliction for example, which has a cast time of 1.5sec. We will give it a recast delay of 1000 ms.

Seconds | Notes
0.00 | Start Casting, set this abilities recast delay to 2.5 seconds (1.5 sec cast + 1000ms)
0.50 | Still Casting, this ability currently has a delay set to 2 seconds in the future.
1.00 | Still Casting, this ability currently has a delay set to 1.5 seconds in the future.
1.50 | Finish Casting, there should be 1000ms left on the recast delay anyway, but set it to 1000ms anyway (and for support of instant cast spells.)
2.50 | Recast delay is over, and is now available for cast.

Now if we gave UA a 0 second recast delay:
0.00 | Start Casting, no recast delay, so do not add anything.
0.50 | Still Casting, we never set a recast delay so it still wont have one.
1.50 | Finish casting, no recast delay, so do not add anything

The new SetRecastDelay code is working fine.

--

I will however look into PQR_IsMoving()

[Kinky]

@fluxflux: I don't think that's possible through LUA alone. What you could do is setup a table and call the TargetUnit function, e.g. something like this as a possibility:

local myTable = {
	-- Set autoTarget to true or false, to allow automatic targeting of the unit
	-- All names are strictly case-sensitive!
	{unitName = "Twilight Assault Drake", autoTarget = true},
	{unitName = "Twilight Assassin", autoTarget = true}
	{unitName = "Raider's Training Dummy", autoTarget = true},
	{unitName = "Arm Tentacle", autoTarget = true},
	{unitName = "Wing Tentacle", autoTarget = true},
	{unitName = "Mutated Corruption", autoTarget = true},
	{unitName = "Mana Void", autoTarget = true},
	{unitName = "Elementium Bolt", autoTarget = true},
	{unitName = "Burning Tendons", autoTarget = true},
	{unitName = "Warmaster Blackhorn", autoTarget = true},
	{unitName = "Goriona", autoTarget = true}
}
for i=1,#myTable do
	if myTable[i].autoTarget == true then
		if not UnitExists("target") then
			-- Fetch a target
			TargetUnit(myTable[i].unitName, true)
			return false
		else
			-- Are we in range?
			if IsSpellInRange(GetSpellInfo(8092), "target") == 1
				and not UnitIsDeadOrGhost("target")
				and UnitCanAttack("player","target")
			then return true else ClearTarget() return false end
		end
	end
end

This should try and automatically target a unit matching the exact name (I can't stress that enough), closest to you. I added in Raider's Training Dummy for convenience reason, if you want to check it out, paste this code into an ability with ID 0, set the delay to 100-200 and place the ability at the top of your rotation. Then start it up and test to see if it targets anything.

Update:
Updated the coding a little bit.. Should help validate a target in case of multiple entries.
However, I probably won't ever support this kind of targeting and probably won't use it within my own profiles because I feel and want the people using it to learn from it, while actually actively playing their class, rather than PQR doing everything for them.

[Valma]

I do not add a recast delay for any spell that does not have a recast delay, chaincasting spells will not fail. If the recastDelay is 0, I do not even add the cast time. SetRecastDelay also has nothing to do with latency, it is only the time before that ability can be reused.

Lets take Unstable Affliction for example, which has a cast time of 1.5sec. We will give it a recast delay of 1000 ms.

Seconds | Notes
0.00 | Start Casting, set this abilities recast delay to 2.5 seconds (1.5 sec cast + 1000ms)
0.50 | Still Casting, this ability currently has a delay set to 2 seconds in the future.
1.00 | Still Casting, this ability currently has a delay set to 1.5 seconds in the future.
1.50 | Finish Casting, there should be 1000ms left on the recast delay anyway, but set it to 1000ms anyway (and for support of instant cast spells.)
2.50 | Recast delay is over, and is now available for cast.

Now if we gave UA a 0 second recast delay:
0.00 | Start Casting, no recast delay, so do not add anything.
0.50 | Still Casting, we never set a recast delay so it still wont have one.
1.50 | Finish casting, no recast delay, so do not add anything

The new SetRecastDelay code is working fine.

--

I will however look into PQR_IsMoving()

OK,you read it wrong (: You forgot about your spellavailable check(which is -50ms by default if I remember right).
So actually we got this:

casttime 1500 ms recastdelay 0 ms spellavailable -50ms GCD(!!!) 1200 ms
0.00 | recast set to 1500 GCD left 1200 program not trying to cast anything
0.50 | still 1000 ms left on recast GCD left 700 program not trying to cast anything
1.15 | -->MAGIC HERE<-- 350 ms left on recast GCD left 50 ms ==> from this point program assumes that ALL OTHER spells without delay is available so the next spell in rotation is available and it STARTS to cast it.
1.50 | spellcasting ends and recast set to 0 BUT(!!!) we already got next spell sent to server and due to lag tolerance and latency serverside you are ALREADY casting this spell so program will indeed TRY to send needed spell to server,but server assumes you are already casting another spell(which is lower in rotation and is not intended to be cast)

What can you do to fix this?OK 2 ways:
1. Dunno why you still not adding this but substracting LATENCY from recast EVERY time you calculate it.
2. Substract minimumspellavailabletime(or whatever you name it,sorry I forgot) EVERY time you calculate recast.