[BETA] PQRotation - an automated ability priority queue.

[phantom325]

This is normal. Just copy the profiles from your previous install of PQR to their respective Class Folders under Profiles.

Alright, thanks, was just wondering why they weren't showing. I thought it was just an error I was having, thanks for clearing it up, +rep

[Xelper]

Now that I added the "Download Offsets" button I've actually decided to do a few more things with downloading updates.

I'm actually writing an update PQR application, that if/when you run it, goes and downloads the latest exe... hopefully that should reduce the burdens of updating.

I'm also giving profile developers the ability to use a "Download Update" button. If you click Download Updates it will download the two XMLs, prompt the user with the current version as well as the downloaded version, and give the user the option to accept the XMLs or not. Quick preview:

[abndrew82]

Now that I added the "Download Offsets" button I've actually decided to do a few more things with downloading updates.

I'm actually writing an update PQR application, that if/when you run it, goes and downloads the latest exe... hopefully that should reduce the burdens of updating.

I'm also giving profile developers the ability to use a "Download Update" button. If you click Download Updates it will download the two XMLs, prompt the user with the current version as well as the downloaded version, and give the user the option to accept the XMLs or not. Quick preview:

That sounds awesome

[Ninifay]

Is this bannable to use?

[expunge]

Is this bannable to use?

Yes. (10 chars)

[bu_ba_911]

I like this idea a lot Xelper, ty for offering it!!!

[firepong]

I like this idea a lot Xelper, ty for offering it!!!

Now all we need is a way for it to pull git code Would be perfect then lol

[bu_ba_911]

@fluxlfux:

local myTable = {
	"Twilight Assault Drake",
	"Twilight Assassin",
	"Raider's Training Dummy",
	"Arm Tentacle",
	"Wing Tentacle",
	"Mutated Corruption",
	"Mana Void",
	"Elementium Bolt",
	"Burning Tendons",
	"Warmaster Blackhorn",
	"Goriona"
}
for i=1,#myTable do
	if not UnitExists("target") then
		RunMacroText("/tar "..myTable[i])
	else
		if IsSpellInRange(GetSpellInfo(8092), "target") == 1
			and not UnitIsDeadOrGhost("target")
			and UnitCanAttack("player","target")
			and not PQR_IsOutOfSight("target", 1)
		then return true else RunMacroText("/cleartarget") end
	end
end

Fixed, should automatically target an enemy and clear your current target if:
- You walk out of a 40 yard range
- Target is dead
- You can't attack the target anymore

local myTable = {
	"Twilight Assault Drake",
	"Twilight Assassin",
	"Raider's Training Dummy",
	"Arm Tentacle",
	"Wing Tentacle",
	"Mutated Corruption",
	"Mana Void",
	"Elementium Bolt",
	"Burning Tendons",
	"Warmaster Blackhorn",
	"Goriona"
}
for i=1,#myTable do
	if not UnitExists("target") then
		RunMacroText("/tar "..myTable[i])
	else
		if IsSpellInRange(GetSpellInfo(20271), "target") == 1
			and not UnitIsDeadOrGhost("target") -- Can't have this enabled to test Dummies
			and UnitCanAttack("player","target")
			and not PQR_IsOutOfSight("target", 1)
		then return false else RunMacroText("/cleartarget") end
	end
end

I edited this to test on my Pally, and made the change I recommended and it worked beautiful Mentally <3

Wonderful Mentally I wish i could rep you more lol (Anyone willing to rep her for me?)

Here's Mentally's idea in the form of auto Focusing Targets

local myTable = {
	"Twilight Assault Drake",
	"Twilight Assassin",
	"Raider's Training Dummy",
	"Arm Tentacle",
	"Wing Tentacle",
	"Mutated Corruption",
	"Mana Void",
	"Elementium Bolt",
	"Burning Tendons",
	"Warmaster Blackhorn",
	"Goriona"
}
for i=1,#myTable do
	if not UnitExists("focus") then
		RunMacroText("/tar "..myTable[i])
		if UnitExists("target") and UnitName("target") == myTable[i] then
			RunMacroText("/focus")
			TargetLastTarget()
		end
	else
		if IsSpellInRange(GetSpellInfo(20271), "focus") == 1
			and not UnitIsDeadOrGhost("focus") -- Can't have this enabled to test Dummies
			and UnitCanAttack("player","focus")
			and not PQR_IsOutOfSight("focus", 1)
		then return false else RunMacroText("/clearfocus") end
	end
end

[phantom325]

Is this bannable to use?

Everything that modifies the game in some way that Blizzard does not intend to do is bannable.
However, this is very unlikely to get you banned, unless you do Arenas and get into the top 2% or whatever, and even then, Blizzard can't really prove it.

[crystal_tech]

ok i figured out the timer code and i'm going to share it

notes:
put it after a pause ability
it does throw an error when turning it on. something about a nil compared to a number. if you find the fix let me know as i'm working on it now.
it does take a half sec to get the calc going so it may delay casting something.

if TTD_loaded == nil and UnitAffectingCombat("player") ~= nil then
	PQ_TimeA = GetTime()
	PQ_LifeStart = UnitHealth("target")
	PQ_LifeMax = UnitHealthMax("target")
	TTD_loaded = 1
elseif TTD_loaded == 1 and UnitAffectingCombat("player") == nil then
	PQ_TimeA = nil
	PQ_LifeStart = nil
	PQ_LifeMax = nil
	TTD_loaded = nil
        -- set PQ_CalcTime to something other than zero to stop delays
	PQ_CalcTime = 0
end

if TTD_loaded then
	PQ_TimeDiff = GetTime() - PQ_TimeA
	PQ_HPDiff = PQ_LifeStart - UnitHealth("target")

	if PQ_HPDiff > 0 then
		PQ_FullTime = (PQ_TimeDiff * PQ_LifeMax)/PQ_HPDiff
		PQ_PastFullTime = (PQ_LifeMax - PQ_LifeMax) * PQ_TimeDiff/ PQ_HPDiff
		PQ_CalcTime = PQ_TimeA - PQ_PastFullTime + PQ_FullTime - GetTime()
	end
end

--here i set Hunter's mark (ALLHM) to 1  if the TTD is greater than 21 secs
if PQ_CalcTime >= 21 then
	ALLHM = 1
else
	ALLHM = nil
end


--under the hunters mark ability its
if unitdebuff("target", 1130) == nil and ALLHM then return true end

I hope this helps with timing things. and give rep where due.

[cukiemunster]

Ok, my next question is does anyone know how to incorporate the use of Healthstone into a profile? So it uses it at x% health? I quite simply fail at remembering to use lock stones in the heat of battle lol.

Bump for this question^^

[bu_ba_911]

Bump for this question^^

just run a check on inventory items, then run a check on player health then return true if under that limit

i think sheuron or i (i think it was him) made something for loot-a-rang

[diesall]

@a9058727: Fire away. :P You can speed that code up quite a bit though!

local BleedDebuff = BleedDebuff -- Localize the function variable first and foremost
function BleedDebuff(t)
    local Bleeds = { 
		16511, -- Rogue, Hemorrhage
		33876, -- Druid, Cat: Mangle
		33878, -- Druid, Bear: Mangle
		35290, -- Hunter Pet: Gore
		46857, -- Warrior, Trauma
		50271, -- Hunter Pet: Tendon Rip
		57386, -- Hunter Pet: Stampede
    }
    for i=1,#Bleeds do
		if UnitDebuffID(t,Bleeds[i]) then return true else return false end
	end
end

-- Now BleedDebuff() returns either true or false which speeds things up a bit
if BleedDebuff("target") then return false else return true end

It doesn't speed it up by anything noticeable, but, over-time it will make it a lot faster if you have a lot of code in the same ability this is called.
If you split it up and put the function into another "ability", by all means, localize the function first. :P

Take it like this. All global variables are like stars in the universe. Trying to pinpoint every single global call is gonna take some CPU power, the more globals, the more power it draws, if you localize the global variable you want to use (you essentially create a "local" copy of the global variable) it tells the program/addon exactl where/when/how to grab it and pinpoint it exactly where you want it, optimizing and speeding up your code considerably.

Just send me a PM if you are ever wondering about anything, you can pretty much do the same with Valma and Bu_ba iirc as well.

- Elizabeth

Edit:
@fluxflux: As bu_ba_911 pointed out bellow my post, try removing the part marked in red! (Unsure how it calls the exactMatch setting.)

just a few tips to clarify previously made or not made clear enough and to explain why this piece of code would not even function correctly:

local BleedDebuff = BleedDebuff

This is useless, a waste of cpu cycles.


Dont declare the local table inside the function, declare it outside of the function, your pointlessly creating a new local variable and table every time you call the function....

if UnitDebuffID(t,Bleeds[i]) then return true else return false end

this statement will cause the function to only ever check for Hemorrhage, as your returning false if the buff isn't active thus breaking out of the function and never testing for the other bleeds


basically this is how it would want to be written for performance and clarity:

if not 'name'_Constants then
	local Bleeds = {
		16511, -- Rogue, Hemorrhage
		33876, -- Druid, Cat: Mangle
		33878, -- Druid, Bear: Mangle
		35290, -- Hunter Pet: Gore
		46857, -- Warrior, Trauma
		50271, -- Hunter Pet: Tendon Rip
		57386, -- Hunter Pet: Stampede
	}
	function PQ_BleedDebuff(unit)
		for i=1,#Bleeds do
			if UnitDebuffID(unit,Bleeds[i]) then return true end
		end
		return false
	end

     'name'_Constants = true
end

this would want to be placed in the first ability of the rotation named for example RotationConstants
'name'_Constants: substitute this for example with the name of your rotation, anything unique , for example: MyCombatRogue_Constants

this is where you would define all other functions used by your rotation as well, in the same format

Of-course this could be declared in the on pqr load script xelper has added in 2.0 and not the rotation itself.

[marcmk2]

Omg I can't give anyone any rep. Every profile writer that I use and some that I don't all need to have rep spread before I can re-rep :| Sorry bubba I tried to give rep to mentally but the silly website won't let me

[Deva]

this is where you would define all other functions used by your rotation as well, in the same format

Of-course this could be declared in the on pqr load script xelper has added in 2.0 and not the rotation itself.

diesall, thanks for the improvements! Sorry I butchered it the first time.

You also touched on a question I had regarding the LUA script loader - I wasn't sure what could and could not be used in there. Anything that could be used in PQR? It would be great if I could make the new profiles I'm working on more flexible, or could share class-related code for different specs.