[BETA] PQRotation - an automated ability priority queue.

[happydado]

Hi guys someone can help me to find 1 PVP warlock profile?
I have look on all forum but no one.

[Xelper]

OK,you read it wrong (: You forgot about your spellavailable check(which is -50ms by default if I remember right).
So actually we got this:

casttime 1500 ms recastdelay 0 ms spellavailable -50ms GCD(!!!) 1200 ms
0.00 | recast set to 1500 GCD left 1200 program not trying to cast anything
0.50 | still 1000 ms left on recast GCD left 700 program not trying to cast anything
1.15 | -->MAGIC HERE<-- 350 ms left on recast GCD left 50 ms ==> from this point program assumes that ALL OTHER spells without delay is available so the next spell in rotation is available and it STARTS to cast it.
1.50 | spellcasting ends and recast set to 0 BUT(!!!) we already got next spell sent to server and due to lag tolerance and latency serverside you are ALREADY casting this spell so program will indeed TRY to send needed spell to server,but server assumes you are already casting another spell(which is lower in rotation and is not intended to be cast)

What can you do to fix this?OK 2 ways:
1. Dunno why you still not adding this but substracting LATENCY from recast EVERY time you calculate it.
2. Substract minimumspellavailabletime(or whatever you name it,sorry I forgot) EVERY time you calculate recast.

I am not doing anything with latency at all, not adding or subtracting. If, and only if, a spell has a recast delay it is not available for cast until cast time + recastDelay.

Your example is flawed from the start, at 0.00 I DO NOT add anything to it if it is 0. If a spell has a recast of 0 it is NEVER given a recast delay, I do not even add the cast time.

If recastDelay = 0 then delay = 0
if recastDelay = 1 then delay = cast time + 1

This gives the profile developers the freedom to choose exactly what they want their recast delay to be. RecastDelay is the minimum time before the spell can be used again, it is up to the profile developer to decide if they want it to be available in 1000ms or 800ms. It has nothing to do with latency, it is just simply "I do not want to use this ability again for 10 seconds"

[wtfnix]

Dude I used your profile you have up there on your svn.... TOTAL ownage Thanks man!

Every pally profile I have tested (cokx and mine) have both worked on new pqr. My alpha will probably be done soon and that will probably give my old one a run for its money and win lol.

Sent from my phone.

[Valma]

Hi guys someone can help me to find 1 PVP warlock profile?
I have look on all forum but no one.

There are not any.And I said for you before,I WILL do it,but only when I will be sure that my main profile is fully functional and causes no bugs at all.

If someone willing to do it faster - go on I don't care

[happydado]

There are not any.And I said for you before,I WILL do it,but only when I will be sure that my main profile is fully functional and causes no bugs at all.

If someone willing to do it faster - go on I don't care

I wait for Valma u are the best and np i wait if u say that u do...
TNX alot.

[Nyghtwing]

Thank You Valma/Bu_ba/Kickmydog/Xelper/Firepong/MENTALLY!!!!!. The profiles you guys made are outstanding. If it would allow me to give Rep i would give you guys all the rep i could give. Thank you again for all the hard work you guys put into these.

[Valma]

Thank You Valma/Bu_ba/Kickmydog/Xelper/Firepong. The profiles you guys made are outstanding. If it would allow me to give Rep i would give you guys all the rep i could give. Thank you again for all the hard work you guys put into these.

You've forgotten mentally!You bastard!!!! OK,joking (:

[bu_ba_911]

You've forgotten mentally!You bastard!!!! OK,joking (:

lol y u be joking!!! HE FORGOT MENTALLY!!!! :-O



*edit*

grats on Contributer

maybe i should have threatened to go private to reach it sooner!!! HAHAHA

[Gabbz]

I will however look into PQR_IsMoving()

I removed the PQR_IsMoving from fireball and it still cast scorch. I even tried with Pyroblast! instead of scorch and i casted Pyroblast when it just should have casted Fireball
Do you have the same problem pr is it just me ?
I tested on Sheuron Mageprofile and it happened there also.

[Valma]

I removed the PQR_IsMoving from fireball and it still cast scorch. I even tried with Pyroblast! instead of scorch and i casted Pyroblast when it just should have casted Fireball
Do you have the same problem pr is it just me ?
I tested on Sheuron Mageprofile and it happened there also.

Easy to test.Create new rotation with 2 spells like fireball and scorch.Both spells should have recast set to 0 and only return true in test code.

If it will still cast fireball-scroch-fireball-scorch then its the problem I stated before.If it will cast fireball-fireball-fireball-fireball then its PQR_IsMoving problem.

[Xelper]

Yeah, I've been working on it, it does cycle back and forth... not sure why.

I'll have a fix out hopefully shortly.

[Deva]

First of all, yes, I'd like to take the time to thank everyone who contributes time to this project. Xelper, the new version is wonderful, even if people are having some problems. The increased speed and improved look of the ability editor were immediately noticeable!

Second, to all the profile writers whose stuff I have used, tweaked, and learned from - THANK YOU! Looking into some of the newer profiles is truly amazing, I'm doing my best to wrap my head around how they work so I can continue to tweak, or... who knows, maybe make my own profile contributions!? O.o

Now, on that note, a while back, diesall posted some tips on code focused on improved speed ([BETA] PQRotation - an automated ability priority queue.). Using his example, I wrote a test for Cat Mangle (although this should theoretically be able to be used by any class?):

if not BleedDebuff then
function BleedDebuff(t)
    local Bleeds = { 
    16511, -- Rogue, Hemorrhage
    33876, -- Druid, Cat Mangle
    33878, -- Druid, Bear Mangle
    35290, -- Hunter pet, Gore
    46857, -- Warrior, Trauma
    50271, -- Hunter pet, Tendon Rip
    57386, -- Hunter pet, Stampede
    }
    for i=1, #Bleeds do if UnitDebuffID(t,buff[i]) then return true end end
end
end

if BleedDebuff("target") then return false end
if not BleedDebuff("target") then return true end

As it stands now, this code works as intended - if there's already a bleed debuff on the target, don't bother casting, otherwise, cast it!

Now, I'd like to get more in-depth with this, or see other examples of how this sort of code could be used? I know Xelper's aspect switching function came in handy and taught me something new as well. I'd also like to see if there are any ways I could improve code I have in existing profiles, or possibly just re-write them in a more advanced way. What I am requesting is for one or more of the more advanced profile writers (bu_ba, diesall, mentally, Valma, Xelper are the ones that come to mind, sorry if I left anyone out!) to be willing to "mentor" me a bit here and there. I know bu_ba and I have already exchanged an email or two in the past, but I know everyone is busy (especially mentally) which is why it's kind of an open call. :P

Anyway, I hope someone finds the bleed code useful - thank diesall for that - and sorry for the rambling! :P

[cokx]

Hi guys someone can help me to find 1 PVP warlock profile?
I have look on all forum but no one.

http://www.mediafire.com/?95ts92sssvki8og

here is a warlock pvp profile i made, but its quite far from perfect
but it will do in RBG in high ratings.
in arena i played with this @ 2,1k until i left my lock

i'm not quite sure if these bindings are right


- right shift mouseover fear and unstable affliction
- left control stop rotation
- right alt mass fear

have fun with that :P

i have 817 downloads and only 5 guys gave me + :P
but i dont care its just for the fun

btw.: i'm currently working on a program called "simple ability creator".
its made for ppl who want to create there own profiles or abilities, without the knowledge of lua or programmin
atm it doesnt goes too far in complexity.

in 2 or 3 weeks i'll release my alpha

[Gabbz]

I started to test using combatlogg and found that pqr isnt casting as fast as i do when i smash the buttons.
Here Comes combat logg standing naked casting Fireball with PQR

 16:00:14.614  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:17.164  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:19.731  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:22.298  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:24.881  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:27.481  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:30.115  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:32.715  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:35.282  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:37.865  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:40.382  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:43.131  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:45.682  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:48.315  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:50.915  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:53.399  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
 16:00:56.066  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4

This show average cast time fore Fireball to be 2.44

3/15 16:04:43.473  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:45.760  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:48.193  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:50.593  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:52.957  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:55.357  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:04:57.809  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:05:00.208  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:05:02.660  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:05:05.010  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:05:07.476  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",0x4
3/15 16:05:09.843  SPELL_CAST_START,0x050000000379D7D7,"Mkael",0x511,0x0,0x0000000000000000,nil,0x80000000,0x80000000,133,"Fireball",3/15

This shows the average cast time for Fireball to be 2.19

So the difference is 0.25 and in the long run that a rather big DPS decrease.
I dont know if this happened from last PQR version or was earlier.

[Xelper]

PQR v2.0.4
Download Here

-Bugfix that caused a recast delay to be applied to a spell without a recast delay. Was comparing "0" to 0, which was returning false.

If you upgraded to 2.0.3 you must do this upgrade or your rotation will not work right.