Azerothcore WoTLK Repack (Playerbots + Individual Progression + 32 other modules)

[korenchkin]

In the changelog.txt i try to inform which config files where changed, so that you don't need to replace everything.

i would also recommend winmerge (for windows users),helps a lot

[korenchkin]

one important thing,there is better version,i was confused by github's '26 commits behind' and last week(that seems recent...yeah),i looked at sources and failed merge,failed merge...why is there not a warning?,so i started examining,lots of fixes in naxx not included,after about 1 hour later of trying to figure out how to merge it myself i discovered this person and cloned his repo: Update20250509 by hipejoe . Pull Request #45 . liyunfan1223/azerothcore-wotlk . GitHub
so might wanna start here,since it is up to date(almost) @Aldebaraan

i can't comment on code quality(not a programmer),but i believe there are some 'quick hacks' so it can't be merged upstream,which would be really nice one day to have playerbots branch up to date...and maybe pandaria some time...

edit:i did not try random enchants there,likely issue with playerbots,but if anyone has powerfull compiling machine,try that (my i5-7600k can either run wow server or breathe )

[mario-64]

Windows Defender today suddenly flagged worldserver.exe as having Amadey.A!MTB trojan/virus despite the fact that my server has been running for weeks. Never seen this before. Anyone else? I assume it's a false positive?

[Aldebaraan]

One question I have is updating particular modules. I don't know if I should wait for your next update or attempt them on my own. Are they pretty straight forward? I'd like to have Playerbots fully updated since 4-21

You need to git clone and then compile everything to update them.

[smilingbob]

Windows Defender today suddenly flagged worldserver.exe as having Amadey.A!MTB trojan/virus despite the fact that my server has been running for weeks. Never seen this before. Anyone else? I assume it's a false positive?

Just scanned with Defender and Malwarebytes and got nothing. Server is running Win10.

[mario-64]

Just scanned with Defender and Malwarebytes and got nothing. Server is running Win10.

Thank you. Your virus definitions are from May 17? I just ran another scan and it showed no threats. Not sure what's going on. My server runs nothing but this repack on Windows 11.

[smilingbob]

Yes, and I just updated this morning and ran another scan with both with no threats detected.

[Budicles]

All clear with Defender, Malwarebytes, and 2 online scanner - Kaspersky and Metadefender

[Aldebaraan]

one important thing,there is better version,i was confused by github's '26 commits behind' and last week(that seems recent...yeah),i looked at sources and failed merge,failed merge...why is there not a warning?,so i started examining,lots of fixes in naxx not included,after about 1 hour later of trying to figure out how to merge it myself i discovered this person and cloned his repo: Update20250509 by hipejoe . Pull Request #45 . liyunfan1223/azerothcore-wotlk . GitHub
so might wanna start here,since it is up to date(almost) @Aldebaraan

i can't comment on code quality(not a programmer),but i believe there are some 'quick hacks' so it can't be merged upstream,which would be really nice one day to have playerbots branch up to date...and maybe pandaria some time...

edit:i did not try random enchants there,likely issue with playerbots,but if anyone has powerfull compiling machine,try that (my i5-7600k can either run wow server or breathe )

The playerbot branch is updated once a week on average. You can update it yourself by using git clone and then git merge:

git clone --depth 100 [email protected]:liyunfan1223/azerothcore-wotlk.git --branch=Playerbot azerothcore-wotlk
cd azerothcore-wotlk
git remote add upstream https://github.com/azerothcore/azerothcore-wotlk.git
git fetch upstream
git merge upstream/master

[korenchkin]

The playerbot branch is updated once a week on average. You can update it yourself by using git clone and then git merge:

git clone --depth 100 [email protected]:liyunfan1223/azerothcore-wotlk.git --branch=Playerbot azerothcore-wotlk
git remote add upstream https://github.com/azerothcore/azerothcore-wotlk.git
git fetch upstream
git merge upstream/master

okay,something is off,i end up with not updated code,can you please check for me you have camparable source to upstream,for example this file ? (and you do NOT have boss_anubrekhan.h ? ) azerothcore made some changes here and i can't get them included

basically,i wanted to go back in time,diff the changes made by liyunfan1223,make patch and push it to clean source,but failed yet again

edit2: so you understand here-i'm just trying to cleanup and simplyfy(my own personal problem,sometimes i feel like i need to optimize),but looking through sources using several tools(winmerge,total commander compare directories) i found out,that the big missing part is just some azerothcore devs optimization,that did not get to playerbots fork(this started my quest),and that optimization is moving naxxramas .h into .cpp files..

i still don't understand this: why it is in sync with upstream,when all the files are certainly NOT (i.e. i don't understand github)

but definitely thanks for your quick merge howto,i will be using it

[mario-64]

Thanks for the responses. Must have been a false positive. It only happened that one time and subsequent scans, including Malwarebytes, have showed no threat. Hopefully it's all clear.

[Aldebaraan]

okay,something is off,i end up with not updated code,can you please check for me you have camparable source to upstream,for example this file ? (and you do NOT have boss_anubrekhan.h ? ) azerothcore made some changes here and i can't get them included

basically,i wanted to go back in time,diff the changes made by liyunfan1223,make patch and push it to clean source,but failed yet again

edit2: so you understand here-i'm just trying to cleanup and simplyfy(my own personal problem,sometimes i feel like i need to optimize),but looking through sources using several tools(winmerge,total commander compare directories) i found out,that the big missing part is just some azerothcore devs optimization,that did not get to playerbots fork(this started my quest),and that optimization is moving naxxramas .h into .cpp files..

i still don't understand this: why it is in sync with upstream,when all the files are certainly NOT (i.e. i don't understand github)

but definitely thanks for your quick merge howto,i will be using it

You need to cd into the cloned directory. I forgot to include that. I updated the snippet.

[Aldebaraan]

Due to issues with a fork of reagent bank, i will be delaying the update to tomorrow. Hopefully the author will respond to my bug report and fix it by then.

[GameGenie]

Now this a work of art.

Ty for keeping it free. This is a server I would invest a lot of time playing on. I'm in the process of looking through the modules. You sure give us a lot of control over this server.

[korenchkin]

You need to cd into the cloned directory. I forgot to include that. I updated the snippet.

yeah,i did that,what i mean not updated,it is not updated with upstream,i bet yours is not updated too (liyunfan1223 managed to somehow edit naxxramas folder so it is now as his patch,it does not get updated from upstream,but i did not see any updates related to playerbots,later in time azerothcore updated naxxramas,but the change is not reflected into liyunfan1223's fork)..
now i have hopefully said what i mean

i have created issue on his repo,maybe i'm not wrong and it is something he missed...