[PE] - NO CARRIER's Rotations

[svs]

Yeah it's not working with the hands on Kromog now for some reason, no idea why. Still investigating.

Maybe because of this:

or UnitInVehicle("Player")

function NOC.pause() library.lua line 375

[NOCARRIER]

Maybe because of this:

or UnitInVehicle("Player")

in function NOC.pause() in library.lua line 375

Oh Shit! Nice find! I just fixed it. Don't know why I never grepped my own code for this. It isn't even necessary to have that check in my own local pause function since PE itself was doing the necessary check.

[StinkyTwitch]

Oh Shit! Nice find! I just fixed it. Don't know why I never grepped my own code for this. It isn't even necessary to have that check in my own local pause function since PE itself was doing the necessary check.

Now it makes sense why it was working as we were working on it in IRC :P.

[kakashi10]

Great finding. will test it when i get to kromog. Thank you for resolving that.

[kakashi10]

now getting error on Interface\AddOns\Probably_NOC_Rotations\library.lua:442: bad argument #2 to 'strsplit' (string expected, got nil)

[NOCARRIER]

now getting error on Interface\AddOns\Probably_NOC_Rotations\library.lua:442: bad argument #2 to 'strsplit' (string expected, got nil)

This should be fixed now with a commit made just moments ago.

[NOCARRIER]

Pushed a few changes:

• Monk (WW): Adding Pause for when using Zen Meditation
• Removing reference to pause() function in all profiles. After comparing to the PE engine, this appears to be redundent
• Removed all spell-queue related code for now - will replace with something cleaner soon
• Monk (WW): Removed all 'autoTOD' code - decided it wasnt necessary
• Monk (WW): Added, thanks to code from StinkyTwitch, the ability to detect when there is any sort of agility or multistrike buff and apply this detection for more optimal TeB usage - This should result in a DPS increase
• Monk (WW): Changed TeB stack size from 10 to 9 based on simc changes

[NOCARRIER]

Another update just pushed:

• -Monk (WW): Completely overhauled the opener and synced up (mostly) with the simc changes. This should be a more ideal opener and should theoretically result in a DPS increase
• -Monk (WW): Changing !modifier.lastcast to !lastcast
• Re-added special check for Kromog Hands

[knightwish]

After latest updates seems like energizing brew usage is broken. energyTime() function is not working properly i guess

[NOCARRIER]

After latest updates seems like energizing brew usage is broken. energyTime() function is not working properly i guess

Yep, somehow I missed actually testing that new function with all of the other changes. Reverted to previous logic for Energizing Brew until I properly test it. I cleared 8/10 H BrF last night without even realizing it wasn't being cast until I saw your note too! No wonder DPS was lower than I expected it to be!

[voilet]

Hey, have you thought about making any updates to the survival profile, everything seems to be based off of MoP, im curious if you are willing to revisit it, to make it perform as it should, its pasuing using focusing hot because its not capable of managing the focus correctly, like it should

[NOCARRIER]

Hey, have you thought about making any updates to the survival profile, everything seems to be based off of MoP, im curious if you are willing to revisit it, to make it perform as it should, its pasuing using focusing hot because its not capable of managing the focus correctly, like it should

Hey Violet,

Between RL commitments and raid commitments I have not been able to spend enough time on the hunter profiles. I'm sorry! There's actually one under development right now by another author which is really really good, and if he releases it I'll probably discontinue development on mine and direct people to his. It's really slick.

[NOCARRIER]

Yep, somehow I missed actually testing that new function with all of the other changes. Reverted to previous logic for Energizing Brew until I properly test it. I cleared 8/10 H BrF last night without even realizing it wasn't being cast until I saw your note too! No wonder DPS was lower than I expected it to be!

Just pushed a change that will re-implement a working energizing brew ussgae using the custom function:

• -Monk (WW): Re-implementing (working) custom function check for Energizing Brew instead of 'dumb' 'timetomax' check. This should result in more optimal use of Energizing Brew
• -Monk (WW): Fixing check for Hurricane Strike (does anyone actually use this talent?)

p.s. not using Energizing Brew at all is about a 2.5% DPS loss!

[earth1337]

Hey, have you thought about making any updates to the survival profile, everything seems to be based off of MoP, im curious if you are willing to revisit it, to make it perform as it should, its pasuing using focusing hot because its not capable of managing the focus correctly, like it should

i am not sure if it is ok for nocarrier, but i edited the profile by myself for mythic brf progression and made some really really good logs with it. optimized for toth/amoc/glaives or barrage/lw or fs, you can copy and paste it in your survival lua:

{{
{ "A Murder of Crows" },
{ "Lifeblood" },
{ "Berserking" },
{ "Blood Fury" },
{ "Bear Hug" },
{ "#trinket1" },
{ "#trinket2" },
{ "Stampede" },
}, "modifier.cooldowns" },

{ "Tranquilizing Shot", { "target.dispellable(Tranquilizing Shot)", "toggle.tranq" }, "target" },

-- AoE
{ aoe, { "toggle.multitarget", "modifier.enemies >= 2" }},

{ "Arcane Shot", "target.debuff(Serpent Sting).duration <= 3" },
{ "Black Arrow", { "!target.debuff(3674)", "player.spell(Explosive Shot).cooldown > 0" }},
{ "Arcane Shot", "player.focus >= 95" },
{ "Explosive Shot", "player.buff(Lock and Load)" },
{ "Explosive Shot", "!player.buff(167165)" },
{ "Barrage", { "modifier.enemies >= 2", "toggle.barrage" }},
{ "Arcane Shot", { "player.buff(17703", "player.buff(34720)" }},
{ "Explosive Shot" },
{ "Black Arrow", "!target.debuff(3674)" },
{ "Arcane Shot", { "player.buff(34720)", "player.focus >= 35" }},
{ "Arcane Shot", { "player.focus > 35", "player.spell(Focusing Shot).exists" }},
{ "Arcane Shot", { "player.focus >= 75" }},
{ "Arcane Shot", { "player.moving", "player.spell(Focusing Shot).exists" }},
{ "Glaive Toss", { "player.moving", "player.spell(Focusing Shot).exists" }},
{ "Focusing Shot", { "player.focus < 35" }},
{ "Cobra Shot" },
}, "@NOC.immuneEvents('target')" },

optimized on simcraft and azorthations hunter guide ( one of the best hunters out there, from danish terrace ). it works perfect for me with 4 set bonus and scales of doom+bhotm.

but remember, next ID bm and mm get a HUGE buff, it seems like bm will be best for single target and aoe cleave.

edit: i could upload the lua file, if NOC says its ok, because i also integrated some toggles for barrage and tranq shot.

[Produktionshuset]

in the Iron Maidens encounter on Hc i couldent get it to cast Ehi Ex at all on newest addition