[Announce] Model Edits 4.0.3a

[Cromon]

Oh I gotcha, so you just re-purposed an already existing pointer? It may very well be safe then.

I dont know. Most likely Warden is not watching on SFileOpenArchive and i cant imagine, that SFileSystem::AddArchive is watched (but theoretically possible). So yes, the only thing that could tell warden, that there is something new is hash of data pointed by the Array.

When I tried to run the injector I got the following:

Assertion failed: proc != NULL, file main.cpp, line 213

What do?

You messed something up in the DLL. Did you accidentally remove the __declspec(dllexport) in one of the functions? Or is even a DLL missing?

I managed to compile it properly...at least i think so, but if i just run the exe, either with double-clicking it or via a cmd line, then it returns nothing and does nothing. If I launch it with the -nodelay command, then it launches WoW, but won't inject the patch-M.MPQ (a model edit).

Did I do something wrong or is the injector just not working for everything so far?

Try to do the following and look what wow tells. Maybe you use the old MPQ-format, or something else with your MPQ is not completly corret. WoW will tell ya in the console:
http://www.mmowned.com/forums/world-...ml#post2011601

[Asir]

I compiled them all correctly (I think) but when I try to start it up I this error.

Injector.exe
The NTVDM CPU has encountered an illegal instruction.
CS:1261 IP:0103 OP:63 6c 75 64 65 Choose 'Close' to terminate the application.

I looked up this error to see that its a result of using an incorrect command.exe file from windows 95 which of course there aren't any on my computer. I tried running it directly from the command prompt but it still kept giving me the same error so I can only assume something isn't right with the way I compiled them but I don't know what that could be.

[WanjiK]

Interesting stuff.

Strange thing on my system: 1st method is not working because FindWindow returns NULL, even if I call it with a NULL window class. English client on XP home SP3, the window IS named "World of Warcraft" but it cannot find it, beats me why.

About the edits that work with 1st method but crash with 2nd, maybe this has something to do with the introduction of patch MPQs in cataclysm (see MPQ Archives - Incremental MPQ patches). I do not know what the load order is for files inside MPQ, but if the game tries to apply a patch to a file modified after injection, it could surely lead to a crash.

And how did you get your hands on function names and addresses inside the client? They don't seem to be exposed.

Happy new year

[Maxunit]

Try to do the following and look what wow tells. Maybe you use the old MPQ-format, or something else with your MPQ is not completly corret. WoW will tell ya in the console:
http://www.mmowned.com/forums/world-...ml#post2011601

I tried that out now and I get a 2nd command prompt now, but it isn't showing, that it loads the Data\mypatch.mpq file and outputs no error regarding that.

[Ihasalazer]

So I made a project, put a C++ file in it, copy pasted VectoredHandler's code into it, set the project to DLL and clicked Build Solution, the Output window says Build: 1 succeeded, 0 failed. But I can not find the DLL anywhere.

[Cromon]

@Maxunit: Copy your consle output once

@Ihasalazer: Try lookin at My Documents\Visual Studio 2010 (or 200\Projects\<ProjectName>\Debug

[Ihasalazer]

[QUOTE=@Ihasalazer: Try lookin at My Documents\Visual Studio 2010 (or 200\Projects\<ProjectName>\Debug[/QUOTE]

I tried that, but there only two files in there, one called VectoredHandler.lastbuildstate, and one called VectoredHandler.txt which contains the following:

Build started 02-01-2011 22:53:57.
1>Project "c:\Users\xxx\documents\visual studio 2010\Projects\VectoredHandler\VectoredHandler.vcxproj" on node 2 (build target(s)).
1>InitializeBuildStatus:
Creating "Debug\VectoredHandler.unsuccessfulbuild" because "AlwaysCreate" was specified.
FinalizeBuildStatus:
Deleting file "Debug\VectoredHandler.unsuccessfulbuild".
Touching "Debug\VectoredHandler.lastbuildstate".
1>Done Building Project "c:\Users\xxx\documents\visual studio 2010\Projects\VectoredHandler\VectoredHandler.vcxproj" (build target(s)).

Build succeeded.

Time Elapsed 00:00:00.02

[giggins]

Good work, Cromon. +rep

For some reason the -nodelay command doesn't seem to work but the old way seems to work flawlessly.

[recklesss]

I wonder.. Are people already using this method and does it seem to work good? Anyone has some more comment on this?

[Cromon]

It either works or it doesnt and as you can see on the images it worked for me. Of course only for 4.0.3a.

[Saotan]

Did someone use it on a main account ? If Yes, since how long ?
Cromon, you're really doing a great job, waiting for your noobie version, because
i don't understand a clue of what's written here hehe ^^

[WanjiK]

Finally got the 1st method to work. FindWindow returns NULL every time I run the program by double-clicking on the generated exe, BUT it works when I run it through the MSVC debugger (I'm not really into windows API, but this is pretty weird if you ask me). It then fails at GetExitCodeThread() in LoadDll(), with GetLastError() returning 87 (incorrect parameter). I had to edit the LoadDll() call in main() to provide a fully qualified name to mopaq.dll and then it worked.
So I can confirm that my brand new edit works perfect with 1st method and crashes right at character selection screen with 2nd.
@Cromon: did you try it with an edit containing patched files?

[Cromon]

@Cromon: did you try it with an edit containing patched files?

Sure: http://imagr.eu/up/4d18e458aff5c8_Wo...710_170953.jpg

[WanjiK]

Neither interface/glues/models/ui_worgen/ui_worgen2.m2 or enGB/interface/glues/models/ui_mainmenu_cataclysm/ui_mainmenu_cataclysm.m2 are patched, to my knowledge. Could you please point to me in which MPQ these files are marked with a patch flag?

[Cromon]

wow-update-13241.MPQ, deDE\Interface\Glues\Models\UI_MainMenu_Catclysm\UI_MainMenu_Cataclysm.m2 is marked as incremental patch file.