Injecting ASM problems

[Shynd]

Go

kill

yourself.

Seriously. I almost gouged my ****ing eyes out writing fasmdll_managed like 18 separate times. Here, I'll let you do the same!:

namespace Fasm
{
	public ref class ManagedFasm
	{
	public:
		ManagedFasm();
		ManagedFasm(IntPtr hProcess);

		~ManagedFasm();

		void AddLine(String ^ szLine);
		void AddLine(String ^ szFormatString, ... array<Object ^> ^ args);
		void Add(String ^ szLine);
		void Add(String ^ szFormatString, ... array<Object ^> ^ args);
		void InsertLine(String ^ szLine, int nIndex);
		void Insert(String ^ szLine, int nIndex);
		void Clear();

		array<Byte> ^ Assemble();

		bool Inject(IntPtr hProcess, DWORD dwAddress);
		bool Inject(DWORD dwAddress);

		DWORD InjectAndExecute(IntPtr hProcess, DWORD dwAddress, DWORD dwParameter);
		DWORD InjectAndExecute(IntPtr hProcess, DWORD dwAddress);
		DWORD InjectAndExecute(DWORD dwAddress);

		IntPtr InjectAndExecuteEx(IntPtr hProcess, DWORD dwAddress, DWORD dwParameter);
		IntPtr InjectAndExecuteEx(IntPtr hProcess, DWORD dwAddress);
		IntPtr InjectAndExecuteEx(DWORD dwAddress);

		IntPtr GetProcessHandle() { return m_hProcess; }
		void SetProcessHandle(IntPtr Value) { m_hProcess = Value; }

		int GetMemorySize() { return m_MemorySize; }
		void SetMemorySize(int Value) { m_MemorySize = Value; }

		int GetPassLimit() { return m_PassLimit; }
		void SetPassLimit(int Value) { m_PassLimit = Value; }

		static array<Byte> ^ Assemble(String ^ szSource);
		static array<Byte> ^ Assemble(String ^ szSource, int nMemorySize);
		static array<Byte> ^ Assemble(String ^ szSource, int nMemorySize, int nPassLimit);

	private:
		StringBuilder ^ m_AssemblyString;
		List<IntPtr> ^ m_ThreadHandles;

		IntPtr m_hProcess;
		int m_MemorySize;
		int m_PassLimit;
	};
}

AGHGHHHHHHHHHHHHHHLSDLMFFOFOFOLSHITSHITSHIT.

[Cypher]

I lol'd.

[lanman92]

Okay, I switched to casting and other things using DoString() now, but I can't cast most of the time. I'm using C# so detouring EndScene() is not exactly an option. I've been looking at IDA for an hour or two, trying to find the protection patch. I thought it was at 0x12EB440, but I was sadly wrong. At the moment, I'm just completely mashing DoString about 100x and it usually casts... But this is very ugly. Any hints to finding the patch? I know I could get it in a second with Bobbysing's lib, but I want to know where it's at so I can patch my stuff easier next time.

[Cypher]

You don't need to patch anything if you're using DoString.

[lanman92]

I'm pretty sure that the reason it's not working for me because I'm pausing the main thread before I do it. I was having crash issues before I did this.

[Cypher]

I'm pretty sure that the reason it's not working for me because I'm pausing the main thread before I do it. I was having crash issues before I did this.

Yep. You need to pause the main thread when doing anything that uses thread-local data, otherwise it could invalidate the linked list half way through.

[lanman92]

Here's my suspend code, I somewhat ripped it from some guys Lua lib... Updated addys real quick, still throwing me that stupid error when I hit my Test lua button to cast Fel armor. After this code I inject and execute then resume.

while (magic.ReadInt(0x12EB444) != 0)
{
Thread.Sleep(1);
}
magic.SuspendThread();

[Cypher]

Here's my suspend code, I somewhat ripped it from some guys Lua lib... Updated addys real quick, still throwing me that stupid error when I hit my Test lua button to cast Fel armor. After this code I inject and execute then resume.

while (magic.ReadInt(0x12EB444) != 0)
{
Thread.Sleep(1);
}
magic.SuspendThread();

[lanman92]

Uhm. Wtf was that?

[Nesox]

Maybe this helps, you obvious want to resume it too after all the injeciton is done

            const uint Addon_Lock = 0x12EB444;

            ProcessThread wowMainThread = SThread.GetMainThread(_process.Id);
            IntPtr hThread = SThread.OpenThread(wowMainThread.Id);

            SThread.SuspendThread(hThread);

            if (wow.ReadUInt(Addon_Lock) != 0)
            {
                SThread.ResumeThread(hThread);
                System.Threading.Thread.Sleep(500);
                SThread.SuspendThread(hThread);
            }

            Stopwatch _watch = new Stopwatch();
            while (wow.ReadUInt(Addon_Lock) != 0)
            {
                _watch.Start();
                System.Threading.Thread.Sleep(5);

                if (Addon_Lock == 0 || _watch.ElapsedMilliseconds < 2000)
                {
                    _watch.Stop();
                    _watch.Reset();
                    break;
                }
            }

[lanman92]

Wait, am I making a correct assumption that the BlackMagic Lib automatically Opens the main thread when I use OpenThreadAndProcess()? If it doesn't, there's my problem..... /sigh. It seems like my code does the exact same thing as yours, btw. Yours just looks prettier.

[Nesox]

It seems like my code does the exact same thing as yours, btw. Yours just looks prettier.

:hug:

</Fillah of love>

[lanman92]

Still not working though. Any other tips?

[Nesox]

Still not working though. Any other tips?

No nothing that i can think of, just make sure u use the new BlackMagic and dont suspend before u do any reads or you get a nasty exception.
And if you want a failsafe lua_dostring you shoud not resume wows mainthread until the injected code has finished executing.
Send a message when it's done and then catch it in a messageloop and then resume wows main thread

[lanman92]

I was looking into doing that, but what message do you send? I was a little confused on that part =/ kind of noobish question, but whatever.

EDIT: OMFG, anyone feel like explaining the 3rd parameter to DoString()? I thought it was the luaState or w/e, so I was copying that... Ugh. Now it works like a charm