[PQRotation] Firepong's PQR Profile's Feedback - Comments - Question's?

[piratepetey]

Agreed, 2.0.0 seems to be a lot better with energy management. My only suggestion (and this was a problem in 1.9.8 and 9 as well) is that Rake isn't used on targets that don't already have it. It seems to either mangle or shred to 5cp to get Rip up before Rake will be applied.

[firepong]

Agreed, 2.0.0 seems to be a lot better with energy management. My only suggestion (and this was a problem in 1.9.8 and 9 as well) is that Rake isn't used on targets that don't already have it. It seems to either mangle or shred to 5cp to get Rip up before Rake will be applied.

I don't see how. Rake is one of the highest Priority spell's (if not already the highest besides Savage Roar) in my rotation. It will even stop to apply it when we get a stack of DoC. Reason for this is since the tool-tip of rip always shows 99 damage per second, instead of the intended damage per second like Rip does, we cannot tell if there is a high damage Rake or Low damage rake. So I just have it refresh it whenever we get a 2 stack DoC for the first DoC then whatever is best for the second DoC. If you are not specced into DoC, this it will try and keep Rip up as much as possible. I know I can say, with DoC, my Rake up-time is almost always 99%+, but if I were ever specced out of DoC into NV or HotW, it usually sat ~92%, no idea why. Also, my Rake does way more damage specced into DoC over any of the other 2 Talents.

You can look under the Rake code and also pull up the Lua file and look at HasRake(var1) and you will see that everything is covered there to give Rake the most Optimal up-time on the target.

EDIT* Mangle, Shred and Ravage all have checks to not fire off if Rake is not on the target.

[piratepetey]

It only seems to happen when target switching. Not sure if that's relevant

[firepong]

It only seems to happen when target switching. Not sure if that's relevant

Don't see why, it will always take in the current target, as can be seen from:

//var1 = any unit, usually "Target"
function HasRake(var1)
    local rake = select(7,UnitDebuffID(var1, 1822, "PLAYER"))
    
    if rake then
        if (rake - GetTime()) > 3 then
            return true
        end
    end
    return false
end 

[piratepetey]

Agreed, I've reviewed the abilities myself and can't find any issue. I'll get PQInterface installed and see where it holds up.

[firepong]

For anyone that wants to know what I'm wearing, which isn't much, heres my masked armor. Obviously, most of my gear has at least a level of upgrades from valor

Level 90 Troll Druid | WoW World of Warcraft Armory Profiles | Masked Armory

[piratepetey]

Ok, just confirmed on dummies that when switching targets, sometimes even though Rake is top priority cast (according to PQInterface) the profile is still occasionally casting mangle or shred to get rip up before rake. I have zero idea why this would be the case.

Can anyone else confirm?

[firepong]

Ok, just confirmed on dummies that when switching targets, sometimes even though Rake is top priority cast (according to PQInterface) the profile is still occasionally casting mangle or shred to get rip up before rake. I have zero idea why this would be the case.

Can anyone else confirm?

Could possibly be the spell Queue system. I don't have anything in my profile that clears that like Bu_Ba's, Mentally and all the other many developers that take advantage of it. Didn't think I needed to, but I might add it in anyways.

[piratepetey]

That would be a bonus, I'm just glad I wasn't going mad

I'll keep PQInterface installed in any case as it's helpful to see if there are any holdups in the rotation.

[K1ngp1n]

will there be a Time To Die function soon?

[TehVoyager]

will there be a Time To Die function soon?

read back, pretty sure pong said there allready was a function for this

[cukiemunster]

read back, pretty sure pong said there allready was a function for this

Nah, there's no TTD yet. Gabbz gave him his TTD function, but not sure it ever plans on being implemented.

Here comes a framework for TTD

if (guid ~= UnitGUID("target")) or (guid == UnitGUID("target") and UnitHealth("target") == _firstLifeMax) then
               guid = UnitGUID("target")
               _firstLife = UnitHealth("target")
               _firstLifeMax = UnitHealthMax("target")
               _firstTime = GetTime()
            end             
            _currentLife = UnitHealth("target")
            _currentTime = GetTime()
            timeDiff = _currentTime - _firstTime
            hpDiff = _firstLife - _currentLife
            if hpDiff > 0 then
               fullTime = timeDiff*_firstLifeMax/hpDiff
                pastFirstTime = (_firstLifeMax - _firstLife)*timeDiff/hpDiff
                calcTime = _firstTime - pastFirstTime + fullTime - _currentTime
                if calcTime < 1 then
                       calcTime = 1
                   end
                   timeToDie = calcTime
            end
            if hpDiff <= 0 then
            guid = UnitGUID("target")
            _firstLife = UnitHealth("target")
            _firstLifeMax = UnitHealth("target")
            _firstTime = GetTime()
            end
            -- dummy
            if UnitHealthMax("target") == 1 then
                timeToDie = 99
            end
            if not timeToDie  then
                timeToDie = 1
            end 

Works great for me.
You just need to tweak it somewhat.

Think I can get that with the variables already in place so I don't have to go searching through your profiles for em xD? Can PM the base code to me if you want. If it works good enough, it's going to be turned into a function instead of making it an ability like stated there lol

[OnionsTich]

does anyone know how to remove the unitfacing as its causing me serious lag please

[firepong]

does anyone know how to remove the unitfacing as its causing me serious lag please

Quote it out in the profiles, but I guarantee you will loose a K or 2 DPS C.c

EDIT* Reason for DPS lose is it reverts back to PQR_NotBehindTarget() or whatever that function is.

[PIPOL13]

Quote it out in the profiles, but I guarantee you will loose a K or 2 DPS C.c

EDIT* Reason for DPS lose is it reverts back to PQR_NotBehindTarget() or whatever that function is.

when will the normal profile that would not lag?