[PQRotation] Firepong's PQR Profile's Feedback - Comments - Question's?

[firepong]

Ok, version 1.9.6 pushed. Let me know how it does now. Still think its doing less DPS. Starting to think the aggressive Ferocious Bite code was working better than keeping Rip time up C.c :confused:

EDIT* Looks like if you have really low Mastery, it's better to go with aggressive Ferocious Bite usage and lower Rip times and vise versa if you have high Mastery ... .. .

[cukiemunster]

I just used your new update, and did 80k, top 20 WoL parse on Sha in Terrace LFR. I stayed on Sha the whole time like a baddie just to test the Rip, and it still only ended up with 73% uptime using the new version. I did notice however that it rarely uses FB now, only 6 used the whole 7 minute fight. Using the new version I did beat my previous best Tsulong ranking, but not the Lei Shi, but it did FEEL like dps was higher, just ended up with crappy CD usage during Lei Shi. Completely unbuffed, i have about 6700(60%) Mastery, but I am not sure how this compares to others since Feral is typically few and far in between. Also note that I do not gem +320 mastery like i see some doing, basically +160 Agi gems everywhere but a socket or two for the bonus.

[Apsalaar]

As mentioned here, the RiP uptime itself is pretty good, even in the low 80's. Whats really important is to always line up TF and/or Gloves and/or DoC on every one. Also a prio when both rip and rake are about to run out, do RiP first, then a DoC'd rake. Now I think Rake is prio nr1 nomatter what(after SR)?

Also: Sometimes it applies NS+HS at 4 combo points, and then uses the next 2 DoC charges on Shred before applying RiP.

[Bottter]

Can someone try the new version with SotF i think the agressive ferocious Bite is better with Sotf and not with Incarnation .

[firepong]

As mentioned here, the RiP uptime itself is pretty good, even in the low 80's. Whats really important is to always line up TF and/or Gloves and/or DoC on every one. Also a prio when both rip and rake are about to run out, do RiP first, then a DoC'd rake. Now I think Rake is prio nr1 nomatter what(after SR)?

Also: Sometimes it applies NS+HS at 4 combo points, and then uses the next 2 DoC charges on Shred before applying RiP.

What I've got coded right now is pretty much what I've got time to do. I just had to work Thanksgiving and it was ultra slow, so I had time to look over my own code. Don't think I'll be changing it anytime soon. Has been stated time and again that I've only got a lack luster DoC coded, but it still does damn good the way it is.

Can someone try the new version with SotF i think the agressive ferocious Bite is better with Sotf and not with Incarnation .

Yeah, I'm pretty sure this is true. I might have to add in 2 different versions of Rip and Ferocious Bite, which isn't hard to do.

[firepong]

Hmmmm, I think I'm going to add a HP check to Rip. If the Target is less than playerHP * 100, then use Ferosiuos Bite, otherwise consider the target long enough to live through a application of Rip and apply Rip. What would you guys sayon that for Feral DPS?

[piratepetey]

Hmmmm, I think I'm going to add a HP check to Rip. If the Target is less than playerHP * 100, then use Ferosiuos Bite, otherwise consider the target long enough to live through a application of Rip and apply Rip. What would you guys sayon that for Feral DPS?

playerHP * 100 for me would be ~3.6mil HP. I'd think that a Rip on that would be preferential to just FB'ing. Can you base it on boss HP percentage ((current boss HP / max boss HP) *100)?

[Soapbox]

FIrepong has the right idea. you are best basing it off of the players health.

for example

PlayerHP*10
BossHP

if PlayerHP*10 > BossHP then
return true
end


im brain-dead right now so forgive me for the lack of code, im sure you already have an idea of what to do

[failroad]

Just add time to die function. I'll PM you one if you want. Then you can add the amount in seconds from simcraft for real precise rippin

[Soapbox]

Just add time to die function. I'll PM you one if you want. Then you can add the amount in seconds from simcraft for real precise rippin

TTD is wonky

[Gabbz]

Here comes a framework for TTD

if (guid ~= UnitGUID("target")) or (guid == UnitGUID("target") and UnitHealth("target") == _firstLifeMax) then
               guid = UnitGUID("target")
               _firstLife = UnitHealth("target")
               _firstLifeMax = UnitHealthMax("target")
               _firstTime = GetTime()
            end             
            _currentLife = UnitHealth("target")
            _currentTime = GetTime()
            timeDiff = _currentTime - _firstTime
            hpDiff = _firstLife - _currentLife
            if hpDiff > 0 then
               fullTime = timeDiff*_firstLifeMax/hpDiff
                pastFirstTime = (_firstLifeMax - _firstLife)*timeDiff/hpDiff
                calcTime = _firstTime - pastFirstTime + fullTime - _currentTime
                if calcTime < 1 then
                       calcTime = 1
                   end
                   timeToDie = calcTime
            end
            if hpDiff <= 0 then
            guid = UnitGUID("target")
            _firstLife = UnitHealth("target")
            _firstLifeMax = UnitHealth("target")
            _firstTime = GetTime()
            end
            -- dummy
            if UnitHealthMax("target") == 1 then
                timeToDie = 99
            end
            if not timeToDie  then
                timeToDie = 1
            end 

Works great for me.
You just need to tweak it somewhat.

[firepong]

Here comes a framework for TTD

if (guid ~= UnitGUID("target")) or (guid == UnitGUID("target") and UnitHealth("target") == _firstLifeMax) then
               guid = UnitGUID("target")
               _firstLife = UnitHealth("target")
               _firstLifeMax = UnitHealthMax("target")
               _firstTime = GetTime()
            end             
            _currentLife = UnitHealth("target")
            _currentTime = GetTime()
            timeDiff = _currentTime - _firstTime
            hpDiff = _firstLife - _currentLife
            if hpDiff > 0 then
               fullTime = timeDiff*_firstLifeMax/hpDiff
                pastFirstTime = (_firstLifeMax - _firstLife)*timeDiff/hpDiff
                calcTime = _firstTime - pastFirstTime + fullTime - _currentTime
                if calcTime < 1 then
                       calcTime = 1
                   end
                   timeToDie = calcTime
            end
            if hpDiff <= 0 then
            guid = UnitGUID("target")
            _firstLife = UnitHealth("target")
            _firstLifeMax = UnitHealth("target")
            _firstTime = GetTime()
            end
            -- dummy
            if UnitHealthMax("target") == 1 then
                timeToDie = 99
            end
            if not timeToDie  then
                timeToDie = 1
            end 

Works great for me.
You just need to tweak it somewhat.

Think I can get that with the variables already in place so I don't have to go searching through your profiles for em xD? Can PM the base code to me if you want. If it works good enough, it's going to be turned into a function instead of making it an ability like stated there lol

[Dersam]

Sorry for posting this nooby question, but why whenever the bot start attacking i am getting tiny fps slutter?i'm not having any problems when it's not doing the rotation but it gets very annoying i didnt had this problem before. (I just reinstalled WoW yesterday so i'm not using any addons or etc)

[firepong]

Sorry for posting this nooby question, but why whenever the bot start attacking i am getting tiny fps slutter?i'm not having any problems when it's not doing the rotation but it gets very annoying i didnt had this problem before. (I just reinstalled WoW yesterday so i'm not using any addons or etc)

You weren't getting it before because before, I had made my own function for the way it handled Mangle and shred. Now, its bundled with mangle and shred so you don't have to focus the tank or player for smart detection. It's probably me using PQR_UnitFacing() thats causing it and I've found that when you go into Control-Alt-Delete and click Task Manager and right click WoW.exe and change the Priority to something higher than medium, it pretty much gets rid of that stutter. I just have my WoW set on launch to do priority == High so I don't have to do this every time.

[Dersam]

You weren't getting it before because before, I had made my own function for the way it handled Mangle and shred. Now, its bundled with mangle and shred so you don't have to focus the tank or player for smart detection. It's probably me using PQR_UnitFacing() thats causing it and I've found that when you go into Control-Alt-Delete and click Task Manager and right click WoW.exe and change the Priority to something higher than medium, it pretty much gets rid of that stutter. I just have my WoW set on launch to do priority == High so I don't have to do this every time.

I tried this, no luck im still getting the same problem.

Also i saw this in your to do list: Add in Xelper's New Facing Code for Shred and Mangle.

Is it still needed to do?