PQR - Rotation Bot

[Mavmins]

mine doesnt cast immolate twice !

[warlock2000]

Thanks for all the above ^^^.

[OnionsTich]

im backkk long time

[warlock2000]

And I'm taking back what I said about profiles not having solved the problem

[warlock2000]

Another question, on fights where there's a succession of adds popping, is there a way to code constant target switching always to the one with highest health?

I'm thinking of Heroic Immerseus, for example, when all the Congealed Sha adds come popping out of the floor. It's a tricky one for Destro, because your target for fire and brimstoneing is always in danger of getting instantly vaporized in all the aoe.

[Partykilla]

FriendlyTars = {"player",
    "party1",
    "party2",
    "party3",
    "party4",
    "party5"
    } 

Can anyone help me cast rallying cry if any of thise targets drops below 20%?
Sofar I got this:

function HealCheck(unit) -- Thanks to Bubba<3
   if UnitCanCooperate("player",unit)
   and not UnitIsCharmed(unit)
   and not UnitIsDeadOrGhost(unit)
   and not PQR_IsOutOfSight(unit)
   and UnitIsConnected(unit)
   then return true else return false end
end

function helpFriendly(unit)
if getHp(FriendlyTars) < 20
and HealCheck(FriendlyTars)
   then return true else return false end
end 

Here I want it to be more like if HelpFriendly < 20 then:

if helpFriendly then return true end 

getHp fucntion: ( To make getHp("unit") < 20 )

function getHp(unit)
if UnitExists(unit) ~= nil
        then
                return 100 * UnitHealth(unit) / UnitHealthMax(unit)
        end
end 

[crystal_tech]

FriendlyTars = {"player",
    "party1",
    "party2",
    "party3",
    "party4",
    "party5"
    } 

Can anyone help me cast rallying cry if any of thise targets drops below 20%?
Sofar I got this:

function HealCheck(unit) -- Thanks to Bubba<3
   if UnitCanCooperate("player",unit)
   and not UnitIsCharmed(unit)
   and not UnitIsDeadOrGhost(unit)
   and not PQR_IsOutOfSight(unit)
   and UnitIsConnected(unit)
   then return true else return false end
end

function helpFriendly(unit)
if getHp(FriendlyTars) < 20
and HealCheck(FriendlyTars)
   then return true else return false end
end 

Here I want it to be more like if HelpFriendly < 20 then:

if helpFriendly then return true end 

getHp fucntion: ( To make getHp("unit") < 20 )

function getHp(unit)
if UnitExists(unit) ~= nil
        then
                return 100 * UnitHealth(unit) / UnitHealthMax(unit)
        end
end 

i think you need to loop inside helpfriendly

here try this:

FriendlyTars = {
	"player", 
    "party1", 
    "party2", 
    "party3", 
    "party4", 
    "party5" 
    }  
	
function HealCheck(unit) -- Thanks to Bubba<3 
   if UnitCanCooperate("player",unit) 
	and not UnitIsCharmed(unit) 
	and not UnitIsDeadOrGhost(unit) 
	and not PQR_IsOutOfSight(unit) 
	and UnitIsConnected(unit) 
   then return true else return false end 
end 

function getHp(unit) 
if UnitExists(unit) ~= nil 
        then 
                return 100 * UnitHealth(unit) / UnitHealthMax(unit) 
        end 
end  

function helpFriendly() 
for i=1, #FriendlyTars do
	if getHp(i) < 20 and HealCheck(i) then 
		return true
	else
		return false
	end 
end  

if helpFriendly() then return true end

[Partykilla]

i think you need to loop inside helpfriendly

here try this:
...

Seems to be right, but how would I go on about if I'd like to cast spell on this friendly target that needs help?

[crystal_tech]

Ah one min I'll mod the code a bit, hard to do this since my wow game time is up and i have no money to get more. but i think this should work

FriendlyTars = {
	"player", 
    "party1", 
    "party2", 
    "party3", 
    "party4", 
    "party5" 
    }  

order = { }
function HealCheck(unit) -- Thanks to Bubba<3 
   if UnitCanCooperate("player",unit) 
	and not UnitIsCharmed(unit) 
	and not UnitIsDeadOrGhost(unit) 
	and not PQR_IsOutOfSight(unit) 
	and UnitIsConnected(unit) 
   then return true else return false end 
end 

function getHp(unit) 
if UnitExists(unit) ~= nil 
        then 
                return 100 * UnitHealth(unit) / UnitHealthMax(unit) 
        end 
end  

function helpFriendly() 
for i=1, #FriendlyTars do
	if getHp(FriendlyTars[i]) < 20 and HealCheck(FriendlyTars[i]) then 
		return FriendlyTars[i]
	else
		return false
	end 
end  

if helpFriendly() ~= false then
	shouldtarget = helpFriendly()
	CastSpellByName(GetSpellInfo(id), shouldtarget)
	return true
end

it might need a table sort but like i said i can't test this until i get some game time.

[Partykilla]

Ah one min I'll mod the code a bit, hard to do this since my wow game time is up and i have no money to get more. but i think this should work

FriendlyTars = {
	"player", 
    "party1", 
    "party2", 
    "party3", 
    "party4", 
    "party5" 
    }  

order = { }
function HealCheck(unit) -- Thanks to Bubba<3 
   if UnitCanCooperate("player",unit) 
	and not UnitIsCharmed(unit) 
	and not UnitIsDeadOrGhost(unit) 
	and not PQR_IsOutOfSight(unit) 
	and UnitIsConnected(unit) 
   then return true else return false end 
end 

function getHp(unit) 
if UnitExists(unit) ~= nil 
        then 
                return 100 * UnitHealth(unit) / UnitHealthMax(unit) 
        end 
end  

function helpFriendly() 
for i=1, #FriendlyTars do
	if getHp(FriendlyTars[i]) < 20 and HealCheck(FriendlyTars[i]) then 
		return FriendlyTars[i]
	else
		return false
	end 
end  

if helpFriendly() ~= false then
	shouldtarget = helpFriendly()
	CastSpellByName(GetSpellInfo(id), shouldtarget)
	return true
end

it might need a table sort but like i said i can't test this until i get some game time.

1hr later, still waiting like a little boy on xmas

[Beelzix]

anyone have a link to a survival hunter pvp profile? thats updated

[cokx]

anyone have a link to a survival hunter pvp profile? thats updated

I have a BM/MM/SV Hunter PVP Profile

1hr later, still waiting like a little boy on xmas

FriendlyTars = {
"player",
"party1",
"party2",
"party3",
"party4",
"party5"
}
function HealCheck(unit) -- Thanks to Bubba<3
if UnitCanCooperate("player",unit)
and not UnitIsCharmed(unit)
and not UnitIsDeadOrGhost(unit)
and not PQR_IsOutOfSight(unit)
and UnitIsConnected(unit)
then return true
end
end
function getHp(unit)
if UnitExists(unit)
then
return 100 * UnitHealth(unit) / UnitHealthMax(unit)
end
end

table.sort(FriendlyTars , function(x,y) return getHp(x) < getHp(y) end)

for i = 1, #FriendlyTars do --- You still need a Range Check otherwise you will waste your shout
if getHp(FriendlyTars[i]) < 20 -- First check the HP (performance wise and your HP check also checks if the unit rly exist
and HealCheck(FriendlyTars[i])
then
PQR_CustomTarget = FriendlyTars[i]
return true
end
end

[rootlsuer]

It would be cool if we could get the functionality that MagicHealingBalls does in PQR - so the reticle/aoe abilities can be cast on units. That is, if you think it's safe.

[Ninjaderp]

Its been talked about already and told to come into the 3.0 version of PQR, whenever Xelper is done with that ^^

[rootlsuer]

Its been talked about already and told to come into the 3.0 version of PQR, whenever Xelper is done with that ^^

There is so much talk to weed through - searching for "3.0" shows that it's indefinitely on hold(?) And when I saw it's initial feature list; continuing the whole lua-in-xml ordeal, my heart sunk a bit more.

Why not just use simple, tangible, editable and debug-able lua files for each ability? It seems a wasted effort to include a clunky component editor since that job is done far better elsewhere; a very personal thing - then use one xml to manage the rotation. Basically, ditch the ability editor and add the ability's parameters to the rotation editor. It would make the app smaller and this guy weep with joy.