PQR - Rotation Bot

[haisenberg]

High level frameworks are generally a bad idea especially with changing content. The WoW API has all the tools you need to perform these actions; adding more obscurity would merely make this task more difficult or obscure. If you want to see code on how to heal blue blobs or tsulong, check out vachiusa's profiles.

I see your point. Blue blobs or tsulong were just examples. The main idea behind it (was): Right now, most profiles have their own library of events and actions, some work very good some not ( -> I mean certain bosses and actions work better then others and certain libraries work better then others in certain regards). Why not merging them into one "big (bad)" thing / library where any developer can make use of right away... not really bigger then currently existent. 3 modules: dps, tank, heal (MAYBE fourth category for whatever special task a person can have). The developer takes the respective and necessary module for hier/her new/current profile.. and ta-da... boss actions added (of course, my description is VERY superficial, I am aware of that).

[crystal_tech]

Hi, quick question for the knowledgeable guys. Here's a piece of code I've written for a Shadowburn function with Havoc up. It works perfectly for its designed function so far in raids.

The weird thing is, if I'm running around Shrine or in a raid instance and do not have a target, I get huge LUA error spam. The moment I target any player or Npc, the spam stops.

Code:

local Targethealth = 100*UnitHealth("target")/UnitHealthMax("target")
local Havoc,_,_,Havocstacks = UnitBuffID("player",80240)
local TargetID = tonumber(UnitGUID("target"):sub(6,10),16)
----------------------------------------------------------------------------

if UnitAffectingCombat("player")
and UnitExists("target") ~= nil then
if TargetID == 73195 -- Kor'kron Jailer
or TargetID == 71720 -- Ice Tomb
or TargetID == 71979 -- Kor'kron Warbringer
or TargetID == 71983 -- Farseer Wolf Rider
or TargetID == 72154 -- Desecrated Weapon
or TargetID == 72198 -- Empowered Desecrated Weapon
or TargetID == 72272 then -- Minion of Y'Shaarj
if IsPlayerSpell(17877) == true
and PQR_SpellAvailable(17877) == true
and IsSpellInRange(GetSpellInfo(17877),"target") == 1
and Havoc ~= nil and Havocstacks >= 1
and UnitPower("player",14) >= 1
and Targethealth <= 20 then
CastSpellByName(GetSpellInfo(17877),"target")
LASTCAST = "Shadowburn"
return true
end
end
end

Any ideas?!?

the lua errors stem prob from you math not getting a value or its returning a nil.

i've made some mods to your code however, take them as you see them or change them up again.

local sTargets = { 73195, 71720, 71979, 71983, 72154, 72198, 72272 } --add your mobs here
local Havoc,_,_,Havocstacks = UnitBuffID("player",80240)
local Targethealth = 999 --using this to prevent nil math errors

if UnitExits("target") then Targethealth = 100*UnitHealth("target")/UnitHealthMax("target") else Targethealth = 999 end 
--above keeps Targethealth as a local for ya

function isStarget() --pretty much this is ments specialUnit function 
    if UnitExists("target") then
        local TargetID = tonumber(UnitGUID("target"):sub(6,10),16)
        for i=1, #sTargets do
            if sTargets[i] == TargetID then
                return true
            end
            return false
        end
    else
        return false
    end
end

--the core
if UnitAffectingCombat("player") and UnitExists("target") then
    if IsPlayerSpell(17877)
        and PQR_SpellAvailable(17877)
        and IsSpellInRange(GetSpellInfo(17877),"target") == 1
        and Havoc ~= nil and Havocstacks >= 1
        and UnitPower("player",14) >= 1
        and Targethealth <= 20
        and isStarget() --the new function to check npcids 
    then
        CastSpellByName(GetSpellInfo(17877),"target") 
        LASTCAST = "Shadowburn"
        return true
    end
end 

[warlock2000]

Thanks for this crystaltech ^^^. This is superb.

[Cikapaja]

New offsets anyone?

Edit:
Actually everything is working on 17399, disregard this post.

[crystal_tech]

Thanks for this crystaltech ^^^. This is superb.

no prob, i did forget one thing.

the function is being recreated everytime the ability is ran so to stop it and only create it once put the function inside a if then like this

if not _runonce then
function here
_runonce = true
end


would prevent some laggy-ness in the the profile.

[jshookz]

PQR not working on the PTR servers.

[Ninjaderp]

I didnt know PTR-servers were still up, what can they possible be testing there now when 5.4 has gone live already?

[crystal_tech]

5.4.1 patch

[jshookz]

Well not even that I go on the PTR to test out profiles for the toons that I don't have 90's for :P

[fzU]

Any possibility to use razer mouse buttons Num1-12? like IsMouseButtonDown(9) ?

[crystal_tech]

Any possibility to use razer mouse buttons Num1-12? like IsMouseButtonDown(9) ?

Doubtful as the name keys are just mapped keyboard keys and they don't have api like the mod keys have

[Bekimo]

I'm really sadpanda cause there aint good working UH rotation to PVE. Would be extremely happy and spam rep to person who makes one good UH rotation.

But still i thanks everyone who has made free rotations and Xelper massive thanks.

[firepong]

Doubtful as the name keys are just mapped keyboard keys and they don't have api like the mod keys have

Oh, but there is (Possibly). Download the Razer WoW addon for the mouse and look how they have the buttons setup there. Might give you an Idea on how to get it to work. My guess though is it would be a custom function where you inject a macro on start then delete the macro after the spell is cast or something like that.

[kickmydog]

performing arithmetic on unchecked values makes me cringe...

API UnitHealthMax - WoWWiki - Your guide to the World of Warcraft

returns 0 by default.. you've now divided by zero.

Returns 0 if you have no target.

[CodeMyLife]

Any possibility to use razer mouse buttons Num1-12? like IsMouseButtonDown(9) ?

You should not use razer its really shitty :P

That beign said it could be done with macros that you assing to keys in WoW.. Simply