PQR - Rotation Bot

[daveyboyuk]

anyone having problems with pqi on ptr ?

[cpowroks]

heres my edit for PQI on the ptr
https://dl.dropboxusercontent.com/u/...0for%20PTR.zip

also ill post the new ptr off sets in the morning because im off tomorrow. dont feel like doing it tonight

[darkblood14]

Hey, I'm running PQR 2.2.2 with a 4.3.4 wow client (15595 build) and every time I'm pressing alt+x or alt+c the pqr window just freezes for 5-10 seconds then it does nothing. The program seems to detect character name and class just fine, not sure about other offsets.

Can anyone give any idea how to fix this?

[MrHeroe]

i just cant find a guide how to start with lua or creating pqr profiles. Im pretty good in Java and visual basic so i have a solid background but its realy hard to get into this topic.

My try and error experience wont get me any furhter.

Can someone give me a advise how to create simple profile?
The funny thing is, that i understand what other developers have wrote in their profiles but if i change something (to cast another spell for example) i cant get it working. So i started with a single ability in a new profile and i got it working but without any kind of controll structure (if or loops). If i try to implement some simple statements it stops working without any message (even with advanced debug mode). Now im depressed =(

To get a better feeling i have several questions - please answer on them =)

How does functions work? Can i declare them in the ability itself or do i have to implement them in a "initiate" ability?
Does PQR runs through everyability from up to down?
What means if a ability returns "true" ?
What does PQI do and what do i need to implement it into the profile? Pros / Cons?
Due to performance issues what kind of checks i should avoid?
What do i need to enter into the ability settings window if i want to adjust everything in the code?

I hope you can get me a better picture of working with PQR.

Thank you. Excuse my english - its not my native language.

Best regads

[masteradzy]

Does anyone have a quick fix for why my PQR lags wow??
It was working fine, its up to date etc

(P.S the profile im using is the Hysteria Demo Lock one)

[Vinshom]

For God's sake what is the id code for Dark Soul: Instability, 113858 or 77801 dont seemed to work.

[kickmydog]

i just cant find a guide how to start with lua or creating pqr profiles. Im pretty good in Java and visual basic so i have a solid background but its realy hard to get into this topic.

My try and error experience wont get me any furhter.

Can someone give me a advise how to create simple profile?
The funny thing is, that i understand what other developers have wrote in their profiles but if i change something (to cast another spell for example) i cant get it working. So i started with a single ability in a new profile and i got it working but without any kind of controll structure (if or loops). If i try to implement some simple statements it stops working without any message (even with advanced debug mode). Now im depressed =(

To get a better feeling i have several questions - please answer on them =)

How does functions work? Can i declare them in the ability itself or do i have to implement them in a "initiate" ability?
Does PQR runs through everyability from up to down?
What means if a ability returns "true" ?
What does PQI do and what do i need to implement it into the profile? Pros / Cons?
Due to performance issues what kind of checks i should avoid?
What do i need to enter into the ability settings window if i want to adjust everything in the code?

I hope you can get me a better picture of working with PQR.

Thank you. Excuse my english - its not my native language.

Best regads

You can declare functions to be called later but you either want them in an ability at the start of the rotation or in a datafile.

function F_traplaunch()
    if ( IsLeftAltKeyDown() or IsRightAltKeyDown() )
    and not UnitBuffID("player", 77769) 
    then CastSpellByID(77769, "player") end
end 

PQR checks if the statements are true for each ability top to bottom until it finds one that is true. Then it activates that ability and starts at the top again.

If something "returns true" that means that the ability activates.

I would steer clear of PQI until you have mastered writing for PQR. It isn't needed to run PQR, but does add some pretty nice UI stuff. There is a PQI wiki somewhere I've forgotten the link for it because I don't use it.

Write the code as short and concise as possible. The longer the code the slower it runs. Try to avoid loops because they can bog things down.

Look at wowhead for spell id numbers. For example Explosive Shot is 53301 on wowhead you would find "http://www.wowhead.com/spell=53301/explosive-shot"

[MrHeroe]

You can declare functions to be called later but you either want them in an ability at the start of the rotation or in a datafile.

function F_traplaunch()
    if ( IsLeftAltKeyDown() or IsRightAltKeyDown() )
    and not UnitBuffID("player", 77769) 
    then CastSpellByID(77769, "player") end
end 

PQR checks if the statements are true for each ability top to bottom until it finds one that is true. Then it activates that ability and starts at the top again.

If something "returns true" that means that the ability activates.

I would steer clear of PQI until you have mastered writing for PQR. It isn't needed to run PQR, but does add some pretty nice UI stuff. There is a PQI wiki somewhere I've forgotten the link for it because I don't use it.

Write the code as short and concise as possible. The longer the code the slower it runs. Try to avoid loops because they can bog things down.

Look at wowhead for spell id numbers. For example Explosive Shot is 53301 on wowhead you would find "http://www.wowhead.com/spell=53301/explosive-shot"

Great thank you.

And i can use every function the wow api provides without implement anything?

for example:

if UnitHealth("player") < 100000 then return true end

just for example? Every function i can find here? World of Warcraft API - WoWWiki - Your guide to the World of Warcraft ?

Whats about the functions i cant find but many programmer here use? Looked inside their --init-- ability or the lui file in the data folder and didnt find it. For example For 1 to #member (or something like that) ? #member is not a normal function/variable i think.

Thank you very much

[tobmaps]

And i can use every function the wow api provides without implement anything?

for example: just for example? Every function i can find here? World of Warcraft API - WoWWiki - Your guide to the World of Warcraft ?

yes, everything from this page can be used.

Whats about the functions i cant find but many programmer here use? Looked inside their --init-- ability or the lui file in the data folder and didnt find it. For example For 1 to #member (or something like that) ? #member is not a normal function/variable i think.

i never used PQR since i always write own ingame LUA based bots via SDM addon but i believe it's additional API stuff integrated by PQR like LOS checks and etc. You can find short reference at PQR wiki page i think.

function F_traplaunch()
    if ( IsLeftAltKeyDown() or IsRightAltKeyDown() )
    and not UnitBuffID("player", 77769) 
    then CastSpellByID(77769, "player") end
end 

PQR checks if the statements are true for each ability top to bottom until it finds one that is true. Then it activates that ability and starts at the top again.

If something "returns true" that means that the ability activates.

not for PQR and even for MoP (dunno if the spells ids are the same but it's for Cata) but can gave ya some ideas. Just a part of my "really" one-button hunter mod. Allow you to push your bind to instantly freeze ranged target even if you run and it's behind you ^^

function CanFreezingTrap()
    if CanUse(throwTrap) and EnoughFocusNoCooldown(freezingTrap) then
        return true
    else
        return false
    end
end

function RunFreezingTrap()
    FreezingTrapInAction = true
    WhenRefuseFreezingTrap = GetTime() + 1
end

function CastFreezingTrap()
    if GetTime() > WhenRefuseFreezingTrap or FreezingTrapUsed then
		--[[if FreezingTrapUsed then
			print("freezing trap finished")
		else
			print("waiting too long - refusing freezing trap, time waited: ", GetTime() - WhenRefuseFreezingTrap + 1)
		end]]
 		FreezingTrapInAction = false
		FreezingTrapUsed = false
		ThrowTrapUsed = false
        return
    end
	if HasBuff(throwTrap) then
		if CanUse(freezingTrap) then
			c(freezingTrap)
			if SpellIsTargeting() then
				CameraOrSelectOrMoveStart()
				CameraOrSelectOrMoveStop()
			end
		end
	elseif CanUse(throwTrap) and not ThrowTrapUsed then
		c(throwTrap)
	end
end

local onEvent = function(self, event, ...)
	if (event == "UNIT_SPELLCAST_SUCCEEDED") then
		local unitCaster, spellName, spellRequirements, spellLineId, spellId = select(1, ...)
		if unitCaster == me then
			if spellId == 60192 then FreezingTrapUsed = true
			elseif spellId == 77769 then ThrowTrapUsed = true end
		end
...

function names and variables talk for themselves ^^

[kickmydog]

yes, everything from this page can be used.


i never used PQR since i always write own ingame LUA based bots via SDM addon but i believe it's additional API stuff integrated by PQR like LOS checks and etc. You can find short reference at PQR wiki page i think.



not for PQR and even for MoP (dunno if the spells ids are the same but it's for Cata) but can gave ya some ideas. Just a part of my "really" one-button hunter mod. Allow you to push your bind to instantly freeze ranged target ^^

function CanFreezingTrap()
    if CanUse(throwTrap) and EnoughFocusNoCooldown(freezingTrap) then
        return true
    else
        return false
    end
end

function RunFreezingTrap()
    FreezingTrapInAction = true
    WhenRefuseFreezingTrap = GetTime() + 1
end

function CastFreezingTrap()
    if GetTime() > WhenRefuseFreezingTrap or FreezingTrapUsed then
		--[[if FreezingTrapUsed then
			print("freezing trap finished")
		else
			print("waiting too long - refusing freezing trap, time waited: ", GetTime() - WhenRefuseFreezingTrap + 1)
		end]]
 		FreezingTrapInAction = false
		FreezingTrapUsed = false
		ThrowTrapUsed = false
        return
    end
	if HasBuff(throwTrap) then
		if CanUse(freezingTrap) then
			c(freezingTrap)
			if SpellIsTargeting() then
				CameraOrSelectOrMoveStart()
				CameraOrSelectOrMoveStop()
			end
		end
	elseif CanUse(throwTrap) and not ThrowTrapUsed then
		c(throwTrap)
	end
end

local onEvent = function(self, event, ...)
	if (event == "UNIT_SPELLCAST_SUCCEEDED") then
		local unitCaster, spellName, spellRequirements, spellLineId, spellId = select(1, ...)
		if unitCaster == me then
			if spellId == 60192 then FreezingTrapUsed = true
			elseif spellId == 77769 then ThrowTrapUsed = true end
		end
...

function names and variables talk for themselves ^^

So much of that code is redundant it is not even a joke. If you don't have enough focus it won't use an ability so you don't need to check if you have enough focus. If something is on cooldown it won't use it either, so there is no point checking for that.

If you have a "return true" before the "return false" then you really don't need the "return false". Since it will automatically "return false" if the "return true" is not activated.

Also the post was supposed to be for a brand new person trying to write code for PQR for the first time. Your code is not going to really going to help them understand the fundamentals.

[bgr]

if by AoE casting automatically you think of positioning mouse over a desired target then no. You have to position yourself and then aoe can be casted on mouseover with a keybind. For now there is no way to keybind other keys than shift, alt, control but you can use ingame macros and keybind them to any key and make PQR respond to that, so it's a kind of a workaround and I must say it works very nice. Scanning enemy is possible but not in PQR itself, you have to be a bit creative about it . LOS is a major issue as it's being throtthled on a 3 sec basis, meaninig you can run 1 LOS check in 3 secs with PQR_IsOutOfSight(). you can check more at PQR Custom Functions - PQRotation Wiki . And as for last, PQR is managing your abilities, recast delays, follows the rotation list etc.... while Lua Unlocker well....only unlocks

Could you please explain how to do this or point me in the right direction?

Thank you

[tobmaps]

If you don't have enough focus it won't use an ability so you don't need to check if you have enough focus. If something is on cooldown it won't use it either, so there is no point checking for that.

Checks included inside CanUse() that's why i said it's only the part and that's why i said that names is self-explanatory. It's only to show up idea. All of those variables used in my priority handler. I can upload if someone interested in it. Just did a random share nothing else have fun with that.

[CodeMyLife]

did i missed it? i don't find it. In his svn he has "pokerotation", but i don't know if thats it.

It's not yet released you did not miss it. I have it at a beta stage on my SVN. It works insanely for leveling pets at this stage the only downside is that not all pets are coded. I've been out for the week sadly did nothing but I want to release this and my prot warrior setup this week.

Feel free to try it already if you want! What is to do atm is refining my buff/abilities report so that players can report me their pets abilities so that i can add these to the lists. The engine is already pretty solid. Coding a new pet at this development stage takes me 2 minuts approx. It's very close to release.

Try using " -- 2X Ringner " rotation. Put two good pets (lvl 25 if possible) in the slots 2-3. One pet to level in slot 1, no matter what level. This will make battle so that the pet in slot 1 survive and ringners will finish the job. Pretty simple.

Have fun!

[deadpanstiffy]

It's not yet released you did not miss it. I have it at a beta stage on my SVN. It works insanely for leveling pets at this stage the only downside is that not all pets are coded. I've been out for the week sadly did nothing but I want to release this and my prot warrior setup this week.

Feel free to try it already if you want! What is to do atm is refining my buff/abilities report so that players can report me their pets abilities so that i can add these to the lists. The engine is already pretty solid. Coding a new pet at this development stage takes me 2 minuts approx. It's very close to release.

Try using " -- 2X Ringner " rotation. Put two good pets (lvl 25 if possible) in the slots 2-3. One pet to level in slot 1, no matter what level. This will make battle so that the pet in slot 1 survive and ringners will finish the job. Pretty simple.

Have fun!

I have a profile to level pets with a friend, the first part is manual from 1-6-9, once both pets are level 9 you can run the profile and it will start trading wins. Takes 15-20 min per pet.

[MrHeroe]

yes, everything from this page can be used.


i never used PQR since i always write own ingame LUA based bots via SDM addon but i believe it's additional API stuff integrated by PQR like LOS checks and etc. You can find short reference at PQR wiki page i think.



not for PQR and even for MoP (dunno if the spells ids are the same but it's for Cata) but can gave ya some ideas. Just a part of my "really" one-button hunter mod. Allow you to push your bind to instantly freeze ranged target even if you run and it's behind you ^^

function CanFreezingTrap()
    if CanUse(throwTrap) and EnoughFocusNoCooldown(freezingTrap) then
        return true
    else
        return false
    end
end

function RunFreezingTrap()
    FreezingTrapInAction = true
    WhenRefuseFreezingTrap = GetTime() + 1
end

function CastFreezingTrap()
    if GetTime() > WhenRefuseFreezingTrap or FreezingTrapUsed then
		--[[if FreezingTrapUsed then
			print("freezing trap finished")
		else
			print("waiting too long - refusing freezing trap, time waited: ", GetTime() - WhenRefuseFreezingTrap + 1)
		end]]
 		FreezingTrapInAction = false
		FreezingTrapUsed = false
		ThrowTrapUsed = false
        return
    end
	if HasBuff(throwTrap) then
		if CanUse(freezingTrap) then
			c(freezingTrap)
			if SpellIsTargeting() then
				CameraOrSelectOrMoveStart()
				CameraOrSelectOrMoveStop()
			end
		end
	elseif CanUse(throwTrap) and not ThrowTrapUsed then
		c(throwTrap)
	end
end

local onEvent = function(self, event, ...)
	if (event == "UNIT_SPELLCAST_SUCCEEDED") then
		local unitCaster, spellName, spellRequirements, spellLineId, spellId = select(1, ...)
		if unitCaster == me then
			if spellId == 60192 then FreezingTrapUsed = true
			elseif spellId == 77769 then ThrowTrapUsed = true end
		end
...

function names and variables talk for themselves ^^

All right thank you. One more question about the functions:

i found (for example) this function:

function CalculateHP(t)
incomingheals = UnitGetIncomingHeals(t) or 0
return 100 * ( UnitHealth(t) + incomingheals ) / UnitHealthMax(t)
end

The function UnitGetIncomingHeals() is not declared in a ability or in the lua api or in the custom functions... where does it come from?

World of Warcraft API - WoWWiki - Your guide to the World of Warcraft
PQR Custom Functions - PQRotation Wiki

best regards