PQR - Rotation Bot

[thenthelies]

Thanks a lot crystal_tech, I'll dig deep and try to recreate that though nova/profile you gave for reference.

What is your problem exactly? Im coding in a similiar way and for the most part there is no issue. Altough some of the abilities that are off cd like Soulburn there could be some timing issues.

The best way is to create a timer for when you tried the ability and then check that amount of time has passed. But again, what is the problem really?

I've started coding a destro lock and the most glaring problem would be double casting immolate on initial application because it's queuing up the next spell (another immolate) before it registers the DOT is active. Pretty much It will usually double cast ANY ability that cast time is longer than the GCD and doesn't have a CD. I know I can fix these things with SpellCancelQueuedSpell() but that's loosing precious milliseconds on my minmax rotation.

I play with manual cast macro set to auto hotkey spamming 0ms + my ingame latency adjuster set to 400ms (i play at 200ms) so I can guarantee 0ms delay between ability casts.

[crystal_tech]

Thanks a lot crystal_tech, I'll dig deep and try to recreate that though nova/profile you gave for reference.



I've started coding a destro lock and the most glaring problem would be double casting immolate on initial application because it's queuing up the next spell (another immolate) before it registers the DOT is active. Pretty much It will usually double cast ANY ability that cast time is longer than the GCD and doesn't have a CD. I know I can fix these things with SpellCancelQueuedSpell() but that's loosing precious milliseconds on my minmax rotation.

I play with manual cast macro set to auto hotkey spamming 0ms + my ingame latency adjuster set to 400ms (i play at 200ms) so I can guarantee 0ms delay between ability casts.

for the quickest fix heres the code from the data file

--Tabled Cast Time Checking for When you Last Cast Something.
CheckCastTime = {}
Nova_CheckLastCast = nil
function Nova_CheckLastCast(spellid, ytime) -- SpellID of Spell To Check, How long of a gap are you looking for?
    if ytime > 0 then
        if #CheckCastTime > 0 then
            for i=1, #CheckCastTime do
                if CheckCastTime[i].SpellID == spellid then
                    if GetTime() - CheckCastTime[i].CastTime > ytime then
                        CheckCastTime[i].CastTime = GetTime()
                        return true
                    else
                        return false
                    end
                end
            end
        end
        table.insert(CheckCastTime, { SpellID = spellid, CastTime = GetTime() } )
        return true
    elseif ytime <= 0 then
        return true
    end
    return false
end 

pretty much this is how to use it

if Nova_CheckLastCast(spellid, .3) then --set delay
     if not UnitDebuffID("target", SpellID) then --if debuff is missing
          CastSpellByName(GetSpellInfo(spellid)) --cast it
          return true
     --if debuff is up and time left on it is less than 2 secs 
     elseif UnitDebuffID("target", SpellID) and select(7, UnitDebuffID("target", SpellID)) - GetTime() < 2 then 
          CastSpellByName(GetSpellInfo(spellid)) -- cast it
          return true
     end
end 

[WWF]

Any chance you could upload that for me?

done (private)

[paintpauller]

any idea on how to check if a spell was successfully cast? trying to make some simple code to both take advantage of double jeopardy and keep Censure up on my focus.
here is what i have so far, it will only cast on my focus because JudgOnTarget is never being set true. ignore the prints they are there for debugging =p

if UnitExists("focus")
    and not UnitIsDeadOrGhost("focus")
    and not PQR_IsOutOfSight("focus", 1)
    and UnitCanAttack("player", "focus") == 1
    and IsSpellInRange(GetSpellInfo(20271), "focus") == 1
then
    useFocusJudg = true
else
    useFocusJudg = false
end


if setJudgOn == nil then
    setJudgOn = true
    
    JudgOnFocus = true 
    print("JudgOnFocus set")
    JudgOnTarget = false 
    print("JudgOnTarget set")
end


if useFocusJudg then
    if JudgOnFocus == true then
        JudgOnTarget = CastSpellByName(GetSpellInfo(20271),"focus")
        if JudgOnTarget == true then
            JudgOnFocus = false
            print("Judg on Focus")
        end
        return true
    elseif JudgOnTarget == true then
        JudgOnFocus = CastSpellByName(GetSpellInfo(20271),"target")
        if JudgOnFocus == true then
            JudgOnTarget = false
            print("Judg on Target")
        end
        return true
    end
else
    print("No focus, Judg on Target")
    CastSpellByName(GetSpellInfo(20271),"target")
    return true
end 

[piratepetey]

Hi all.

Curious problem for the coders here:

Remember the checks for MSV heroic that would stop DPSing the boss if certain abilities were up, e.g. Spirit Kings heroic:

if npcID == 60709 then --Spirit Kings: Qiang. (Impervious Shield) 
            --Stop all attacks until 0.2 seconds after cast time ends and until buff (Impervious Shield) is gone. 
             
            --only continue checking if we are targetting the boss or have no target. 
            if (not UnitExists("target")) or (UnitIsUnit("target", bossCheck)) or (cleaveClass or isAOE) then 
                local impName = GetSpellInfo(117961) 
                local impShieldBuff = UnitBuffID(bossCheck, 117961) 
                 
                if (bossCasting and bossCasting == impName) then 
                    StopAttack() 
                    SpellStopCasting() 
                    local delayAdd = (castEnd/1000) - GetTime() --the number of seconds remaining on the cast. 
                    PQR_resumeAttack = GetTime() + delayAdd + 0.2 
                    return true 
                end 

Could anyone have a bash at doing that for some of the fights in 5.2? I'm thinking specifically from a healer POV for Twin Consorts for the tank debuff Beast of Nightmare. Healers can't heal that target and should only use BIG hitting heals to top.

Anyone up for a bit of a challenge?



Edit: I think I've found a way to do it using one of Sheuron's healing functions that's included in the Nova data file, but if anyone else has a more elegant method I'd be interested to hear it

[vitalic]

So WWF kindly sent me 2.1.0 and I can say with some certainty there has been a change between the two versions that is having a big effect on CPU consumption, perhaps you might want to take a look Xelper?



On 2.1.0 it runs at 0% cpu when idle, and 0-0.1% when running my profile, which is using 2-7% in 2.2.0

[dklcfr]

anyone got ability code for this trinket? Stolen Relic of Zuldazar - Item - World of Warcraft

[Troy598]

Reserved thread - In case one day I try to develop profile

[blakehan]

So WWF kindly sent me 2.1.0 and I can say with some certainty there has been a change between the two versions that is having a big effect on CPU consumption, perhaps you might want to take a look Xelper?



On 2.1.0 it runs at 0% cpu when idle, and 0-0.1% when running my profile, which is using 2-7% in 2.2.0

hi ! can u send me 2.1.0 PQR?
email: [email protected]

[gnitor]

anyone got ability code for this trinket? Stolen Relic of Zuldazar - Item - World of Warcraft

Could it be this? Blessing of Zuldazar - Spell - World of Warcraft

any idea on how to check if a spell was successfully cast? trying to make some simple code to both take advantage of double jeopardy and keep Censure up on my focus.
here is what i have so far, it will only cast on my focus because JudgOnTarget is never being set true. ignore the prints they are there for debugging =p

I haven't done anything like that but you might want to try to use Units GUID between your target and your focus, and store on which you did your Judgement last directly. http://www.wowwiki.com/API_UnitGUID
This is maybe stupid, but my understanding of GUID is that they are unique so you should be able to differentiate easily on which target you did your Judgement.

This said, it might be very interesting if there is already a way to know if a spell has been successfully cast on the target like you mean.

[MaathaiWangari]

I am interested in Affliction Warlock and 5.0.4 BM Hunter. Reviewed in detail on the issue of PQR - Rotation Bot. Nice comments and sharing seen here.

Hanging Scales

[Gabbz]

for the quickest fix heres the code from the data file

--Tabled Cast Time Checking for When you Last Cast Something.
CheckCastTime = {}
Nova_CheckLastCast = nil
function Nova_CheckLastCast(spellid, ytime) -- SpellID of Spell To Check, How long of a gap are you looking for?
    if ytime > 0 then
        if #CheckCastTime > 0 then
            for i=1, #CheckCastTime do
                if CheckCastTime[i].SpellID == spellid then
                    if GetTime() - CheckCastTime[i].CastTime > ytime then
                        CheckCastTime[i].CastTime = GetTime()
                        return true
                    else
                        return false
                    end
                end
            end
        end
        table.insert(CheckCastTime, { SpellID = spellid, CastTime = GetTime() } )
        return true
    elseif ytime <= 0 then
        return true
    end
    return false
end 

pretty much this is how to use it

if Nova_CheckLastCast(spellid, .3) then --set delay
     if not UnitDebuffID("target", SpellID) then --if debuff is missing
          CastSpellByName(GetSpellInfo(spellid)) --cast it
          return true
     --if debuff is up and time left on it is less than 2 secs 
     elseif UnitDebuffID("target", SpellID) and select(7, UnitDebuffID("target", SpellID)) - GetTime() < 2 then 
          CastSpellByName(GetSpellInfo(spellid)) -- cast it
          return true
     end
end 

Crystal, is there no check that you actually cast the spell? It seems that when checking if it already have been cast you also insert the spell in the table. However it is not certain that the spell actually was cast.

[Nerder]

any idea on how to check if a spell was successfully cast? trying to make some simple code to both take advantage of double jeopardy and keep Censure up on my focus.
here is what i have so far, it will only cast on my focus because JudgOnTarget is never being set true. ignore the prints they are there for debugging =p

So I already responded to paint in a PM but just for anyone else who wants to see for his check on the successful cast you could work with what I did. I am giving credit to the nova team on the main part to me getting this, which is what bubba put out for his mistweaver check a while ago.

Long story short though my code was made for my combat rogue profile to check how many times sinister strike and or revealing strike have been cast while the moderate insight buff was up and active. Here's what I have and have it working:

if UnitBuffID("player", MODERATEINSIGHT) == nil then
	CheckForDeep = 0
end

if CombatLog == nil then
   Nova_CombatLog = CreateFrame('Frame')

   Nova_CombatLog:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
   function CombatLog_OnEvent(self, event, ...)
   		local type, _, sourceGUID, sourceNAME, _, _, destGUID, destNAME = select(2, ...)
        if (event=="COMBAT_LOG_EVENT_UNFILTERED") then
			if sourceNAME ~= UnitName("player") then --Could add in a "if destGUID ~= UnitGUID("focus") then"
            	return false
            end
            if type == "SPELL_DAMAGE" and ( select(12, ...) == 1752 or select(12, ...) == 84617 ) then --It'll trigger if there was any damage either sinister strike, or revealing strike
               	CheckForDeep = CheckForDeep + 1
			elseif type == "SPELL_AURA_REMOVED" and ( select(12, ...) == 84745 or select(12, ...) == 84746 or select(12, ...) == 84747 ) then --will set the counter back to 0 if any of the 3 buffs were lost
				CheckForDeep = 0
			end
		end
	end


    
    Nova_CombatLog:SetScript("OnEvent", CombatLog_OnEvent)
    
	CombatLog = true
end

and then after it has the check the application for it was in my spell for slice and dice, so when I had the buff moderate insight, and was at 3 sucsessful hits from either sinister strike or revealing strike to cast slice and dice again:

if AoE and FanOK == 1 then
	return false
end

if ( not HasBuff(SLICEANDDICE)
 or ( BuffTime(SLICEANDDICE) < 2
 or ( BuffTime(SLICEANDDICE) < 15
 and CheckForDeep == 3
 and GetComboPoints("player", "target") >= 4 ) ) ) then
        Cast(SLICEANDDICE)
end

[Guinness]

Just so you know there will be some PQR functions that will not work right in 2.1 because of the way Blizzard updated their end. It might not be an impact for the character and profile your are using PQR on at the moment, just something to realize.

[paintpauller]

Big thanks to Nerder for pointing me into the right direction!

for those wanting a working double jeopardy/censure code for your focus here it is!

if UnitExists("focus")
    and not UnitIsDeadOrGhost("focus")
    and not PQR_IsOutOfSight("focus", 1)
    and UnitCanAttack("player", "focus") == 1
    and IsSpellInRange(GetSpellInfo(20271), "focus") == 1
then
    useFocusJudg = true
else
    useFocusJudg = false
end


if CombatLog == nil then
    local function BadInfos()
        if sourceNAME ~= UnitName("player") then
            return false
        end
        if destGUID == UnitGUID("focus") or destGUID == UnitGUID("target") then
        else return false end
    end
    NextJudgTarget = "focus"
    Nova_CombatLog = CreateFrame('Frame')
    Nova_CombatLog:RegisterEvent("COMBAT_LOG_EVENT_UNFILTERED")
    function CombatLog_OnEvent(self, event, ...)
        local type, _, sourceGUID, sourceNAME, _, _, destGUID, destNAME = select(2, ...)
        if (event=="COMBAT_LOG_EVENT_UNFILTERED") then
            BadInfos()
            if type == "SPELL_DAMAGE" and select(12, ...) == 20271 then
                if destGUID == UnitGUID("target") then
                       NextJudgTarget = "focus"
                   else
                       NextJudgTarget = "target"
                   end
            end
        end
    end
    Nova_CombatLog:SetScript("OnEvent", CombatLog_OnEvent)
    CombatLog = true
end


if useFocusJudg then
    CastSpellByName(GetSpellInfo(20271), NextJudgTarget)
else
    CastSpellByName(GetSpellInfo(20271),"target")
end