PQR - Rotation Bot

[Noelpqr]

can anyone please point where i made the mistake on this script

ability name : PWS
spell id : 17
target custom
code :

for i=1,#members do
  if UnitGroupRolesAssigned(members[i].Unit) == "TANK" and UnitThreatSituation(members[i].Unit) == 3 
  and not UnitbuffID(members[1].Unit,17)
    and not UnitDebuffID(members[1].Unit,6788)
        then PQR_CustomTarget = members[i].Unit return true end 
  end

what i was trying to do is making a script that will check if the one that should be target by PWS is a tank and he or she has aggro

[Noelpqr]

I've been having issues with PQR as of late with my shaman. It seems that neither of the resto profiles that I've got (Onya and Sheuron) will do Chain Heal at all. I've redownloaded both PQR and the profiles, and have turned off every addon, and still neither profile will cast chain heal.

I've added a simple output to chat type debug to each of the profiles chain heal ability, so that i can get a visual notice on if it's casting it, however it never seems to fire off at all.

Here's what Onya's current CH ability lookes like:

function IsInRange(u1,u2)
  local range = DistanceBetweenUnits(member[u1].name,member[u2].name)
  if range == nil then range = 100 end
  if range < 11.5  then
     return true
   else 
     return false
   end
end

function getDefHealth(unit)
   local hp = member[unit].health
   if UnitBuffID(member[unit].name, 974) then hp = hp - 5 end
    return (100 - hp)
end

function sortDefHealth(aUnit, anotherUnit)
    return getDefHealth(aUnit) > getDefHealth(anotherUnit)
end

function getnexthop(u)
 for nh = 1, table.maxn(chhops) do
   local onlist = 0
   for xxx = 1, table.maxn(nexthop) do
      if tostring(member[nexthop[xxx]].name) == tostring(member[chhops[nh]].name) then
        onlist = 1
      end
   end
   if nexthop[u] ~= nil and onlist == 0 then
     if IsInRange(nexthop[u],chhops [nh]) then return chhops[nh] end       
   end
 end
end

function findGoodTarget()
  if table.maxn(chtargets) ~=0 and table.maxn(chhops) >= hops then   
   table.sort(chtargets, sortDefHealth)  
   table.sort(chhops, sortDefHealth)
   for x = 1, table.maxn(chtargets) do
      nexthop = {}
      nexthop[1] = chtargets[x]
      for z = 1,hops do
       nexthop[z+1] = getnexthop(z)     
        if nexthop[(hops + 1)] ~= nil then
          return chtargets[x]
        end
        if nexthop[z] == nil then z = hops end
      end
   end
 end  
end

if PQR_SpellAvailable(1064) and spell ~= GetSpellInfo(1064)then
   local chtarget = findGoodTarget()
   if chtarget ~= nil and moving == 0 then
      SilentCast(1064,member[chtarget].name) 
      PQR_WriteToChat("Casting Chain Heal") 
      return true
   end
end

Even with everyone stacked up for fights like ultraxion, it seems that the profile can't seem to find a good target to start casting on.

lol i thought i was the only one who had this problem

[FrostDKsFTW]

Hey guys. :P Working on making the Shadow Priest and Death Knight profiles MoP ready.
Should especially see an extensive change on Shadow Priests mainly because changes is all over the place on the beta. Not really sure about the future of the MS/MB profile yet as it's only really viable in 4.3.x patches if you have the Shadow 4-set. (Which in turn is gonna change to boost SW: Pain once 5.0 hits live.) We'll see! Maybe I have a few ideas to prove it there as well.

I saw a question before as to why it's not fleshed out like the standard shadow priority, it's mainly because that multi-dotting while spamming MS/MB would ruin it all and produce a lot lower DPS than possible, but, I'm going to see if I can't get it enabled with my final re-write of the 4.3.x patch(es).

It's good to know someone is working on DKs already for MOP Will you be working on both Unholy and Frost or just one? Frost is looking pretty weird at the moment especially DW Frost. : /
I just want to say a big thanks to all from Nova Team, I tried out the Holy Pally profile recently and it's amazing!! Auto swapping to suit Raids, 5 Mans, ect. - awesome! Rep+ to you and Bubba (let me know if I'm leaving people out)

[Weischbier]

Message: [string "if PQR_Addon_Loaded == nil then..."]:760: attempt to call field '?' (a nil value)
Time: 06/07/12 11:42:19
Count: 1469
Stack: [string "if PQR_Addon_Loaded == nil then..."]:760: in function `PQR_NextAbility'
[string "if PQR_Addon_Loaded == nil then..."]:533: in function `PQR_ExecuteRotation'
[string "if PQR_Addon_Loaded == nil then..."]:289: in function <[string "if PQR_Addon_Loaded == nil then..."]:214>

Locals: rotationNumber = 0
nextAbility = -1
playerChanneling = false
(for index) = 6
(for limit) = 1023
(for step) = 1
i = 6
spellID = 0
skipUnknown = true
(*temporary) = nil
(*temporary) = "attempt to call field '?' (a nil value)"

Hey Firepong,

this is what I get when I use your profiles. Never happened before.

greetz

Weischbier

[firepong]

@weicshbeir

Its not just my profile. I've never gotten the errors on mine myself, but I had gotten the error on numerous profiles. This was only after I updated to 2.1.6. Didn't get the error on 2.1.5.

Also, if you have changed anything on the profile to do with the LUA file or don't have the LUA file, it will shit that error out as well. Make sure you go through the rotation editor and update my profile if you haven't already.


Sent from my MB860 using Tapatalk 2

[Weischbier]

@weicshbeir

Its not just my profile. I've never gotten the errors on mine myself, but I had gotten the error on numerous profiles. This was only after I updated to 2.1.6. Didn't get the error on 2.1.5.

Also, if you have changed anything on the profile to do with the LUA file or don't have the LUA file, it will shit that error out as well. Make sure you go through the rotation editor and update my profile if you haven't already.


Sent from my MB860 using Tapatalk 2

I'm using your latest version + latest PQR version.
PQInterface shows that it stucks at Ravage!.
Since I don't understand any LUA...well reading is easy but the rest is just meh to me^^

greetz

Weischbier

[ace99ro]

any Priest Disc PVE profiles ? i only found Sheurons PVP one , thx

[acrodox]

Any hutner survival PvE rotations? ive looked EVERYWHERE :P

[abndrew82]

I'm using your latest version + latest PQR version.
PQInterface shows that it stucks at Ravage!.
Since I don't understand any LUA...well reading is easy but the rest is just meh to me^^

greetz

Weischbier

I saw the same thing the other day, didnt note the errors but can try. I am using the most recent PQR and my feral druid was doing nothing with your profiles Firepong, it said an ability in pqr interface but never moved from it.

I loaded up another feral one of the ones by gabbz and it went fine, but with any of your active my char was only doing white swings.

I will try it again tonight and see if I can get an error to post.

[scatterer]

Anyone else having troulbe with bubba's paladin profile? PQR itself works, but with rthis profile the bot isn't healing at all, and i've copied the Data file. Another healpala profile would be fine too

Thanks

[NickGI]

Any hutner survival PvE rotations? ive looked EVERYWHERE :P

liar =)))))

[yourson]

Any chance for beta offsets?

[tigole1]

crystal tech the demo is good just 1 small problem, when i turned on demo rotation it works, but it doesnt pet swap during rotation, i had pet swap turned on before doing the demo rotation. i tried left shift but it does not do meta, demon soul+ felstorm and no pet swap.

[Ninjaderp]

Any hutner survival PvE rotations? ive looked EVERYWHERE :P

You havent looked everywhere

[Mirabis]

@Firepong

Any reason for not putting Ferocious Bite at last behind Shred instead of before Rip in rotation ?
When I switch them around I've like a 2~5k dps increase.