PQR - Rotation Bot

**crystal_tech** · 07-16-2012

Originally Posted by katuro

bump still having problems!

its normal its a part of bubbas coding to allow for custom targets to be stored if its empty don't worry about it.

**frII** · 07-16-2012

Sheuron,
I saw u have made a Dics PVP profile.
So since u made PVP maybe with a few fixes u cold also do a PVE Disc profile?

**pigbot** · 07-16-2012

I hope someone can help me out. I am wondering if it's possible to add code to BuBBA's Holy Paladin profile that can help with healing the Searing Plasma debuff on Heroic Spine of Deathwing. The profile is absolutely terrific otherwise.

I have seen the following code in Onya's Resto Shaman profile for Healing Wave:

Code:

local searingplasmadebuffs = { 105479,109363,109364 }
local hassp = 0
for _,v in ipairs(searingplasmadebuffs) do
    if UnitDebuffID(member[lowest].name,v) then hassp = 1 end
end

if ( member[lowest].health &amp;lt; hwhealth or hassp ==1) and moving == 0  and isvalidhealtarget(member[lowest].name) and PQR_SpellAvailable(331) then
  SilentCast(331,member[lowest].name)
  return true
end

Here is BuBBa's code for Holy Light:

Code:

if Nova_Spell[PQ_HolyLight].check then
	if members[1].HP &amp;lt; Nova_Spell[PQ_HolyLight].targetHealth 
	 and Nova_Spell[PQ_HolyLight].manaCost &amp;lt; select(4, Nova_UnitInfo(&amp;quot;player&amp;quot;)) 
	 and PQR_SpellAvailable(635) then
		PQR_CustomTarget = members[1].Unit
		return true
	end
end

So, would something like this work?

Code:

local searingplasmadebuffs = { 105479,109363,109364 }
local hassp = 0
for _,v in ipairs(searingplasmadebuffs) do
    if UnitDebuffID(member[lowest].name,v) then hassp = 1 end
end
if Nova_Spell[PQ_HolyLight].check then
	if (members[1].HP &amp;lt; Nova_Spell[PQ_HolyLight].targetHealth or hassp==1)
	 and Nova_Spell[PQ_HolyLight].manaCost &amp;lt; select(4, Nova_UnitInfo(&amp;quot;player&amp;quot;)) 
	 and PQR_SpellAvailable(635) then
		PQR_CustomTarget = members[1].Unit
		return true
	end
end

I have zero experience in any kind of coding besides reading all the posts here, so I hope what I have posted is enough information and is presented properly.

Thanks in advance for your help.

**averykey** · 07-16-2012

What is wrong with my profile? I have looked through the code several times and I have not seen anything wrong.
Rep+ for help.

Buggrabber has not been useful, is there another lua error checking mod?

Download AveryV3.zip @ UppIT

**Dominium** · 07-16-2012

:O Already V3? I have to say your V2 Retri profile is superb! Can't really help you debug this one tho, going to sleep now ;p

**averykey** · 07-16-2012

Originally Posted by Dominium

:O Already V3? I have to say your V2 Retri profile is superb! Can't really help you debug this one tho, going to sleep now ;p

This one is even better, In lfr I have been able to burst 70k+ with it. 400 ilvl~

edit: some of the numbers on it

41k morchok
60k yor'sahj
43k ultraxion
40k Spine
64k zon'ozz
40k hagara
44k warmaster

This is with proper switching and cooldown usage though, it doesn't do these numbers out of the box; takes some effort and know how of when to do things.

**crystal_tech** · 07-16-2012

Originally Posted by averykey

What is wrong with my profile? I have looked through the code several times and I have not seen anything wrong.
Rep+ for help.

Buggrabber has not been useful, is there another lua error checking mod?

Download AveryV3.zip @ UppIT

some things need a target so thats why i have a local in calcs/functions hastarget to make sure i have a target before trying to call other calcs/debuffs and such.

**firepong** · 07-16-2012

Originally Posted by averykey

What is wrong with my profile? I have looked through the code several times and I have not seen anything wrong.
Rep+ for help.

Buggrabber has not been useful, is there another lua error checking mod?

Download AveryV3.zip @ UppIT

In laymen terms, what are we speaking of that's wrong with it. I'll load it up in a text editor and see if I can find anything. At the moment, not around a comp with WoW loaded up on it. What error is it that it's shitting out?

EDIT* I see a couple thing's that I don't see how they would work. For example, I'll post all of it and comment out the parts. All of these are in -- Special --

Code:

-- Avoid sudden death on Madness 
local tentacledeath = select(7,UnitDebuffID("player",109597))
if tentacledeath and tentacledeath - GetTime() < 1 then return true end

What's this returning true to? Is it suppose to just be a rotation pause when you have the debuff?

Code:

-- Burning Tendons
RunMacroText("/cancelaura Parachute")

For this one, I would add a check to see if you have the Parachute first. If you don't it will always be trying to cancel that aura, no matter what. Not a good thing to do as it takes processor cycles, would want to have it using as little as possible to make the rotation as fast as possible.

Code:

if UnitExists("boss2") and UnitName("boss2") == "Burning Tendons" then
    if UnitName("target") ~= "Burning Tendons" then
        RunMacroText("/cast Avenging Wrath")
        RunMacroText("/cast Zealotry")
        RunMacroText("/use 13")
        RunMacroText("/use 14")
    end
    TargetUnit("boss2")
end
if UnitExists("boss3") and UnitName("boss3") == "Burning Tendons" then
    if UnitName("target") ~= "Burning Tendons" then
        RunMacroText("/cast Avenging Wrath")
        RunMacroText("/cast Zealotry")
        RunMacroText("/use 13")
        RunMacroText("/use 14")
    end
    TargetUnit("boss3")
end

The above, I don't even see how it would work. I mean, there's just no way it would do all 4 of those at the same time. Both Zealotry and Avenging Wrath induce a global. And since PQRotation can only do 1 thing at a time, I don't know lol. And as for the trinkets, those can be used at the same time.

Blessings Ability, change:

Code:

if BlessingOfKings ~= nil or MarkOfTheWild ~= nil or BlessingOfMight ~= nil or IsMounted() then
	return false
end

if BlessingOfMight ~= nil then
	CastSpellByID(20217,"player")
		return true
	else if BlessingOfKings ~= nil or MarkOfTheWild ~= nil then
		CastSpellByID(19740,"player")
			return true
		else if BlessingOfKings == nil or MarkOfTheWild == nil then
			CastSpellByID(19740,"player")
				return true
		end
	end
end

to

Code:

if BlessingOfKings ~= nil or MarkOfTheWild ~= nil or BlessingOfMight ~= nil or IsMounted() then
	return false
end

if BlessingOfMight ~= nil then
	CastSpellByID(20217,"player")
	return true
elseif BlessingOfKings ~= nil or MarkOfTheWild ~= nil then
	CastSpellByID(19740,"player")
	return true
elseif BlessingOfKings == nil or MarkOfTheWild == nil then
	CastSpellByID(19740,"player")
	return true
end

Judgement(OOR) ability, change:

Code:

if EnemyExists then
	if PlayerPower < 3 and Zealotry == nil and LustEffect = nil then
		if JudgementsOfThePure == nil then 
			return true
else if EnemyExists then
		if PlayerPower < 3 and Zealotry == nil then
			if IsSpellInRange(crusaderStrike, "target") == 0 then
						return true
					end
				end
			end
		end
	end
end

to:

Code:

if EnemyExists then
	if PlayerPower < 3 and Zealotry == nil and LustEffect = nil then
		if JudgementsOfThePure == nil then 
			return true
		end
	elseif PlayerPower < 3 and Zealotry == nil then
		if IsSpellInRange(crusaderStrike, "target") == 0 then
			return true
		end
	end
end

You were flat ass missing ends here. Revamped it a little for you though to make it better and use less processor cycles.

Seal of the Righteousness ability, change:

Code:

if IsMounted() then
	return false
end

if SealOfRighteousness == nil then
	return true
end

to:

Code:

if IsMounted() then
	return false
elseif not IsMounted() and SealOfRighteousness == nil then
	return true
end

Same for Seal of Truth, change to:

Code:

if IsMounted() then
	return false
elseif not IsMounted() and SealOfTruth == nil then
	return true
end

Again, processor cycles.

And this is all I have seen. Could be a problem with your Wait Ability. Has that been there since V2 and if so, has it been changed in any way? All I could find from what I read lol

**daveyboyuk** · 07-16-2012

did novas blood profile ever get fixed ?

**averykey** · 07-16-2012

Originally Posted by firepong

In laymen terms, what are we speaking of that's wrong with it. I'll load it up in a text editor and see if I can find anything. At the moment, not around a comp with WoW loaded up on it. What error is it that it's shitting out?

EDIT* I see a couple thing's that I don't see how they would work. For example, I'll post all of it and comment out the parts. All of these are in -- Special --

Code:

-- Avoid sudden death on Madness 
local tentacledeath = select(7,UnitDebuffID("player",109597))
if tentacledeath and tentacledeath - GetTime() < 1 then return true end

What's this returning true to? Is it suppose to just be a rotation pause when you have the debuff?

Code:

-- Burning Tendons
RunMacroText("/cancelaura Parachute")

For this one, I would add a check to see if you have the Parachute first. If you don't it will always be trying to cancel that aura, no matter what. Not a good thing to do as it takes processor cycles, would want to have it using as little as possible to make the rotation as fast as possible.

Code:

if UnitExists("boss2") and UnitName("boss2") == "Burning Tendons" then
    if UnitName("target") ~= "Burning Tendons" then
        RunMacroText("/cast Avenging Wrath")
        RunMacroText("/cast Zealotry")
        RunMacroText("/use 13")
        RunMacroText("/use 14")
    end
    TargetUnit("boss2")
end
if UnitExists("boss3") and UnitName("boss3") == "Burning Tendons" then
    if UnitName("target") ~= "Burning Tendons" then
        RunMacroText("/cast Avenging Wrath")
        RunMacroText("/cast Zealotry")
        RunMacroText("/use 13")
        RunMacroText("/use 14")
    end
    TargetUnit("boss3")
end

The above, I don't even see how it would work. I mean, there's just no way it would do all 4 of those at the same time. Both Zealotry and Avenging Wrath induce a global. And since PQRotation can only do 1 thing at a time, I don't know lol. And as for the trinkets, those can be used at the same time.

Blessings Ability, change:

Code:

if BlessingOfKings ~= nil or MarkOfTheWild ~= nil or BlessingOfMight ~= nil or IsMounted() then
	return false
end

if BlessingOfMight ~= nil then
	CastSpellByID(20217,"player")
		return true
	else if BlessingOfKings ~= nil or MarkOfTheWild ~= nil then
		CastSpellByID(19740,"player")
			return true
		else if BlessingOfKings == nil or MarkOfTheWild == nil then
			CastSpellByID(19740,"player")
				return true
		end
	end
end

to

Code:

if BlessingOfKings ~= nil or MarkOfTheWild ~= nil or BlessingOfMight ~= nil or IsMounted() then
	return false
end

if BlessingOfMight ~= nil then
	CastSpellByID(20217,"player")
	return true
elseif BlessingOfKings ~= nil or MarkOfTheWild ~= nil then
	CastSpellByID(19740,"player")
	return true
elseif BlessingOfKings == nil or MarkOfTheWild == nil then
	CastSpellByID(19740,"player")
	return true
end

Judgement(OOR) ability, change:

Code:

if EnemyExists then
	if PlayerPower < 3 and Zealotry == nil and LustEffect = nil then
		if JudgementsOfThePure == nil then 
			return true
else if EnemyExists then
		if PlayerPower < 3 and Zealotry == nil then
			if IsSpellInRange(crusaderStrike, "target") == 0 then
						return true
					end
				end
			end
		end
	end
end

to:

Code:

if EnemyExists then
	if PlayerPower < 3 and Zealotry == nil and LustEffect = nil then
		if JudgementsOfThePure == nil then 
			return true
		end
	elseif PlayerPower < 3 and Zealotry == nil then
		if IsSpellInRange(crusaderStrike, "target") == 0 then
			return true
		end
	end
end

You were flat ass missing ends here. Revamped it a little for you though to make it better and use less processor cycles.

Seal of the Righteousness ability, change:

Code:

if IsMounted() then
	return false
end

if SealOfRighteousness == nil then
	return true
end

to:

Code:

if IsMounted() then
	return false
elseif not IsMounted() and SealOfRighteousness == nil then
	return true
end

Same for Seal of Truth, change to:

Code:

if IsMounted() then
	return false
elseif not IsMounted() and SealOfTruth == nil then
	return true
end

Again, processor cycles.

And this is all I have seen. Could be a problem with your Wait Ability. Has that been there since V2 and if so, has it been changed in any way? All I could find from what I read lol

Madness/Hour/Fading returns true to do the action /click ExtraActionButton1
Removed the return trues added RunMacroText("/click ExtraActionButton1")

The burning tendon thing is xelpers, It works just fine when I do spine.
edit:

local parachute = UnitAura("player", "Parachute")
if parachute ~= nil then
RunMacroText("/cancelaura Parachute")
end

Should work hopefully.

Nothing is wrong with blessings, why did you make that change?
edit: Are you not supposed to have an end for every if?

I will try the judgement fix
edit: Added it in but it still won't hit the dummy.

The reason I did seals that way is because, I am not completely sure how things work and I figured keeping the false and true apart couldn't hurt.
Added your fix.

The wait ability hasn't changed since v1, So it shouldn't be a problem.

Originally Posted by crystal_tech

some things need a target so thats why i have a local in calcs/functions hastarget to make sure i have a target before trying to call other calcs/debuffs and such.

That makes sense, I didn't understand why you had that.

I added in the hastarget and it still won't attack the dummy.

edit:
The error in game

64x <string>:"if PQR_Addon_Loaded == nil then...":737: attempt to call field "?" (a nil value)
<string>:"if PQR_Addon_Loaded == nil then...":737: in function "PQR_NextAbility"
<string>:"if PQR_Addon_Loaded == nil then...":533: in function "PQR_ExecuteRotation"
<string>:"if PQR_Addon_Loaded == nil then...":289: in function <string>:"if PQR_Addon_Loaded == nil then...":214

Locals:
rotationNumber = 0
inCombat = 1
requireCombat = false

edit2:

Here is it again with all the fixes

http://up.ht/Q3eJbk

The problem is, it won't attack anything; It is hung up on something and I have no idea what it is.

**crystal_tech** · 07-16-2012

in the judgement change your missing an = after LustEffect = nil should be LustEffect == nil

**averykey** · 07-16-2012

Originally Posted by crystal_tech

in the judgement change your missing an = after LustEffect = nil should be LustEffect == nil

Is that the same for LustEffect == 1? Or is it still LustEffect = 1

**firepong** · 07-16-2012

Originally Posted by averykey

Is that the same for LustEffect == 1? Or is it still LustEffect = 1

Go through your Profile and change all LustEffect = 1 to LustEffect == 1. Need to have 2 "==" in there when doing a if statement.

Doing this fixed the profile and made it run for me.

**averykey** · 07-16-2012

Originally Posted by firepong

Go through your Profile and change all LustEffect = 1 to LustEffect == 1. Need to have 2 "==" in there when doing a if statement.

Doing this fixed the profile and made it run for me.

Fixed, Thanks

.

**Ralphiuss** · 07-16-2012

Anyone using Bu_Ba holy paladin profile in a heroic DS environment? As much as I love it, and it being mana efficient...it's too efficient. I'm being blown away by my other healing partners.

Pretty much being told to close the gap or I probably need to find a different group...Even though we're 8/8HM...bastards...lol

Shout-Out

User Tag List

Thread: PQR - Rotation Bot

Thread Tools

Search Thread

Similar Threads

[Bot] PQR PE Next Steps / Future of Rotation Botting

[Bot] PQR - Rotation Bot

[Selling] 3 Lifetime Session Keys For Sale, Great for the PQR user looking for a rotation bot

rotation bot leveling (PQR)

[HELP] PQR Rotation Bot Profile Making

OwnedCore Forums

casino

CoreCoins

My OwnedCore

About Us

Casino