you only want to use divine purpose with 5 holy power if it has less than 2 seconds left to prevent a proc loss
it might freeze for people if they didn't pick up sacred shield because it doesn't check if they have the spell
will the delay list stop the rotation for a sec if it notices that spell being used?
My Svn - https://subversion.assembla.com/svn/averykeys-svn/
@ averykey
So i'm not really sure what the issue is but the Boss in Mogu' shan Vaults Elegon the rotation does not work with him I'm not sure if it's a boss type issue or what but the rotation will just quit working Exorcism will quit, Judgement will quit and other abilities just do not function not sure what causes it I made quite a few changes and tried both mop and mopv3 rotations and neither rotation will work properly. What does keep working is TV and CS but nothing else will keep working, Now I restarted then client and pqr and is didn't resolve it so I think there is something else causing it.
On that same note ES does not cast as well on any boss or target dummy. It will take some more testing before I can actually figure out what is going on with it but if I figure anything out i'll post it and let you know.
I'm aware that you can't support other profiles, however I have noticed a similar issue with the profile I use (Dual wield). The code appears to be exactly the same:
Would love to have some confirmation from someone with an actual knowledge of this, unlike myself.PHP Code:
<Ability><Name>-- Soul Reaper (Sub 35%)</Name><Default>false</Default><SpellID>130735</SpellID><Actions></Actions><Lua>local Targethealth = 100 * UnitHealth(&quot;target&quot;) / UnitHealthMax(&quot;target&quot;)
if Targethealth &lt; 35 then
if ValidTarget then
if ( UnitLevel(&quot;target&quot;) == -1 or UnitIsUnit(&quot;target&quot;, &quot;boss1&quot;) ) then
return true
end
end
I''m going to try and reach 90 tomorrow and I will test as much as I can, I'm not sure why it wouldn't be working, try xelpers.
Pushing out an update tomorrow, don't know if the raid stuff is fixed could have been execution sentence bugging, not sure.
should have fixed execution sentence, was using wrong spell id
added a check in avenger's shield for prot
tidied up some code
added xelper's delays
xelper's boss/inq check on execution sentence
added in the 90 talents for sacred shield gcd check
working on seal of insight switching for ret solo/pvp/raid and prot raid/pvp, it's mostly done just need to add check in the aoe switch ability
going to test the double jeopardy code tomorrow, if it works I will add it in.
can anyone tell me how light's hammer works?
I read the tooltip and it sounds like death and decay
Current code for it
probably won't work just found some dnd code and tried to merge.PHP Code:
--Light's Hammer
if IsPlayerSpell(114158) then
if RangeCheck(114158, "target") and not UnitChannelInfo("player") and not PQR_IsMoving(1) then
SpellCancelQueuedSpell()
CastSpellByName(GetSpellInfo(114158), "target")
if SpellIsTargeting() then CameraOrSelectOrMoveStart() CameraOrSelectOrMoveStop() end
return true
end
end
Last edited by averykey; 10-04-2012 at 01:53 AM.
My Svn - https://subversion.assembla.com/svn/averykeys-svn/
Any one got the hamstring code for Arms PVP warrior? Cant seem to get old ones working.
I'm making a arms warrior profile for pve and pvp. Following simcraft exactly and prioritize the pvp cooldown over the simcraft rotation for the pvp one. I am level 85 now with junk gear and at 84 with a 409 wep (last time I dpsed with it) I was doing 30k single target dps without recklessness. I will release finished 90 for raids when I get to 90..
Also started to **** around with fury. that seems an easy rotation too
Interrupts, spell reflects, disarms, hamstrings and everything else you could want for pvp is working as intended as well
Last edited by Bgreen12; 10-04-2012 at 08:55 AM.
Anyone see obvious errors here?
PHP Code:
-- Seal Check
local PlayerHP = 100 * UnitHealth("player") / UnitHealthMax("player")
local PlayerMana = 100 * UnitPower("player") / UnitPowerMax("player")
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
if not IsInInstance() and PlayerHP <= 35 and GetShapeshiftForm("player") ~= 4 or IsInInstance() and select(2, GetInstanceInfo()) ~= "raid" and PlayerHP <= 35 and GetShapeshiftForm("player") ~= 4 then
CastShapeshiftForm(4)
elseif PlayerMana <= 15 and GetShapeshiftForm("player") ~= 4 then
CastShapeshiftForm(4)
elseif AoeSwap == nil and GetShapeshiftForm("player") ~= 1 and PlayerMana > 15 then
CastShapeshiftForm(1)
end
elseif (select(2, GetSpecializationInfo(GetSpecialization()))) == "Protection" then
if PlayerHP <- 25 and GetShapeshiftForm("player") ~= 4 then
CastShapeshiftForm(4)
elseif AoeSwap == nil and GetShapeshiftForm("player") ~= 1 and PlayerHP > 25 then
CastShapeshiftForm(1)
end
end
-- Blessing of Might/Kings
local haveBuff = false
if haveBuff == nil then haveBuff = false end
if not IsMounted() and not UnitInVehicle("player") and not UnitIsDeadOrGhost("player") then
if not UnitBuffID("player", 19740) and not UnitBuffID("player", 116956) and haveBuff == false then
CastSpellByName(GetSpellInfo(19740), "player")
haveBuff = true
elseif not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) and not UnitBuffID("player", 90363) and not UnitBuffID("player", 115921) and haveBuff == false then
CastSpellByName(GetSpellInfo(20217), "player")
haveBuff = true
end
end
Can anyone tell me how light's hammer works? I haven't reached 90 yet.
My Svn - https://subversion.assembla.com/svn/averykeys-svn/
Didn't look at code all the way through, but I suggest using incoming heals added in because if your health is constantly spiking, this slows down the profile from swapping back and forth so much. Multiply by 100 if you use whole percent numbers.
Code:(UnitHealth("player")+UnitGetIncomingHeals("player"))/UnitHealthMax("player")
Do or Die
[PQR] Monk Mistweaver