PQR - Rotation Bot

[crystal_tech]

adf.ly is back up so either link will work

sidenote: workin with buba to make releases easier.

[Wopak]

I'm fine with it the way it is after I changed to 1 PQR_UnitInfo. All the other stuff is localized so it has a space in memory. Just don't want it to keep adding and adding and adding W, H, and Distance to memory. With it localized, it will be in a reserved spot. now, I don't know if the return is in a saved memory spot, but until I know and even then, it's going to stay like it is. Not like it's wasting much memory spaces the way I have it right now.

EDIT* As soon as I figure out a way to get the X and Y Coordinates of a Zone ( Felwood, Mount Hyjal, Durotar, etc), this is what will be going in H and W. It's not going to be a fixed value like it is right now.

Right.. A reserved spot in memory.. Well you DO declare it every time you call the function, so quite unneccesary, but well nevermind.

[bu_ba_911]

Since I read that Creche of the Final Dragon - Item - World of Warcraft are much better I useing it right now.

Buba doesnt use Berserks rage and Dragon's roar(thats really could be the reason),Sheurone do,
buba-

Sheurone-

I alos can do Simcraft if you want.Again not sure who is the author.

And yes,I was useing CD's.

The author of very,very nice Fury Profiles called Simcraft are knightnova1

I believe most CD's are situational.... Like Spine/Hagara/Zon'oz..... You don't want to blow CD's are the wrong time, so I have the Player just cast them themselves....

[ImayoboeiI]

Bubba, you're Blood DK profile is just wrong.

You're supposed to use Death Strike as much as possible to build up a good Blood Shield (mastery).
Your profile is currently only using Rune Strike and Heart Strike, and only uses Death Strike when HP is lost; to heal.

Also, please support the use of Blood Tap, as it is vital for all Blood DKs.

[expunge]

I'm sure it's kind of confusing who to download from for some people, you or bu_ba's SVN mainly because bu_ba's affliction has a higher version number then the one currently on your SVN.

@Kinkeh, your newest update removed d&d from right shift and made it AMZ instead :P

I see why:

-- AMZ on Left Alt.
if IsLeftAltKeyDown() then
   SpellCancelQueuedSpell()
   CastSpellByName(GetSpellInfo(51052),nil)
   if SpellIsTargeting() then CameraOrSelectOrMoveStart() CameraOrSelectOrMoveStop() end
   return true
end
-- DnD on Right Shift.
if IsRightShiftKeyDown() then
   SpellCancelQueuedSpell()
   CastSpellByName(GetSpellInfo(51052),nil)
   if SpellIsTargeting() then CameraOrSelectOrMoveStart() CameraOrSelectOrMoveStop() end
   return true
end 

Spell ID's are the same.

[firepong]

Right.. A reserved spot in memory.. Well you DO declare it every time you call the function, so quite unneccesary, but well nevermind.

If you wanna change it, be my guest. It's posted for everyone to use. I'm not stopping anyone from using it the way you posted it. No reason to be a smartass about the way I worded it.

[Kinkeh]

Bubba, you're Blood DK profile is just wrong.

You're supposed to use Death Strike as much as possible to build up a good Blood Shield (mastery).
Your profile is currently only using Rune Strike and Heart Strike, and only uses Death Strike when HP is lost; to heal.

Also, please support the use of Blood Tap, as it is vital for all Blood DKs.

Your main objective isn't to build blood shields anymore as blood, were suppose to be able take spike damage now hence the recent stamina increase, and death strike to heal up from that, again hence the death strike buff, the blood shield after that is incase spike damage is taken again you have the shield to protect you.

[bu_ba_911]

Bubba, you're Blood DK profile is just wrong.

You're supposed to use Death Strike as much as possible to build up a good Blood Shield (mastery).
Your profile is currently only using Rune Strike and Heart Strike, and only uses Death Strike when HP is lost; to heal.

Also, please support the use of Blood Tap, as it is vital for all Blood DKs.

I stack Scent of Blood for my Death Strikes so that when I take damage, I'm instantly back at full health again.

The profile will continue to use Death Strike even when full health to help maintain Runic Power regen, which also in turn gives you a Blood Shield.

*edit* also it does support blood tap >.>

[Dominium]

To everyone asking about my ret PvP profile - I will be releasing it at 90, I dont have the time atm to write it and simply using Averykeys ret single target PvE profile is enough for random BG (top dmg in all 9 BGs I did today, only thing it lacks is utility). Just bind HoF, bubble, WoG etc. to shift+keybind.

Cheers!

[averykey]

To everyone asking about my ret PvP profile - I will be releasing it at 90, I dont have the time atm to write it and simply using Averykeys ret single target PvE profile is enough for random BG (top dmg in all 9 BGs I did today, only thing it lacks is utility). Just bind HoF, bubble, WoG etc. to shift+keybind.

Cheers!

Glad to hear it's working good for you, re-writing the whole thing to include utility and better seal switching depending on the situation.




Does this look correct? trying to end everything if a condition is true like people suggested.

--if we don't have a seal check current aoe mode and apply that seal, if no aoe mode then cast truth
if AoeSwap = nil then
    if GetShapeshiftForm("player") ~= 1 or GetShapeshiftForm("player") ~= 2 or GetShapeshiftForm("player") ~= 3 then
        CastShapeshiftForm(1)
    end
elseif AoeSwap then
    CastShapeshiftForm(1)
end
    elseif not AoeSwap then
        CastShapeshiftForm(2)
    end
end 

still need to include seal of insight, does justice still exist or do people just pick up burden of guilt?

[Wopak]

If you wanna change it, be my guest. It's posted for everyone to use. I'm not stopping anyone from using it the way you posted it. No reason to be a smartass about the way I worded it.

I'm sorry that you're taking it that way. You asked something about a FPS loss you had, i replied with the changes you could do in you end to at least minimize whatever minute things that clogs up eventually. I have no interested it changing it for my own good.

I wish you the best in your future coding.

[Wopak]

Glad to hear it's working good for you, re-writing the whole thing to include utility and better seal switching depending on the situation.




Does this look correct? trying to end everything if a condition is true like people suggested.

--if we don't have a seal check current aoe mode and apply that seal, if no aoe mode then cast truth
if AoeSwap = nil then
    if GetShapeshiftForm("player") ~= 1 or GetShapeshiftForm("player") ~= 2 or GetShapeshiftForm("player") ~= 3 then
        CastShapeshiftForm(1)
    end
elseif AoeSwap then
    CastShapeshiftForm(1)
end
    elseif not AoeSwap then
        CastShapeshiftForm(2)
    end
end 

still need to include seal of insight, does justice still exist or do people just pick up burden of guilt?

I'm just on my way out the door, so didnt quite look it all thru, but in the first line
if AoeSwap = nil then
it should be
if AoeSwap == nil then

Also this
if GetShapeshiftForm("player") ~= 1 or GetShapeshiftForm("player") ~= 2 or GetShapeshiftForm("player") ~= 3 then
can be replaced by
if GetShapeshiftForm("player") == 0 then

[firepong]

Glad to hear it's working good for you, re-writing the whole thing to include utility and better seal switching depending on the situation.




Does this look correct? trying to end everything if a condition is true like people suggested.

--if we don't have a seal check current aoe mode and apply that seal, if no aoe mode then cast truth
if AoeSwap = nil then
    if GetShapeshiftForm("player") ~= 1 or GetShapeshiftForm("player") ~= 2 or GetShapeshiftForm("player") ~= 3 then
        CastShapeshiftForm(1)
    end
elseif AoeSwap then
    CastShapeshiftForm(1)
end
    elseif not AoeSwap then
        CastShapeshiftForm(2)
    end
end 

still need to include seal of insight, does justice still exist or do people just pick up burden of guilt?

//if we don't have a seal check current aoe mode and apply that seal, if no aoe mode then cast truth
local index = GetShapeshiftForm()

if AoeSwap = nil then
    if GetShapeshiftForm() ~= 1 or GetShapeshiftForm() ~= 2 or GetShapeshiftForm() ~= 3 then //"Player" isn't needed because the Function is just a check on stance forms
        CastShapeshiftForm(1)
    end
elseif AoeSwap and index ~= 1 then
    CastShapeshiftForm(1)
//end <------------------------------------------------------REMOVE THIS END HERE
elseif not AoeSwap and index ~= 2 then
    CastShapeshiftForm(2)
end
//end <------------------------------------------------------REMOVE THIS END HERE 

If the check was not there when switching to AE, it would keep spamming that ability over and over.

[Dominium]

Glad to hear it's working good for you, re-writing the whole thing to include utility and better seal switching depending on the situation.




Does this look correct? trying to end everything if a condition is true like people suggested.

--if we don't have a seal check current aoe mode and apply that seal, if no aoe mode then cast truth
if AoeSwap = nil then
    if GetShapeshiftForm("player") ~= 1 or GetShapeshiftForm("player") ~= 2 or GetShapeshiftForm("player") ~= 3 then
        CastShapeshiftForm(1)
    end
elseif AoeSwap then
    CastShapeshiftForm(1)
end
    elseif not AoeSwap then
        CastShapeshiftForm(2)
    end
end 

still need to include seal of insight, does justice still exist or do people just pick up burden of guilt?

The profile is working great 45k dps on HC Ultrax as a ilvl 395 mainly PvP geared retri pal (Haste reforge)

That code looks good, although I think I would just do it with if's and not elseif's, but that just me (very rarely using elseif)

I've never used Seal of Justice since 5.0.4 and thats in PvP, so I highly doubt theres any use whatsoever in PvE (+ yeah, ppl can take BoG)

[bu_ba_911]

if AoeSwap == nil then
    if GetShapeshiftForm() == 0 or GetShapeshiftForm() == 3 then
        CastShapeshiftForm(1)
        AoESwap = true
    elseif GetShapeshiftForm() == 2 then
        AoESwap = false
    end
elseif AoeSwap == true and GetShapeshiftForm() ~= 1 then
    CastShapeshiftForm(1)
elseif AoeSwap == false and GetShapeshiftForm() ~= 2 then
     CastShapeshiftForm(2)
end 

did i miss something?