PQR - Rotation Bot

[Wopak]

I don't believe it's a PQR profile, but something more optimized...

[crystal_tech]

well adf.ly is down atm so heres an updated link: http://goo.gl/Zn3at

[mrleo]

is FAW Sheuron's Fury Arms profile?

hey bubba... i need help... i have put shockwave to be cast when leftaltkey is down... but i want it to cast only when a target isnt immune to stun and only when i am actually going to hit them! is there a way to make a code into which u can add some buffs that ur target has that will make shockwave not fire? and about the facing/range thing? waiting for answer thanks in advance

[sylaborg]

just came back to wow.. updated PQR to 2.1.9 and download the offsets from the software.. after that updated my Ret profile to Xelpers new MOP beta profile.. after running it in game, all it does is just cast SoT.. nothing else.

Did i download the correct version and offsets?

[bu_ba_911]

hey bubba... i need help... i have put shockwave to be cast when leftaltkey is down... but i want it to cast only when a target isnt immune to stun and only when i am actually going to hit them! is there a way to make a code into which u can add some buffs that ur target has that will make shockwave not fire? and about the facing/range thing? waiting for answer thanks in advance

im assuming this is pvp based?

i'll try and put a list together for my pvp profiles when i start working on those

[frII]

Well I'm 409 itemlvl SMF fury,trinkets were-Bone-Link Fetish - Item - World of Warcraft and Eye of Unmaking - Item - World of Warcraft.

Weapons are Souldrinker - Item - World of Warcraft and normal version of it.
Tested with Sheurones,but useing Simcraft(I'm not sure who is author).

Gonna test buba's right now,if I be able to download them.

[Wopak]

Well I'm 409 itemlvl SMF fury,trinkets were-Bone-Link Fetish - Item - World of Warcraft and Eye of Unmaking - Item - World of Warcraft.

Weapons are Souldrinker - Item - World of Warcraft and normal version of it.
Tested with Sheurones,but useing Simcraft(I'm not sure who is author).

Gonna test buba's right now,if I be able to download them.

Ye well, there's a big difference to that ilvl and the he tested with with LFR weapons.

[Wopak]

Well I'm 409 itemlvl SMF fury,trinkets were-Bone-Link Fetish - Item - World of Warcraft and Eye of Unmaking - Item - World of Warcraft.

Weapons are Souldrinker - Item - World of Warcraft and normal version of it.
Tested with Sheurones,but useing Simcraft(I'm not sure who is author).

Gonna test buba's right now,if I be able to download them.

Ye well, there's a big difference to that ilvl and the he tested with with LFR weapons.

[frII]

Since I read that Creche of the Final Dragon - Item - World of Warcraft are much better I useing it right now.

Buba doesnt use Berserks rage and Dragon's roar(thats really could be the reason),Sheurone do,
buba-

Sheurone-

I alos can do Simcraft if you want.Again not sure who is the author.

And yes,I was useing CD's.

The author of very,very nice Fury Profiles called Simcraft are knightnova1

[knightnova1]

edit........

[Kinkeh]

well adf.ly is down atm so heres an updated link: http://goo.gl/Zn3at

I'm sure it's kind of confusing who to download from for some people, you or bu_ba's SVN mainly because bu_ba's affliction has a higher version number then the one currently on your SVN.

[bu_ba_911]

I'm sure it's kind of confusing who to download from for some people, you or bu_ba's SVN mainly because bu_ba's affliction has a higher version number then the one currently on your SVN.

Lol we've been sorting issues like this out. Should be easier to tell shortly

Sent from my ADR6400L using Tapatalk 2

[firepong]

Your last EDIT was my point exactly Now you've taken 2 call out out PQR_UnitDistance, that you basically have no control over, which leaves us with:

Function PQR_UnitDistance(var1, var2)
if UnitExists(var1) and not UnitIsDead(var1) then
local x1 , y1 = PQR_UnitInfo(var1)
local x2 , y2 = PQR_UnitInfo(var2)
local w = 100000
local h = 100000
local distance = sqrt(min(x1 - x2, w - (x1 - x2))^2 + min(y1 - y2, h - (y1-y2))^2)

return distance
end
end

-----
Now, i know this is all minor thing's, but i'm used to database optimizing IRL and everything adds up, so here goes.

You declaring to local variables that you're not carrying over to something else, or doing any other internal manipulation too, so i assume it's only 'fot the looks'
local w = 100000
local h = 100000
Delete those and put those values directly in the line

local distance = sqrt(min(x1 - x2, 100000 - (x1 - x2))^2 + min(y1 - y2, 100000 - (y1-y2))^2)

Now for this line itself, it's rather pointless to make distance a local variable for the exact same reasons as stated above, plus the fact that you're declaring distance only to return it in the next line, best option is to do this.
return sqrt(min(x1 - x2, w - (x1 - x2))^2 + min(y1 - y2, h - (y1-y2))^2)

and delete
return distance
Leaving you with

Function PQR_UnitDistance(var1, var2)
if UnitExists(var1) and not UnitIsDead(var1) then
local x1 , y1 = PQR_UnitInfo(var1)
local x2 , y2 = PQR_UnitInfo(var2)
return sqrt(min(x1 - x2, 100000 - (x1 - x2))^2 + min(y1 - y2, 100000 - (y1-y2))^2)
end
end



For your thought's about taking out UnitExists(), i can't say really, i only deal with objects. But a general rule of thumb is: Always ensure you have valid input data

I'm fine with it the way it is after I changed to 1 PQR_UnitInfo. All the other stuff is localized so it has a space in memory. Just don't want it to keep adding and adding and adding W, H, and Distance to memory. With it localized, it will be in a reserved spot. now, I don't know if the return is in a saved memory spot, but until I know and even then, it's going to stay like it is. Not like it's wasting much memory spaces the way I have it right now.

EDIT* As soon as I figure out a way to get the X and Y Coordinates of a Zone ( Felwood, Mount Hyjal, Durotar, etc), this is what will be going in H and W. It's not going to be a fixed value like it is right now.

[Frissle]

@bu_ba_911

I'm having a bit trouble with your destro lock profile, when i actvate it with ALT-X nothing happends. Am i missing something completely fundamental?

[Kinkeh]

Try with my profile on pqr http://dl.dropbox.com/u/101636169/Si...uryWorking.zip

The test shouldn't be of time either, it should be of damage done, easy test is do 22 million damage with both profiles, when 22 million damage is done then you can look at the dps and divide that by the damage done to determine how much time the rotation has ran, so yeah, test with same amounts of damage done for more accurate results please.

Here is an old one of mine with the profile i linked http://i45.tinypic.com/33jntco.jpg

Awesome profile! got on my warrior alt to try it out on a dummy.

@ilvl 398, wielding 2 normal gurthalaks, 2400 crit/hit/exp capped and 1128 mastery. Pretty good in my opinion, seeing how RNG had some play in there.