PQR - Rotation Bot

[Wopak]

Lol, you could say that's how I did my own UnitDistance instead of using the one that Xelper made.

Not understood ?

EDIT:
Why are you querying PQR_UnitInfo(var1) twice and the same with PQR_UnitInfo(var2)?

local x1 , y1 = select(1,PQR_UnitInfo(var1)), select(2,PQR_UnitInfo(var1))
local x2 , y2 = select(1,PQR_UnitInfo(var2)), select(2,PQR_UnitInfo(var2))

[firepong]

Not understood ?

EDIT:
Why are you querying PQR_UnitInfo(var1) twice and the same with PQR_UnitInfo(var2)?

local x1 , y1 = select(1,PQR_UnitInfo(var1)), select(2,PQR_UnitInfo(var1))
local x2 , y2 = select(1,PQR_UnitInfo(var2)), select(2,PQR_UnitInfo(var2))

Because PQR_UnitInfor(var1) returns 5 Values or more, can't remember in a Table:
Value 1: X position
Value 2: Y position
Value 3: Z position
Value 4: Faction ID?
Value 5: Cant remember I know most of the time, for me, it return's 0 lol

EDIT* See how I do select(1,... and select(2,...? I'm selecting those 2 values from the table that PQR_UnitInfo() is creating, in this case, The X and Y values of both my Target and myself in my rotation's.
EDIT** After reading over it, I just came to a conclusion. I don't have to call it twice, but hey, I made this function way back when I was just really starting to understand LUA coding. I'll have to change it around xD lol

[Wopak]

Because PQR_UnitInfor(var1) returns 5 Values or more, can't remember in a Table:
Value 1: X position
Value 2: Y position
Value 3: Z position
Value 4: Faction ID?
Value 5: Cant remember I know most of the time, for me, it return's 0 lol

EDIT* See how I do select(1,... and select(2,...? I'm selecting those 2 values from the table that PQR_UnitInfo() is creating, in this case, The X and Y values of both my Target and myself in my rotation's.
EDIT** After reading over it, I just came to a conclusion. I don't have to call it twice, but hey, I made this function way back when I was just really starting to understand LUA coding. I'll have to change it around xD lol

Your last EDIT was my point exactly Now you've taken 2 call out out PQR_UnitDistance, that you basically have no control over, which leaves us with:

Function PQR_UnitDistance(var1, var2)
if UnitExists(var1) and not UnitIsDead(var1) then
local x1 , y1 = PQR_UnitInfo(var1)
local x2 , y2 = PQR_UnitInfo(var2)
local w = 100000
local h = 100000
local distance = sqrt(min(x1 - x2, w - (x1 - x2))^2 + min(y1 - y2, h - (y1-y2))^2)

return distance
end
end

-----
Now, i know this is all minor thing's, but i'm used to database optimizing IRL and everything adds up, so here goes.

You declaring to local variables that you're not carrying over to something else, or doing any other internal manipulation too, so i assume it's only 'fot the looks'
local w = 100000
local h = 100000
Delete those and put those values directly in the line

local distance = sqrt(min(x1 - x2, 100000 - (x1 - x2))^2 + min(y1 - y2, 100000 - (y1-y2))^2)

Now for this line itself, it's rather pointless to make distance a local variable for the exact same reasons as stated above, plus the fact that you're declaring distance only to return it in the next line, best option is to do this.
return sqrt(min(x1 - x2, w - (x1 - x2))^2 + min(y1 - y2, h - (y1-y2))^2)

and delete
return distance
Leaving you with

Function PQR_UnitDistance(var1, var2)
if UnitExists(var1) and not UnitIsDead(var1) then
local x1 , y1 = PQR_UnitInfo(var1)
local x2 , y2 = PQR_UnitInfo(var2)
return sqrt(min(x1 - x2, 100000 - (x1 - x2))^2 + min(y1 - y2, 100000 - (y1-y2))^2)
end
end



For your thought's about taking out UnitExists(), i can't say really, i only deal with objects. But a general rule of thumb is: Always ensure you have valid input data

[CrazyCactuaR]

Testing comparison between Buba Fury Single Target and FAW, Results Attachment 10052 http://oi49.tinypic.com/34ypauc.jpg

[Daganjaman]

Still LF disc priest profiles both pvp / pve :s

[Wopak]

Testing comparison between Buba Fury Single Target and FAW, Results Attachment 10052 http://oi49.tinypic.com/34ypauc.jpg

Crazy stuff.

[Ninjaderp]

Whats FAW?

[bu_ba_911]

Testing comparison between Buba Fury Single Target and FAW, Results Attachment 10052 http://oi49.tinypic.com/34ypauc.jpg

were u casting CD's on mine?

[Wopak]

were u casting CD's on mine?

I asked CrazyCactuaR the same, he said: No cd's, same char, same gear, same target, same timespan (20 mins) for both tests.

[Fumi]

is it possible to make PQR press Keys after a key press? if i press E if will press Q W R right after ? or if i press R Q it will press mouse5?

[frII]

Testing comparison between Buba Fury Single Target and FAW, Results Attachment 10052 http://oi49.tinypic.com/34ypauc.jpg

So who is FAW?Could u give a link to his profile,also DPS is kind of low.I have 35-37 on 85 lvl dummy.If u beat the new raid one,it's senless.

Xelper are u plannig to fix interrupt?And could we expect it soon?=)
Best regards.

[Wopak]

So who is FAW?Could u give a link to his profile,also DPS is kind of low.I have 35-37 on 85 lvl dummy.If u beat the new raid one,it's senless.

Xelper are u plannig to fix interrupt?And could we expect it soon?=)
Best regards.

"also DPS is kind of low" ^^ Compared to ?

Sorry i didn't relay all info, so here goes.

I asked CrazyCactuaR the same, he said: No cd's, same char, same gear, same target, same timespan (20 mins) for both tests.

Additional info: Training Dummy lvl 85, ilvl384

[bu_ba_911]

"also DPS is kind of low" ^^ Compared to ?

Sorry i didn't relay all info, so here goes.

I asked CrazyCactuaR the same, he said: No cd's, same char, same gear, same target, same timespan (20 mins) for both tests.

Additional info: Training Dummy lvl 85, ilvl384

so just to clarify since I don't know what that other profile is.... i know for a fact my Profile doesn't auto cast ANY CD's.... Does the other profile auto cast ANY CD's as well?

[Wopak]

so just to clarify since I don't know what that other profile is.... i know for a fact my Profile doesn't auto cast ANY CD's.... Does the other profile auto cast ANY CD's as well?

No it doesn't

I asked CrazyCactuaR the same, he said: No cd's, same char, same gear, same target, same timespan (20 mins) for both tests.

[bu_ba_911]

No it doesn't

I asked CrazyCactuaR the same, he said: No cd's, same char, same gear, same target, same timespan (20 mins) for both tests.

is FAW Sheuron's Fury Arms profile?