PQR - Rotation Bot

[Ssateneth]

link: API IsSpellInRange - WoWWiki - Your guide to the World of Warcraft

some notes on this api:

You will get a 'nil' if:

1) The spell cannot be cast on the unit. i.e. attempting to check range using 'Frostbolt' on a party member will always return 'nil', similarly testing 'Heal' against an enemy target will also return nil.
2) If the unit is not 'visible' (see API UnitIsVisible) then you will get a nil, and not a '0' as you might expect.
3) The unit doesnt exist (e.g. 'target' when you have nothing targetted)
4) The current player does not know this spell (so you cannot use 'Heal' to test 40 yard range for anyone other than a priest)
5) It can be used for scanning raid members distances, but just take care what spell you use. For example scanning heal range will start throwing out 'nil' if a raid member is mind controlled.


so best use of IsSpellinRange() would be this:

local inRange = 0
--sets up if target is in range of spell
if UnitExists("target") and UnitIsVisible("target") and UnitIsEnemy("target") then
   inRange = IsSpellInRange("spellid", "target")
end

--if your in range then do what you want
if inRange==1 then
   return true
end

You completely ignored his issue. Did you even bother to see if you could replicate his problem? Certain spells are BUGGED. If he has a hostile target within melee range and wants to get IsSpellInRange("Living Bomb","target"), it SHOULD return 1, but it returns nil. This also occurs with Devastate and ... wait for it ... FROST STRIKE! Instead of trying to look smart, how about looking to see if his problem is actually a problem and not a bad assumption on your part that he is stupid.

[crystal_tech]

You completely ignored his issue. Did you even bother to see if you could replicate his problem? Certain spells are BUGGED. If he has a hostile target within melee range and wants to get IsSpellInRange("Living Bomb","target"), it SHOULD return 1, but it returns nil. This also occurs with Devastate and ... wait for it ... FROST STRIKE! Instead of trying to look smart, how about looking to see if his problem is actually a problem and not a bad assumption on your part that he is stupid.

wow just wow.

if IsSpellInRange() is bugged have you tried the PQR_UnitDistance(unit1, unit2) instead?

and just check if its 8 yards or less?

if PQR_UnitDistance("player", "target") <= 8 then
do something
end

might be the workaround you need for this. I think the id that your using is wrong as the game itself wouldn't let you cast it if you where in range or not if it was bugged.

[Bgreen12]

That would be perfect. How soon do you think you could get that up and running? Right now I'm just pvping on other characters until one gets released.

I mean by the time people get to 90 in mop ill be there too so I'd say by then atleast

[Taran32]

I mean by the time people get to 90 in mop ill be there too so I'd say by then atleast

Oh I meant with regards to 85. You mentioned possibly being able to code one for current levels, so I was more interested in that. Or did I read that wrong?

[Wopak]

wow just wow.

if IsSpellInRange() is bugged have you tried the PQR_UnitDistance(unit1, unit2) instead?

and just check if its 8 yards or less?

if PQR_UnitDistance("player", "target") <= 8 then
do something
end

might be the workaround you need for this. I think the id that your using is wrong as the game itself wouldn't let you cast it if you where in range or not if it was bugged.

Hi crystal_tech.

First of, thank you for your constructive input.

First of, as i said in my original post. I'm not using PQR or anything else found here on ownedcore, i merely brought this issue up for you guys as a heads up. Now with that said, let's continue.

The link you gave earlier API IsSpellInRange - WoWWiki - Your guide to the World of Warcraft is outdated, as it doesn't state that you can also pass spelll index as an argument to IsSpellInRange, so the correct documentation for this would be:
inRange = IsSpellInRange(index, "bookType", "unit") or IsSpellInRange("name", "unit")
Return values remains the same as always.

Using a range check on those spell thats bugged was actually my first workaround, but i found it to flakey.

So the right approach to solve this is the following.
If IsSpellInRange([name or ID], "unit") fail, you should try IsSpellInRange(index, "bookType", "unit")

The reason you want to check first with the normal way IsSpellInRange([name or ID], "unit"), is because i just found out that Tricks of the Trade is bugged is used with the spell index.

So to summ it up.
First check the way you normally do, if that returns empty, then check with the spell index and problem solved.

[kabman]

not sure why but non of the lock profiles are working for me. Any ideas?

[kickmydog]

If you are using my BM rotation replace the Kill Command ability with the following

if not IsPetAttackActive() 
or IsRightControlKeyDown() 
or UnitIsDead("pet") then return false end

if IsSpellInRange(tostring(GetSpellInfo(2649)), "pettarget") == 1 then return true end

This will make the rotation skip Kill Command when you hold down Right CTRL or it will skip if you do not have a pet out or your pet is dead. This might help on those fights where the pet goes nuts and won't Kill Command.

[sheuron]

Hi crystal_tech.

First of, thank you for your constructive input.

First of, as i said in my original post. I'm not using PQR or anything else found here on ownedcore, i merely brought this issue up for you guys as a heads up. Now with that said, let's continue.

The link you gave earlier API IsSpellInRange - WoWWiki - Your guide to the World of Warcraft is outdated, as it doesn't state that you can also pass spelll index as an argument to IsSpellInRange, so the correct documentation for this would be:
inRange = IsSpellInRange(index, "bookType", "unit") or IsSpellInRange("name", "unit")
Return values remains the same as always.

Using a range check on those spell thats bugged was actually my first workaround, but i found it to flakey.

So the right approach to solve this is the following.
If IsSpellInRange([name or ID], "unit") fail, you should try IsSpellInRange(index, "bookType", "unit")

The reason you want to check first with the normal way IsSpellInRange([name or ID], "unit"), is because i just found out that Tricks of the Trade is bugged is used with the spell index.

So to summ it up.
First check the way you normally do, if that returns empty, then check with the spell index and problem solved.

You name all things you dont understand bug?

It's not a bug, IT'S A FEATURE

[imdasandman]

You completely ignored his issue. Did you even bother to see if you could replicate his problem? Certain spells are BUGGED. If he has a hostile target within melee range and wants to get IsSpellInRange("Living Bomb","target"), it SHOULD return 1, but it returns nil. This also occurs with Devastate and ... wait for it ... FROST STRIKE! Instead of trying to look smart, how about looking to see if his problem is actually a problem and not a bad assumption on your part that he is stupid.

you are a contribute at least post like one this is the garbage a leecher would write

Sent from my SAMSUNG-SGH-I717 using Tapatalk 2

[Ssateneth]

you are a contribute at least post like one this is the garbage a leecher would write

Sent from my SAMSUNG-SGH-I717 using Tapatalk 2

I contributed a lot when lua ninja hack was around (about the time of late tier 9, early tier 10 of WotLK) by making 1 button rotations, but I got fed up with the same redundant questions that were asked left and right. I had hoped people would -learn- from my scripts, but apparently that was too hard, so I stopped writing scripts and stopped receiving rep.

[wooloveshacks]

Whatever you think of Ssateneth's post in this thread, it's undeniable that Ssateneth is legendary in scripting.

Loved the luaninja scripts (and assistance given to other scripters). and they're still used by quite a few as the framework for their current work.

On that note, I'd like to thank everyone for their contributions and wish you all a happy 2 week, 3 days countdown till MoP

[firepong]

Aaaaaaaaaaand, to further update on the Feral Rotation of using Rake only and Shred/Mangle for Rip extensions, here's a little Blizzard feedback from Ghostcrawler:
Beta Class Balance Analysis Pt. II - Forums - World of Warcraft

At both level 85 and level 90, in high-mastery conditions, Rake will outscale Shred for DPE and become the primary filler move for CPs. Shred is still weaved in to extend rip duration and letting tf/proc buffed Rakes roll, but overall the rotations is largely simplified by just spamming rake.

Yeah, this seems like a valid concern (i.e. the numbers make sense). We'll investigate and try to shift damage around to discourage it.

Soooo, further ado, my profile will be staying the same as it is as most likely, from the wording of that post, they are going to remove damage from rake and put it in other places. My guess, their going to probably seriously buff Rip to make up for the missing Damage or add it back to Shred/Mangle like it was before 5.0.4.

Until something comes out on Beta, it's a big waiting game to see exactly what their going to do from stopping Rake spam. For all we know, they might Buff our Bleeds and Nerf our mastery, which doesn't seem half bad since the mastery got a buff I believe in 5.0.4.

[crystal_tech]

this will be the last post on the isspellinrange api,

I wasn't trying to start a flame war and I never used luaninja, with the info that i posted from wowwikki i was hoping that we could find coders the workaround for the api messing up. I posted the info from that page to show people what can cause a nil value on the call. its a major patch and things changed we all are having to relearn a bit so there will be bugs/errors/upset people but I wasn't trying to 'out smart' anyone.

Anywho, I'm sorry if I seemed like that. Next up: Demo Lock!

[bu_ba_911]

this will be the last post on the isspellinrange api,

I wasn't trying to start a flame war and I never used luaninja, with the info that i posted from wowwikki i was hoping that we could find coders the workaround for the api messing up. I posted the info from that page to show people what can cause a nil value on the call. its a major patch and things changed we all are having to relearn a bit so there will be bugs/errors/upset people but I wasn't trying to 'out smart' anyone.

Anywho, I'm sorry if I seemed like that. Next up: Demo Lock!

Woot woot I know quite a few people who are expectant of Demo !

[KleskReaver]

@ [Blinded]

Just wanted to give you a heads up, in the new 5 man instance "Scarlet Halls" there are some mobs that man cannons called "Scarlet Cannoneer": Scarlet Cannoneer - NPC - World of Warcraft

these mobs don't engage you in combat and just stand there firing cannon balls onto your group doing AOE damage

Due to the way these mobs function I had to add "Scarlet Cannoneer" to your list of SpecialAggro targets in "PQR_notValid.lua"

tested and works