Checking Lua script!

[mantor4]

I've been reading up on Lua boss fights recently, and came up with a very basic boss script. If anyone could check it for errors and whatnot, that would be fantastic! Thanks!


function Boss_Say(pUnit, event)
pUnit:SendChatMessage(12, 0, "Prepare for Annihilation!")
pUnit:RegisterEvent("Boss_Phase1",1000, 0)
end

function Boss_Phase1(pUnit, event)
if pUnit:GetHealthPct() < 70 then
pUnit:CastSpell(11)
pUnit:RegisterEvent("Boss_Phase2",1000, 0)
end
end

function Boss_Phase2(pUnit, event)
if pUnit:GetHealthPct() < 30 then
pUnit:RemoveEvents()
end
end

function Boss_Start(pUnit, Event)
pUnit:RegisterEvent("Boss_Say",1000, 0)
end
RegisterUnitEvent(999989, 1, "Boss_Start")

[stoneharry]

You have the basic idea, but there's one flaw your making:

:RemoveEvents()

This is used to stop any RegisterEvents you currently have running attached to that creature.

RegisterEvent("name", time, repeat)

Setting repeat to 0 will make it check infinite times.

So currently, it starts, does Boss_Say every second, Boss_Phase1 every second (which is correct as it may not be < 70% on Phase1), then does phase 2 till <30%, then stops everything.

Maybe you want to change Boss_Say to only happen once, and to add a RemoveEvents() in phase 1?

[choweyiii]

If you're new to lua, take a look at Arcemu Unit Commands it's very, very helpful!

[mantor4]

Thanks for the help! So, what you're saying I should do is add the line pUnit:RemoveEvents() into phase 1? Because right now, I added it in right here:

function Boss_Phase1(pUnit, event)
if pUnit:GetHealthPct() < 70 then
pUnit:CastSpell(11)
pUnit:RegisterEvent("Boss_Phase2",1000, 0)
pUnit:RemoveEvents()
end
end

[newtech]

nono, always add it as the first line after the function is initiated. Otherwise its gonna remove the RegisterEvent xD In this case, as it looks now, you have registered the event Boss_Phase2, but by putting a RemoveEvents right after, its gonna stop repeating the event Boss_Phase2 x)
Oh yes, and could you please use [Code] tag?

Thanks
Newtech

[mantor4]

Alright, thanks. Change has been made. Thanks again for the advice!