Complex If Statements

[MaiN]

Yes, assuming you are only reading 32 bits. But seeing as his ReadOffset is a templated function I think it's safe to assume he is reading sizeof(type) bytes.

Well, *THAT* is a very good point. :P

Without major troubles, you can't inject a x64 dll into x86 wow anyways.

Inject 64-bit dll into 32-bit WoW bro. Warden umad?

[Amrok]

My memory library can handle both x86 and x64 instances of wow and i'd like to be compatible with any architecture regardless of current binary state

[Cypher]

I'm not much into windows specific stuff, sorry.
This then requires that you compile for 32 bit, just as WoW was compiled for. It seems to be more save imho to use a uint32_t then.

Huh?

When targeting native 64-bit, INT_PTR is a 64-bit data type.
When targeting native 32-bit, INT_PTR is a 32-bit data type.

There is no compatibility problem unless you're targeting native 64-bit and then interfacing with the 32-bit WoW client, which is dumb except in very specific circumstances that don't apply here.

Using INT_PTR means that in the future, if they were ever to upgrade WoW to native x64 your code would still work (assuming you updated your offsets etc).

He's doing the right thing. uint32_t should not be used to hold a pointer if you're trying to remain architecture agnostic.

Inject 64-bit dll into 32-bit WoW bro. Warden umad?

This is one of those 'specific circumstances' in which targeting native 64-bit then interacting with a 32-bit target is the 'right' thing to do.

My memory library can handle both x86 and x64 instances of wow and i'd like to be compatible with any architecture regardless of current binary state

A good attitude imo.