[PQR] CodeMyLife's Profiles

[CodeMyLife]

What most people reading this thread should know is that CML is currently working on porting all of his profiles over to Probably Engine.
So if you want to help him make his profiles better, head over there and test them out for him and give him feedback in his thread there.

Yep, I'm out of here. Some profile sellers are ruining my fun. The saddest part is that the website owners don't seems to care much about it. Coding and giving is what I like. Now people steal my work and make money out of it and i can't even manage doing rep. Got 10 rep in the last 2 months or something? Well I guess people won't care anyway they can just "Steal" what they want by dumping. Oh yeah really.


Not gonna update anything anymore in here I guess. If you want to steal my work it's the right time.

CML

[Enuma]

Yep, I'm out of here. Some profile sellers are ruining my fun. The saddest part is that the website owners don't seems to care much about it. Coding and giving is what I like. Now people steal my work and make money out of it and i can't even manage doing rep. Got 10 rep in the last 2 months or something? Well I guess people won't care anyway they can just "Steal" what they want by dumping. Oh yeah really.


Not gonna update anything anymore in here I guess. If you want to steal my work it's the right time.

CML

D: Its a sad day for PQR community, really is.. I guess, no, i know that you are right, so i dont try to post "dont go" and that shit. I do love your profiles and i think that they are unique in some way, so i decided to stick to them. I really hope that you will have much more luck on PE base and that you will manage to do whatever you planned with it. I will probably follow you, as a happy user of your rotations, but also as a custom modder of profiles. Well, only thing that i can ask you now, since i have been buzzing around PE forums, whats your username there to look up your profiles? Last time i checked i havent seen any of your profiles under class profiles sub-forums.

Till we have a chance to run into each other, good luck mate and hope to sniff you there!

On the positive side, i played a bit with your fury rotation to fix some things, so ill post it public cause i love when profiles are top optimized.

Added support for Berserk Stance for those naughty warriors that like to stand in deadly stuff /whistle... who? me? naah xD

Under Initialization, find and replace:

	SLASH_STANCEDANCE1 = "/stancedance"
	function SlashCmdList.STANCEDANCE(msg, editbox)
		if macros["Stance"] == 1 then
			xrn:message("\124cFF006FEDDefensive Stance.")
			macros["Stance"] = 2
		else
			xrn:message("\124cFFFF3300Battle Stance.")
			macros["Stance"] = 1	
		end
	end

with this code:

	SLASH_STANCEDANCE1 = "/stancedance"
	function SlashCmdList.STANCEDANCE(msg, editbox)
		if macros["Stance"] == 1 then
			xrn:message("\124cFF006FEDDefensive Stance.")
			macros["Stance"] = 2
		elseif macros["Stance"] == 2 then
			xrn:message("\124cFFED0000Berserker Stance.")
			macros["Stance"] = 3
		else
			xrn:message("\124cFFFF3300Battle Stance.")
			macros["Stance"] = 1	
		end
	end

Next, fixed issue with casting bloodbath when entering the combat, but being out of melee range of the target for fury rotation.
Under Fury Rotation find line:

if BloodbathCheck and Spells[_Bloodbath].known and _SA(_Bloodbath) and GetSpellCD(_ColossusSmash) < 2 then
	_Cast(_Bloodbath, "player")
end

Replace it with:

-- single_target=bloodbath,if=enabled&(target.melee&debuff.colossus_smash.up)
if BloodbathCheck and Spells[_Bloodbath].known and _SA(_Bloodbath) and (CML_MeleeTarget() and _SmashUP) then
	_Cast(_Bloodbath, "player")
end

This will cast Bloodbath only when target is in melee range and have Colossus Smash debuff (since Bloodbath is off GCD to maximize its potential).

One last thing, this is fix for Impending victory and Victory Rush which weren't working before at all. This will fix it and make them work according to settings in PQI

Locate their code at the end of single target rotation and replace it with this:

-- normal_rotation+=/victory_rush,if=!talent.impending_victory.enabled&buff.vrushed.up&HP<=iv.value
if ImpendingVictoryCheck and Spells[_VictoryRush].known and _SA(_VictoryRush) and CML_HaveBuff("player", _Vrushed) and _HP <= ImpendingVictory then
	_Cast(_VictoryRush, CML_MeleeTarget())
	return true
end

-- normal_rotation+=/impending_victory,if=talent.impending_victory.enabled&(rage>=10&HP<=iv.value)|(buff.vrushed.up&HP<=iv.value)
if ImpendingVictoryCheck and Spells[_ImpendingVictory].known and _SA(_ImpendingVictory) and ( _Rage >= 10 and _HP <= ImpendingVictory) or (CML_HaveBuff("player", _Vrushed) and _HP <= ImpendingVictory) then
	_Cast(_ImpendingVictory, CML_MeleeTarget())
	return true
end

If you want to have Victory Rush/Impending victory working in all AOE modes paste this same code between the end of Single Target and start of AOE rotations:

Now, i have some more ideas here and there, will update it when i do them

EDIT: Did some cleanup and testing, everything works fine if put in as explained. In addition to that, i added Heroic Throw toggle in PQI settings, as im not found of it.

As for Interrupt code.. looking into it.. on first glance It was wrong spell id into Plummer code, it was code for rogues Kick. Will post future updates here if anyone is willing to play with the code, or even use this rotation.

Edit2: Interrupts fixed!

Go to functions find and select everything, including from CML_Interrupts = nil down to this line, excluding xrn:message("\124cFF9E6720...CodeMyLife Warrior..."). Basically your switching whole interrupt code with this one posted, implemented both Pummel and Disrupting Shout.

CML_Interrupts = nil
	function CML_Interrupts()
		-- Credit goes to Xelper for his interupt code. Thank you very much Xelper!!
	
		
		if not PummelCheck then 
			return false 
		end
		
			if RandomPummel == nil then
			if Pummel == 1 then RandomPummel = math.random(0,50) end
			if Pummel == 2 then RandomPummel = 30 end
			if Pummel == 3 then RandomPummel = 0 end
		end
		
		function PQR_InterruptSpell()
			if IsPlayerSpell(6552) and PQR_SpellAvailable(6552) then --Pummel
				return 6552
			elseif IsPlayerSpell(102060) and PQR_SpellAvailable(102060) then -- Disrupting Shout
				return 102060
			else
				return 0
			end    
		end   
		
		local PQR_InterruptPercent = Pummel
		local interruptSpell = PQR_InterruptSpell()
		local interruptName = GetSpellInfo(interruptSpell)
		
		InterruptTargetsList = { "target", "focus", "mouseover" }
		-- Interrupt Casts and Channels on Target and Focus.
		if interruptSpell ~= 0 then
			for i = 1, #InterruptTargetsList do
				
				local customTarget = InterruptTargetsList[i]
				local castName, _, _, _, castStartTime, castEndTime, _, _, castInterruptable = UnitCastingInfo(customTarget)
				local channelName, _, _, _, channelStartTime, channelEndTime, _, channelInterruptable = UnitChannelInfo(customTarget)
					
				if channelName ~= nil then
					--target is channeling a spell that is interruptable
					--load the channel variables into the cast variables to make logic a little easier.
					castName = channelName
					castStartTime = channelStartTime
					castEndTime = channelEndTime
					castInterruptable = channelInterruptable
					PQR_InterruptPercent = 0
					local IsChannel = true
				end
				
				--This is actually "Not Interruptable"... so lets swap it around to use in the positive.
				if castInterruptable == false then
					castInterruptable = true
				else
					castInterruptable = false
				end	
				
				if castInterruptable then
				  	local timeSinceStart = (GetTime() * 1000 - castStartTime) / 1000
					local timeLeft = ((GetTime() * 1000 - castEndTime) * -1) / 1000
					local castTime = castEndTime - castStartTime
					local currentPercent = timeSinceStart / castTime * 100000
				  	if IsSpellInRange(GetSpellInfo(23881), customTarget) ~= nil
				  	  and ( currentPercent > PQR_InterruptPercent or interruptSpell ~= 6552 )
				  	  and UnitCanAttack("player", customTarget) ~= nil then
					--target is casting something that is interruptable.
					--the following 2 variables are named logically... value is in seconds.
						if InteruptTimer == nil 
						  or InteruptTimer <= GetTime() - 1.25 then
						  	if currentPercent < RandomPummel and not IsChannel then return false end
							CastSpellByID(interruptSpell, customTarget)
							InteruptTimer = GetTime()
						end		
					end
				end
			end
		end
	end

[CodeMyLife]

My user there is the same, it's just that i'm not in any class, rather in the bottom of the classes page as I'm planning to code more classes. You will always be welcome to use anything//modify any of my profiles to develop for free. I just do not like leechers that sells profiles so it's all good, enjoy the modding

[Enuma]

My user there is the same, it's just that i'm not in any class, rather in the bottom of the classes page as I'm planning to code more classes. You will always be welcome to use anything//modify any of my profiles to develop for free. I just do not like leechers that sells profiles so it's all good, enjoy the modding

Ahh... took a look on your PE pala profile, looking good! Keep up the good work! I have to stick to PQR until you toss out warriors profile as im so used to your profile that im unable to switch to other Good luck, ill be bugging you there for sure!

As for future fury/prot updates, any changes that i make and find them decent improvement, i will post them here for ppl that are willing to edit their profiles. cheers.

And forgot to mention.. reply on your previous comment regarding 10 rep in last 2 months.. Im not quite sure what exactly rep is for here, but i can tell you for sure that i edited bunch of other profiles and added features/fixes to them, not a single fuk, i mean rep is given, so im kinda used to it. ^_^

[snowhawk]

Yep, I'm out of here. Some profile sellers are ruining my fun. The saddest part is that the website owners don't seems to care much about it. Coding and giving is what I like. Now people steal my work and make money out of it and i can't even manage doing rep. Got 10 rep in the last 2 months or something? Well I guess people won't care anyway they can just "Steal" what they want by dumping. Oh yeah really.


Not gonna update anything anymore in here I guess. If you want to steal my work it's the right time.

CML

That sucks man that people are just ripping off your profiles and profiiting off of it, kinda the reason I don't release my own personal profiles/edits. I can understand your frustration as I've looked through a few of the paid profiles and you can just see all of the rips (valma, sheuron, team nova). Love your pet battle profile still and good luck with your PE projects!

[crystal_tech]

its been that way for awhile now, I've been coding for pqr since it was still in beta, and now that the free devs set the ground work as it were, people came in and reused without asking and sold that code as if they coded it. disclaimer: not every paid profile out there did this but its enough to harm the community to where we are today. thats just my take on it.

oh, I know this isn't my thread but I'm still around working on pqr profiles.

[anclav]

Hello. Does anyone else have the same problem - checkbox for Execution sentence in prot rotation doesnt work. Its casted no matter checked or unchecked. Amount of vengeance is working but still there are some situations (especially at siegecrafter HM) where you should cast it manually.
Second question - SotR options dont work for me also. At klaxxi HM i really need this manual mode, but the routine continue casting SoTR @5 holy power. I have to pause rotation to wait for needed cast or cast EF for example. And i cant move to PE cause it seems to not work with russian client.
Seems that CML wont help me here, but maybe someone ran already into this? Any help would be greatly appreciated.
Thanx in advance

[CodeMyLife]

You tried casting it with your fingers!? Might help.

About SotR, how can it be an issue? First time I hear that one.

[Jettand]

hi CodeMyLife, Prot Warrior profile, uses Battle Stance instead of Defensive.
When I switch it manually it goes back into Battle (Currently level 15), everything else is working great!

edit: read your first page again and found /stancedance, overlooked it, thanks!

[anclav]

You tried casting it with your fingers!? Might help.

About SotR, how can it be an issue? First time I hear that one.

Your profiles are great! Thanx a lot for these - i finished all the ToT HM content and now almost done with OO

Casting ES with fingers? The issue that its casting automatically no matter checked or not, and theres a moment just before crosher comes when i have vengeance over 400k - so its cast even when vengeance threshhold is set to 400k
About sotr - usually used wise mode so never needed to keep 5 holy powers for some time, or some specific times when i dont need that sotr buff
So when i chose manual sotr mode its still casting sotr at 5 holy powers, i hope its not intended? May it be that the problem is russian client?
Btw are abilities in your PE profiles are coded by spell ID?

[Deathsmind]

Who is stealing and selling your profiles? You are pretty much the only prot pally person here. The only person I see selling accounts is also Soapbox which doesnt have a prot pally profile.

As a prot pally we need you to stay. What will moving over to PE change?

[Enuma]

Who is stealing and selling your profiles? You are pretty much the only prot pally person here. The only person I see selling accounts is also Soapbox which doesnt have a prot pally profile.

As a prot pally we need you to stay. What will moving over to PE change?

Thats kinda rude, wont you say? Since i would. CML never said that someone is stealing his profiles, but, i quote:

Now people steal my work and make money out of it.

The "work" is everything, from initial idea and even creating a blank .xml file, over typing in code, testing it, fixing it, changing it to serving finished product, that is, profiles it self. Tbh I've seen his code in few paid profiles, so, i get what is he saying. It doesnt have to be paladin specific code as his code can be used pretty much for every class if you spend a little time getting to know it. I have no lua experience and i spent two hours getting to know code, and what i did? managed to fix several issues in it just by using simple logic, wowhead for spell IDs and.. copy/paste.

As for second part of your question.. "What will moving over to PE change?" Nothing.. and everything.. Nothing HERE cause ppl will continue to use his work to make paid profiles, everything cause now there is no more prot pala profiles around, all thx to those same ppl. Next, it changes a lot from dev standpoint as PE it self is much more friendly to work with and code is simple to write. Best of all, its completely open source community so there will be no profile sellers, well at least i dont see them in any near future.

I have to take his stand on this and say that i understand him, mainly cause of idea that someone, free of charge, actually took his time and devoted it to community, writing something that will be useful and sharing it to ppl. So, that he can one day see someone actually selling his code to make a profit for HIMSELF. I would probably move long time ago too, but, sadly, there are no solid profiles yet for what i play. I would like to devote my time and move to PE, writing my own fistweaver rotation as i stumbled on PE composition code way back when i was on HB, but sadly i dont have time for it now.

For all others.. CML said that he wont update his profiles any more so its kinda not fair to spam this topic any more with stuff. Its fair, but dont expect much of an help from him, maybe someone else will pitch in and fix it. Instead, take your time and try to dig out issue try to fix it, or just play the game with profile how it is now. I personally wouldnt share my fixes as i like to keep them for myself, but also cause i shared so many fixes and added features in the past, yet not a single fuk (rep) is given. BUT warr fury profile is kinda in really bad shape so i wanted to see it up and running, at least till next expansion or major changes that would brake them.

Anyhow peace, prosperity and love.. all that stuff. CML, lad, I've seen that you are already balls deep on pala PE profile. Keep up the good work! <3

[Deathsmind]

Not being rude at all. Im just saying that moving to PE he can have his work stolen as well. I mean if its all open source over there and everyone is sharing profiles why does it matter if people are taking his work over here but fine over there? Im just being rational. You cant be mad at people using your work here and then be happy that people use your work over there. Also if im not mistaken there are already paid profiles on PE or they were allowing it in the future, cant remember where I saw it.

Likes arent the only thing that matters. Check out websites that allow downloading of games, movies, etc. Millions of people take your stuff and use it, only about 1% actually like or support the page.

[jaxino1982]

Even if you make your profiles to be paid, people will buy them and will use the code.... so i can't see any good solution.

Another thing is that, imho PQR it's THE BEST. PE still needs some work...

[Beelzix]

how do i take this thing off thats in teh center of my screen from this profile?

edited: nvm found it sry