Ill run some LFR raids with it and report back soon. Thanks for your hard work also![]()
Ill run some LFR raids with it and report back soon. Thanks for your hard work also![]()
Actually I thrown some codes using same conditions as for rapidfire and focus fire, and tried to add berserking but cannot test myself actually i'm alliance.. the code looks like this
As tou can see, Berserking is there with same conditions as RF and FF, it's the 3rd to be used as it is right now but it should be thrown anytime RF and FF are not active is your Focus regen is under 6. I do not see why it would not work.PHP Code:
if GetSpecialization() == 1
and Nova_ActiveCooldowns == 1
and not UnitBuffID("player", 34692) then -- Never use Any CD during BW
-- Stampede
if PQR_SpellAvailable(121818)
and StampedeCheck then
CastSpellByName(GetSpellInfo(121818))
end
if select(1, GetPowerRegen()) < 6 then
-- Focus Fire
local _,_,_,frenzycount,_,_,_ = UnitBuffID("player",19615)
if frenzycount == 5
and GetSpellCD(19574) > 8 then
CastSpellByName(GetSpellInfo(82692))
end
-- Rapid Fire
if RapidFireCheck -- Checked.
and ( GetSpellCD(19574) < 3 or GetSpellCD(19574) > 15 ) then
CastSpellByName(GetSpellInfo(3045))
end
-- Readiness
if ReadinessCheck
and GetSpellCD(3045) > 90 -- More than 90 sec on Focus fire.
and GetSpellCD(19574) > 30 -- Bestial Wrath more than 30 secs remaining.
and GetSpellCD(34026) > 4 then -- Kill Command more than 4 seconds remaining.
CastSpellByName(GetSpellInfo(23989))
end
-- Berserking (Troll Racial)
if PQR_SpellAvailable(26297) then --Berserking
CastSpellByName(GetSpellInfo(26297))
end
end
--Bestial Wrath
if GetSpellCD(19574) < 0.1 -- Bestial Wrath available.
and BestialWrathCheck then
if not UnitChannelInfo("player")
and ( UnitPower("player",2) < ( BestialWrath - 20 ) and ( HaveBuff("player", 3045, 2) or HaveBuff("player", 82692, 2)))
or ( UnitPower("player",2) < BestialWrath and not ( HaveBuff("player", 3045, 2) or HaveBuff("player", 82692, 2))) then
CastSpellByName(GetSpellInfo(56641),"target")
end
if GetSpellCD(34026) < 3 -- Kill Command close to be ready
and ( GetSpellCD(3045) > 6 or select(1, GetPowerRegen()) > 6 )
and not ( PQR_SpellAvailable(121818) and StampedeCheck ) -- Stampede not Ready.
and ( UnitPower("player",2) > BestialWrath or ( UnitPower("player",2) > ( BestialWrath - 20 ) and ( HaveBuff("player", 3045, 2) or HaveBuff("player", 82692, 2)))) then -- Enough focus
CastSpellByName(GetSpellInfo(19574)) -- Bestial Wrath.
end
end
end
![]()
Soapbox Rotations Developer
If I'm BM, /activecooldowns is on, I don't have BW activated, and my power regen is less than 6 focus/s, and Berserking is available, then cast it.
As far as that goes, it looks like it should work.
The "if"s and "end"s look like they match up, so I don't know! There is an extra "end" in the berserking section, but that's just the end of
so it should be fine.PHP Code:
if select(1, GetPowerRegen()) < 6 then
However, I think that blowing CDs during BW is fine - as long as it's not FF. The CDs you want to avoid stacking with each other are haste - so never Focus Fire with RF, or BL etc, but it looks like the power regen under 6 thing covers this so that's fine anyway.
Other things:
I suggest putting in a recast delay for Serpent Sting. At the beginning of some fights, before SrS is applied, sometimes it will cast twice (since there is a travel time, it casts a second one before the first one hits).
I put in my own Berserking (and Lifeblood) ability. Had to change it to this:
Lifeblood/Berserk work fine, but they completely break the RF/Readiness interaction, no matter where I put them in the rotation. It's weird. Either RF will cast and Readiness never will, or it will cast Readiness without casting RF first, then cast RF after Readiness.PHP Code:
if Nova_ActiveCooldowns == 1
then if PQR_SpellAvailable(26297) --Berserking
and UnitBuffID("player", 138938) --Juju Madness
or UnitBuffID("player", 109085) --Scope proc
or UnitBuffID("player", 34471) --BW
then
if not UnitBuffID("player", 3045) --RF
and not UnitBuffID("player", 2825) --BL
and not UnitBuffID("player", 80353) --Time Warp
and not UnitBuffID("player", 90355) --Ancient Hysteria
and not UnitBuffID("player", 82692) --Focus Fire
and not UnitBuffID("player", 121279) --Lifeblood
then
return true
end
end
end
In fact, when I take my lifeblood/berserk out of the rotation, it's still broken. The abilities still exist, but they're not in the rotation, so there is no difference between our rotations - I haven't edited any of your abilities. After unloading PQR, /reload, and closing and restarting WoW, it's STILL broken.
After removing my abilities from the Ability Editor entirely, it's still broken. Unload PQR, /reload, restart PQR - still broken.
But, after I restart WoW again (now that the abilities no longer exist), it's back to normal. I guess just having those abilities in there, even if they're not in the actual rotation, is breaking it somehow? Very odd.
Edit: Now that I'm looking at it, it kind of makes sense that it wouldn't hit Rapid Fire during the time I'd have lifeblood/berserk active, but that's not the issue, plus it's still using Readiness at the wrong time.
Also in the Shot - Widow Venom ability, it makes reference to a "WidowVenomCheck" which I can't find anywhere.
I'd also like to suggest a Concussive Shot option - for kiting/pvp?
Last edited by ozmodiar; 06-28-2013 at 01:07 PM.
My way to calc is theres a haste buff is effectively trought GetPowerRegen() it works great.
The SS blacklist is an idea I already tested and was giving very bad result. however, if you stand at 10-15 yard of your target the sting whould be applied before script re-run so should not cast twice. If it's casted twice it's because your sting is not landed yet, it's flying.
Widowvenom is to be re-implemented as macro or in PQI, was thinking of making on/off toglle macro for it and conc shot as these should be toggled on live.
I tested blink strikes too, works great. I used Glaive Toss until recently and Blink Strikes is definetly better.
Last edited by CodeMyLife; 06-28-2013 at 03:56 PM.
Soapbox Rotations Developer
I think I found the cause of one of my issues! When my Rune of Reorigination procs, I go up to 6.75 focus/s regen.
I know RoR is garbage, but it's the best I've gotten so far :\
Here are focus regen values for other haste sources - this is unbuffed, so no raid buffs included here.
5.9 Berserking
5.1 Lifeblood
6.39 FF
6.88 RF
Oh I did not realize other abilities might not hit the < 6 treshold. Might use 5 instead I guess to make sur to delay the use of haste buff while over 5? Or should we stack those instead as they gives only 1-1.5 focus/sec? About your trinket "issue" is it that the trinket procs so often that you never fall under 6? If you remove trinket, will Berserking be used?
Soapbox Rotations Developer
The trinket gets about 23% uptime. But, it always procs at the very beginning of combat, which puts me over 6 focus/s and delays Rapid Fire.
I've never seen Berserking cast on its own, with or without the trinket on.
Here's all of the Haste buff uptimes, if it helps:
Berserking: 6%
Focus Fire: 40%
Lifeblood: 17%
Rapid Fire: 13%
RoR: 23%
Which interestingly is 99%. Since we don't want to stack Haste cooldowns, that means that it's possible to have some form of haste buff up almost the entire fight.
I also found out that it's casting RF, Readiness, then RF again, all at once. Since they're not on the GCD, I think it's happening too fast for PQR's checks. I had to record my actionbars and slow down the footage to see what was happening, heh.
Edit: I switched to Engineering from Herbalism - I think you should put in the Synapse Springs enchant that Engineers get on their belt - it lasts 10 second and has a 1min cooldown - perfectly syncs up with BW, so we need to cast them both at the same time.
Something like this:
..PHP Code:
if UnitBuffID("player", "19574")
and GetInventoryItemCooldown("player",10) == 0 then
UseInventoryItem(10)
end
except it appears to me that it'd be better to just combine them into a single function, since there is no GCD on the belt..
So that makes the last 6 lines of Beast - Cooldowns look like this:
Which I can confirm works like a charm.PHP Code:
CastSpellByName(GetSpellInfo(19574)) -- Bestial Wrath.
RunMacroText("/cast "..GetSpellInfo(53401)) -- Rabid
UseInventoryItem(10)
end
end
end
I had a whole wall of text here but it turns out that none of it was even necessary. I made a simple error that turned into several hours work for nothing!
Last edited by ozmodiar; 06-29-2013 at 02:51 AM.
Not 200% sure but Readiness IS on GCD it will never be used before bestial wrath and never during bestial wrath but if you have that trinket, it does make sense that RF is kept until BW is casted then Readiness pops and then BW but should not trigger the second RF as the script will be re-ran before and should block on the focus regen treshold.
The code for Gloves/Rabid is looks super tyvm ozmo, I will add it when I get the net back on monday!
Last edited by CodeMyLife; 06-29-2013 at 08:22 AM.
Soapbox Rotations Developer
I just found this profile a few minutes ago and have only tested it on a training dummy. I noticed that it is not using blood fury orc racial. Is this because I am on a training dummy, or does it just not use racials? I have only seen talk of berserking on here.
Are there console commands I need to be using on this profile??? Saw mention of something on the OP.
Thanks...
i am a lower level and do not yet have cobra shot, how can i get it to use steady shot instead?
it should auto, if not make it spell check.