[PQR Profile] CodeMyLife MoP Paladin Protection/Retribution Rotation.

[CodeMyLife]

Hehe!! You know I love you too Apoc!

CodeMyTest 1.39 Available via Rotation editor.


- This release will get over facing/range issues and will keep rotation flowing regardless of range or facing. With this release you can tank even with the target hitting you in the *** !!
- Severely modded the interupt behaviour to iterate trough ennemy targets and find proper target to cast Avenger's shield and Rebuke. Note that the Avenger's Shield will no longer break the rotation to interupt, it will only cast if no generator are ready at the same moment it would normally use it but now it checks if theres a better target to use it should help you pull back casters to tanking spot. Set Focus or Mouseover them to ensure it works well. You can Still disable Interupt management in PQI if you are using an Interupt Rotation and you do not want this interupt utility.
- Added Righteous Fury to PQI as suggested earlier by sallysteph! Thanks for input was a nice idea!

Again Thanks everyone for testing and giving feedback and Happy Tanking!

[crackz0r]

great profile, i am having one problem i hope someone can shed some light on. When my pally reaches 3 holy power, he just starts autoattacking.
if i dump holy power somehow (manual shield of righteous, word of glory), rotation will kick back in until i reach 3 holy power again.. then autoattack
If i remove shield of the righteous from my rotation, it seems to work fine.
Any thoughts?
Also worth noting that this is happening to me with both the latest codemylife, as well as the latest codemytest versions, as of this writing.
Thanks
btw this error seemed to by related to the problem

Date: 2013-06-02 13:47:44

ID: 1
Error occured in: Global
Count: 146

Message: [string "-- Calculation of GCD for Holy Power genera..."] line 39:
attempt to compare number with nil
Debug:
[string "-- Calculation of GCD for Holy Power genera..."]:39: ?()
[string "if PQR_Addon_Loaded == nil then..."]:742: PQR_NextAbility()
[string "if PQR_Addon_Loaded == nil then..."]:534: PQR_ExecuteRotation()
[string "if PQR_Addon_Loaded == nil then..."]:287:
[string "if PQR_Addon_Loaded == nil then..."]:214
Locals:
(*temporary) = nil
(*temporary) = 1.9199981689453
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to compare number with nil"

[CodeMyLife]

If your toon isnt 85+ you might have to lower the holy power usage to 3 in PQI Shield of the Righteous value.

I didnt see this issue myself, do you have the 1.07 data file? Was that question related to test version 1.37+ Master(CodeMyTest) or Stable version 1.33 Master(CodeMyLife)?

[crackz0r]

having the same problem on both CodeMyTest and CodeMyLife, latest versions of each. Toon is 90.. not really sure whats going on here.

[crackz0r]

this might be addon related, i killed everything except dbm and pqi, seems to work fine now

[aenyth]

Thank you for the work which you makes.
I have a small problem, at the end of a few minutes, my paladin spam " hand of protection " on him even, it boosts every time the cd is up. Even there the cds turn off, it changes nothing, and if I reboot wow, it's good for a few minutes and it begins again. I use 1.33 master et 1.07 data.
Can you help me please ?

[CodeMyLife]

There is a checkbox for Hand of Protection in the panel and an healt value. additionally this spell isnt supposed to target non-players, tanks and people with no assigned roles. There is however atm a Debuff Remover that I coded that works using /debuffme that might be the source of this problem. Your versions should be good. I will remove the debuff remover for now as anyway it does not meet my expectations and I will have to rewrite it. Do not forget to uncheck the Hand of Protection and Salvation for Dark Animus or expect to wipe! lol

For now feel free to remove the ability from the rotation using the Rotation Editor and taking Defense - Hand of Protection from the active abilities list. Sorry for the inconveniences!

I was trying 1.39 Multi-Target interupt and it works great but I think it's lagging a bit too much, is it just me or it's laggy? Well I had lots of stuff running in back so cant say for sure but I will reduce the number of targets we scan to the specific people we have to lower the memory usage as much as possible. Should help people with small machines. My friend have a dual core and he said he's computer want's to die when he start the rotation... Well it's not only the profile fault but i'll try to optimise stuff a bit more now that I learned more ways to do it.

As usual thanks a lot for feedback

[DEFLAMA]

Just done some more testing of your latest test release. Only thing I've noticed so far is when using SotR mode 6: if you hit 5 holy power and get an avengers shield proc, it will use the proc before using SotR, thus wasting 1 Holy Power generation. Its not really an issue since everything works great but thought i would let you know

This was using 1.39 Test, Single Target rotation, 1 enemy, SotR mode 6.

[CodeMyLife]

Were you with the Divine Favor Talent? Sometimes we end with too much holy power especially with DF... Sometimes when lucky on procs we become full. Otherwise if a proc occur, the rotation should shield right before using proc. I'll try to reproduce the issue tyvm for feedback!

[Budoy]

i tried this profile on LFR tortos today, it wont do anything.

[Apocalypse59]

i tried this profile on LFR tortos today, it wont do anything.

Try completely deleting the data and profiles, and then re installing.

[CodeMyLife]

About Tortos, there was an issue with tortos script (for heroic support) I removed the raiding events from the rotation for now as it seems there was also an issue with ji-kun, not a lua error but shielding was messy. Gotta investigate those a bit more, should clear those wednesday ill try to have something set until that. A little workaround for Tortos would be to macro let's say Alt-2 to a macro like /cast [target=focus] Judgement and if your Alt button is set for pause then you will pause rotation and cast judgement manually on the focus target. Then focus crystal and use when needed!

Removing "-- Raiding Events" from your actual rotation would do the job but if you want you can just update, 1.40 have some more boss checks on lay on hands and removed the extra healing that was originally the healing part, simply forgot to remove it in the process. The Interupts are still pulling lots of ressources for now but I'm working on a check to limit the group number checks and accelerate the process a lot. It's not causing dps/holy regen issues at all however. I was doing even more than never ever yesterday, the dps I do is just sick, it's fun haha

Oh and about the Hand of Protection, if you are set tank It is very unlikely to happend. I have removed the "DebuffMe" for now as I do not thrust it anymore, the timing is not working well and I will work on some events listener before I reimplement it. Last raid it did the HoP on a rogue and I was prett ysure it bugged but we scouted trought the logs and saw that when we landed top platform on heroic ji-kun, he landed before me and got hit down to 44% of is HP and my treshold was 45% so it worked. I didnt see his amount of HP low because I healed him the second rightafter and never seen anything of this going but the log did see it . It took ~ .3 second to throw the HoP and 1 second later he was healed up to 100% with a WoG so from the time he was hit and when he was topped with full hp theres been 1.3s. It is very likely that people will think its a bug as they just wont see what happened. My rogue friend did call it was a bug until he sees it in log.

Well keep me updated if you see anything strange as usuall feedback is very appreciated!

[jaxino1982]

I'm using your profile and i'll test the "test" code asap.

You are doing an awesome job m8!! Actually i'm tanking random hcs in 4 dps, usually i join with an elemental shaman irl friend as off-healer (with cds) and it's like a walk in the park

Ah yes, i have 474 il with pvp items :P

I love ya!

[Terades313]

Many Issues with the profiles today When i make debug on it says like the "spell was Skipped"

[CodeMyLife]

Jaxino very happy you can abuse your pally with my profile thanks for reporting it!

Terrades was it on Tortos? Was it v1.41 test or cml1.34?

I realized after pushing 1.41 that multi-target rebuke wasnt working correctly but beside that it was fine.

It's coming very soon. AoE interrupts will be madness I promise it! It was working for me for 2 Rh but stopped after I dont know why!?

It should be working tonight or at max this week-end. Actually 1.41 shielding events is working fine if the overlay message annoys you you can uncheck shield of righteous, it will still shield but wont report landed shields.