[PE] - NO CARRIER's Rotations

[ThereGoesTheDynamite]

Yes, SV. I tried to put in a "!lastcast(Focusing Shot)" condition on the two instances of Focusing Shot (AOE and non-AOE rotations), but it didn't work. Focusing Shot would just never cast.

I'm an idiot. I didn't bracket the two conditions together. After adding the proper brackets, i.e. { "Focusing Shot", {"!player.moving", "!lastcast(Focusing Shot)"} }, the rate of double casting Focusing Shot drastically dropped and my DPS drastically increased. From 26k to 27k DPS over 20m damage to 28.5k DPS over 20m damage.

[NOCARRIER]

Just pushed a minor update:

• Monk (WW): Removing Chi Torpedo - we don't want the rotation automatically 'rolling' us around the map, it should be manually used
• Fixed issue preventing Primal Elementalist Damage Shield from being considered as an excluding aura

[Lightbrand]

NOCarrier I have a question, in your latest update you've redone the entire code for immunevents, it is now much cleaner, my question is now if I were to add say Paladin bubble spellid 642 to specialaura list.
Will your
select(11, UnitAura(unit, i, "HELPFUL|HARMFUL"))
pick it up if I were to be shooting at an hostile paladin and temporarily stops the rotation?

Because previously you used local _,_,_,_,_,_,_,_,_,_,spellId = _G['UnitDebuff'](target, i) from your NOC.hasdebufftable function (which seems to be obsolete now) that picks up only debuff so I supposed I needed a local _,_,_,_,_,_,_,_,_,_,spellId = _G['Unitbuff'](target, i) to pick up target buffs, which Bubble is considered one.

[EDIT]
Ignore all that, figured it out after couple hours.

[ThereGoesTheDynamite]

NOCarrier I have a question, in your latest update you've redone the entire code for immunevents, it is now much cleaner, my question is now if I were to add say Paladin bubble spellid 642 to specialaura list.
Will your
select(11, UnitAura(unit, i, "HELPFUL|HARMFUL"))
pick it up if I were to be shooting at an hostile paladin and temporarily stops the rotation?

Because previously you used local _,_,_,_,_,_,_,_,_,_,spellId = _G['UnitDebuff'](target, i) from your NOC.hasdebufftable function (which seems to be obsolete now) that picks up only debuff so I supposed I needed a local _,_,_,_,_,_,_,_,_,_,spellId = _G['Unitbuff'](target, i) to pick up target buffs, which Bubble is considered one.

[EDIT]
Ignore all that, figured it out after couple hours.

Can you post what exactly you figured out?

[Lightbrand]

First off I don't have much chance to test this which is why I chose to first ask the question but I'm almost quite certain "Harmful|Helpful" will return nothing because the | is not an "or" operator, it's an "and" so no single aura (with any spellid) on the target can be both harmful and helpful'

IE: Bubble is helpful, Sap is harmful. If the guy casts bubble on himself, this wouldn't recgonize because of the Helpful|Harmful filter.

So what you need to do is essentially set 2 operations, local debuff = select(blah blah harmful), and local buff = select(blaha) that should work.
Although I'm not quite sure what the Break when debuff = nil accomplishes so I just removed it.

[NOCARRIER]

First off I don't have much chance to test this which is why I chose to first ask the question but I'm almost quite certain "Harmful|Helpful" will return nothing because the | is not an "or" operator, it's an "and" so no single aura (with any spellid) on the target can be both harmful and helpful'

IE: Bubble is helpful, Sap is harmful. If the guy casts bubble on himself, this wouldn't recgonize because of the Helpful|Harmful filter.

So what you need to do is essentially set 2 operations, local debuff = select(blah blah harmful), and local buff = select(blaha) that should work.
Although I'm not quite sure what the Break when debuff = nil accomplishes so I just removed it.

I think you might be on to something. I noticed last night on blast furnace that the fix (by checking Helpful|Harmful) didn't appear to work when checking the Primal Elementalist 'defensive shield' ability. That code probably needs to be revisited.

[NOCARRIER]

Pushed some changes:

• Monk (WW): Adding new (toggleable) experimental opener that uses Fists of Fury before Serenity
• Monk (BrM): Several tweaks to the brewmaster rotation in support of 6.1 and extra utility

[xodius98]

Awesome changes !!!!!!!!! well done and ty

Pushed some changes:

• Monk (WW): Adding new (toggleable) experimental opener that uses Fists of Fury before Serenity
• Monk (BrM): Several tweaks to the brewmaster rotation in support of 6.1 and extra utility

[Eddyan]

HI,Noc. I use your lastest MM hunter Rotations.but it didn't work.
BugGrabber\BugGrabber.lua:589: in function <!BugGrabber\BugGrabber.lua:589>
[C]: ?
[C]: in function `pcall'
probably\system\protected\generic.lua:12: in function `Generic'
probably\system\timers\rotation.lua:206: in function `event'
probably\system\core\timer.lua:16: in function <probably\system\core\timer.lua:11>

Locals:
nil
By the way,when I use your 20150226 version. it worked good.

[Luciferozzy]

Noc your Brewmaster only casts Tigers palm.

[NOCARRIER]

Noc your Brewmaster only casts Tigers palm.

I can't reproduce this. I just 'tanked' the tanking dummy for about 5 mins and everything was being properly used. Is this happening for anyone else as well?

[MrBrain1]

I can't reproduce this. I just 'tanked' the tanking dummy for about 5 mins and everything was being properly used. Is this happening for anyone else as well?

worked fine for me yesterday.

[Luciferozzy]

Sorry it was my foult. everything working only need a mistweaver now :P

[skayleef]

When I tried putting this routines in my addon folder, it comes up as: incompatible in my wow addons, any fix for this?

[NOCARRIER]

Just pushed a new update:

• Monk (WW): Making FoF-before-Serenity opener baseline
• Monk (WW): Prevent interruption of casting during all abilities