PQR - Rotation Bot

[averykey]

Pqr says, Not logged in (10980) (16825)
Download offsets is grayed out
Might be my bad, going to re-download .

Anyone know of a way to iterate through raid members while doing a heal check and ignoring anyone who is out of range. Healing rotations can get laggy in BGs for example if you constantly iterate through the 40 members checking for range along the way and LOS.

Edit: I worded that in a stupid manner. In short whats currently the most efficient method of healing a large raid/battleground without causing massive lag to the user. Most healing profiles I looked at use a simple loop, would there be a more efficient way is my question. I'm trying to optimize my resto profile for RBG's (and random BGs) and would love to have it working at full capacity all of the time.

Not sure how to, you could blacklist members as it iterates through for one second, but maybe they get in range, are close to death and still blacklisted.
If you go to task manager, you can set cores to programs, set different cores for wow and pqr and maybe you will get less lag.
Right click and click set affinity.

if IsInRaid() then group = "raid" elseif IsInGroup() then group = "party" end

if GetNumGroupMembers() > 0 then
for i=1,GetNumGroupMembers() do
local member = group..i
end
end

[joboy_67]

Pqr says, Not logged in (10980) (16825)
Download offsets is grayed out
Might be my bad, going to re-download .



sec typing code

Thanks I'll check it out when I get back to my computer.

[Blackjetta]

New prot profile is in here, ret profile still breaks on second door horridon but works on the third and fourth? Any ideas?!?
Also included some wip warrior profiles, the arms one should pull decent damage, the fury might be ok. Needs more testing.

https://dl.dropboxusercontent.com/u/...5/Profiles.rar

First of all thx Avery for your great profiles, been using Ret for over a year and i love it. For some reason you last release doesnt work for me at all on any mob or dummy, it just stays there a do nothing. Maybe i am doing something wrong. I should be using the RetSimcraft one right?

thx for your help

[CodeMyLife]

I'm having some issues with PQR_UnitFacing("player", "target") since some days, is it deprecated or what? lol it was working just fine 2 days ago!

[Gabbz]

Anyone know of a way to iterate through raid members while doing a heal check and ignoring anyone who is out of range. Healing rotations can get laggy in BGs for example if you constantly iterate through the 40 members checking for range along the way and LOS.

Edit: I worded that in a stupid manner. In short whats currently the most efficient method of healing a large raid/battleground without causing massive lag to the user. Most healing profiles I looked at use a simple loop, would there be a more efficient way is my question. I'm trying to optimize my resto profile for RBG's (and random BGs) and would love to have it working at full capacity all of the time.

Another way is using events to add replace units that are candidate for healing. Instead of looping and asking each member of your raid if they are hurt it is possible via events to read when someone damaged. So have a event handler that listen to events(UNIT_HEALT or COMBAT_LOG) and each time check if they are in range for you, if so store them into a list of candidates to heal. But there are of course things that will need good design for it to work flawlessly and i think its a massive work to do so. Using events you can also be a bit more proactive since you can also check what Units are being targetted and pre determine who will be hurt soon.

[Gabbz]

First of all thx Avery for your great profiles, been using Ret for over a year and i love it. For some reason you last release doesnt work for me at all on any mob or dummy, it just stays there a do nothing. Maybe i am doing something wrong. I should be using the RetSimcraft one right?

thx for your help

Check if removing the Gloves ability fixes it. I had the same issue but removing it made the profile perform.

[averykey]

What is the issue here? This ability is freezing up the profile.

local css, csd = GetSpellCooldown(86346)
local gt = GetTime()
local csTime = select(7, UnitDebuffID("target", 86346)) - GetTime()
local inRange = IsSpellInRange(GetSpellInfo(78), "target")

if IsPlayerSpell(12292) then
    if PQR_SpellAvailable(12292) and inRange == 1 then
        if (((css - gt + csd) < 2) and ((css - gt + csd) > 0)) or csTime >= 5 or ttd <= 20 then
            return true
        end
    end
end 

edit: Another ability is freezing it up.

local inRange = IsSpellInRange(GetSpellInfo(78), "target")
local reckTime = select(7, UnitBuffID("player", 1719)) - GetTime()
local rb = select(4, UnitBuffID("player", 131116))
local enrage = UnitBuffID("player",12280)
local tHealth = (100 * UnitHealth("target") / UnitHealthMax("target"))

if PQR_SpellAvailable(18499) and inRange == 1 then
    if (enrage or (rb == 2 and tHealth >= 20)) or (reckTime >= 10 and rb == 0) then
        return false
    else
        return true
    end
end 

ttd is timetildeath for the target, works in several other abilities, so I don't think its the problem.

Similar abilities that work fine.

local rage = UnitPower("player")
local cs = UnitDebuffID("target",86346)
local rb = select(4, UnitBuffID("player", 131116))
local rbTime = select(7, UnitBuffID("player", 131116)) - GetTime()
local css, csd = GetSpellCooldown(86346)
local gt = GetTime()
local bts, btd = GetSpellCooldown(23881)

if PQR_SpellAvailable(85288) and rage >= 10 then
    if rb == 2 or (rb and (cs or ((css - gt + csd) >= 3) or (((bts - gt + btd) >= 1) and rbTime <= 3))) then
        return true
    end
end

-------------

local tHealth = (100 * UnitHealth("target") / UnitHealthMax("target"))
local rage = UnitPower("player")
local cs = UnitDebuffID("target",86346)
local enrage = UnitBuffID("player",12880)
local reck = UnitBuffID("player",1719)

if PQR_SpellAvailable(5308) and rage >= 30 then
    if tHealth < 20 then
        if enrage or cs or rage >= 90 or ttd < 12 or reck then
            return true
        end
    end
end 

[SeveredShadow]

I'm looking for a way to detect weapon enchants like rogue poisons or shaman imbues.
I have been using:
local arg1= GetWeaponEnchantInfo()
if arg1 == nil then
CastSpellByName("Windfury Weapon")
end

I'm pretty sure GetWeaponEnchantInfo() doesn't return the spell ID of my weapon buff though so this only really checks if I have ANY enchant and if I don't it casts Windfury Weapon. It cannot distinguish between Flametongue and Windfury or any variety of poisons, it can only see if there is or is not a buff. What I want to be able to do is check for a specific enchant and if it doesn't exist I want to cast an appropriate weapon enchant.

How to do?!?

[Nerder]

Hey averykey tried to pm you for the ability issyes but your box is full it said

Sent from my GT-I9300 using Tapatalk 2

[averykey]

Hey averykey tried to pm you for the ability issyes but your box is full it said

Sent from my GT-I9300 using Tapatalk 2

Will clear it, thanks

https://dl.dropboxusercontent.com/u/...95/WARRIOR.rar

usable but won't have cd management till next update.

please provide feedback

actions=auto_attack
actions+=/mogu_power_potion,if=(target.health.pct<20&buff.recklessness.up)|target.time_to_die<=25
actions+=/blood_fury
actions+=/bloodbath,if=talent.bloodbath.enabled&(cooldown.colossus_smash.remains<2|debuff.colossus_smash.remains>=5|target.time_to_die<=20)
actions+=/recklessness,if=(talent.avatar.enabled&(cooldown.colossus_smash.remains<2|debuff.colossus_smash.remains>=5))|(talent.bloodbath.enabled&(buff.bloodbath.up&(target.time_to_die>192|target.health.pct<20)))|target.time_to_die<=12
actions+=/avatar,if=buff.recklessness.up&talent.avatar.enabled
actions+=/skull_banner,if=buff.recklessness.up
actions+=/use_item,name=gauntlets_of_the_last_mogu,if=(!talent.bloodbath.enabled&debuff.colossus_smash.up)|(talent.bloodbath.enabled&buff.bloodbath.up)
actions+=/berserker_rage,if=!(buff.enrage.react|(buff.raging_blow.react=2&target.health.pct>=20))|(buff.recklessness.remains>=10&!buff.raging_blow.react)
actions+=/heroic_leap,if=debuff.colossus_smash.up
actions+=/run_action_list,name=single_target,if=active_enemies=1
actions+=/run_action_list,name=two_targets,if=active_enemies=2
actions+=/run_action_list,name=three_targets,if=active_enemies=3
actions+=/run_action_list,name=aoe,if=active_enemies>3

actions.single_target=heroic_strike,if=((debuff.colossus_smash.up&rage>=40)&target.health.pct>=20)|rage>=110
actions.single_target+=/raging_blow,if=buff.raging_blow.stack=2&debuff.colossus_smash.up&target.health.pct>=20
actions.single_target+=/bloodthirst,if=!(target.health.pct<20&debuff.colossus_smash.up&rage>=30)
actions.single_target+=/wild_strike,if=buff.bloodsurge.react&target.health.pct>=20&cooldown.bloodthirst.remains<=1
actions.single_target+=/wait,sec=cooldown.bloodthirst.remains,if=!(target.health.pct<20&debuff.colossus_smash.up&rage>=30)&cooldown.bloodthirst.remains<=1&cooldown.bloodthirst.remains
actions.single_target+=/dragon_roar,if=talent.dragon_roar.enabled&(!debuff.colossus_smash.up&buff.bloodbath.up)
actions.single_target+=/colossus_smash
actions.single_target+=/execute,if=buff.enrage.up|debuff.colossus_smash.up|rage>90|target.time_to_die<12|buff.recklessness.up
actions.single_target+=/storm_bolt,if=talent.storm_bolt.enabled
actions.single_target+=/raging_blow,if=buff.raging_blow.stack=2|(buff.raging_blow.up&(debuff.colossus_smash.up|cooldown.colossus_smash.remains>=3|(cooldown.bloodthirst.remains>=1&buff.raging_blow.remains<=3)))
actions.single_target+=/wild_strike,if=buff.bloodsurge.react
actions.single_target+=/shockwave,if=talent.shockwave.enabled
actions.single_target+=/heroic_throw,if=debuff.colossus_smash.down
actions.single_target+=/battle_shout,if=rage<70&!debuff.colossus_smash.up
actions.single_target+=/whirlwind,if=debuff.colossus_smash.up&target.health.pct>=20
actions.single_target+=/impending_victory,if=talent.impending_victory.enabled&target.health.pct>=20
actions.single_target+=/whirlwind,if=cooldown.colossus_smash.remains>=2&rage>=80&target.health.pct>=20
actions.single_target+=/battle_shout,if=rage<70

actions.two_targets=cleave,if=rage>=110
actions.two_targets+=/dragon_roar,if=talent.dragon_roar.enabled&(!debuff.colossus_smash.up&buff.bloodbath.up)
actions.two_targets+=/shockwave,if=talent.shockwave.enabled
actions.two_targets+=/bladestorm,if=talent.bladestorm.enabled
actions.two_targets+=/execute,if=debuff.colossus_smash.up
actions.two_targets+=/bloodthirst
actions.two_targets+=/wait,sec=cooldown.bloodthirst.remains,if=cooldown.bloodthirst.remains<=1&cooldown.bloodthirst.remains
actions.two_targets+=/colossus_smash
actions.two_targets+=/raging_blow,if=buff.meat_cleaver.up
actions.two_targets+=/whirlwind,if=!buff.meat_cleaver.up
actions.two_targets+=/raging_blow,if=buff.raging_blow.stack=2|(buff.raging_blow.up&(debuff.colossus_smash.up|cooldown.colossus_smash.remains>=3|buff.raging_blow.remains<=3))
actions.two_targets+=/storm_bolt,if=talent.storm_bolt.enabled
actions.two_targets+=/battle_shout,if=rage<70
actions.two_targets+=/heroic_throw

actions.three_targets=cleave,if=rage>=110
actions.three_targets+=/dragon_roar,if=talent.dragon_roar.enabled&(!debuff.colossus_smash.up&buff.bloodbath.up)
actions.three_targets+=/shockwave,if=talent.shockwave.enabled
actions.three_targets+=/bladestorm,if=talent.bladestorm.enabled
actions.three_targets+=/raging_blow,if=buff.raging_blow.remains<=2|buff.meat_cleaver.react=2
actions.three_targets+=/whirlwind
actions.three_targets+=/bloodthirst
actions.three_targets+=/wait,sec=cooldown.bloodthirst.remains,if=cooldown.bloodthirst.remains<=1&cooldown.bloodthirst.remains
actions.three_targets+=/colossus_smash
actions.three_targets+=/storm_bolt,if=talent.storm_bolt.enabled
actions.three_targets+=/raging_blow,if=buff.raging_blow.stack=2|(buff.raging_blow.up&(debuff.colossus_smash.up|cooldown.colossus_smash.remains>=3|buff.raging_blow.remains<=3))
actions.three_targets+=/battle_shout,if=rage<70
actions.three_targets+=/heroic_throw

actions.aoe=cleave,if=rage>110
actions.aoe+=/dragon_roar,if=talent.dragon_roar.enabled&(!debuff.colossus_smash.up&buff.bloodbath.up)
actions.aoe+=/shockwave,if=talent.shockwave.enabled
actions.aoe+=/bladestorm,if=talent.bladestorm.enabled
actions.aoe+=/bloodthirst
actions.aoe+=/colossus_smash
actions.aoe+=/raging_blow,if=buff.meat_cleaver.stack=3
actions.aoe+=/whirlwind
actions.aoe+=/storm_bolt,if=talent.storm_bolt.enabled
actions.aoe+=/battle_shout,if=rage<70 

this is the rotation, has a few extra things. Ranged attacks, boss code, some raid utility stuff.

[joboy_67]

Another way is using events to add replace units that are candidate for healing. Instead of looping and asking each member of your raid if they are hurt it is possible via events to read when someone damaged. So have a event handler that listen to events(UNIT_HEALT or COMBAT_LOG) and each time check if they are in range for you, if so store them into a list of candidates to heal. But there are of course things that will need good design for it to work flawlessly and i think its a massive work to do so. Using events you can also be a bit more proactive since you can also check what Units are being targetted and pre determine who will be hurt soon.

I never thought about doing it this way. Guess i'll take some time off from coding my moonkin pvp to try implementing events to my resto profile.

Edit: Actually I think the majority of the event handling could be found in addons and wouldnt need to be made from scratch which would be awesome.

[firepong]

I never thought about doing it this way. Guess i'll take some time off from coding my moonkin pvp to try implementing events to my resto profile.

Edit: Actually I think the majority of the event handling could be found in addons and wouldnt need to be made from scratch which would be awesome.

But reading from those addon's will throw taint errors 99% of the time. I know, I've tried and it didn't work worth a damn with a custom UI. Some frames are fine, but if the frames updated a lot, then just reading from them will freeze your game till you stop the rotation.

I had a custom interrupt profile built around DBM that worked pretty damn good till I turned TukUI/ElvUI on and I got infinite Taint errors, even when taintLog was turned off.

The default WoW frames that aren't part of any addon, can be read fine, but frames made by addon's will give you problems.

[triggersad]

Pqr says, Not logged in (10980) (16825)
Download offsets is grayed out
Might be my bad, going to re-download .

ya..im getting the same thing..whats up?

[joboy_67]

But reading from those addon's will throw taint errors 99% of the time. I know, I've tried and it didn't work worth a damn with a custom UI. Some frames are fine, but if the frames updated a lot, then just reading from them will freeze your game till you stop the rotation.

I had a custom interrupt profile built around DBM that worked pretty damn good till I turned TukUI/ElvUI on and I got infinite Taint errors, even when taintLog was turned off.

The default WoW frames that aren't part of any addon, can be read fine, but frames made by addon's will give you problems.

That's disappointing but I have framework set up for the event handling. Far from perfect and many bugs but it will come with time. Hoping to make my resto one of the only viable high rank pvp profiles.

[paintpauller]

@averykey, sent your a pm with some things about your RetSimCraft profile. =D