Never mind figured it out :P
Last edited by Sorzek; 04-30-2013 at 03:12 PM.
Every now and then I get this error message and to me it seems to be from PQR itself not the rotation, can anyone help about the error please?
Date: 2013-05-01 19:12:31
ID: 1
Error occured in: Global
Count: 1
Message: [string "if PQR_Addon_Loaded == nil then..."] line 984:
Usage: UnitBuff("unit", [index] or ["name", "rank"][, "filter"])
Debug:
[C]: UnitBuff()
[string "if PQR_Addon_Loaded == nil then..."]:984: UnitBuffID()
[string "hawkid = 13165 ..."]:23: F_SwitchToFox()
[string "F_SwitchToFox() ..."]:1: ?()
[string "if PQR_Addon_Loaded == nil then..."]:765: PQR_NextAbility()
[string "if PQR_Addon_Loaded == nil then..."]:534: PQR_ExecuteRotation()
[string "if PQR_Addon_Loaded == nil then..."]:287:
[string "if PQR_Addon_Loaded == nil then..."]:214
Locals:
(*temporary) = "player"
(*temporary) = nil
It's defiantly your rotation, m8.
Somewhere in your profile you have a misused UnitBuff check. Looking at this;
(*temporary) = "player"
(*temporary) = nil
your second argument is invalid in one of your UnitBuff functions (meaning after player, the spell you're checking is an invalid value)
This usually happens when someone makes a typo like adding an extra digit or letter to a spell ID
UnitBuffID("player", 1152880t)
or misusing the UnitBuffID by simply typing buff by name
UnitBuffID("player", "Energizing Brew") (and vice verca)
Could also be due to a buggy function handling multiple buff IDs.
You are using KMD old cata rotation... Remove this ability "-- Functions" in the rotation editor. It is because aspect of the fox kick in when you start moving and it does not exist anymore... also you might like to try other profiles with much current optimisation and less bugs
Hope this helps.
Last edited by CodeMyLife; 05-01-2013 at 04:14 PM. Reason: Short answer via tapatalk was not enough detailed!
Soapbox Rotations Developer
Ive never used this program before, but ive heard alot of good things about it.
I have a couple questions so if someone could help me with them, i can start trying this thing out sooner.
Im GREAT at single target or two target DPS on my destro lock, but somehow i mess up or maybe im not using the right rotation when it comes to large group AoE puls (rain of fire + brimstone+ incinerate and all that good stuff) so im wondering if this is program is capable of heloing me with my over all AoE rotation in raids?
2nd question. Is it possible or does anyone have a profile. for a Prot pally that will auto target and kill stuff. I want to use my 90 pally to run my 80 warrior through dungeons for upgrades so im trying to figure out how to pull large groups and then have the pally go through rotation, or would it be best to play the pally by hand..and have the warrior on follow and have it use PQR / auto target some how while in dungeons.
Thank you in advance
"Opinions are like a$$holes. Everybody's got one and everyone thinks everyone else's stinks."
#1 Absolutely~ and with all due respect, as great as you are manually, it's impossible for manual play to out-preform a well written profile with proper conditions for each ability, regardless of AoE or ST. Writing a profile requires LUA knowledge, but there are plenty of profiles out there for you to try.
#2 Here's the directory of all current released profiles:
http://www.ownedcore.com/forums/worl...1252013-a.html ([PQR] List of Community Rotations - Updated 01252013)
Give it a try, and don't be afraid of doing tinkering with LUA code. It's quite easy and you can learn a lot by just looking over a written profile and see how everything works and to get the most out of PQR you'll want some LUA knowledge.
why it doesn't work?
COUNCIL OF ELDERS
TORTOSPHP Code:
if UnitDebuffID("player", 137641) ~= nil then -- Soul Fragment
_, _, _, mySScount = UnitDebuffID("player", 137650) -- Shadowed Soul stacks
if mySScount > 9 then
group = "raid"
for i=1, GetNumGroupMembers() do
if UnitDebuffID("player", 137641) ~= nil then
ShadowedSoul, _, _, membersSScount = UnitDebuffID(group..i, 137650)
SoulFragment = UnitDebuffID(group..i, 137641)
Role = UnitGroupRolesAssigned(group..i)
OOS = PQR_IsOutOfSight(group..i)
Dead = UnitIsDeadOrGhost(group..i)
ItIsMe = UnitIsUnit("player",group..i)
if Role ~= "TANK" and Dead == false and OOS == false and SoulFragment == nil
and (ShadowedSoul == nil or ShadowedSoul ~= nil and membersSScount < mySScount)
and not ItIsMe then
TargetUnit(group..i)
RunMacroText("/click ExtraActionButton1")
TargetLastTarget()
end end end end end
what is wrong? how it is better to correct?PHP Code:
for i=1,4 do
local bossCheck = "boss"..i
if UnitExists(bossCheck) then
local npcID = tonumber(UnitGUID(bossCheck):sub(6,10), 16)
if npcID == 67977 then -- Tortos
-- check focus:
-- focus exist but not a Humming Crystal
if UnitDebuffID("player", 137633) == nil and UnitExists("focus") ~= nil then
-- if the wrong target focused
if GetUnitName("focus") ~= GetUnitName(69639) or UnitIsDeadOrGhost("focus")
-- if other crystal is closer
or GetUnitName("focus") == GetUnitName(69639) and IsSpellInRange(GetSpellInfo(123408), "focus") ~= 1 then
ClearFocus()
end
elseif UnitDebuffID("player", 137633) == nil and UnitExists("focus") == nil then
TargetUnit(GetUnitName(69639))
if GetUnitName("target") == GetUnitName(69639) then
RunMacroText("/focus")
TargetLastTarget()
end
end
-- check absorb debuff
if UnitHealth("player")*100/UnitHealthMax("player") >= 50 and UnitExists("focus") ~= nil then
if UnitDebuffID("player", 137633) == nil then -- if no crystall shell effect
if GetUnitName("focus") == GetUnitName(69639) then -- if a Humming Crystal focused
if IsSpellInRange(GetSpellInfo(123408), "focus") == 1 then
if UnitPower("player", 12) >= 1 then
CastSpellByName(GetSpellInfo(123408), "focus")
return true
end end end end end end end end
Last edited by WWF; 05-01-2013 at 05:38 PM.
Try this:
PHP Code:
---------------------
--Council of Elders--
---------------------
local SS_Threshold = 9 -- stack # you want to pass @
local tank1 = "tank1" -- replace with your tanks name!!
local tank2 = "tank2" -- replace with your tanks name!!
local SoulFragment = UnitDebuffID("player", 137641)
local My_SS,_,_,My_SSCount = UnitDebuffID("player",137650)
if UnitExists("boss1") then
group = "raid"
if SoulFragment and My_SS and My_SScount > SS_Threshold then
for i = 1,GetNumGroupMembers() do
local PQR_CustomTarget = group..i
local Target_SS,_,_,Target_SSCount = UnitDebuffID(PQR_CustomTarget,137650)
if not UnitDebuffID(PQR_CustomTarget,137650)
or Target_SS and Target_SSCount < My_SSCount then
if not PQR_IsOutOfSight(PQR_CustomTarget)
and not UnitIsDeadOrGhost(PQR_CustomTarget)
and not UnitIsUnit("player", PQR_CustomTarget) then
if UnitName(PQR_CustomTarget)==tank1 or UnitName(PQR_CustomTarget)==tank2 then
return false
else
CastSpellByName(GetSpellInfo(137643),PQR_CustomTarget)
end
end
end
end
end
end
Last edited by Christopher X; 05-01-2013 at 08:24 PM.
Are PQR profile writers now creating a couple of massive abilities and functions that encompass the entirety of the profile, or do most still create separate abilities for each skill and then build a priority-based rotation? Things seemed to be trending towards the former when I took a break from WoW; I'm curious how things have changed.
Also hello to everyone![]()
with my testing all in ones or huge if thens miss some abilitys (note: I just did a simple rotation) where as one ability per spell gained dps with the same logic. (same statements just not in a long if then in my testing). I am playing around with functions thats like a huge if then but only returns the spellid using the combat log and tables (using valma's old lock profile as a framework).
thats my findings
Please if someone helped you donate rep to them.
not universallyPHP Code:
local tank1 = "tank1" -- replace with your tanks name!!
local tank2 = "tank2" -- replace with your tanks name!!
soulfragment check is necessaryPHP Code:
or Target_SS and Target_SSCount < My_SSCount then
with soulfragment check in it there is no needPHP Code:
and not UnitIsUnit("player", PQR_CustomTarget) then
thanks, didn't guess to use itPHP Code:
CastSpellByName(GetSpellInfo(137643),PQR_CustomTarget)
hi all! im very new to pqr, and i love it! so im trying to learn how everything works with trying to make some pvp profiles.
because i dont know very much yet, i thought the easiest way is to look at other profiles, copy paste here and there, adjust it to my needs, and see how it works
now here is my problem, whenever i start the rotation i get some errors, for example:
Code:18x <string>:"if not PQR_LoadedDataFile then...":93: attempt to compare string with number <string>:"if not PQR_LoadedDataFile then...":93: in function "HaveDebuff" <string>:"--DemoBaner-- ...":223: in function "?" <string>:"if PQR_Addon_Loaded == nil then...":765: in function "PQR_NextAbility" <string>:"if PQR_Addon_Loaded == nil then...":534: in function "PQR_ExecuteRotation" <string>:"if PQR_Addon_Loaded == nil then...":287: in function <string>:"if PQR_Addon_Loaded == nil then...":214 Locals: (*temporary) = 41
is there a easy way how i can search in all the abilities for example DemoBaner?Code:27x <string>:"if PQR_Addon_Loaded == nil then...":1013: Usage: UnitDebuff("unit", [index] or ["name", "rank"][, "filter"]) <in C code> <string>:"if PQR_Addon_Loaded == nil then...":1013: in function "UnitDebuffID" <string>:"local Root = { ...":487: in function "?" <string>:"if PQR_Addon_Loaded == nil then...":742: in function "PQR_NextAbility" <string>:"if PQR_Addon_Loaded == nil then...":534: in function "PQR_ExecuteRotation" <string>:"if PQR_Addon_Loaded == nil then...":287: in function <string>:"if PQR_Addon_Loaded == nil then...":214 Locals: unit = "target" spellID = 110610 filter = nil spellName = nil
couldnt find DemoBaner and the spellid for DemoBaner 114203 in the data.lua ;-(
for the second problem, it seems that the spellid 110610 doesnt exist, how do i know where to search for the problem?
anyone can help me out and tell me whats the problem?
thanks in advance! ;-)
edit: just did found the error of my second problem, seems like 110610 is an old spellid for hunters ice trap ;-)
but as i said before, is there an easy way to search for names or numbers in ALL abilities, better and quicker then just look all abilities with my eyes?
the data.lua im editing in notepad++ , perhaps for the abilities there is a similar way, or can i only do it directly in pqr?
Last edited by finish; 05-02-2013 at 09:15 AM.
New prot profile is in here, ret profile still breaks on second door horridon but works on the third and fourth? Any ideas?!?
Also included some wip warrior profiles, the arms one should pull decent damage, the fury might be ok. Needs more testing.
https://dl.dropboxusercontent.com/u/...5/Profiles.rar
My Svn - https://subversion.assembla.com/svn/averykeys-svn/