PQR - Rotation Bot

[PCharlesAA]

Edit: Nvm got it to work.

[saga3180]

How would i go upon writing a code that Uses holy prism(114165) on boss/mob if Player is under 90% if we are in range

Wish someone could help me out here.

[Kinky]

@saga3180: It's very easy.. There are different ways of doing it.
First you look up the functions to determine your own HP. You have 2 functions for this:
UnitHealth(unit) and UnitHealthMax(unit). The first one returns your current HP, while the latter returns your maximum HP. By dividing your current HP by Maximum HP, then multiplying that difference by 100 (Since you can only have a maximum of 100% HP), you've determined your current HP as a percentage. You then check if you actually know the spell and can cast it, then check your HP, then create the function to cast it.

Spell Name: Holy Prism
Spell ID: 0

local HolyPrism = 114165
local PlayerHP = UnitHealth("player") / UnitHealthMax("player") * 100

if IsPlayerSpell(HolyPrism) and PQR_SpellAvailable(HolyPrism) then
	if PlayerHP < 90 then
		CastSpellByName(GetSpellInfo(HolyPrism),"target")
		return true
	end
end

That should be a pretty thorough explanation of how you do it, along with the actual coding behind the explanation, for future reference.

[kclux]

@mentally: How is the Mage profile coming along, tweaked the numbers enough? Really curious to see it

[iliekcoffee]

I was just wondering if the no-mouseover paladin profile was going to be updated?

[Ralphiuss]

What am I doing wrong here?

Eternal Flame

if Nova_Spell[PQ_WordofGlory].check then
    if members[1].HP < Nova_Spell[PQ_WordofGlory].targetHealth
         and select(5, Nova_UnitInfo("player")) <= 3
             and PQR_SpellAvailable(114163) then
                CastSpellByName(GetSpellInfo(114163), members[1].Unit)
       

elseif members[1].HP >= Nova_Spell[PQ_WordofGlory].targetHealth 
            and UnitBuffID(members[1].Unit, 114163) == nil  then
                CastSpellByName(GetSpellInfo(114163), members[1].Unit)
     end
end 

[ace99ro]

tried the exact same code last night with some differences , the NOVA data file actually has in it the new spells for holy pala , eternal flame , light's hammer , holy prism , with the necesary Spell ID's , so i basicly changed the word of glory code to fit the eternal flame code with all the necesary adjusments , but it didnt trigger , never used it

[Ralphiuss]

@ace99ro:

If you use

if Nova_Spell[PQ_WordofGlory].check then
    if members[1].HP < Nova_Spell[PQ_WordofGlory].targetHealth
         and select(5, Nova_UnitInfo("player")) <= 3
             and PQR_SpellAvailable(114163) then
                CastSpellByName(GetSpellInfo(114163), members[1].Unit)
    end
end 

It should work. What I'm trying to do is get it to use EF with the 4 piece PVP bonus. To my understanding EF should be on the raid even if it's over healing, for consistent tank healing.

Within the data file if you look for it..

[PQ_EternalFlame]        =     { check = true, isKnown = IsPlayerSpell(114163) }, 

it's missing the .targethealth value as in

 [PQ_WordofGlory]         =     { check = true, castTime = 0, isKnown = IsPlayerSpell(85673), targetHealth = 82, overRide = false }, 

[Kinky]

@kclux: It's coming along greatly. =)

And to you guys who's wondering about the Paladin Profile. It's basically Bu_ba_911 that has been working on them, and he ha been doing so for a long time. He's currently busy IRL with work, and I'm being kept pretty busy as well personally. As I said though, once my projects are done, I'll try and look through the issues with Restoration Druid, Holy Paladin and Holy/Disc Priests. I'm almost done with most of my projects so keep tight.

[firepong]

@kclux: It's coming along greatly. =)

And to you guys who's wondering about the Paladin Profile. It's basically Bu_ba_911 that has been working on them, and he ha been doing so for a long time. He's currently busy IRL with work, and I'm being kept pretty busy as well personally. As I said though, once my projects are done, I'll try and look through the issues with Restoration Druid, Holy Paladin and Holy/Disc Priests. I'm almost done with most of my projects so keep tight.

Whats wrong with them? The Resto/Holy profiles? I might be able to give them all a whirl on the code bus while waiting in between ques while trying to cap my VP on my druid today C.c

[Ralphiuss]

Whats wrong with them? The Resto/Holy profiles? I might be able to give them all a whirl on the code bus while waiting in between ques while trying to cap my VP on my druid today C.c

IMO...nothing really...heal values could use adjusting...

There are certain things thus far that i've noticed on different boss fights it should do. I've made these changes personally....

Do not heal target on Amber Shapper. There are two debuffs I believe...

There's a debuff on grand empress it shouldn't heal on...


Maybe firepong..maybe you can look above and see if there area any errors in the code I posted?

[googlebee]

@Googlebee: I've looked over the code you posted above. While it does parse through all raid/party members, it also checks if your target can be healed. You're checking the wrong target!
If I'm reading it correctly, simply changing members[1].HP to members[customtarget].HP should do the trick.

That did not do the trick Mentally...any other ideas?

I simply want Healing Touch to heal Tsulong (IF in range) instead of other members. If not then heal me.

[Ralphiuss]

That did not do the trick Mentally...any other ideas?

I simply want Healing Touch to heal Tsulong (IF in range) instead of other members. If not then heal me.

Maybe using a simple code to spam a heal on Tsulong? using a else if function? Normal heal code then else if target = Tsulong then spam heal of choice?

[firepong]

That did not do the trick Mentally...any other ideas?

I simply want Healing Touch to heal Tsulong (IF in range) instead of other members. If not then heal me.

Get me his bossID with:

local bossid = tonumber(UnitGUID(unit):sub(-13, -9), 16) 

And I'll be able to add it in pretty easily into the next push I do to the SVN.

P.S. This is going to be on a Mouseover as I don't think he shows up as a person in the party correct? So we cant do it the way Sheuron's Healing Engine is currently setup, at least from my understanding.

[googlebee]

Reposting this for mentally to look over again. Really interested to get this to work.

@Mentally: If using customtarget the mob needs to be targetted tho ...unless i mouseover it?

Due to being melee, and needing to constantly target adds during the encounter, and the majority of my Healing Touches are from Predatory Swiftness talent (Proc from melee for instant casts) it makes it difficult to mouseover the boss. If that is indeed what you were trying to do.

The way it works now , it has no need to target any party member to heal, so why cant that logic be applied to a boss as well? Or is it even possible?

If anyone else has a suggestion I would be grateful.

Thanks

Trying to figure out how to alter Firepongs code, and add Boss (when friendly) to list of targets to heal - Specifically for the Tsulong Encounter. (Think of it as a cross between Elagon and Dreamwalker [ICC].

Tsulong is either Hostile or Friendly.

Tsulong does seem to have 2 NPC Id's however.

During Night Phase Tsulong is Hostile and attack-able. (NPC ID = 62442)
During Day Phase Tsulong is Friendly and needs to be healed. (NPC ID = 63025? Could be he uses the above one always though)

It should be noted that healing Tsulong by any class that can, should be done when players have the buff: Bathed in Light

This buff is obtained after any players are hit with his Sun Breath (Frontal cone) during Day Phase.

here is Firepongs code:

--Variables
local inBG = PQR_Battleground()
--Misc Buffs/Debuffs/CD's
local playerHP1 = 100 * UnitHealth("Player") / UnitHealthMax("Player")
local psBuff = UnitBuffID("Player",69369)
local nsBuff = UnitBuffID("Player",132158)

if psBuff or nsBuff then
    if members[1].HP < playerHP1 then
        PQR_CustomTarget = members[1].Unit
        CastSpellByName(tostring(GetSpellInfo(5185)),PQR_CustomTarget)
    else
        CastSpellByName(tostring(GetSpellInfo(5185)),"Player")
    end
end

Here is the Data File Functions relevant to the above code. This would probably need to be altered as well.

 function CanHeal(t)
  if UnitInRange(t) and UnitCanCooperate("player",t) and not UnitIsEnemy("player",t) 
  and not UnitIsCharmed(t) and not UnitIsDeadOrGhost(t) and not PQR_IsOutOfSight(t) 
  then return true end 
end

function GroupInfo()
  members, group = { { Unit = "player", HP = CalculateHP("player") } }, { low = 0, tanks = { } } 
  group.type = IsInRaid() and "raid" or "party" 
  group.number = GetNumGroupMembers()
  for i=1,group.number do if CanHeal(group.type..i) then 
local unit, hp = group.type..i, CalculateHP(group.type..i) 
table.insert( members,{ Unit = unit, HP = hp } ) 
if hp < 90 then group.low = group.low + 1 end 
if UnitGroupRolesAssigned(unit) == "TANK" then table.insert(group.tanks,unit) end 
  end end 
  if group.type == "raid" and #members > 1 then table.remove(members,1) end 
  table.sort(members, function(x,y) return x.HP < y.HP end)
  local customtarget = CanHeal("target") and "target" -- or CanHeal("mouseover") and GetMouseFocus() ~= WorldFrame and "mouseover" 
  if customtarget then table.sort(members, function(x) return UnitIsUnit(customtarget,x.Unit) end) end 
end

Feral cats will have a HUGE advantage with this as healing up Tsulong during Day Phase is key to defeating the encounter. The Raid literally only gets 2 Day Phases before Berserk.

Granted the easiest way to do this would to simply use Heart of the Wild talent and spam healing Touches on the second day phase. However, the dps loss and overall healing would be considerably less than using Dream of Cenarius.

I have never dealt with boss targets paired with my moderate knowledge of LUA, I really have no idea where to start.

thanks.