PQR - Rotation Bot

[firepong]

Hi I'm trying to write my own external LUA file and I make a file and put a few functions in it but it fails to load even though the name is exactly the same that I used for the name of the data file. It keeps failing to loaD. Even after reloading the UI and reloading pqr. Why would this happen? Is there something special you need to put in the data files to allow them to load to pqr?


I run /dump PQR_LoadLua(**my file name**)

And I get fail returns all the time..

The Data file has to also be loaded from within the profile itself. For example, this is what Bu_Ba and Sheuron came up with and I've been using it since:

if PQR_RotationStarted == true then
  PQR_RotationStarted = false
  if PQR_LoadLua ~= nil then
    if PQR_LoadLua("PQR_Firepong.lua") == false then 
       PQR_WriteToChat("Put the file PQR_Firepong.lua in the Data file for this profile to work properly!!!", "Error")
       PQR_RotationStop()
        return true
     end
   end
end 

That is pretty much the universal code we use to load our Data files. Just change anything you see that's PQR_Firepong to your Data file name. For a while now, you haven't had to use the same name as the rotation for the name of the Data file.

If after using the above, you still get a error, then you have a coding problem in your Data file somewhere.

[osbornx22]

@xelper

Every time i change between the rotation editor and abilitiy editor, i need to reselect the class, profile and rotation or ability. please can you make the windows tabbed or dont close ability editor, if the rotation editor opened.

[Bgreen12]

The Data file has to also be loaded from within the profile itself. For example, this is what Bu_Ba and Sheuron came up with and I've been using it since:

if PQR_RotationStarted == true then
  PQR_RotationStarted = false
  if PQR_LoadLua ~= nil then
    if PQR_LoadLua("PQR_Firepong.lua") == false then 
       PQR_WriteToChat("Put the file PQR_Firepong.lua in the Data file for this profile to work properly!!!", "Error")
       PQR_RotationStop()
        return true
     end
   end
end 

That is pretty much the universal code we use to load our Data files. Just change anything you see that's PQR_Firepong to your Data file name. For a while now, you haven't had to use the same name as the rotation for the name of the Data file.

If after using the above, you still get a error, then you have a coding problem in your Data file somewhere.

Yes I do put that in my profile, and it says the data file isn't found even though it is in my data file in pqr

[firepong]

Yes I do put that in my profile, and it says the data file isn't found even though it is in my data file in pqr

Then you got a error in your Data file somewhere that stops it from loading. If their is a error in the Data file, it will not inject it to keep from injecting fugged up Code into wow (the Data file is directly injected into the WoW memory code if I remember correctly).

[Bgreen12]

Then you got a error in your Data file somewhere that stops it from loading. If their is a error in the Data file, it will not inject it to keep from injecting fugged up Code into wow (the Data file is directly injected into the WoW memory code if I remember correctly).

Right, maybe an extra end, or forgetting a then... ill have to stare at it for awhile tonight. Is it only appropriate to define functions in the data files? Or should variables (ill give a simple one as an example) such as PlayerCombat = UnitAffectingCombat("player") be in there aswell, or should those go in the initialize ability on pqr? Thanks for all the info btw

[firepong]

Right, maybe an extra end, or forgetting a then... ill have to stare at it for awhile tonight. Is it only appropriate to define functions in the data files? Or should variables (ill give a simple one as an example) such as PlayerCombat = UnitAffectingCombat("player") be in there aswell, or should those go in the initialize ability on pqr? Thanks for all the info btw

I don't do it, but if I remember correctly, Bu_ba and maybe Sheuron both declare those in their Data file. I haven't taken a look at them in a while.

[jericco]

Which profiles are you using? With MoP Blizzard introduced a lot of morphed spell and in some cases we need to use CastSpellByID instead of just entering id in he Ability field.

Furthermore i think that DS have some ranged issues so if you are using distance it can be bugged.

Most recently it was the rogue combat pve profile from [ Sheuron PQR Profiles Pack ] [Release] PQR - Rotation Bot

And then it happened to me on my hunter, I believe the BM profile by kick my dog, I dont have a link to it right now.

Thanks for the response Gabbz +rep, I just went and updated all the profiles I'll let you know if the problem happens again.

[nilrem2004]

I got a question for the experienced.
I need to do a delay within ability, for example:

if condition1 and condition2 then
CastSpellByName(bla..bla..bla..)
Delay 0.2 secs
CastSpellByName(bla..bla..bla..)
return true
end

is there a posibility to do such a delay?
and another question, is it possible to call a macro in wow from PQR , like I make a macro called "Nilremmacro" and use PQR to use the macro.

[Bgreen12]

I got a question for the experienced.
I need to do a delay within ability, for example:

if condition1 and condition2 then
CastSpellByName(bla..bla..bla..)
Delay 0.2 secs
CastSpellByName(bla..bla..bla..)
return true
end

is there a posibility to do such a delay?
and another question, is it possible to call a macro in wow from PQR , like I make a macro called "Nilremmacro" and use PQR to use the macro.

PQR_DelayRotation(.2)

Or you can

PQR_DelayRotation()

This will default to 1 second

[nilrem2004]

ty for info, that is what I thought but obviously something else is the problem...ah, stearing at the code again

[bu_ba_911]

I have updated my SVN to include the Holy Paladin Test that I have let a select number of users try out

I have heard many good reports about mana issues being better with this as well

It is currently in my SVN's WIP folder, so grab the Data File and the profiles from there if you want to try it out

Please report back to me if you are more mana efficient, and if you are a better healer with it

Summary of what i've done -

Made all my Healing Spells Smarter.
Healing Based off Healing Amount not % (Level 85 only and No Mouseover Only[For Testing Purposes])
WoG is now a smart lil mofo with how it uses it's Holy Power if you have Divine Purpose (more Divine Purpose procs now)
Rewrote the Stop Casting ability.... (Still testing this one.... may need to improve it some more)
AND completely butchered Sheuron's Tabled healing even more XD

[firepong]

PQR_DelayRotation(.2)

Or you can

PQR_DelayRotation()

This will default to 1 second

This is a new one. Don't think I've seen it around anywhere. Does it actually work? :confused:

[Gabbz]

I got a question for the experienced.

is there a posibility to do such a delay?
and another question, is it possible to call a macro in wow from PQR , like I make a macro called "Nilremmacro" and use PQR to use the macro.

RunMacro(id or "name") - Runs a macro.
So your should look like this
RunMacro("Nilremmacro")

[firepong]

RunMacro(id or "name") - Runs a macro.
So your should look like this
RunMacro("Nilremmacro")

I did that for the longest time on Beta when they had the spell problem of having to have "!" in front of all the spell names. Had a ability in my rotation that checked for all macros with a certain name and if they didn't exist, made them. Then, when the rotation was ran, it called those macros instead of using everything else.

[nilrem2004]

ty very much. btw PQR_DelayRotation() delays between PQR abilities order, not in my case where I need to cast Soulburn + Soulswap.
I tried putting 1 second in between but it still sometimes casts soulswap without soulburn and then ofc there is a problem.
I need a delay between Soulburn and Soulswap in same pqr ability.

ex:

CastSpellByName(tostring(GetSpellInfo(74434)))
"delay 0.2-0.3 secs"
CastSpellByName(GetSpellInfo(86121),target)