PQR - Rotation Bot

[deadpanstiffy]

guys i have a question. how do i know if the bot updated? i just click the pqrupdater once a week so idk

When it doesn't work, update it. You shouldn't worry about updates otherwise.

[vorn10]

Ok so i have a question. Cuz for resto mushrooms i used old code from balance rotation and changed ids. But now (even on balance rotation) it cast mushroom and then next cast staying on my mouse. Anybody got similar problem?

EDIT
nope i didnt solve it. So when i try create and detonate abilities which are the only one in rotation it working well, but when i put this to full rotation it create one mushroom and stop with ...(that thing to select where to cast) on mouse pointer and nothing do.
Tested in combat and nocombat.

EDIT2
deleted from initialize ability:
"IsSpellTargeting()"
and it works now.

[bauwoo]

Dom and Averykey, some input on the ret pvp profile. No where near done yet, I know. Can we get the left shift key to do HoJ and the left alt to do HoP on mouse over? During burst I noticed that WoG wouldn't go off on its under percentage life (wings and HA). Other than that if you can get Eman/HoF working and WoG/Selfless Healer workong on party targets, I think you guys are in business. thanks for the effort up to this point. Looking forward to future updates.

[808]

yes, the situation is like this, for boss level check return value is -1 , thin is mutated corruption is also "boss" so it triggers doomguard. I can do an exclusion for it or just put doomguard on LeftAlt so you call it manually but I will ignore doomguard for now since I'm more focused on optimizing new profile wich is for level 90.
Ty for info. I will optimize Doomguard as needed in MoP

I was gonna say since MOP is around the corner, just forget about =) Your profile is spectacular as it is. If anything i can probably just remove doomguard from the rotation and hit it manually for situations like Madness. There is one thing though, looking at simulationcraft's action priority list (in both the 85 and 90 sims), I notice the doomguard is summoned at the start of the fight. I know simc is just a sim but what are your thoughts on this?

Thank you again for the great work!
808

edit* I just noticed you now have a new thread dedicated to your profile =) Thanks to Gabbz for the suggestion and thank you Nilrem for the continued great work.

[nilrem2004]

I was gonna say since MOP is around the corner, just forget about =) Your profile is spectacular as it is. If anything i can probably just remove doomguard from the rotation and hit it manually for situations like Madness. There is one thing though, looking at simulationcraft's action priority list (in both the 85 and 90 sims), I notice the doomguard is summoned at the start of the fight. I know simc is just a sim but what are your thoughts on this?

Thank you again for the great work!
808

edit* I just noticed you now have a new thread dedicated to your profile =) Thanks to Gabbz for the suggestion and thank you Nilrem for the continued great work.

Ty for noticing, I'm also looking at Doomguard and I will try to see what is the best situation for him, but I presume we can put doomguard up either on prepot-pull, bloodlust, or bosshp < 20%.
I'll see what will become of him
Let's continue this in my thread so we don't make useless counts of pages here

[averykey]

Did you entirely miss what i posted about checking times? With Judgment base cooldown being 6 seconds and swapping between target to focus it would take:

6 (second cooldown) * 5 (stacks of Censure) * 2 (applications between focus and target) = 1 min to get to 5 stacks of Censure on your focus by judging.

I'd suggest making this a function and returning "focus" or "target" and don't forget to add all your checks, Exists, Holy Power and Range, etc.

local _,_,_,_,_,_,focus=UnitDebuff("focus","Censure",nil,"player")
local _,_,_,_,_,_,target=UnitDebuff("target","Censure",nil,"player")
if not focus or target and target>focus then
	CastSpellByName("Judgment","focus")
elseif not target or focus and target<focus or target==focus then
	CastSpellByName("Judgment","target")
end

I don't quite understand what you mean about, returning "focus" or "target".

if not focus(focus doesn't exist? or are you comparing censure stacks.) or target(so if I don't have censure on focus or target) and target>focus then(target has more stacks than focus?)
cast judge on focus
elseif not target or focus(same as above) and target < focus or target == focus(target has less censure stacks than focus or target has the same stacks as focus) then
cast judge on target
end

Since censure never loses stacks it will stop when both targets have 5 and wait for someones stacks to fall off and then just judge the other target, and it won't switch back and forth, if I'm reading this right.

Am I missing something.



edit: re-post from last page.

--local judgedTarget = false -- This will always be false as it is written
if judgedTarget == nil then judgedTarget = false end
local hasSeal = false

-- Seal Check
if GetShapeshiftForm() ~= 0 then hasSeal = true end

-- double jeporady
if hasSeal then
    if judgedTarget == false then
        if UnitExists("target") and UnitPower("player", 9) < 5 then
            CastSpellByName(GetSpellInfo(20271), "target")
            if UnitExists("focus") then
                judgedTarget = true
            end
        end
    elseif judgedTarget == true then
        if UnitExists("focus") and UnitPower("player", 9) < 5 then
            CastSpellByName(GetSpellInfo(20271), "focus")
            judgedTarget = false
        end
    end
end 

also in your code you posted, you had an extra end in there

after second thought....

--local judgedTarget = false -- This will always be false as it is written
if judgedTarget == nil then judgedTarget = false ResetTimer = GetTime() end
local hasSeal = false


function RangeCheck(spellid, t)
    if IsSpellInRange(GetSpellInfo(spellid), t) == 1 then
        return true
    end
    
    return false
end

-- Seal Check
if GetShapeshiftForm() ~= 0 then hasSeal = true else hasSeal = false end

if judgedTarget == true then
    if GetTime() - ResetTimer >= 12 then
        judgedTarget = false
    elseif not UnitExists("focus") then
        judgedTarget = false
    end
end

-- double jeporady
if hasSeal then
    if judgedTarget == false then
        if UnitExists("target") and UnitPower("player", 9) < 5 and RangeCheck(20271, "target") then
            CastSpellByName(GetSpellInfo(20271), "target")
            if UnitExists("focus") and RangeCheck(20271, "focus") then
                ResetTimer = GetTime()
                judgedTarget = true
            end
        end
    elseif judgedTarget == true then
        if UnitExists("focus") and UnitPower("player", 9) < 5 and RangeCheck(20271, "focus") then
            CastSpellByName(GetSpellInfo(20271), "focus")
            judgedTarget = false
        end
    end
end 

It keeps judging the focused target, changing ResetTimer >= 7 helped slighty, but then it judged the focus twice, then just the target.
Not sure what to do about this, I have tried many things and it still doesn't want to work.


The only fix I have thought of is, storing the players last casted spell and the target the spell was casted on, then you check it before you casting judgment again.
I have no idea how to go about this though.

again rep+ for any help, willing to try anything.

edit: Thank you very much for the range check function, going to change everything to use it instead of my current code.
Will rep again when it lets me.

[fluxflux]

hi

i have a problem with pqr after login into wow 32 bit pqr can not load any profiles there iss on the top the msg not logging in

net framework i have the newest i have tetset with and without addons

yesterday it was working fine

whaT CAN I DOO?

[Ninjaderp]

hi

i have a problem with pqr after login into wow 32 bit pqr can not load any profiles there iss on the top the msg not logging in

net framework i have the newest i have tetset with and without addons

yesterday it was working fine

whaT CAN I DOO?

What can you DOO? Press download offsets.

[fluxflux]

there iss the newest yesterday it was working

[lostinthewoodslol]

anyone wanna make a quick shadow rotation? $50. upfront.

where the hell did cokx go? lol anyway msg me qt's

[dklcfr]

anyone wanna make a quick shadow rotation? $50. upfront.

where the hell did cokx go? lol anyway msg me qt's

sheepmoon has a shadow rotation in his thread over in the other section.

[lostinthewoodslol]

oh way, thnx mate

[averykey]

before I start filling out code for my spell is anything wrong with it? rep+ if you see anything I could do better or have messed up.

i#party

i#partyhealth

if IsSnared(party) or IsRooted(party) and PlayerHp >= 50 and partyHealth >= 50 then
    if mana >= 40 and hof notavailable then
        if healerisafflicted then
            cast empancipate(afflictedpartymember)
                elseif not healerisafflicted then
                    cast empancipate(afflictedpartymember)
                end
            end
            
    else

if healerisafflicted then
    cast hof on healer
elseif not healerisafflicted and
        cast hof on party member
    end
end
                


if IsSnared("player") or IsRooted("player") then
    if mana >= 40 and hof not available then
        cast empancipate
    end
else
        cast hof on player
    end
end 

[bu_ba_911]

i#party

i#partyhealth

if IsSnared(party) or IsRooted(party) and PlayerHp >= 50 and partyHealth >= 50 then
    if mana >= 40 and hof notavailable then
        if healerisafflicted then
            cast empancipate(afflictedpartymember)
                elseif not healerisafflicted then
                    cast empancipate(afflictedpartymember)
                end
            end
            
    else

if healerisafflicted then
    cast hof on healer
elseif not healerisafflicted and
        cast hof on party member
    end
end
                


if IsSnared("player") or IsRooted("player") then
    if mana >= 40 and hof not available then
        cast empancipate
    end
else
        cast hof on player
    end
end 

alright this is the second time i've seen you do this in about a week

When you are using elseif, here is how the code structure should look


if .. then
elseif ... then
elseif ... then
end

how you are coding it

if ... then
elseif .. then
end
end

this will break your entire profile and not just your ability code.

the same coding style applies to
if .. then
else
end

also your first bit of code seems to contradict your second bit of code

[deadpanstiffy]

I don't quite understand what you mean about, returning "focus" or "target".

if not focus(focus doesn't exist? or are you comparing censure stacks.) or target(so if I don't have censure on focus or target) and target>focus then(target has more stacks than focus?)
cast judge on focus
elseif not target or focus(same as above) and target < focus or target == focus(target has less censure stacks than focus or target has the same stacks as focus) then
cast judge on target
end

Since censure never loses stacks it will stop when both targets have 5 and wait for someones stacks to fall off and then just judge the other target, and it won't switch back and forth, if I'm reading this right.

Am I missing something.

I am not comparing stacks, it is the time of censure left and since I am comparing 2 of the same, I don't have to subtract from GetTime()

not target

if target doesn't have censure applied

focus and target<focus

focus has censure and focus censure time difference than target censure time

target==focus

If your target ever becomes your focus, the code will still run