PQR - Rotation Bot

[yourson]

does anyone else have memory leak problem with PQR?

On one computer it works perfect on Win 7 64bit but on other Win XP SP3 32bit it has huge memory leak and in around 30mins it take up to 600mb ram...

Any idea how to sort this?

[rovillien]

Is there a working version of PQinterface around?

Mine works fine make sure you have pqr interface v2 should be somewhere here in this forum.

[n1ce0n3]

GUYS!
I'm playing wotlk 3.3.5a and i have a problem using pqr.
when i'm playing warrior if i go to berserker stance he automatically uses pummel as intended.
how do i force my warrior to equip shield and 1h and automatically shield bash in battle/def stance?

anyone.. please :Z

[nilrem2004]

You should create your own thread in the profile secton to make it cleaner and simplier for you to get feedback
I am missing
* Toggle DarkSoul/Doomguard, ie be able to "wait" for a burn phase or similiar
* Trinkets should be used with Dark Soul
* Target Handling, should be possible to evaluate Target, Focus, MouseOver and event Boss1-Boss3 and perhaps event Tank targets, Assist targets etc.

Also i am not sure but i think you need to add some check to see if a DoT was buffed or not when it was applied so you can decide to overwrite a weak current on if you have a procc up(int, haste etc) That will be more valid at 90 since we get pandamenic.

Will test out the rotation and see if there is something that stands out, except for casting Soul Burn out of combat if you have 4 Soulshards. That way u can have Soul burn up and have 4 shards at start of the fight.

- Toogle darksoul/doomguard will be done for lvl 90 profile
- Yes I forgot a bit for trinkets, will put them in ty for reminding me
- Evaluate target? can you elaborate the purpose of that and what would it exactly do since I don't understand what it means
- Yes for lvl 90 profile I plan to incorporate dot refreshing upon procs like tailoring cloak enchant, trinket, weapon procs etc. ty for info.
- Casting SS out of combat can be done only If I would have the idea when the pull will be done since it should be casted like 20 secs before the pull, but I can't know when will your raid pull the boss. If you got any suggestions I'm all ears

Hmm, yes I will make my own thread, will keep things easyer to track then.

Ty for info and feedback

[Bgreen12]

Is there a real reason for making a data file for all your functions other than personal preference? Would it be the same to just make an ability called "functions" and put it in there and add it to the rotation?

[averykey]

Is there a real reason for making a data file for all your functions other than personal preference? Would it be the same to just make an ability called "functions" and put it in there and add it to the rotation?

From what I understand, it loads the data file once and keeps it loaded, but abilities are ended and re-checked over and over, abilities never stay loaded.
So the benefit of having a data file is, you can keep a lot of information loaded, or keep many functions loaded that you use many times through out the profile; pqr should use less memory and is faster as a result.

I might be wrong, but that's what I think data files are used for, maybe someone else can provide input.



edit: re-post from last page.

--local judgedTarget = false -- This will always be false as it is written
if judgedTarget == nil then judgedTarget = false end
local hasSeal = false

-- Seal Check
if GetShapeshiftForm() ~= 0 then hasSeal = true end

-- double jeporady
if hasSeal then
    if judgedTarget == false then
        if UnitExists("target") and UnitPower("player", 9) < 5 then
            CastSpellByName(GetSpellInfo(20271), "target")
            if UnitExists("focus") then
                judgedTarget = true
            end
        end
    elseif judgedTarget == true then
        if UnitExists("focus") and UnitPower("player", 9) < 5 then
            CastSpellByName(GetSpellInfo(20271), "focus")
            judgedTarget = false
        end
    end
end 

also in your code you posted, you had an extra end in there

after second thought....

--local judgedTarget = false -- This will always be false as it is written
if judgedTarget == nil then judgedTarget = false ResetTimer = GetTime() end
local hasSeal = false


function RangeCheck(spellid, t)
    if IsSpellInRange(GetSpellInfo(spellid), t) == 1 then
        return true
    end
    
    return false
end

-- Seal Check
if GetShapeshiftForm() ~= 0 then hasSeal = true else hasSeal = false end

if judgedTarget == true then
    if GetTime() - ResetTimer >= 12 then
        judgedTarget = false
    elseif not UnitExists("focus") then
        judgedTarget = false
    end
end

-- double jeporady
if hasSeal then
    if judgedTarget == false then
        if UnitExists("target") and UnitPower("player", 9) < 5 and RangeCheck(20271, "target") then
            CastSpellByName(GetSpellInfo(20271), "target")
            if UnitExists("focus") and RangeCheck(20271, "focus") then
                ResetTimer = GetTime()
                judgedTarget = true
            end
        end
    elseif judgedTarget == true then
        if UnitExists("focus") and UnitPower("player", 9) < 5 and RangeCheck(20271, "focus") then
            CastSpellByName(GetSpellInfo(20271), "focus")
            judgedTarget = false
        end
    end
end 

It keeps judging the focused target, changing ResetTimer >= 7 helped slighty, but then it judged the focus twice, then just the target.
Not sure what to do about this, I have tried many things and it still doesn't want to work.


The only fix I have thought of is, storing the players last casted spell and the target the spell was casted on, then you check it before you casting judgment again.
I have no idea how to go about this though.

again rep+ for any help, willing to try anything.

edit: Thank you very much for the range check function, going to change everything to use it instead of my current code.
Will rep again when it lets me.

[MACH9 WoW Services]

What's better for 5.0.4 for Holy Paladin, Sheepmoon or Bubba/Nova's?

Nova seems to spam holy light non-stop and waste mana for me..

[Bgreen12]

From what I understand, it loads the data file once and keeps it loaded, but abilities are ended and re-checked over and over, abilities never stay loaded.
So the benefit of having a data file is, you can keep a lot of information loaded, or keep many functions loaded that you use many times through out the profile; pqr should use less memory and is faster as a result.

Right. That would make sense, and I thought it was like that too however lets say in the data file you got a function to check if the target is snared.. it would have to be re-checked constantly anyway due to the fact you don't want to put a slow on someyhing that's already snared and it constantly changes... but you see people put these types of things in data files all the time.

[sheuron]

Anyone figure out Living Bomb spell id? not 44457

Living Bomb = Mage Bomb

Use this script in game chat to find the spell id

/run for i=1,200000 do local f=FindSpellBookSlotBySpellID(i,"spell") if f then local n,id=GetSpellBookItemName(f,"spell"),select(2,GetSpellBookItemInfo(f,"spell")) local s=GetSpellInfo(id) s=n==s and " " or "\124cFF4FF763"..s print(id,n,s) end end

[bu_ba_911]

What's better for 5.0.4 for Holy Paladin, Sheepmoon or Bubba/Nova's?

Nova seems to spam holy light non-stop and waste mana for me..

Set the value that it heals at lower. I'm working on a rework for healing that should fix most of the overhealing issues

Sent from my Thunderbolt using Tapatalk 2

[averykey]

Right. That would make sense, and I thought it was like that too however lets say in the data file you got a function to check if the target is snared.. it would have to be re-checked constantly anyway due to the fact you don't want to put a slow on someyhing that's already snared and it constantly changes... but you see people put these types of things in data files all the time.

Since the data file is already loaded, it will only check that functions list/array/table(not sure what it's called in lua), instead of all your functions/lists/tables/arrays if they were in a ability.
I think that's how that would work.

Anyone have a solution for my problem :O, I have no idea what to do.

[vorn10]

Ok so i have a question. Cuz for resto mushrooms i used old code from balance rotation and changed ids. But now (even on balance rotation) it cast mushroom and then next cast staying on my mouse. Anybody got similar problem?

[Bgreen12]

Since the data file is already loaded, it will only check that functions list/array/table(not sure what it's called in lua), instead of all your functions/lists/tables/arrays if they were in a ability.
I think that's how that would work.

Anyone have a solution for my problem :O, I have no idea what to do.

OK well then I guess ill be changing my custom functions to go in a data file. I'll look at your script tonight and see if I can think of something

[deadpanstiffy]

From what I understand, it loads the data file once and keeps it loaded, but abilities are ended and re-checked over and over, abilities never stay loaded.
So the benefit of having a data file is, you can keep a lot of information loaded, or keep many functions loaded that you use many times through out the profile; pqr should use less memory and is faster as a result.

I might be wrong, but that's what I think data files are used for, maybe someone else can provide input.



edit: re-post from last page.



It keeps judging the focused target, changing ResetTimer >= 7 helped slighty, but then it judged the focus twice, then just the target.
Not sure what to do about this, I have tried many things and it still doesn't want to work.


The only fix I have thought of is, storing the players last casted spell and the target the spell was casted on, then you check it before you casting judgment again.
I have no idea how to go about this though.

again rep+ for any help, willing to try anything.

edit: Thank you very much for the range check function, going to change everything to use it instead of my current code.
Will rep again when it lets me.

Did you entirely miss what i posted about checking times? With Judgment base cooldown being 6 seconds and swapping between target to focus it would take:

6 (second cooldown) * 5 (stacks of Censure) * 2 (applications between focus and target) = 1 min to get to 5 stacks of Censure on your focus by judging.

I'd suggest making this a function and returning "focus" or "target" and don't forget to add all your checks, Exists, Holy Power and Range, etc.

local _,_,_,_,_,_,focus=UnitDebuff("focus","Censure",nil,"player")
local _,_,_,_,_,_,target=UnitDebuff("target","Censure",nil,"player")
if not focus or target and target>focus then
	CastSpellByName("Judgment","focus")
elseif not target or focus and target<focus or target==focus then
	CastSpellByName("Judgment","target")
end

[Battler624]

guys i have a question. how do i know if the bot updated? i just click the pqrupdater once a week so idk