PQR - Rotation Bot

[stephanicus]

Okay, released an update..try downloading that and let me know.

Just tested that DK profile update and its working real good. Don't know if you cleaned up the code or something but im pulling more DPS, might have been lucky with Gurth procs or something else but its increased roughly 2.5k

[averykey]

Anyone know what I did wrong here? Looks fine to me, I keep getting a nil error in-game.

 --if we are in ret and not might then apply might else if we have might and we dont have kings or wild then apply kings
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
	if not UnitBuffID("player", 19740) then
		CastSpellByName(GetSpellInfo(19740), "player")
	end
elseif UnitBuffID("player", 19740) and not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(20217), "player")
	end
end

-- if we are in prot and we dont have kings or wild then apply kings  else if we have kings or wild we and dont have might then apply might
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Protection" then
	if not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
		CastSpellByName(GetSpellInfo(20217), "player")
	end
elseif UnitBuffID("player", 20217) or UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(19740), "player")
	end
end

[hbkx1]

Lol for mods booting the internet toughguy but back to pqr and a question for KickMyDog.....Is misdirection written into your code? I'm trying to do some raid solos and would to be able to cast MD+glyph to my pet everytime its up!...If not how could I add that in easily thx!!!

[Kinkeh]

Just tested that DK profile update and its working real good. Don't know if you cleaned up the code or something but im pulling more DPS, might have been lucky with Gurth procs or something else but its increased roughly 2.5k

I changed some stuff with plague leech, that may be it or it's a combination of both . Frost in general without a gurth is extremely RNG filled, gets quite annoying sometimes :3.

[averykey]

Lol for mods booting the internet toughguy but back to pqr and a question for KickMyDog.....Is misdirection written into your code? I'm trying to do some raid solos and would to be able to cast MD+glyph to my pet everytime its up!...If not how could I add that in easily thx!!!

this is the general idea, I don't have the code, but if you search a few profiles you should be able to find all the code needed.

if mdknown then // for lower levels
if haveglyph then
if md is available and pet exist then
cast md on pet
end
end
end

re post from 261 so people can see

Anyone know what I did wrong here? Looks fine to me, I keep getting a nil error in-game.

 --if we are in ret and not might then apply might else if we have might and we dont have kings or wild then apply kings
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
	if not UnitBuffID("player", 19740) then
		CastSpellByName(GetSpellInfo(19740), "player")
	end
elseif UnitBuffID("player", 19740) and not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(20217), "player")
	end
end

-- if we are in prot and we dont have kings or wild then apply kings  else if we have kings or wild we and dont have might then apply might
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Protection" then
	if not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
		CastSpellByName(GetSpellInfo(20217), "player")
	end
elseif UnitBuffID("player", 20217) or UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(19740), "player")
	end
end

[[Blinded]]

Hit the Download Offsets button...

Though... I just realized I removed the offsets from new downloads for the current EU build (if you already had them they still remain.) I will add them back to the download list for the time being.

Update -> Not Logged In-Problem again

Edit : <GameState>0xD1138D</GameState> <-- this Offset will fix it

[kickmydog]

KMD, it keeps casting Hawk every time it fires an arcane shot. i noticed you added the F_SwitchToHawk to the top of a lot of the abilities. Shouldn't there be a check to see if you already have it though?

I need a little more info, I have tried my SV and BM profiles, I don't run with a MM spec myself. I have not noticed this at all.

function F_SwitchToHawk()
    if not UnitBuffID("player", 13165)
    and UnitExists("target") 
    then CastSpellByName(GetSpellInfo(13165),nil) end
    end 

There is a check in the function to see if you do not have hawk, so if you have hawk already it should not cast. However, are you using Hawk or Iron Hawk? I did not test with Iron Hawk since I do not use it.

Where is the check for aspect switching? I looked at your code but I don't see a delay or anything, really having problems with seal switching because I think stances are off the gcd like aspects are.

I would ignore the datafile stuff, I put that in by mistake. The Aspect code is all in the ability - "Aspects"

There is no delay hard coded in, because generally one should not be running all over the place. So basically I didn't bother, I might tweak it a little so that it stays in fox longer and then as a result it will do more focus builders then switching to hawk and a normal rotation after you either stop moving or focus gets close to maximum. That would require more extensive testing, I wanted to get something out quickly to address the changes that Blizzard put into the patch today.

Anyone know what I did wrong here? Looks fine to me, I keep getting a nil error in-game.

 --if we are in ret and not might then apply might else if we have might and we dont have kings or wild then apply kings
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
	if not UnitBuffID("player", 19740) then
		CastSpellByName(GetSpellInfo(19740), "player")
	end
elseif UnitBuffID("player", 19740) and not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(20217), "player")
	end
end

-- if we are in prot and we dont have kings or wild then apply kings  else if we have kings or wild we and dont have might then apply might
if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Protection" then
	if not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
		CastSpellByName(GetSpellInfo(20217), "player")
	end
elseif UnitBuffID("player", 20217) or UnitBuffID("player", 1126) then
	CastSpellByName(GetSpellInfo(19740), "player")
	end
end

I would try switching the code that you are using to cast the spell. I was having issues with that when I tried to use my old functions for Aspect Switching, it would refuse to cast the spells until I changed to what Shueron was using in his code. Try this:

if (select(2, GetSpecializationInfo(GetSpecialization()))) == "Retribution" then
    if not UnitBuffID("player", 19740) -- check for might
    or not UnitBuffID("player", 116956) -- check for grace of air
    or not UnitBuffID("player", 93435) -- roar of courage
    then CastSpellByName(GetSpellInfo(19740),nil) -- cast might
    end
elseif not UnitBuffID("player", 20217) -- check for kings
    or not UnitBuffID("player", 1126) --check for motw
    or not UnitBuffID("player", 90363) -- shale spider
    then CastSpellByName(GetSpellInfo(20217),nil) -- cast kings
    end
end 

[averykey]

I need a little more info, I have tried my SV and BM profiles, I don't run with a MM spec myself. I have not noticed this at all.

function F_SwitchToHawk()
    if not UnitBuffID("player", 13165)
    and UnitExists("target") 
    then CastSpellByName(GetSpellInfo(13165),nil) end
    end 

There is a check in the function to see if you do not have hawk, so if you have hawk already it should not cast. However, are you using Hawk or Iron Hawk? I did not test with Iron Hawk since I do not use it.



I would ignore the datafile stuff, I put that in by mistake. The Aspect code is all in the ability - "Aspects"

There is no delay hard coded in, because generally one should not be running all over the place. So basically I didn't bother, I might tweak it a little so that it stays in fox longer and then as a result it will do more focus builders then switching to hawk and a normal rotation after you either stop moving or focus gets close to maximum. That would require more extensive testing, I wanted to get something out quickly to address the changes that Blizzard put into the patch today.



I would try switching the code that you are using to cast the spell. I was having issues with that when I tried to use my old functions for Aspect Switching, it would refuse to cast the spells until I changed to what Shueron was using in his code.

CastSpellByName(GetSpellInfo(13165),nil) 

CastSpellByName(GetSpellInfo(13165),nil) will the nil just reference to the ability properties?



edit:
Stance check /buff for anyone wanting, haven't tried it in my profile so be weary of errors :O

local hasSeal
local seal = GetShapeshiftForm()
if seal >= 1 and seal <= 4 then hasSeal end
if not hasSeal then CastShapeshiftForm(1) end


Thanks to everyone who has been helping me, going to go through the thread and make sure you all get the rep you deserve!


edit2: kickmydog, the edit didn't work, got any other ideas?

[kickmydog]

Well one thing i do when testing code is to start with the simplest thing and then start to add to it.

Remove the specialisation check and see if the unitbuff stuff works with just Might or Kings. If they do then there is no reason why the rest of the unit buff stuff shouldn't work. Then I would check the specialisation code again. Although do you really need a specialisation check, don't you have different rotations for each one, or is your ret/prot code all in one?

[averykey]

Well one thing i do when testing code is to start with the simplest thing and then start to add to it.

Remove the specialisation check and see if the unitbuff stuff works with just Might or Kings. If they do then there is no reason why the rest of the unit buff stuff shouldn't work. Then I would check the specialisation code again. Although do you really need a specialisation check, don't you have different rotations for each one, or is your ret/prot code all in one?

It will be, I got tired of having 50+ abilities in my rotation; the rotation was harder to maintain having to scroll up and down all the time and moving all of the spells to the correct spots, right now I have singled it down to around 10 abilities and it should work if I can get this specialization check working.

I removed it and still got the error so I'm not sure what the culprit here is, I will paste the error from in-game and then disable my addons to see if one of them could be the culprit.

[kickmydog]

It will be, I got tired of having 50+ abilities in my rotation; the rotation was harder to maintain having to scroll up and down all the time and moving all of the spells to the correct spots, right now I have singled it down to around 10 abilities and it should work if I can get this specialization check working.

I removed it and still got the error so I'm not sure what the culprit here is, I will paste the error from in-game and then disable my addons to see if one of them could be the culprit.

I know that feeling, that is why this time around I'm not doing an all in one hunter profile, it just became super annoying.

[hbkx1]

Anyone else having a problem with Crystal Techs Affliction profile, it totally stops rotation between 4.5-5 million dmg on a target dummy then i have close it down and restart.....forgot about the debug ill post back





tested in dungeons all good

[Wopak]

this is the general idea, I don't have the code, but if you search a few profiles you should be able to find all the code needed.

if mdknown then // for lower levels
if haveglyph then
if md is available and pet exist then
cast md on pet
end
end
end

Here a function to check if you have a certai Glyph inscribed to get you going.

-- Check if Player has a Glyph inscribed. Accepts Glyph Index or Glyph Name
-- Signature
---- psaHasGlyph("glyph") or psaHasGlyph(glyph)
-- Arguments:
---- glyph: Glyph name or Index to query
-- Returns:
---- true if player has glyphName inscribed, otherwise false (true/false)
function psaHasGlyph(glyph)
    for glyphIndex = 1, NUM_GLYPH_SLOTS do
        if tonumber(glyph) ~= nil then
            if select(4, GetGlyphSocketInfo(glyphIndex)) == glyph then
                return true;
            end
        else
            if GetSpellInfo((select(4, GetGlyphSocketInfo(glyphIndex)))) == glyph then
                return true;
            end
        end
    end    
    return false;
end 

[averykey]

Here a function to check if you have a certai Glyph inscribed to get you going.

-- Check if Player has a Glyph inscribed. Accepts Glyph Index or Glyph Name
-- Signature
---- psaHasGlyph("glyph") or psaHasGlyph(glyph)
-- Arguments:
---- glyph: Glyph name or Index to query
-- Returns:
---- true if player has glyphName inscribed, otherwise false (true/false)
function psaHasGlyph(glyph)
    for glyphIndex = 1, NUM_GLYPH_SLOTS do
        if tonumber(glyph) ~= nil then
            if select(4, GetGlyphSocketInfo(glyphIndex)) == glyph then
                return true;
            end
        else
            if GetSpellInfo((select(4, GetGlyphSocketInfo(glyphIndex)))) == glyph then
                return true;
            end
        end
    end    
    return false;
end 

docs/api/GetSpecializationInfo - World of Warcraft Programming: A Guide and Reference for Creating WoW Addons

Hey do you know why I'm getting a nil error whenever I try any of the below?

local specid = select(1, GetSpecializationInfo(GetSpecialization()))
local specname = select(2, GetSpecializationInfo(GetSpecialization()))


if specid == 70 then
do stuff
end

if specname == "Retribution" then
do stuff
end

I've also the below and for id as well

if select(2, GetSpecializationInfo(GetSpecialization())) == "Retribution" then
dostuff
end

still no luck

Here is the full code, I have no idea why this isn't working.

--if we are in ret and not might then apply might else if we have might and we dont have kings or wild then apply kings
if select(2, GetSpecializationInfo(GetSpecialization())) == "Retribution" then
    if not UnitBuffID("player", 19740) then
        CastSpellByName(GetSpellInfo(19740), "player")
    end
elseif UnitBuffID("player", 19740) and not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
    CastSpellByName(GetSpellInfo(20217), "player")
    end
end

--if we are in prot and we dont have kings or wild then apply kings  else if we have kings or wild we and dont have might then apply might
if select(2, GetSpecializationInfo(GetSpecialization())) == "Protection" then
    if not UnitBuffID("player", 20217) and not UnitBuffID("player", 1126) then
        CastSpellByName(GetSpellInfo(20217), "player")
    end
elseif UnitBuffID("player", 20217) or UnitBuffID("player", 1126) and not UnitBuffID("player", 19740) then
    CastSpellByName(GetSpellInfo(19740), "player")
    end
end 

I get a nil error every time, I have no idea what is wrong, I have tried removing the specialization code as well but I still get errors, I don't see anything wrong with my buff code.

[Ninjaderp]

Anyone else having a problem with Crystal Techs Affliction profile, it totally stops rotation between 4.5-5 million dmg on a target dummy then i have close it down and restart.....forgot about the debug ill post back





tested in dungeons all good

Does it only stop on dummys? Because if its fine when you go dungeons or raid it shouldnt be a problem. May have something to do with dummys having infinite hp/not dying but I dont really know.