[BETA] PQRotation - an automated ability priority queue.

[Dominium]

It worked!!! )

Going to test it out now on a ~20mln test and see how it goes. Thank you SO much Kaolla!

[deadpanstiffy]

Sheuron, I have a question - I want to create a Stopcasting 'ability' in your Survival Hunter rotation. This is what I want it to do:

if Explosive Shot cooldown = 0 and focus>44 then stop casting cobra shot.

Could you write me some code for that? I am sure it's very short, I just don't want to **** it up ;/

Would it be possible for it to check how much of the Cobra Shot cast has been completed? For example, if Cobra Shot is less then 0,3sec from being shot (the cast is ending in 0,3 sec) it wouldn't cancel it... would be great.

I am pretty sure that this could actually result in a DPS increase... on EJ it is said that Explosive shot is your absolute priority and that cancelling your cobra shot cast to get off an explo shot right as it comes off CD is good.

Edit!

Maybe it would be easier to just add some code into the Cobra Shot ability... something like this: if Explosive Shot cooldown < 1 second and focus>44 then don't cast? I am not sure but that could work..

Cheers!

That is a 3k DPS LOSS in simcraft to wait to fire a Cobra Shot.

Please take the stuff you read on EJ with a grain of salt, 1 out of 100 people actually know what they are talking about, as the other 99 are just sheep and monkeys repeating and misinterpreting information.

[Dominium]

Yeah well so far I am testing out my new LnL handling I guess I won't try with the Cobra shot cancelling.

[Kaolla]

Yes well it would be the best if it used it right as it comes off cooldown (without any delays). However, the situation is different during LnL.

I think I understand what you mean about creating another ability - actually I'll try to code that myself ^^ (yes I am a newbie lol). Thank you so much for all the help, +rep already!

Haha, I appreciate it. It actually makes even more sense to split the two Explosive Shots if you want it used whenever it's off-cooldown, because it will simplify the logic during LnL. I doubt you've seen PQR cancel many Cobra Shots with the ability I wrote earlier.

Try this:

Name: Explosive Shot (LnL)
Recast Delay: 100
Spell ID: 53301
Target: Target

local Spell, _, _, _, _, EndTime = UnitCastingInfo("player")

if select(2,GetSpellCooldown(53301)) == 0
    and not setAoE
    and UnitBuffID("player", 56453) then
        if Spell == "Cobra Shot"
        and (((GetTime() * 1000 - EndTime) * -1) / 1000) > 0.3 then
            SpellStopCasting()
            return true end
end


if select(2,GetSpellCooldown(53301)) == 0
    and not setAoE
    and UnitBuffID("player", 56453) then
        return true
end

Name: Explosive Shot
Recast Delay: 0
Spell ID: 53301
Target: Target

local Spell, _, _, _, _, EndTime = UnitCastingInfo("player")


if select(2,GetSpellCooldown(53301)) == 0
    and not setAoE
    and not UnitBuffID("player", 56453)
    and UnitPower("player") >= 50 then
        if Spell == "Cobra Shot"
        and (((GetTime() * 1000 - EndTime) * -1) / 1000) > 0.3 then
            SpellStopCasting()
            return true end
end


if select(2,GetSpellCooldown(53301)) == 0
    and not setAoE
    and not UnitBuffID("player", 56453)
    and UnitPower("player") >= 50 then
            return true
end

I have no idea how this will actually work, but technically it should use the first ability when you gain Lock and Load, with a 0.1s delay in between shots. It will only use the second ability when you don't have Lock and Load, but it should now use Explosive Shot on cooldown.

Give it a shot Just make sure you place both abilities above Cobra Shot in the Rotation Editor.

[Dominium]

Thanks for those new codes Kaolla! Will definately test them out in the morning (although deadpanstiffy said it's actually a loss - oh well, we will see).

So far I have great news with my LnL edit - actually, awesome news! OVER 1000 dps more! It can't be RNG - these were both 20mln dmg tests.

Test 1 - unedited Sheuron Survival without Rapid Fire
28,5k DPS, 32,7% Explosive shot

Test 2 - my edit to Sheurons profile
29,6k DPS, 35,4% Explosive shot

I am so happy!

[Kaolla]

Success! ^^ Congratulations, haha. Glad I could help.

[LiquidAtoR]

@ Firepong,

I've updated the rotations to 2.8 but now have issues (also after a restart) with Ultrax LFR25.
Pretty much the only 3 things it casts are Faerie Fire (Feral), Rake and Savage Roar when there are combo points.
If I manually cast a few Mangles in between it seems to go trough another few mangles and then a Rip or Ferocious Bite and then it falls back to the previous 3 spells.
I've tried a restart, a reboot, a clean install and a clean update, all yielding Ultrax problems.
And this is only tied to Ultrax, since I didn't have problems on any of the other bosses so far.
Any suggestions?

ps, Gabz's CC had the same issue hanging on a unchecked shred cast according to PQInterface's statusbar.

[firepong]

I've noticed this problem as well today in LFR. It's probably something to do with my Data file as I can take out a couple pieces of my code and it will work fine. I'll look through it tonight and see what I can get figured out.

It has to be the data file though as it wasn't locking up on Ultraxion till after I made the changes I did. I can revert them back, but the Lua errors about Nil value on PQR_FireBoss function will be back.

EDIT* When you can, update the profile so it can download the new Data file and let me know of its fixed. I commented the few bosses that I had the same in 2 functions out of PQR_FireBoss function. That might have been the problem, I'm not sure.

[deadpanstiffy]

Thanks for those new codes Kaolla! Will definately test them out in the morning (although deadpanstiffy said it's actually a loss - oh well, we will see).

So far I have great news with my LnL edit - actually, awesome news! OVER 1000 dps more! It can't be RNG - these were both 20mln dmg tests.

Test 1 - unedited Sheuron Survival without Rapid Fire
28,5k DPS, 32,7% Explosive shot

Test 2 - my edit to Sheurons profile
29,6k DPS, 35,4% Explosive shot

I am so happy!

It is a dps loss, your testing is inconclusive.
Unless you mean to tell me that simcraft at 10k iterations and a 350s (Ultraxion) boss time, a total which would be close to 972 hours is a liar.

PQR isn't a theory craft test tool, however it AMAZING at applying what ideas are derived from tools like simcraft.

[LiquidAtoR]

@ Firepong,

I will test it tomorrow and get back to you.
We're close to reset EU side and half the idiots currently online are clueless in LFR or CBA to do anything.

btw I did have that lua error with fireboss and bleed thing after killing DW with your 2.8 datafile.

[Kaolla]

It is a dps loss, your testing is inconclusive.
Unless you mean to tell me that simcraft at 10k iterations and a 350s (Ultraxion) boss time, a total which would be close to 972 hours is a liar.

PQR isn't a theory craft test tool, however it AMAZING at applying what ideas are derived from tools like simcraft.

He acknowledged that it's technically a DPS loss, according to Simcraft.

He's only noting that the new code, for whatever reason, is an improvement over how Sheuron's Survival Profile currently handles Explosive Shot.

I believe the debate over personal preference versus SimCraft has already been done to death in this thread

[Dominium]

I am not talking about cancelling cobras to cast ExS, deadpanstiffy. I am talking about the LnL change that I made. Before it was: exs exs cobra(sometimes twice!) exs. Now I made it exs exs exs with 0,1sec delays between them ^^

[deadpanstiffy]

I believe the debate over personal preference versus SimCraft has already been done to death in this thread

If you call personal preference: delusional theory crafting, then yes.

Personal preference is as follows:
I have my Simcraft Rogue profile, when I apply my profile to PQR, it is an exact copy of said profile in Simcraft.
The personal preference of PQR is then choosing which actions I may also use (and if they are on the GCD they are always a DPS loss) and when to use them or on a hot key.

Also to note if you are now waiting X seconds to cast a certain ability, have you tried changing the Ability Check Delay in PQR? That would of made more sense to start with.

[kickmydog]

You could always just use the code from my explosive shot.

[g1teglover]

You noticed you can just click the ability or use any of your hotkeys to activate those spells?

I've got to manually activate them by clicking on the action bar buttons, the hotkey's that I've programmed into PQR's code don't trigger at all.