[BETA] PQRotation - an automated ability priority queue.

[diesall]

w00t the ****? O.o I have weird computer and even on it it doesn't lags :/

i havnt got time to look over your code but here are a few performance techniques for lua:

• avoid using ipairs and pairs as much as possible they are up to 250% slower then using an indexed table and traversing the table this way:
  

for i=1,#table do
    table[x] --do stuff with key here
end

• avoid defining a function as a parametre for another function it us up to 1200% slower then defining it as a local outside the calling function, ie.

Bad

myfunction(arg1,arg2,function(a) return a*2 end)
   ...
 end

Good

local function Multiply(a)
    return a*2
 end
myfunction(arg1,arg2,Multiply)
    ...
end

• avoid using table.insert its up to 700% slower then using table[index] = value
• if you are accessing any global variable or function more then once in the same ability i can't stress this enough LOCALIZE it, same goes for tabled references, for example if you are referencing: myGlobalTable.myValue more then once use local myValue = myGlobalTable.myValue
• when using if statements always check the statement that is most likely short circuit the ability first

[imdasandman]

@ valma getting this error in wow with your profile with the use of PQR 2.01 or w/e his newest version is... your profile is the only one to be throwing errors so far....

Message: [string "  ..."]:272: attempt to index a nil value
Time: 03/12/12 02:55:28
Count: 224
Stack: [string "  ..."]:272: in function `PQ_Init'
[string "  ..."]:293: in function `?'
[string "..."]:542: in function `PQR_NextAbility'
[string "..."]:355: in function `PQR_ExecuteRotation'
[string "..."]:139: in function <[string "..."]:74>

Locals: (*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

edit I just tried with the older PQR and it is tossing same error... I use elv ui I will try disableing it and see what happens for you.

[Valma]

Gotta admit though, your profile is one of the biggest ones I've used. My systems specs are not that bad and even when I use your profiles, I notice a good 10fps drop on boss fights. Guess all that code is really killer though Anyways, I just got to trying out your Last Profile update before the latest one and have to say. It works great. Will have to try out the new one later.

EDIT* Damn, if only I had enough time to code a profile that has almost 3.5k lines of code in it

This accounts to COMBAT_LOG_UNFILTERED event :/ Anyway more flexible and complicated any profile is - more CPU it needs. TBH I tested my fps when PQR is not loaded on ultraxion_LFR(ye-ye I'm bad boy standing here and slacking (((((((( ),then I tested fps with loaded PQR and loaded events and debug window(no rotation) and got 0-2 fps loss and finally then I started rotation and got further more 0-1 fps loss.So as for me I got maximum of -3 fps drop in 25 ppl raid(this is without BL ofc).

[Valma]

@ valma getting this error in wow with your profile with the use of PQR 2.01 or w/e his newest version is... your profile is the only one to be throwing errors so far....

Message: [string "  ..."]:272: attempt to index a nil value
Time: 03/12/12 02:55:28
Count: 224
Stack: [string "  ..."]:272: in function `PQ_Init'
[string "  ..."]:293: in function `?'
[string "..."]:542: in function `PQR_NextAbility'
[string "..."]:355: in function `PQR_ExecuteRotation'
[string "..."]:139: in function <[string "..."]:74>

Locals: (*temporary) = <function> defined =[C]:-1
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = nil
(*temporary) = "attempt to index a nil value"

Its my bad,changed things from work and haven't tested them. QUICK FIX

[Valma]

i havnt got time to look over your code but here are a few performance techniques for lua:

• avoid using ipairs and pairs as much as possible they are up to 250% slower then using an indexed table and traversing the table this way:
  

for i=1,#table do
    table[x] --do stuff with key here
end

• avoid defining a function as a parametre for another function it us up to 1200% slower then defining it as a local outside the calling function, ie.

Bad

myfunction(arg1,arg2,function(a) return a*2 end)
   ...
 end

Good

local function Multiply(a)
    return a*2
 end
myfunction(arg1,arg2,Multiply)
    ...
end

• avoid using table.insert its up to 700% slower then using table[index] = value
• if you are accessing any global variable or function more then once in the same ability i can't stress this enough LOCALIZE it, same goes for tabled references, for example if you are referencing: myGlobalTable.myValue more then once use local myValue = myGlobalTable.myValue
• when using if statements always check the statement that is most likely short circuit the ability first

THX for feedback I'm not that really familiar with luacoding(coding on #,.NET etc on work) so this info is really helpfull +rep mate.

Just quick question.
Slow:

PQ_EventHandlerFrame:SetScript("OnEvent", function(self, event, ...) events[event](self, ...); end);

Faster ??? :

function PQ_HandleEvents(self, event, ...)
	events[event](self, ...)
end

PQ_EventHandlerFrame:SetScript("OnEvent", PQ_HandleEvents(self, event, ...));

[momo1029]

Its my bad,changed things from work and haven't tested them. QUICK FIX

thanks valma for the pro lock profile
but somehow it repeatly summon felguard when out of combat

[Valma]

thanks valma for the pro lock profile
but somehow it repeatly summon felguard when out of combat

Yes,coz it is intended to do so :/ FG is better for most of the trash and on bosses profile will auto swap for FH,but I see your point coz hardcoded FG for trash is not good.Will probably add key modifier to change this.

EDIT: OK,changed this.By default pet swap is off,you can change this by pressing right ctrl when you are in demo,there will be notify on screen when you do so.If you will target boss petswap will be set to true automatically,if you target not boss mob it will be set to false.

DOWNLOAD

EDIT2: Or you mean that profile is loopcasting FG when out of combat? :/ Actually I know about the bug with casting FG 2 times in a row,and will fix it a bit later.

[happydado]

@Valma
Hi m8 your pve profile is realy pro.
Do u think that can do some pvp profile for lock?

[diesall]

THX for feedback I'm not that really familiar with luacoding(coding on #,.NET etc on work) so this info is really helpfull +rep mate.

Just quick question.
Slow:

PQ_EventHandlerFrame:SetScript("OnEvent", function(self, event, ...) events[event](self, ...); end);

Faster ??? :

function PQ_HandleEvents(self, event, ...)
	events[event](self, ...)
end

PQ_EventHandlerFrame:SetScript("OnEvent", PQ_HandleEvents(self, event, ...));

yes quite a bit faster, localizing PQ_HandleEvents will result in even more performance.

[bu_ba_911]

PQR (v2.0.1) Download Here

-Changed default 'spell available time' to 125ms before a spell is off CD. Up from 50ms. It was 250ms in the original version. This can be changed in a profile by changing PQR_SpellAvailableTime.
-Changed default refresh rate from 100ms to 50ms.
-Added external Lua file loading. Any file in the "Data" directory named as follows: "PQR_*.lua" will be loaded into WoW when PQR starts. It should only be loaded once. If you reload UI, log off then in, etc.. it should re-inject on the next PQR start.


----

Here is a quick sample of Time to Die for developers: TTD.zip
Place the Lua file in the Data directory. Place the mage profile in the MAGE directory. Start the rotation and attack a dummy.

lol freaking awesome Now I can just transfer all my most used functions that i use across all my profiles into a single file

[imdasandman]

@ valma the error only cropped up on testing on test dummies and well your profile is not made to support that so everything is working fine for destro…

Hagara on LFR with a 360 ilvl equipped lock..... 19k dps… that is very good I think imo

[yourson]

Haven't seen Boss around for some time... Started to worry.

[Valma]

yes quite a bit faster, localizing PQ_HandleEvents will result in even more performance.

Are local variables works in some different way in lua then in other languages? :/

So this is right way? :

if not PQ_EventHandlerLoaded then

	local PQ_EventHandlerFrame, events = CreateFrame("Frame"), {};

	local function events:COMBAT_LOG_EVENT_UNFILTERED(...)
				  
	end

	local function events:PLAYER_REGEN_DISABLED(...)
		
	end

	local function events:PLAYER_REGEN_ENABLED(...)
	
	end

	local function events:PLAYER_CONTROL_LOST(...)

	end

	local function events:PLAYER_CONTROL_GAINED(...)

	end

	local function events:MODIFIER_STATE_CHANGED(...)

	end

	local function events:UNIT_POWER(...)

	end
	
	local function events:PLAYER_TARGET_CHANGED(...)

	end

	local function events:PLAYER_FOCUS_CHANGED(...)

	end

	local function events:UPDATE_MOUSEOVER_UNIT(...)
		
	end
	
	local function events:INSTANCE_ENCOUNTER_ENGAGE_UNIT(...)
	
	end
	
	local function events:UNIT_SPELLCAST_START(...)

	end
	
	local function events:UNIT_SPELLCAST_SUCCEEDED(...)

	end	
	
	local function events:RAID_ROSTER_UPDATE(...)

	end
	
	local function events:ACTIVE_TALENT_GROUP_CHANGED(...)

	end
	
	local function PQ_Init()
	
	end

	--Notify frame
	PQ_NotifyFrame = CreateFrame('Frame')
	PQ_NotifyFrame:ClearAllPoints()
	PQ_NotifyFrame:SetHeight(300)
	PQ_NotifyFrame:SetWidth(300)
	PQ_NotifyFrame:SetScript('OnUpdate', PQ_NotifyFrame_OnUpdate)
	PQ_NotifyFrame:Hide()
	PQ_NotifyFrame.text = PQ_NotifyFrame:CreateFontString(nil, 'BACKGROUND', 'PVPInfoTextFont')
	PQ_NotifyFrame.text:SetAllPoints()
	PQ_NotifyFrame:SetPoint('CENTER', 0, 200)
	PQ_NotifyFrameTime = 0

	local function PQ_HandleEvents(self, event, ...)
	
	end

	PQ_EventHandlerFrame:SetScript("OnEvent", PQ_HandleEvents(self, event, ...));

	for k, v in pairs(events) do
		PQ_EventHandlerFrame:RegisterEvent(k); -- Register all events for which handlers have been defined
	end

	PQ_Init()
	PQ_EventHandlerLoaded = true
	if PQ_EventHandlerLoaded then
		if PQ_Debug then
			DebugFrame.messageFrame:AddMessage('Sucess!!!')
		end
	else
		if PQ_Debug then
			DebugFrame.messageFrame:AddMessage('FAIL!!!')
		end
	end	
end

[Valma]

@ valma the error only cropped up on testing on test dummies and well your profile is not made to support that so everything is working fine for destro…

Hagara on LFR with a 360 ilvl equipped lock..... 19k dps… that is very good I think imo

Its not about dummy,its about your pet I got a check for pet's npcid in PQ_Init() and it is a mathematic function wich will cause errors if you don't have pet.So I just forgot to add check if pet exists LOL So as for now it must work even if you don't have pet.

[bu_ba_911]

Haven't seen Boss around for some time... Started to worry.

last i heard i think he was doing some background work with somebody..... probably working on epic awesomeness that would blow ur socks off!!!!!

or he quit either or