need cat profile/
need cat profile/
been working on prot warrior single target just checking if I am heading in the right direction
commanding shout
concussion blowCode:local commandingshout = UnitbuffID("player", 469) local PWf = UnitbuffID("player", 21562) if (commandingshout == nil and PWf == nil) then return true else if UnitPower("player") < 40 then return true end end
devestateCode:local shieldslam = UnitbuffID("player", 50277) local thunderclap = UnitbuffID("player", 6343) if (shieldslam == nil and thunderclap == nil) then return true end
rend tho I think I should just leaving it to spam it if not on hmmCode:local rendDebuff = UnitDebuffID("target", 94009, "PLAYER|HARMFUL") local shieldslam = UnitbuffID("player", 50277) local thunderclap = UnitbuffID("player", 6343) local revenge = UnitbuffID("player", 6572) if (shieldslam == 0 and revenge == 0 and thunderclap == 0 and rendDebuff == 0) then return true end
revengeCode:local rendDebuff = UnitDebuffID("target", 94009, "PLAYER|HARMFUL") local shieldslam = UnitbuffID("player", 50277) local thunderclap = UnitbuffID("player", 6343) local revenge = UnitbuffID("player", 6572) if rendDebuff == not nil then return false else if (shieldslam == 0 and revenge == 0 and thunderclap == 0) then return true end end
shockwave single targetCode:local shieldslam = UnitbuffID("player", 50277) local thunderclap = UnitbuffID("player", 6343) local concussionblow = UnitBuffID("player", 12809) if (shieldslam == nil and thunderclap == nil and concussionblow == nil) then return true end
and thunderclapCode:local shieldslam = UnitbuffID("player", 50277) local thunderclap = UnitbuffID("player", 6343) local revenge = UnitbuffID("player", 6572) if (shieldslam == 0 and revenge == 0 and thunderclap == 0) then return true end
Code:local shieldslam = UnitbuffID("player", 50277) if shieldslam == nil then return true end
severs are down so cant test it wondering if there is anything wrong code wise, Just the rotation wasn't doing great so thought if I add conditions
to each ability checking if it should be applied then or something that is better tpr should be first
any help would be appreciated
me28791, why are you checking if the player has a Shield Slam buff on them ? Ofc they won't have because Shield Slam is an ability not a buff.
Go to wowpedia and check their API page to find out how to check for a spell Cooldown.
thanks for that.....and I have only ever coded in html and was ages ago lol will look at it now
edit: so for thunderclap would be
local sh, _, _, _, _, _, timer = UnitbuffID("player", 50277)
local shs, shd, she = GetSpellCooldown(23922)
local cd = (shs + shd - GetTime())
local tc, _, _, _, _, _, timer = UnitDEbuffID("target", 6343)
local tcs, tcd, tce = GetSpellCooldown(6343)
local tccd = (tcs + tcd - GetTime())
if sh == not nil then
if cd = 0 then
return false
else
if tc == nil then
if tccd = 0
then return true
end
end
end
pretty sure that is checking if the sword and board (shield slam proc) is up if not then checks if shield slam is off cd then if is on cd and also no proc will use thunderclap also will check if the tc debuff is alrady up as well
Last edited by me28791; 07-26-2011 at 07:09 AM.
Not sure what you are trying to do with that bit of code.
This code will check if shield slam is off cooldown and return true if it is.Code:local shs, shd, she = GetSpellCooldown(23922) local cd = (shs + shd - GetTime()) if cd > 0 then return false else return true end
Your code is checking for some buff that doesn't even exist.
Why would you want to check for Shield Slam cd on Thunderclap anyways?
so it would priotize shield slam over tc and not worry about TC at all if ss is procced or off cd, the checking of buff on player is sword and board which is the proc, the checking of debuff on target would be checking if the thunderclap debuff is already on target
edit: I think I get what you mean now in rotation editor it will check abilities from top to bottom right? if so I am an idiot
Last edited by me28791; 07-26-2011 at 07:18 AM.
Yes, rotation editor is there so you can prioritize your rotation. The spells at the top will be cast before the spells at the bottom.
50277 is an invalid spell ID according to Wowhead.
Sword and Board - Spell - World of Warcraft maybe I am wrong?
thanks again for all your help now time to change everything on it![]()
Hey all! Thanks again for your great work on this.. program? Xelper!
After extensive testing in both Firelands raid enviroments (all bosses) some heroic bosses and regular heroics I've been able to produce some really good numbers with my really basic rotation, so I've decided to put some more effort into updating my Shadowpriest rotation on a more advanced level.
I do have to stress though that it would be awesome with some kind of warden protection as I really don't want to lose my account which I've had for almost 6 years now (including 2 alt accounts and my Starcraft 2 account).
I'm nore really sure what could be done, or if you want to do it. Look on it like kind of a request. :P
Anyhow, new and updated Shadowpriest rotations are coming up sometime this week!
try the link for warlocks on page 22 again. i just clicked the links and it worked for me.
For me it`s still not working...
ok lets try this.
http://tinyurl.com/3srdqv5 for warlock
http://tinyurl.com/3m4max8 for ArcaneMage
They work. Thanks
Last edited by Kiup66; 07-26-2011 at 11:17 AM.