Sorry all, I have been both on vacation and playing MW3 for the last two weeks... haven't really had time to look at this thread.
The reason I havent been able to push out an update for PTR is because I don't have the time to dig through IDA. When Blizzard flags a build "Release" vs "Test" there is debug code added/removed from a couple of the functions that I use... making them a pain to find. I posted my instructions on how to find them in the test build... my suggestion would be to look at the current Release build that is live (14545) and compare it to the current Release build on PTR.. look at the functions in live then try to search for them in test (using sequence of bytes, etc.).
Don't worry, PQR should be updated day 1 of 4.3.
@Xelper when you say look for sequence of bytes.
Do you mean something that might look like this 8B CB 8D 1C 08 50 ?
yep, in IDA you can search based on a "Sequence of Bytes"
So find the functions in the current build, copy a set of bytes from that function that you think is unique enough that it wont find a million other functions... replacing any references to memory locations with wildcards (I think ??) and search for that same sequence of bytes and hope that nothing major has changed. You should know that you found the same function in the new version by comparing the flow of the function. You'll probably need at least a very basic understanding of ASM to do this.
If anyone has any better ways of finding the functions, I am all for hearing it. I am not so good at finding them.
Oh and here are my notes for finding them in TEST BUILDS ONLY sorry if they are cryptic, they were just meant to be a reference for myself.. most of these will work for the release build but FrameScript__Execute and FrameScript__GetLocalizedText will not.
Code:CheatEngine: To find player name: (String) Enter player's name into the Search, login to a new character and search for that chracter's name. To find player class: (Byte : 2) Enter player's class into the Search (number), switch to new character/class, search for that, rinse repeat until no others left. switch (myClass) { case "1": return "WARRIOR"; case "2": return "PALADIN"; case "3": return "HUNTER"; case "4": return "ROGUE"; case "5": return "PRIEST"; case "6": return "DEATHKNIGHT"; case "7": return "SHAMAN"; case "8": return "MAGE"; case "9": return "WARLOCK"; case "11": return "DRUID"; default: return ""; } MAGE -> HUNTER -> PALADIN -> PRIEST To find WoW Version: (String) Search for the WoW Version # IDA6: GetCurrentKeyBoardFocus: Search for string: GetCurrentKeyboardFocus, go to associated function... first mov esi, dword_VALUE. VALUE is the offset (+400000) Lua_DoString: Search for byte sequence (6A 00 6A 00 51 2B C2 50 56) which is part of FrameScript_Execute in 14545/14809. - Should be only one. - arg_0 = ptr 8 - arg_4 = ptr 0ch - arg_8 = ptr 10h -Has reference to FrameScript.cpp Lua_GetLocalized: Search for (55 8B EC 53 56 8B F1 8B 46 0C 8B 58 04 57 8B 38) which is part of FrameScript__GetLocalizedText in 14545/14809. arg_0= dword ptr 8 arg_4= dword ptr 0Ch GameState search for 55 8B EC 83 7D 08 00 56 8B F1 arg_0= dword ptr 8 arg_4= dword ptr 0Ch It should be one of the first function it finds, you will see a reference like: cmp byte_VALUE, 0 VALUE is the offset +400000
Last edited by Xelper; 11-27-2011 at 01:38 AM.
i hope the patch come this week i am sick of hc 6/7![]()
I've taken the liberty to flesh out the PQRotation wiki home page, along with creating the Priest Rotations category. I've also added partially the Holy Priest rotations and just finished the Shadow Priest Rotation category.
I should be updating the wiki page first from now on I recon, with a changelog of some kind.
I've found a minor "bug", i dont know if its really a bug.
the program is faster then wow itself.
so sometimes if it should use a proc spell, it uses it a mil second before the proc shows up and begans to cast it instead of using the proc for the instant
Looks like 4.3 will be out this week. Any chance that PQR will still work on Tuesday?
Seem most rotations didnt changed, old profiles ll be usable
However boss fights ll need special atention, like to stop dps on new BH boss blades phase
I Appreciate you guys starting to edit and maintain the wiki,
any of you who want admin rights and are well versed with wikia wiki's or want to help with maintenance, template/guideline implementation and making the information easier to access and digest please feel free to inbox me
ive been following this thread since its inception, admin rights will be given based on that.
if frequent posters to the PQR thread can include a link to the wiki in there signature, this will be greatly appreciated and hopefully cut down on useless posts in this thread.
---------- Post added at 12:22 PM ---------- Previous post was at 12:15 PM ----------
are you sure the ability in question is checking for the buff, if the unitbuff api call finds the listed proc, then the client is already ready to consume the proc, you may find that its a standard cast ability of the same spell that's firing it, if so you may want to include an ability at the start of your rotation that cancels the cast if its 'x' amount of time through the cast and the proc buff is present.
@fmagretto wow good job on the ret pally rotation and the tweaks to it. it was about time for a lil more in depth logic and i personally tested it and was jittery like about to lmao at the other players posting recount talking about "nice job". Makes it a lil easier on us for raids ill say. keep it up.
Well I did find that using the 3 orb to mind blast actually gives higher dps. I recorded 2 Meters to test it, 1 orb only gives 10% to the damage delt to your mind blast as well as 10% periodic. Thus if you have 3 that is 30% mind blast damage + 30% periodic tick damage. So given the base of that say your Mind Blast normally crits for 50k. with 1 orb your only getting a 5000 damage imput giving you 55k damage Crit. Now if we have 3 orbs you get 65k Crit damage. That also applies to your 3 dots you put down. This is more for higher levels.
But yes I do see why, Shadow Priests are more like Fire Mages. More Procs higher the damage, but i've seen shadow priests Do this rotation 3 orbs then MB, over the 1orb then MB. IT all depends on your Orb proc.
Yeah the SWP+Mind Flay mouse over works good, was doing a heroic and found out it shouldnt cast Vamperic touch and all the dots to slow and kill, being as your not the only dps doing it, as shadow priests for adds like that are based for slowing as well as damage.
I did another test, to where the dispersion is hit, yours seemed to stay around 9.8k but got to the dispersion in roughly 1 and a half, (shitty gear on my priest) Then did with mine, stayed around 9.8k -10.1k but lasted 2 and a half till the dispersion. I recorded till dispersion because of the reset in the meter. Also I found the Shadowfiend being alittle bugged. It for some reason is going at the start, meaning the breif point of 100% mana for a few seconds so it renders it useless.
But as far as the 30 second thing, run 2 tests for 5 mintues each, see how it works out. Might be different then other tests.
Fix for Shadowfiend:
Ran another with the fix. Yours does do higher dps but at the cost of time. did 10.1k in 2m and 14s. While mine did 9.8k sustained in 3m after the fix. So it all does really depends on your crit for MF for the proc. Bot saying that, neither got the second Shadowfiend off.Code:local learned = GetSpellBookItemInfo("Shadowfiend") local mana = 100 * UnitPower("player") / UnitPowerMax("player") if learned == nil then return false else if mana < 65 then return true end end
Last edited by Elokaynu; 11-28-2011 at 01:49 PM. Reason: New Test
Xelper it seems that Patch 4.3 gonna be live on US tommorow and on wensday on EU.Will u be able to update PRQ?It would be greate!
Yes it will be updated, I already have most of the offsets already just need the patch to go live so I can test them.