LuaNinja Macro Collection

[optovisc]

That's because typing code without being able to test it sucks...It looks ok to me...but maybe try this one...I'm not a huge fan of the syntax I was using for the debuffs...so maybe try it like this:

/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 then SpellStopCasting() CastSpellByName("Wind Shear") end
/run if GetSpellCooldown("Shamanistic Rage")==0 and UnitMana("player")/UnitManaMax("Player")<0.20 then CastSpellByName("Shamanistic Rage") end
/run local _,_,_,c=UnitBuff("player","Maelstrom Weapon") if c==5 then CastSpellByName("Lightning Bolt") end
/run local i=1; while(i<=40) do n,_,_,_,_,_,_,c,_,_=UnitDebuff("target",i); if n=="Flame Shock" and c=="player" then break else i=i+1 end end; if i>40 then CastSpellByName("Flame Shock") end
/run local i=1; while(i<=40) do n,_,_,_,_,_,_,c,_,_=UnitDebuff("target",i); if n=="Stormstrike" and c=="player" then break else i=i+1 end end; if i<=40 then CastSpellByName("Earth Shock") end
/run local i=1; while(i<=40) do n,_,_,_,_,_,_,c,_,_=UnitDebuff("target",i); if n=="Stormstrike" and c=="player" then break else i=i+1 end end; if i>40 then CastSpellByName("Stormstrike") end
/run if GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local _,t,_,_ = GetTotemInfo(1); if totemname==nil or totemname=="" then CastSpellByName("Magma Totem") end
/run local _,_,_,c=UnitBuff("player","Lightning Shield") if c~=nil and c<=1 then CastSpellByName("Lightning Shield") end
/run if GetSpellCooldown("Lava Lash")==0 then CastSpellByName("Lava Lash") end
/run local _,t,_,_ = GetTotemInfo(1); if (totemname==nil or totemname=="") and GetSpellCooldown("Fire Nova")==0 then CastSpellByName("Fire Nova") end

Still the same. Might be your conditions for casting the three spells. I have very basic programming knowledge but I do not understand the conditions i>40, i<=40
AFAIK you seem to be scrolling through all the present debuffs on the current target but other than that I'm not too sure what you're trying to accomplish.

edit
Nvm I figured out what those conditions were for. You're scrolling through for the debuffs and if Flame Shock isn't on the target, cast it due to i>40 and so on
AFAIK they seem fine to me. Not sure what's causing it.

[optovisc]

That's because typing code without being able to test it sucks...

This should be the problem fixer...I was checking the conditions but then not checking if Flame Shock was actually available. So it kept trying to cast a spell that was on cooldown so it just fizzled. This should correct that problem...please test:

/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 then SpellStopCasting() CastSpellByName("Wind Shear") end
/run if GetSpellCooldown("Shamanistic Rage")==0 and UnitMana("player")/UnitManaMax("Player")<0.20 then CastSpellByName("Shamanistic Rage") end
/run local _,_,_,c=UnitBuff("player","Maelstrom Weapon") if c==5 then CastSpellByName("Lightning Bolt") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Flame Shock" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Flame Shock")==0 then CastSpellByName("Flame Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i<=40 and GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Stormstrike")==0 then CastSpellByName("Stormstrike") end
/run if GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local _,t,_,_ = GetTotemInfo(1); if totemname==nil or totemname=="" then CastSpellByName("Magma Totem") end
/run local _,_,_,c=UnitBuff("player","Lightning Shield") if c~=nil and c<=1 then CastSpellByName("Lightning Shield") end
/run if GetSpellCooldown("Lava Lash")==0 then CastSpellByName("Lava Lash") end
/run local _,t,_,_ = GetTotemInfo(1); if (totemname==nil or totemname=="") and GetSpellCooldown("Fire Nova")==0 then CastSpellByName("Fire Nova") end

Almost there Viral! Now it gets stuck on recasting magma totem continouslly until one of the earlier conditions are met (i.e. 5 stack maelstrom, SS CD is up etc)

edit. found the problem just had to replace totemname with t. There's another problem. It doesn't seem to cast Lightning Shield at all.

[Viral Fly-by]

Ok the Magma totem part is easy...I changed the variable from totemname to just t...and forgot to update the ifs:

/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 then SpellStopCasting() CastSpellByName("Wind Shear") end
/run if GetSpellCooldown("Shamanistic Rage")==0 and UnitPower("player")/UnitPowerMax("player")<0.20 then CastSpellByName("Shamanistic Rage") end
/run local _,_,_,c=UnitBuff("player","Maelstrom Weapon") if c==5 then CastSpellByName("Lightning Bolt") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Flame Shock" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Flame Shock")==0 then CastSpellByName("Flame Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i<=40 and GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Stormstrike")==0 then CastSpellByName("Stormstrike") end
/run if GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local _,t,_,_ = GetTotemInfo(1); if t==nil or t=="" then CastSpellByName("Magma Totem") end
/run local _,_,_,c=UnitBuff("player","Lightning Shield") if c==nil or c<=1 then CastSpellByName("Lightning Shield") end
/run if GetSpellCooldown("Lava Lash")==0 then CastSpellByName("Lava Lash") end
/run local _,t,_,_ = GetTotemInfo(1); if t~=nil and t~="" and GetSpellCooldown("Fire Nova")==0 then CastSpellByName("Fire Nova") end

(Note: Above edited to final working version.)

[Viral Fly-by]

There's another problem. It doesn't seem to cast Lightning Shield at all.

That's a problem with the condition...

if c~=nil and c<=1 then CastSpellByName("Lightning Shield") end

...should be...

if c==nil or c<=1 then CastSpellByName("Lightning Shield") end

Blah...sorry about the crazy typos...I fouled it up pretty bad. I'm updating my old posts that have the whole macro.

[optovisc]

The macro works perfectly now. Thank you Viral!+Rep your original post.

[Viral Fly-by]

The macro works perfectly now. Thank you Viral!

Cheers!


As an aside if anyone else needs help or wants specific ones created, let me know. I enjoy this stuff. I'll be posting my holy paladin healing macro of total awesomeness soon...also another healing one for resto shaman. I've got one for the Felguard/Emberstorm warlock dps spec as well. I've also got a tweaked version of the retadin one from this thread that will also cleanse debuffs and use Art of War procs for instant flashes of light if low on hp.

[Evilphtbstrd]

Any chance you can write a macro for prot palas with the 969 rotation? YouTube - Protection Paladin TPS / DPS Tanking Rotation

ye i am looking for this as well , thx

and cant wait for your posts viral , especially the resto shaman

[kakamonster]

[QUOTE=Viral Fly-by;1766979]I'm assuming that never casts unless the debuff isn't present.

a[7]==GetTime()<2

That makes no sense. You also have some problems with your conditions....AND is higher precedence than OR so you need parentheses...but also I don't think it's checking the conditions the way you want.
Here's a better corrected (but untested) version:

/run i=1 while(i<=40)do a={UnitDebuff("target",i)} if(a[1]=="Flame Shock" and a[8]=="player" and (a[7]-GetTime())>2)then break elseif(i==40) then CastSpellByName("Flame Shock") i=i+1 else i=i+1 end end

Thanks mate, im kinda new to this so thats why it dont make sense =) thanks for the help

[Viral Fly-by]

Any chance you can write a macro for prot palas with the 969 rotation? YouTube - Protection Paladin TPS / DPS Tanking Rotation

Ok...here goes...but these are written off the cuff and totally untested guys...
I'm not on a WoW comp at the moment to test them:

Standard 969 (Judge, HotR, HS, SoR, Cons):

/run if _G["ProtTS"]==nil then _G["ProtTS"]=GetTime() end; if _G["Prot6"]==nil then _G["Prot6"]=0 end; if _G["Prot9"]==nil then _G["Prot9"]=0 end; if _G["Prot969"]==nil then _G["Prot969"]=9 end; 
/run if GetTime()-_G["ProtTS"]>9 then _G["Prot6"]=0; _G["Prot9"]=0; _G["Prot969"]=9; end; _G["ProtTS"]=GetTime();
/run if _G["Prot969"]==9 and _G["Prot9"]==0 and GetSpellCooldown("Judgement of Wisdom")==0 then CastSpellByName("Judgement of Wisdom"); _G["Prot9"]=1; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==1 and GetSpellCooldown("Holy Shield")==0 then CastSpellByName("Holy Shield"); _G["Prot9"]=2; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==2 and GetSpellCooldown("Consecration")==0 then CastSpellByName("Consecration"); _G["Prot9"]=0; _G["Prot969"]=6; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==0 and GetSpellCooldown("Hammer of the Righteous")==0 then CastSpellByName("Hammer of the Righteous"); _G["Prot6"]=1; _G["Prot969"]=9; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==1 and GetSpellCooldown("Shield of Righteousness")==0 then CastSpellByName("Shield of Righteousness"); _G["Prot6"]=0; _G["Prot969"]=9; end;

I actually think you could just do a standard /castsequence for that one...lol.

969 with SS for Cons (Judge, HotR, HS, SoR, SS/Cons):

/run if _G["ProtTS"]==nil then _G["ProtTS"]=GetTime() end; if _G["Prot6"]==nil then _G["Prot6"]=0 end; if _G["Prot9"]==nil then _G["Prot9"]=0 end; if _G["Prot969"]==nil then _G["Prot969"]=9 end; 
/run if GetTime()-_G["ProtTS"]>9 then _G["Prot6"]=0; _G["Prot9"]=0; _G["Prot969"]=9; end; _G["ProtTS"]=GetTime();
/run if _G["Prot969"]==9 and _G["Prot9"]==0 and GetSpellCooldown("Judgement of Wisdom")==0 then CastSpellByName("Judgement of Wisdom"); _G["Prot9"]=1; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==1 and GetSpellCooldown("Holy Shield")==0 then CastSpellByName("Holy Shield"); _G["Prot9"]=2; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==2 then i=1 while(i<=40) do a={UnitBuff("player",i)} if a[1]=="Sacred Shield" and a[8]=="player" then break else i=i+1 end end if i>40 then RunMacroText("/cast [@player] Sacred Shield"); _G["Prot9"]=0; _G["Prot969"]=6; elseif GetSpellCooldown("Consecration")==0 then CastSpellByName("Consecration"); _G["Prot9"]=0; _G["Prot969"]=6; end end;
/run if _G["Prot969"]==6 and _G["Prot6"]==0 and GetSpellCooldown("Hammer of the Righteous")==0 then CastSpellByName("Hammer of the Righteous"); _G["Prot6"]=1; _G["Prot969"]=9; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==1 and GetSpellCooldown("Shield of Righteousness")==0 then CastSpellByName("Shield of Righteousness"); _G["Prot6"]=0; _G["Prot969"]=9; end;

969 with SS for Judgement (SS/Judge, HotR, HS, SoR, Cons):

/run if _G["ProtTS"]==nil then _G["ProtTS"]=GetTime() end; if _G["Prot6"]==nil then _G["Prot6"]=0 end; if _G["Prot9"]==nil then _G["Prot9"]=0 end; if _G["Prot969"]==nil then _G["Prot969"]=9 end; 
/run if GetTime()-_G["ProtTS"]>9 then _G["Prot6"]=0; _G["Prot9"]=0; _G["Prot969"]=9; end; _G["ProtTS"]=GetTime();
/run if _G["Prot969"]==9 and _G["Prot9"]==0 then i=1 while(i<=40) do a={UnitBuff("player",i)} if a[1]=="Sacred Shield" and a[8]=="player" then break else i=i+1 end end if i>40 then RunMacroText("/cast [@player] Sacred Shield"); _G["Prot9"]=1; _G["Prot969"]=6; elseif GetSpellCooldown("Judgement of Wisdom")==0 then CastSpellByName("Judgement of Wisdom"); _G["Prot9"]=1; _G["Prot969"]=6; end end;
/run if _G["Prot969"]==9 and _G["Prot9"]==1 and GetSpellCooldown("Holy Shield")==0 then CastSpellByName("Holy Shield"); _G["Prot9"]=2; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==2 and GetSpellCooldown("Consecration")==0 then CastSpellByName("Consecration"); _G["Prot9"]=0; _G["Prot969"]=6; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==0 and GetSpellCooldown("Hammer of the Righteous")==0 then CastSpellByName("Hammer of the Righteous"); _G["Prot6"]=1; _G["Prot969"]=9; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==1 and GetSpellCooldown("Shield of Righteousness")==0 then CastSpellByName("Shield of Righteousness"); _G["Prot6"]=0; _G["Prot969"]=9; end;

969 with SS for Cons and HoW for every other Judgement (HoW/Judge, HotR, HS, SoR, SS/Cons):

/run if _G["ProtTS"]==nil then _G["ProtTS"]=GetTime() end; if _G["ProtJudge"]==nil then _G["ProtJudge"]=0 end; if _G["Prot6"]==nil then _G["Prot6"]=0 end; if _G["Prot9"]==nil then _G["Prot9"]=0 end; if _G["Prot969"]==nil then _G["Prot969"]=9 end; 
/run if GetTime()-_G["ProtTS"]>9 then _G["Prot6"]=0; _G["Prot9"]=0; _G["Prot969"]=9; end; _G["ProtTS"]=GetTime();
/run if _G["Prot969"]==9 and _G["Prot9"]==0 and (UnitHealth("target")/UnitHealthMax("target")>0.2 or _G["ProtJudge"]==1) and GetSpellCooldown("Judgement of Wisdom")==0 then CastSpellByName("Judgement of Wisdom"); _G["Prot9"]=1; _G["Prot969"]=6; _G["ProtJudge"]=0; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==0 and UnitHealth("target")/UnitHealthMax("target")<=0.2 and _G["ProtJudge"]==0 and GetSpellCooldown("Hammer of Wrath")==0 then CastSpellByName("Hammer of Wrath"); _G["Prot9"]=1; _G["Prot969"]=6; _G["ProtJudge"]=1; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==1 and GetSpellCooldown("Holy Shield")==0 then CastSpellByName("Holy Shield"); _G["Prot9"]=2; _G["Prot969"]=6; end;
/run if _G["Prot969"]==9 and _G["Prot9"]==2 then i=1 while(i<=40) do a={UnitBuff("player",i)} if a[1]=="Sacred Shield" and a[8]=="player" then break else i=i+1 end end if i>40 then RunMacroText("/cast [@player] Sacred Shield"); _G["Prot9"]=0; _G["Prot969"]=6; elseif GetSpellCooldown("Consecration")==0 then CastSpellByName("Consecration"); _G["Prot9"]=0; _G["Prot969"]=6; end end;
/run if _G["Prot969"]==6 and _G["Prot6"]==0 and GetSpellCooldown("Hammer of the Righteous")==0 then CastSpellByName("Hammer of the Righteous"); _G["Prot6"]=1; _G["Prot969"]=9; end;
/run if _G["Prot969"]==6 and _G["Prot6"]==1 and GetSpellCooldown("Shield of Righteousness")==0 then CastSpellByName("Shield of Righteousness"); _G["Prot6"]=0; _G["Prot969"]=9; end;

They will all "reset" the rotation if you don't push the macro for more than 9 seconds (between pulls). The Sacred Shield versions will rebuff Sacred Shield rather than the normal ability. (So 2nd one above will buff Sacred Shield rather than dropping consecrate...but of course only if your Sacred Shield is down.) They will NOT reset if you change target (useful for switching targets during trash). It will also not "skip" if you do somethign else with your GCD. If you do a Hand of Reckoning to taunt, it will just go right back to where it was...it won't skip over an ability because you used that GCD elsewhere.

For those who care, it is controlled by a few global variables to persist state between executions of the macro:

1. _G["ProtTS"] :: Used to detect if been more than 9 seconds since the macro ran so it can reset.
2. _G["Prot969"] :: Used to determine if the next ability is a 9-second one or a 6-second one.
3. _G["Prot9"] :: Used to determine where in the sequence of the 9-second abilities the macro is...in first above, 0 = judge next, 1 = holy shield next, 2 = consecrate next.
4. _G["Prot6"] :: Used to determine where in the sequence of the 6-second abilities the macro is...in first above, 0 = HotR next, 1 = SoR next.
5. _G["ProtJudge"] :: Used in the last macro above to alternate the "judgement" spot in the rotation between HoW and JoW. You only want to HoW every other to maintain the judgement effect.

Again...TOTALLY untested...but it should just be spammable and as soon as abilities come of cooldown it will use them in the correct order.

[kakamonster]

Ok the Magma totem part is easy...I changed the variable from totemname to just t...and forgot to update the ifs:

/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 then SpellStopCasting() CastSpellByName("Wind Shear") end
/run if GetSpellCooldown("Shamanistic Rage")==0 and UnitMana("player")/UnitManaMax("Player")<0.20 then CastSpellByName("Shamanistic Rage") end
/run local _,_,_,c=UnitBuff("player","Maelstrom Weapon") if c==5 then CastSpellByName("Lightning Bolt") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Flame Shock" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Flame Shock")==0 then CastSpellByName("Flame Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i<=40 and GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local i=1 while(i<=40) do a={UnitDebuff("target",i)} if a[1]=="Stormstrike" and a[8]=="player" then break else i=i+1 end end; if i>40 and GetSpellCooldown("Stormstrike")==0 then CastSpellByName("Stormstrike") end
/run if GetSpellCooldown("Earth Shock")==0 then CastSpellByName("Earth Shock") end
/run local _,t,_,_ = GetTotemInfo(1); if t==nil or t=="" then CastSpellByName("Magma Totem") end
/run local _,_,_,c=UnitBuff("player","Lightning Shield") if c==nil or c<=1 then CastSpellByName("Lightning Shield") end
/run if GetSpellCooldown("Lava Lash")==0 then CastSpellByName("Lava Lash") end
/run local _,t,_,_ = GetTotemInfo(1); if (t==nil or t=="") and GetSpellCooldown("Fire Nova")==0 then CastSpellByName("Fire Nova") end

Should be this to avoid canceling spells if target is outside range for Wind Shear
/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 and IsSpellInRange("Wind Shear", "target")==1 then SpellStopCasting() CastSpellByName("Wind Shear") end

ahh dident see it was for melee, well if your elemental use this interrupt

[Viral Fly-by]

Should be this to avoid canceling spells if target is outside range for Wind Shear
/run if UnitCastingInfo("target") and GetSpellCooldown("Wind Shear")==0 and IsSpellInRange("Wind Shear", "target")==1 then SpellStopCasting() CastSpellByName("Wind Shear") end

Yes I guess technically it should be...but the macro only attempts to interrupt the target...it doesn't try to interrupt a focus or anything. So why is this enhancement shaman NOT within range for Wind Shear? He sure isn't doing much dps as melee if he's more than 25 yards from his target. ^_^

[Evilphtbstrd]

none of them are casting a judgement for me

they are all casting SoR, HoR , HS and cons but nothing else

and 969 with SS for Judgement (SS/Judge, HotR, HS, SoR, Cons): doesnt work for me at all
thx tho viral

[Viral Fly-by]

none of them are casting a judgement for me

they are all casting SoR, HoR , HS and cons but nothing else

and 969 with SS for Judgement (SS/Judge, HotR, HS, SoR, Cons): doesnt work for me at all
thx tho viral

I typo'd the name of the spell...it was trying to cast "Judement of Wisdom"...LOL.

The one you mentioned doing nothing was a huge typo in the sequence variables...

I edited the post above...try now?

[Evilphtbstrd]

dam just got in a naxx raid as dps , will test sorry i didnt check spelling mate , didnt think of it

[Viral Fly-by]

dam just got in a naxx raid as dps , will test sorry i didnt check spelling mate , didnt think of it

No worries...just let me know when you get a chance to try it. =)