LuaNinja Macro Collection

[Elitetech]

@ Sadchaos: This only happens for me if my game crashes or I press exit & forcelogout (sometimes)

@CrazyCactuaR I don't really think that is possible, I've checked the API list and haven't found anything to check if you're shooting. Try to use

/run if Corruption and Curse then CastSpellByName("Shoot") end

or set a ! in front of shoot. If that doesn't work try

/run if Corruption and Curse then RunMacroText("/castsequence reset=5 Shoot, moolol") end

What this will do is that it will shoot then try to cast moolol (which you don't have) for 5 seconds, then it'll cancel shoot or something. Not entirely sure to be honest and haven't got time to check. schools calling.

[CrazyCactuaR]

/run if Corruption and Curse then RunMacroText("/castsequence reset=combat/target !Shoot, milkthecow") end

Worked spot on! Thank you my good man.

[angusm]

Elitetech i just sent u a PM about DK stuff, i figured it was best to post here since u always check this post !

Tyvm again bout all the hlp !

When i try to run:

#showtooltip Obliterate
/startattack
/Run temp=spell
/Run tamp=miscspell
/Run tump=intspell
/Run CastSpellByName(""..temp.."")
/Run CastSpellByName(""..tamp.."")
/Run CastSpellByName(""..tump.."")

It runs fine but sometimes i get the "A macro script has been blocked from an action only available to the Blizzard UI" its very annoying, anyway to remove this ?

For Aoe i thought of something like this ... but idk, acts stupid most of the time, like firing up Pest with no Diseases on the target.

/Run temp=aoespell
/Run timp=spell
/Run tamp=miscspell
/Run tump=intspell
/Run CastSpellByName(""..temp.."")
/Run CastSpellByName(""..timp.."")
/Run CastSpellByName(""..tamp.."")
/Run CastSpellByName(""..tump.."")


And i also cant find a way to modify FaceSmasher.Lua so it takes "Glyph of Diseas" into account when Single Targetting DPSing, just so i can get a DPS gain there ... any ideas ?

[kakamonster]

Post Removed.

[Elitetech]

I'll just answer here instead of the PM. The AoE function of Facesmasher can't be run alone. You'll have to singletarget the mob until you got both diseases then run AoE. Or to be honest I think it'll check wether you have diseases or not on the target, I'm not sure though as I've rerolled mage and don't use the addon much anymore

You might look for a more advanced macro if you want it to check for diseases before running the AoEspell

/run if UnitDebuff("target", "Blood Plague",unitCaster~="player") then CastSpellByName(""..temp.."") else CastSpellByName(""..timp.."") end

Should check for the disease Blood Plague. If your target have it then it'll run the AoE macro else it'll run the solo.
As for the addon thingie add

/run StaticPopup_Hide("MACRO_ACTION_FORBIDDEN");

to the end of your macro.

So basically the whole macro would look like this

/Run temp=aoespell
/Run timp=spell
/Run tamp=miscspell
/Run tump=intspell
/run if UnitDebuff("target", "Blood Plague",unitCaster~="player") then CastSpellByName(""..temp.."") else CastSpellByName(""..timp.."") end
/run CastSpellByName(""..timp.."")
/Run CastSpellByName(""..tamp.."")
/Run CastSpellByName(""..tump.."")
/run StaticPopup_Hide("MACRO_ACTION_FORBIDDEN");

It's pretty huge

You can always add other conditions or ask me to add them

[angusm]

As Always AMAZING !

SO if i want to check for Frost Fever as well would this be the line code ?

/run if UnitDebuff("target", "Blood Plague",unitCaster~="player") and UnitDebuff("target", "Frost Fever",unitCaster~="player") then CastSpellByName(""..temp.."") else CastSpellByName(""..timp.."") end

[Viral Fly-by]

if UnitDebuff("target", "Blood Plague",unitCaster~="player") then 
     CastSpellByName(""..temp.."") 
else 
     CastSpellByName(""..timp.."") 
end

Elitetech, where did you find or how did you discover that sytnax for UnitDebuff? I've only seen it used in this thread and I can never find any documentation that indicates that's how it works? I'm guessing from the syntax that it's like a predicate that is used to filter the unit's debuff list (so any debuff for which the predicate evaluates as true is ignored). Is that true? Do you know if you can have more complex ones? I'm thinking something like say a Lacerate stack for bear tank...

if not UnitDebuff("target", "Lacerate", (unitCaster~="player" or count<5)) then 
     CastSpellByName("Lacerate") 
end

If the filter really works like I described, that should work because only a 5-stack of your own lacerate would get past the filter. It would be a much shorter way of coding some of those things compared to what we've seen earlier in the thread.

[Elitetech]

Elitetech, where did you find or how did you discover that sytnax for UnitDebuff? I've only seen it used in this thread and I can never find any documentation that indicates that's how it works? I'm guessing from the syntax that it's like a predicate that is used to filter the unit's debuff list (so any debuff for which the predicate evaluates as true is ignored). Is that true? Do you know if you can have more complex ones? I'm thinking something like say a Lacerate stack for bear tank...

if not UnitDebuff("target", "Lacerate", (unitCaster~="player" or count<5)) then 
     CastSpellByName("Lacerate") 
end

If the filter really works like I described, that should work because only a 5-stack of your own lacerate would get past the filter. It would be a much shorter way of coding some of those things compared to what we've seen earlier in the thread.

There's a few things that I know works and a few thinks that should work. What you've written should work, can't test now(which is basically how you figure out if it works), but yeah it is possible to use more and more Returns for the syntax. You could do stuff like

/run local _,_,_,cn,_,_,_,uc,_=UnitDebuff("player","Lacerate"); if( cn<=5 ) and ( uc=="player" ) then CastSpellByName("Lacerate") end

Pretty much anything would go.
Don't know if I've answered your question or not, please say if I haven't, but well on the site it says

 = UnitDebuff("unit", index or ["name", "rank"][, "filter"])

so that's where we got it from

[Viral Fly-by]

local _,_,_,cn,_,_,_,uc,_=UnitDebuff("player","Lacerate"); 
if( cn<=5 ) and ( uc=="player" ) then 
     CastSpellByName("Lacerate") 
end

Yea I know it will work this way...but that's much more cumbersome compared to the other syntax. I agree you just have to test it and see...I was also unable to test at the time of my posting which is why I was asking. =) Cheers!

[angusm]

Seems to be something wrong with :

/run if UnitDebuff("target", "Blood Plague",unitCaster~="player") and UnitDebuff("target", "Frost Fever",unitCaster~="player") then CastSpellByName(""..temp.."") else CastSpellByName(""..timp.."") end

Gets messy sometimes, Keeps giving Prio to AoE even when the main window on FaceSmasher is saying to pop Diseases ... anything i can do to make it "smarter" ? like is not both diseases up the target then and only then run AoE, otherwise keep running Spell ?

[PhillyPhong]

Is it possible to make a macro to target a dead mob and loot it?
I have bound interact with target to K, so I can manually loot it, but it would be uber nice with a macro

edit: I'm killing mobs with exactly same name over and over cause of instant respawn.

[reveng_]

Mutilate Macro:

/run local p = GetComboPoints("player","target") if (p>=4) then CastSpellByName("Envenom") else CastSpellByName("Mutilate") end

It'll only deal with Mutilate and Envenom for now. I'll update it later to include refreshing HfB.

[Elitetech]

Seems to be something wrong with :

/run if UnitDebuff("target", "Blood Plague",unitCaster~="player") and UnitDebuff("target", "Frost Fever",unitCaster~="player") then CastSpellByName(""..temp.."") else CastSpellByName(""..timp.."") end

Gets messy sometimes, Keeps giving Prio to AoE even when the main window on FaceSmasher is saying to pop Diseases ... anything i can do to make it "smarter" ? like is not both diseases up the target then and only then run AoE, otherwise keep running Spell ?

Facesmasher will tell you to pop diseases even though you've already got both on your target. This will only check if you've got diseases on the target, not if you get most dps from casting PS and IT again, or how much time is left on them. This will cast AoE if both diseases are on the target, otherwise it'll run the solo rotation until both diseases are on the target. Shouldn't need improvement

[Ssateneth]

@Elitetech: When checking for certain debuffs on mobs, namely to see if its your own, it will only return info about the first instance of the debuff up on the target. If there's multiple instances of the debuff up and YOUR copy debuff isn't the first one up, it'll mess up. Example: In a raid, DK A debuffs boss with Frost Fever, then you debuff with frost fever. Due to some oddities, DK A's frost fever is first in line, so your macro will think you dont have frost fever up, so it'll spam icy touch until your frost fever debuff is first.

I had this problem when multiple warriors were in a raid and my old macro (similar to yours) AND TellMeWhen addon were messing up because it wasn't checking ALL (up to) 40 debuffs on the boss to see if I had my own copy of rend up, and instead it returned info about the first copy of the debuff which often was someone else's so it spam casted Rend.

Here's a modified version of my Rend macro fitted for Frost Fever. It will guarantee to never spam Icy touch if multiple Frost Fevers are up. Modify it to whatever you want, just trying to help out.

/run i=1 while(i<=40)do a={UnitDebuff("target",i)} if(a[1]=="Frost Fever" and a[8]=="player")then break elseif(i==40) then CastSpellByName("Icy Touch") i=i+1 else i=i+1 end end

[paradoxial]

Aww someone fix the feral druid dps macro it doesn't work after the tuesday maintenance I need it to push out my 7k dps in raids if not I'm 4-5k tops. Someone fix it so it works properly I don't know enough LUA to make it bypass the new filters.

/run if UnitBuff("player", "Clearcasting") then CastSpellByName("Shred") end
/run local _,d,_ = GetSpellCooldown("Tiger's Fury") if (d == 0) and UnitPower("Player") < 30 then CastSpellByName("Tiger's Fury") end
/run p=GetComboPoints("player","target");if not UnitBuff("player", "Savage Roar") and p>0 then RunMacroText("/cast Savage Roar") end
/run p=GetComboPoints("player","target");if not UnitDebuff("target", "Rip",unitCaster~="player") and p>4 then RunMacroText("/cast Rip") end
/run p=GetComboPoints("player","target");if p>4 then RunMacroText("/cast Ferocious Bite") end
/run if not UnitDebuff("target", "Mangle",unitCaster~="player") then CastSpellByName("Mangle") end
/run if not UnitDebuff("target", "Rake",unitCaster~="player") then CastSpellByName("Rake") end
/run local _,d,_ = GetSpellCooldown("Shred") if (d == 0) then CastSpellByName("Shred") end