Creature phasing question

[Xmaily]

Hey Ownedcore,

I am working on this script and when the boss spawns I want him to start sending boulders down a hill. In this raid i'm creating the Alliance and Horde experience different versions of the raid. I have Alliance in phase 1 and Horde in phase 8. However, my function doesn't appear to be working I don't get any errors when running the script I simply don't see the boulders come into phase 1 or 8.

Here is the function;

 

function UTG.VAR.BOULDERZOMGZS(pUnit)
	local plr = pUnit:GetRandomPlayer(0)
	if plr ~= nil then
		local race = plr:GetPlayerRace()
		if race == 1 or race == 3 or race == 4 or race == 7 or race == 11 then -- alliance
	for place,creatures in pairs(pUnit:GetInRangeUnits()) do 
if creatures:GetEntry() == 6814 and  pUnit:GetDistanceYards(creatures) < 800 then
creatures:SetPhase(1)
		else
	for place,creatures in pairs(pUnit:GetInRangeUnits()) do 
if creatures:GetEntry() == 6814 and  pUnit:GetDistanceYards(creatures) < 800 then
creatures:SetPhase(8)
	end
end
end
end
end
end
end

Does anyone know whats wrong with it?

Thanks!

[stoneharry]

I'm not sure why you are coding it in this way.

Store in a instance variable the faction running it.

table[instanceID].faction = 1

Then on npc spawn, get instance ID, and set phase depending on faction variable.

[Xmaily]

I'm not sure why you are coding it in this way.

Store in a instance variable the faction running it.

table[instanceID].faction = 1

Then on npc spawn, get instance ID, and set phase depending on faction variable.

Oh, I forgot that you could do it that way! Awesome! I have seen some scripts that have done that in the past that I can look over. Just out of curiosity though what was wrong with the code above that made it not work.

[stoneharry]

Oh, I forgot that you could do it that way! Awesome! I have seen some scripts that have done that in the past that I can look over. Just out of curiosity though what was wrong with the code above that made it not work.

It could have been a number of reasons, without seeing the full context and script it would be hard to tell and even with that information it could be hard to debug. It's just not a very good way to go about doing it.