[Lua] Newbie Lua scripting question (SOLVED)

[Maybepie]

Everything bellow is solved thanks to the elite scripters of MMowned. :)
Keeping the post as it is for others with similar issues.


Not sure if anyone will read this, I don't want to spam the forum with another question thread so I'll just write my second question here and hope for an answer again. :)

This is my try at creating a second phase, I want the mob to yell out TEXT2 at 80% health, what am I doing wrong this time?

function bossfight(pUnit, event)
    pUnit:SendChatMessage(14, 0, "Hm? You dare to challenge me?! Pfah!")
    pUnit:RegisterEvent("phase1", 5000, 0)
    pUnit:RegisterEvent("phase2", 1000, 0)
end

function phase1 (pUnit, event)
    if pUnit:GetHealthPct() < 95 then
    pUnit:RemoveEvents()
    pUnit:SetModel(27176)
    pUnit:SendChatMessage(14, 0, "TEXT1")
    pUnit:CastSpell(28498)
    end

function phase2(pUnit, event)
    if pUnit:GetHealthPct() < 80 then
    pUnit:RemoveEvents()
    pUnit:SendChatMessage(14, 0, "TEXT2")
    end
end

RegisterUnitEvent(NPCID, 1, "bossfight")

Oh hai!
I recently found out about the wonderful world of LUA scripting and I decided to give it a try. I've been playing around in notepad for a hour or two now, just trying out the basics.
But now I'm stuck! I can't seem to get my script running as I want to.

function Boss7_Test(pUnit, Event)
pUnit:SendChatMessage(14, 1, "RANDOMTEXT")
if pUnit:GetHealthPct() < 95 then
pUnit:RemoveEvents();
pUnit:SendChatMessage(14, 1, "RANDOMTEXT2")
pUnit:SetModel(27176)
end
end

RegisterUnitEvent(50007, 1, "Boss7_Test")

I basically want the mob to first yell out RANDOMTEXT when pulled, and when he's at about 95% I want him to yell out RANDOMTEXT2 AS WELL as change his model to 27176.

When I try it on my private server he only yells out the first text and then nothing happens, any idea how to fix this?

There's obviously 2x+Rep cookies waiting to be eaten, if a decent answer is provided of course! :)

[alj03]

Now i am not pro at this but this is what i think:

Wouldn't you use when he enters combat the function

unit:SendChatMessage(14, 0, "RANDOMTEXT")
end

And then for the 2nd part have

function transform(unit, Event)
if unit:GetHealthPct() <=95 then
unit:SendChatMessage(14, 0, "RANDOMTEXT2")
unit:SetModel(27176
end
end

Try tie this into the script, if it doesn't work, i'll leave it to the experts. :P

[Ground Zero]

You need to make it a seperate function, right now it's making him check if the HP is under 95% when he first starts combat.

function zzOnCombat(pUnit, event)
    pUnit:SendChatMessage(14, 0, "Text")
    pUnit:RegisterEvent("phase1", 3000, 0)
end

function phase1 (pUnit, event)
    if pUnit:GetHealthPct() < 95 then
    pUnit:RemoveEvents()
    pUnit:SetModel(ID)
    pUnit:SendChatMessage(14, 0, "BLAHBLAH"
    end
end

RegisterUnitEvent(NPCID, 1, "zzOnCombat")

You need to register the next function in your current function, so as it is now it checks every 3 seconds to see if the npc is under 95% hp, when it is it will removeevents which means it will stop checking for phase1 and move into phase1 in which the npc will yell it's message. If you want to add extra phases just keep doing so using RegisterEvent and RemoveEvents. The 3000 in the register event stands for milliseconds, 3000 = 3 seconds. The 0 stands for how many times it checks, 0 = unlimited and of course 1,2,3 etc.

[alj03]

I kind of got close? But yeah take GZ's advice. Mine was less thought out.

[RyeRye]

You need to make it a seperate function, right now it's making him check if the HP is under 95% when he first starts combat.

function zzOnCombat(pUnit, event)
    pUnit:SendChatMessage(14, 0, "Text")
    pUnit:RegisterEvent("phase1", 3000, 0)
end

function phase1 (pUnit, event)
    if pUnit:GetHealthPct() < 95 then
    pUnit:RemoveEvents()
    pUnit:SetModel(ID)
    pUnit:SendChatMessage(14, 0, "BLAHBLAH")
    end
end

RegisterUnitEvent(NPCID, 1, "zzOnCombat")

GZ had it right, but he had 1 little error, and with 1 error the whole script won't work, so use this one, (GZ's with the fixed error).

[Ground Zero]

GZ had it right, but he had 1 little error, and with 1 error the whole script won't work, so use this one, (GZ's with the fixed error).

You would have been right if you posted 7 mins ago. :3 Hehe already fixed it.

[RyeRye]

Dang your on it! hahah.

[Maybepie]

Heh, thanks a lot for the quick answers!
It works fine now, I didn't know I had to make it as a separate function, but I do now! :)

EDIT:Rep cookies all around, sorry RyeRye gotta wait 24 hours until yours are ready. ( My rep oven is gettin' quite old you see. )

[RyeRye]

Thanks bro .

[Ground Zero]

Register phase2 in phase1, otherwise the RemoveEvents will cancel phase2 once it hits phase1

It's always the same way, the previous phase registers the next phase.

[Maybepie]

Register phase2 in phase1, otherwise the RemoveEvents will cancel phase2 once it hits phase1

It's always the same way, the previous phase registers the next phase.

Ahh, I see what you mean. It's fixed now.
Thanks once again Ground Zero, you rock! :)