The Ruby Sanctum: Halion

[kjankoski]

The script: Lua | --[[ Made by kjanko (http://ca - Anonymous - tTh3KBGq - Pastebin.com

Enjoy. Do not re-release without mine permission.

Credits:
-Kjanko
-Hypersniper
-GrandElf

[Ground Zero]

Approved, maybe add some screenshots or a little more information, it looks a little bare.

[Breakdawn]

I love this script Good job, Nice contribution. And +rep

[kjankoski]

Approved, maybe add some screenshots or a little more information, it looks a little bare.

I would, If I had a client. But the code looks fine so there should be no problems.

[pantryboy]

RUBY[id].Halion = pUnit:GetCreatureNearestCoords(pUnit:GetX(), pUnit:GetY(), pUnit:GetZ(), HalionID)

Why have you put that there? It's on the Creature Spawn event for Halion, surely it would make more sense to just use:

RUBY[id].Halion = pUnit

[kjankoski]

It's the same, you can use GetCreatureNearestCoords() or RUBY[id].Halion = pUnit to get the creature. There's no difference.

[Dynashock]

Yet one's more efficient. Yours uses more resources (as it uses multiple get accessors and GetCreatureNearestCoord uses an iteration and a calculation), but what pantryboy uses is nothing but accessing an already declared and filled variable.

Otherwise, very good script (haven't fully read it through yet though). I like the fact you're using most of LuaHypArc's new features. Hopefully it'll set the standards for new scripts on MMOwned, thanks.

[kjankoski]

Alright updated the script to use = pUnit instead of GetCreatureNearestCoords()

[jimdhr02]

it would be nice to see a video. see how many spells u have working and how close it it to retail.

[kjankoski]

Every spell should be working. It's about 98% blizzlike, not 100% because I'm not sure about soul_consuption or w/e It's called.

[DarkVanir]

Very nice contribution. Approved.

[besje]

Code looks nice and clean, waiting for some screenshot's!

[kjankoski]

If someone manages to set it up and test it, please post some screenshots during the fight.

[MaCAppLeBiTeMe]

i would upload some pics of this if I knew how to setup your script. Honestly you should've filled in his ID and all the other stuff because I don't what else to write.

Fill data for RegisterUnitEvent(mobid, event, function)
Fill data for PerformIngameSpawn(type,entry,map,x,y,z,o,facOrScale, duration, 0, 0, 0, pUnit:GetInstanceID()
Fill data for GetGameObjectNearestCoords(x, y, z, gameobjectid) This is used when despawning the flame/shadow circle

[kjankoski]

I can't help you because I don't have a WoW Client :\