[Lua] Item Adder & Logging System

[Ground Zero]

Item Adder

What is it?

- It is a Script that allows certain ranks to input a item id into a npc and get that item back in return.
- It logs the transaction with details of the character/account/time/item/date.

Cool, Can I use it for players?

Sure, you can just remove the requirement out of the script or change the rank requirement from a & az to a custom rank such as g for example which could be a VIP rank on your server.





The SQL: *You need this to log the transactions!

SET FOREIGN_KEY_CHECKS=0;
DROP TABLE IF EXISTS `item_logs`;
CREATE TABLE `item_logs` (
  `Entry` int(10) unsigned NOT NULL auto_increment COMMENT 'Unique ID',
  `Character` text collate latin1_general_ci,
  `Account` text collate latin1_general_ci,
  `Rank` text collate latin1_general_ci,
  `Item ID` decimal(10,0) default NULL,
  `Date` date default NULL,
  `Time` time default NULL,
  PRIMARY KEY  (`Entry`)
) ENGINE=MyISAM AUTO_INCREMENT=14 DEFAULT CHARSET=latin1 COLLATE=latin1_general_ci;

The Script:
Lua | local NPC_ID = 90000 functi - Ground Zero - xLzE5g86 - Pastebin.com


Enjoy.

Thanks to pedobear (stoneharry) for fixing sql fails.

[Allstar .ιllιlı.]

Seen this system before. Still, great release.

[Hellgawd]

Looks good, Ground Zero.
Would be nice to see you implement more features into this as time progresses, but this is nice even within itself. +8

[Ground Zero]

I'm going to add some extra stuff in my spare time, considering adding something sexy which I havn't seen released yet, but it's a secret.

[stoneharry]

You didn't mention which table to execute the query into... Also credits to who? >.>

[Ground Zero]

You didn't mention which table to execute the query into... Also credits to who? >.>

Obviously world. -.-

And yes thank you for reminding me, you did help me fix damn sql fails.

[stoneharry]

Obviously world. -.-

And yes thank you for reminding me, you did help me fix damn sql fails.

Well I always use char/logon DB for storing anything related to characters. xD So it's not obviously world.

[Ground Zero]

Well I always use char/logon DB for storing anything related to characters. xD So it's not obviously world.

You're just special.

[Aldun]

An item* not a =] Anyone, nice job

[Dynashock]

First of all, am I honestly the only one who does not see the point of this script? If they're admins or regular GMs they can add the items anyway. If you change it to a donation rank you're going to need to add some filters because you don't want donaters running around with 2 martin furies or something.

Secondly, you can easily merge the two date/time columns together by allowing the mysql server itself to fill the data. (Although it's more of a cosmetic thing than anything)

Thirdly, you're wasting performance by calling

                        local PlayerName = player:GetName()
                        local AccountName = player:GetAccountName()
                        local Rank = player:GetGmRank()

before checking whether the query returned something. You're not going to be using those values if the query didn't return anything thus you could've been saving memory and cpu.

Fourthly, work on your indentation, although it is still part of your personal style of writing keep it consistent! Yours is all over the place.

Fifthly, no need for additional concatenation on

"SELECT * FROM items WHERE entry = "..code..""

Anyway, I'm not trying to sound like an ass and sorry if I do, but it seems like nowadays people get rewarded for being ignorant. I would have forgiven some of your mistakes if you were new to Lua - but you're not and I think I recall seeing some of the made mistakes before. Fix some of the points above and you'll have my rep.

[Ground Zero]

Well thanks for your honest feedback Dyna, I appreciate that, nobody else can be bothered or havn't got the guts to say that, so thanks.

Thanks for the advice, i'll keep it in mind.

[trujillo]

this is a very nice system groundzero
a idea for additions could be spells also? just a thought
or maybe something along those lines

edit: i just thought of another idea that could be added in to this. have a table where there is 2 columns one column for the entry id of items, one for the name of the item so the player can manually add and delete items from the table and instead of checking for the item in the normal items table you can have it check in that table for the item, this just allows the server to set only certain items can be obtained through this script

and you could also have a way to add the item to the table from the npc if your a gm

[Jotox]

Ehhh, leaned-down exact copy of my "Bob the vendor" script, just in lua...

p.s. The SQL in your script is insecure. I realize it's only for GMs, but if one of your GMs were to want to screw you...