[Compiles] Mangos + YTDB + Scriptdev2 + Changelog

[Dj Aligator]

Mangos 10352 - 10361

Implement support explcitly started timed achievements.

* Player::StartTimedAchievementCriteria can be used for activate timer
  for specific explicitly starting timed achievement by timedRequirementId
  in script.

* for ACHIEVEMENT_CRITERIA_TYPE_COMPLETE_QUEST this done in core.
Avoid access to DB at view GM tickets by chat commands.

Also
* Show response text if added at view.
* Show tickets amount at console .ticket use instead unexpected no player error.
* Allow use ticket number in .ticket respond case.
* Some code cleanups.
Use time constants instead of hard coded values for STOP_TIME_FOR_PLAYER
Correctly clearUnitState at Interrupt of WaypointMovementGenerator for creature
Drop unneeded groupFlag and rename it properly

(based on Schmoozerd's repo commit 1e8c842)

Also drop `achievement_criteria_requirement` data use at start timed achivement:
its will be checked at criteria update (and complete) case. So wrong criteria will
started maybe (timer set but always fail - progress not updated.
PacketLog.* not used in core some time already so drop it.
A small spoon of changes and cleanup for WaypointMovementGenerator

* Initialization to ensure destination is always set (prevent evade problem)
* Simplify how behavior for node is processed, incl fix MovementInform script call (based on idea/past code from Quriq14)
* Make sure last node is also processed correct (DB script for last node will now work as expected)

As usual if any problems occur, you can call our toll free customer support number.
Implement spell 45449.
Restore triggered auras cleanup at main aura expire after auraholders adding.
Send proper error message at password check fail.

It specailly fix 1.x client case that not understande used for later clients 4-byte message.
Remove trailing space.

[Dj Aligator]

Mangos 10362 - 10380

Implement creature_movement_template

Template can be used for several cases:
* Unique creature that are already spawned in database (requires creature.MovementType=2 like guid based creature_movement)
* Summoned creature that has a pre-defined path (requires creature_template.MovementType=2)

Note that creature_template.MovementType=2 should be used with care, and must not be used for creatures that may be summoned in random locations in world.

Added additional startup checks for existing creature_movement-table
More wide use ObjectGuid in way remove MAKE_NEW_GUID uses.

Also
* Fixed some amount wrong uses low guids as full player guids.
* Add private without body ObjectGuid(uint32 const&) for catch wrong assigns low guids to ObjectGuid.
  In some cases need assign "0" guid, then use ObjectGuid() instead.
* Fixed .pdump commands work.
Restore build with gcc and cleanup includes a bit.
Implement ACTION_T_MOUNT_TO_ENTRY_OR_MODEL (43) for creature eventAI.

Read doc/EventAI.txt for details.
SQL query to update existing scripts are included (convert from using ACTION_T_SET_UNIT_FIELD, field 68)
Add portable way for hash specialization adding.

Use it for ObjectGuid hash specialization
Making sure CreaturesAddon are re-loaded after creature evade
Use AI function DoCastSpellIfCan for eventAI ACTION_T_CAST
Implement UNORDERED_SET support.

Signed-off-by: VladimirMangos <[email protected]>

Also added compatibility code for old Visual Studio versions
for non standard way hash calculation for hash_set.

Thanks to Lynx3D for help in Unix side testing.
Rename UnorderedMap.h -> UnorderedMapSet.h
More wide use ObjectGuid in group code.

Also drop some unused functions.
And fix some uint32 -> uint6 guid assigns.
Implement EFLAG_RANDOM_ACTION

It allow execute one random action from EventAI event actions
instead each action from event actions.
Drop unused team-argument in ChooseDisplayId -function
Fixes for EFLAG_RANDOM_ACTION

* Field limited to uint8 so use proper flag mask (0x20 now)
* Search of selected action code also fixed.
Updated MySQL client libs to 5.1.49
Fixed build at VS90 with TR1

As problems show VS90 with TR1 different from VS100 by expected namespaces.
Simplify use Guild::BroadcastEvent
Avoid double lookup member slot in guild operations.

Also more wide use ObjectGuid in guild code
and fixed some uint32->uint64 guid assigns.
More wide use ObjectGuid in arena team code.

As always in this commits line fixes for uint32->uint64 guid assigns.
Finaly drop MAKE_NEW_GUID.

This meaning that ObjectGuid only proper way create guid from lowguid now.
But packet handlers still generate uint64 guids. Some DB fields also loaded uint64 values.

Also possible existed not catches et uint32->uint64 assigns.

YTDB 339

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 117 caches (3.3.5a)

[Dj Aligator]

Mangos 10381 - 10403

Implement generic system for racial model selection

Table creature_model_info store creature entry to use model from (or explicit model). The selection is based on a base modelId and racemask.

Hacks for shapeshift models removed (data included in SQL update)
Dropped no longer needed creature_model_info.modelid_other_team, as creature_model_info can and should be used instead (sorry, this is what happen when author doesn't do full research :) )
Add missing holiday id<->battleground id definitions for AB
Store guid instaed pointer for first user of GAMEOBJECT_TYPE_SUMMONING_RITUAL

This is more safe way in pointer store comparison with.
LAso Some related code cleanups.
Fixed reset time calculation for some cases.

Most real fix suggested by Schmoozerd and  Toinan67
and some my code style part coding ;)
Traditional post-commit typo fix.
Remove Unit::GetUnit and update it callers.
 Correct creature entry selection for raid difficulties

Original patch provided by False.Genesis.
Fixed quote parsing after optional arg in chat commands.

This is restore work .guid commands for example.
Make spawntime arg really optional as before for .gobject add
Typo fixes
(based on Darkrulerz's repo commit 758f4c7)
Add several new script calls for InstanceData

OnCreature Evade/Death/EnterCombat and in addition OnPlayerLeave
The functions are intended to help doing instance related tasks (in other words, not for the general AI of creatures).
Restore build at Unix after Unit::GetUnit drop.
Small correction in SetReputation to avoid confusion
Add script call for InstanceData, OnPlayerDeath

Called when a player really dies and also unrelated to the source of the death (for example a player can die indirectly from some mob ability, but must be registered. Achievements, other special events)
Remove redundant use of this-> in recent implemented script calls

Thanks porteyoplait for pointing it out /bonk author
No debug log output when a certain ability is active
Send GMTicket to SendGMTicketGetTicket instead text.
Fixed wrong difficulty selection and possible crash.
Fix mixed up FactionEntry to lookup in SetReputation
 Fixed typo in doc/EventAI.txt
Fixed crash in .aura command for spell without auras.
Some code style cleanups.
Use ObjectGuid in packets and fix some uint32 guids cases.
Stricted name check at chat command data loading from 'command' table.

[Dj Aligator]

Mangos + YTDB + Scriptdev2 + Changelog

If Mangos 9667+ dosen't work on x32 then it work on x64
If Mangos 9972+ dosen't work with .NetFramework 3.5 then it work with .NetFramework 4
If you want to post this releases on other websites you can but please write whos is the original poster. Also if you want me to post this releases on your forum or other contact me.

Red- New Releases
Blue- Little old Releases
Green- Old Releases

Mangos


Mangos 10361
Mangos 10351
Mangos 10326
Mangos 10309
Mangos 10279
Mangos 10269
Mangos 10246
Mangos 10227
Mangos 10189
Mangos 10168
Mangos 10154
Mangos 10144
Mangos 10131
Mangos 10116
Mangos 10091
Mangos 10075
Mangos 10059
Mangos 10049
Mangos 10032
Mangos 10025
Mangos 10011
Mangos 9999
Mangos 9972
Mangos 9901
Mangos 9891
Mangos 9842
Mangos 9818
Mangos 9792
Mangos 9774
Mangos 9756
Mangos 9748
Mangos 9709
Mangos 9678
Mangos 9667
Mangos 9649
Mangos 9637
Mangos 9620
Mangos 9599
Mangos 9577
Mangos 9541
Mangos 9501
Mangos 9473
Mangos 9459
Mangos 9444
Mangos 9435
Mangos 9419
Mangos 9391
Mangos 9364
Mangos 9348
Mangos 9327
Mangos 9311
Mangos 9280
Mangos 9260
Mangos 9239
Mangos 9209
Mangos 9171
Mangos 9130
Mangos 9112
Mangos 9091 + DTS+AT+AHB
Mangos 9071
Mangos 9043
Mangos 9020
Mangos 9007
Mangos 8993
Mangos 8975
Mangos 8953
Mangos 8937
Mangos 8913
Mangos 8898
Mangos 8881
Mangos 8869
Mangos 8854
Mangos 8828
Mangos 8823
Mangos 8812
Mangos 8738
Mangos 8715
Mangos 8695
Mangos 8684
Mangos 8677
Mangos 8670
Mangos 8664




Mangos Update SQL



8/16/2010
8/12/2010
8/7/2010
8/2/2010
7/28/2010
7/25/2010
7/22/2010
7/19/2010
7/14/2010
6 Update
1 Update
3 Update
4 Update
2 Update
5 Update
3 Update
4 Update
5 Update
5 Update
1 Update
8 Update
1 Update
3 Updates
7 Updates
4 Updates
10 Updates
9 Updates
5 Updates
1 Update
6 Updates
1 Update
2 Updates
5 Updates
2 Updates
4 Updates
1 Update
8 Updates
3 Updates
3 Updates
1 Update
8 Updates
2 Updates
4 Updates
3 Updates
1 Update
17 Updates
2 Updates
1 Update
AHB SQL
1 Update
6 Updates
2 Updates + dual spec anticheat sql
4 Updates
5 Updates
6 Updates
2 Updates
4 Updates
6 Updates
4 Updates
9 Updates
3 Updates
Updates 8856 and 8863
Updates 8828 to 8854
Update 8828
Update 8815 and 8818
Update from 8749 to 8812
Update from 8720 to 8731
8702_01_characters_character_reputation.sql
8693_01_mangos_spell_proc_event.rar
8688_01_mangos_creature_template.rar
8676_01_mangos_creature_template.sql
SQL




Scriptdev2 Update SQL


Update 1777
Update 1767
Update 1755
Update 1741
Update 1737
Update 1736 updates full mangos and scriptdev.sql
Update 1736
Update 1718
Update 1713
Update 1706
Update 1703 mangos_scriptname_full
Update 1695 scriptdev2_script_full
Update 1695 mangos_scriptname_full
Update 1695
Update 1688
Update 1683
Update 1681
Update 1671
Update 1679
Update 1670
Update 1663
Update 1660
Update 1653
Update 1643
Update 1639
Update 1635
Update 1615
Update 1605
Update 1601
Update 1593
Update 1586
Update 1571
Update 1557
Update 1556
Update 1553
Update 1547
Update 1543
Update
Update 1536
Update 1525
Update 1523
Update 1520
Update 1516
Update 1513
Update
Update
SQL + Source




YTDB


YTDB 338 full DB
YTDB 337
YTDB 336
YTDB 334
YTDB 332
YTDB 331
YTDB 330
YTDB 328
YTDB 327
YTDB 326
YTDB 325 (full DB)
YTDB 324
YTDB 323
YTDB 322
YTDB 321
YTDB 320
YTDB 319
YTDB 317
YTDB 316
YTDB 314
YTDB 313 full DB
YTDB 300
YTDB 298
YTDB 292
YTDB 281
YTDB 281
YTDB 274
YTDB 267
YTDB 266
YTDB 262
YTDB 255
YTDB 246
YTDB 237
YTDB 236
YTDB 234
YTDB 231
YTDB 227
YTDB 222
YTDB 218
YTDB 217
YTDB 210
YTDB 209
YTDB 188
YTDB 186
YTDB 185

---------- Post added at 03:09 PM ---------- Previous post was at 03:02 PM ----------

Mangos 10404 - 10422

Additional checks for call assist.
Restore remove spell affect 58427 after stealth fade.

(based on Wowka321's repo commit 45c5757)
Fixed work .learn and other spell commands with unlearned talent shift-link.

Unlearned talent have -1 as rank in shift-link, return instead first rank.
Add -o <outfile> option to genrevision.

This gives more flexibility to build systems that don't run genrevision with desired destination as working dir.
For example a build system may run:
build/tools/genrevision -o build/src/shared/revision.h
Fix mistake in recent debug log output change (ref 10395)
Restore work of 47230 and ranks
Fix wrong sql
fix broken sqls for spell_proc_event..
add a BindIP warning to worldd/realmd config files
Add some missing class/struct forward declarations and includes.
Constantify some functions in InstanceSave.
Sort triggered spell chains 44203 and 42231 in proper place `spell_chain` data.
fix 71611 proc and remove check for family name if no spell_proc_event is defined
Fix Battle/Guardian elixirs stacking
Merge not-skill linked spell lists in `spell_chain`
Check redundant single rank spell data in `spell_chain`.

Also, add empty lines to end of file and apply code style tosome sql updates.
Avoid send stop packet in PointMovementGenerator when unit is not moving

Also never send stop packet when destinationHolder hasArrived, it's expected that unit is already not moving.
Correct typo in function name.
 Fix 71642 proc conditions

YTDB 340

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 130 caches (3.3.5a)

[Dj Aligator]

Mangos 10423 - 10446

Load most spell chains data from SkillLineAbility.dbc

* Output error for redundent data in table
* Drop detected data from `spell_chain`
Fix 50334 additional targets part
Add comment in Aura::CanProcFrom
Remove not needed checks from IsNoStackAuraDueToAura
Drop redundant data from `spell_proc_event` after recent spell chain changes.
Fix line ends :/
some format string fixes
Improve detection removed ranks for spell in `spell_chain`
Correcting issues with flying creatures falling to ground at death.

Simplified the way FallGround works and death states are set in a more logical way when a mob is in fact DEAD_FALLING.
Visual will in some cases not be correct. Notes in code for details.

Thanks to Lynx fixing Map::GetHeight
It now return mapHeight as last resort, making FallGround work as expected.
This fix reveal one (known) bug, and therefore a temp hack is added in TargetedMovegen, to be sure Z is not the ground Z for a creature that are able to fly.
Other creatures will follow by the ground level Z (in other words, they will no longer follow in the air).
Rename ASSERT -> MANGOS_ASSERT and related fixes

ASSERT hard use in predictable way because diff. 3rd party libs code
redefine it inf different ways and hard make sure that used in end
of mangos define version. This is real detected problem make some
expected assert checks ignored and so bugs not detected as expected from code.

In addition made related changes:
* Common.h header expected to be first include in any src/game/header except most simple cases.
* Related FILE.h header expected to be first include in FILE.cpp
* Fixed some absent includes and type forwards for safe build without PCH enabled.
* Avoid using MANGOS_ASSERT in src/framework code
Implement EVENT_T_MISSING_BUFF for self buff check

Also added amount spell stack checks at loading
for EVENT_T_BUFFED and EVENT_T_TARGET_BUFFED.
Add missing braces - should fix 51664 and ranks
Fix recently added uint64 use for query in char deleted commands.

In mangos DB we store full guids only in *_aura tables for caster.
Fix typos in invisibility aura handlers
Fix engineering bonus for injectors
Fix GetHeight() to return height within actual search distance only.

Good news: Fixes fishing bobber
Bad news: Mobs follow into the air again unless larger search distance is used
Increase search distance at height search if we know expected limit.

When we know that point above .map ground search at least until ground level for vmap height.

Good news: Fishing bobber still fixed ;)
Good news: Mobs not follow into the air again
Implement spell 55680
Fix 64962 bonus for 47541 and ranks
Fix armor bonus part of talent 33853 and ranks
Fixed expected packet size for SMSG_SET_PROFICIENCY
Fixed scripted AI init for TemporarySummon/Totem summon code

Call AIM_Initialize before adding to map instead after calling.
This make this call order similar other cases.

Re-implement in more safe way single cast spell targets system.

It also fix case when target can unexpected lost single target aura at phase switch
in case when target still visible in new phase (pet for example)
Small fix for single target auras: remove caster only auras

Avoid remove different caster aura if target have similar diff caster auras
in case when auras from diff casters allowed for spell.

[Dj Aligator]

Mangos 10447 - 10489

Certain compilers refuse to erase const_iterator...
Use base run speed * 2 as fall speed.

It equal to base flight speed and not dependent from real creature speed as expected.
Typos in enum names and comments

Also typos find by darkstalker and Neo2003
Skip wrong guid movement packets.

Also fix src/game/SharedDefines.h line ends corrupted in prev. commit. :/
Replace ASSERT by MANGOS_ASSERT
Typo in World field.
Fix disease consume part of 49020 and ranks
Fix 54821 proc
Add missing break, thanks to nos4r2zod
Implement 60764
Fix proc of 51692 and ranks
Changes to corpse decay/respawn times for creatures

*CORPSE_DECAY values adjusted (Rare/RareElite values are guessed) with more proper.
*RATE_CORPSE_DECAY_LOOTED is now 0.0 as default and a modifier of the creatures spawntimesecs are used for corpse decay.

Respawn time for creature is now set at death (result: database spawntimesecs are in most cases the time it takes from kill to respawn)

Overall, this will affect four things:
* corpse will stay visible longer before looted
* corpse will stay visible longer after looted, when creature has long respawn time
* creature without loot will "skip" the default decay times and then fix a "should respawn almost instant" -problem
* creature with loot and very short respawn time may respawn instantly after looted
 Restore update area aura values at caster/around targets.

For example, at related improvement talent learn by caster.
It has been disabled in aura holder code changes.
Fixed unexpected area aura stacking from same caster at spellmods reapply.

In fact it general problem possible with area auras if it re-casted
non-standard way from code. But known only test case for mangos-0.12 branch.

Thanks to ciphercom for reportand original research of problem source.
Fix error message in extractor tool
Implement spell 6495

Also implement proper work CMSG_FAR_SIGHT.
This packet control switch view point from far sight object to caster
and back wihtout modify far sight object seelction.
Clean up the .gitignore files.

* Move the settings for VS and CMake files to /.gitignore
* Drop now unused .gitignore files
Revert a part of [10463] and move them back to the .gitignore file in the sub-directory
Implement SPELL_EFFECT_REDIRECT_THREAT

Note: all spells with effect expect additional code for redirection reset.
Until code adding redirection work longer that expected.
Patch partly rewrited with move new data into HostileRefManager
and added redirection to threatAssist. Also bug fixed with
redirection threat to unit not in hostile list yet.
Proper reset threat rediraction for existed spells.

In 3.5.5a this is: 34477, 57934, 59665 and triggered spells.
Implement proper triggering for spell 34477, 57934
Also fixed charges amount (1) for main spell auras.
Typos in comments in recent patches.
Rename some opcode handler to better follow used naming style
Fixed totem owner faction/level set for creature onwer case.

When totem created creature owner alos not in world yet.
Drop vmap_debugger.

After new vmaps version it not work and useless.
Implement SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE (310)

Original patch provided by rsa
Fix structure SMSG_SPELLHEALLOG for 3.5.5

This also fix proper show critical heals
Cleanup vmap_assembler

* Drop dead code
* Use std::string instead of char*
* Use std::cout instead of printf()
Implement SPELL_AURA_HEAL_ABSORB (301)

Used for example in spells 66237 and 70659.

Also rename CalculateAbsorbAndResist -> CalculateDamageAbsorbAndResist
Fix 31228 and ranks
Fixed heal amount for some cases heal absorb
Implement item 49623 visual effects.

Original patch provided by Darkruler.
Implement heak absorb for periodic heal

Also fix SMSG_PERIODICAURALOG for periodic heal for 3.5.5
Fix a bug causing creature dynamic flags to be removed at normal loot preparation.

In addition add use of UNIT_DYNFLAG_TAPPED_BY_PLAYER
Added check to see if creature is tapped for isAllowedToLoot()
Use prefix m_ for member variable in motionMaster

Some additional code style cleanup.
Add basic function MoveWaypoint() to manually start creature waypoint path
Finally add README to vmap_assembler

Use for auraholde/aura GetStackAmount uint32 result.

uint32 result used in most expressions for stack calculation/compare
Alos uint8implicitly casted to int by C++ in expressions that generate unexpected
signed/unsigned warnings in comparisons (uint8 +1) > uint32 and similar.
Check school mask for SPELL_AURA_MOD_AOE_DAMAGE_AVOIDANCE

* Some spells expect this.
* Check SPELL_AURA_MOD_PET_AOE_DAMAGE_AVOIDANCE just for similarity,
  currently no spels with aura 310 with special school masks.
Use casterGUID check for delaying holder since possible stacking same spell from different casters
Implement SCRIPT_COMMAND_MOVEMENT(20) to start/change movement

datalong can be 0:idle, 2:random, 3:waypoint. In case 3, creature must have a existing creature_movement_template.
Command start movement for source of script. If source is not creature but target is, it will apply to target.
Optionally creature entry can be defined (datalong2) and start movement for this if found nearby (search radius defined in datalong3).
Fix checking text id's for creature_movement_template
Correct some typos in comments for SCRIPT_COMMAND*

YTDB 342

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 130 caches (3.3.5a)

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ The Ruby Sanctum: fix of physical damage from parses
+ Event: "Zalazane's Fall" - sniffs (require support script)
+ Event: "Operation: Gnomeregan" - sniffs (require support script)
+ processed 168 caches (3.3.5a)

[Dj Aligator]

Mangos 10490 - 10502

Arena ratings chnages is signed, fix debug string accordingly.
Search player in player list in update fields data prepare is bad idea.
Fixed crash in debug output for some data.

It well known at account data loading if character/account have
in account data string look like pritf format string (with %s for example)
Implement EVENT_T_TARGET_MISSING_BUFF
Really allow proccesing buff events in EventAI.
Clarify not working state for target buf events in EventAI

Unclear how provide target for event...
Re-work struct ScriptInfo and use union for data fields.

Enumerate SCRIPT_COMMAND_* and move it away from world.h
Add a crude documentation of script command processing

It is mostly copied from source files and should be subject for further improvement.
Arrange case SCRIPT_COMMAND_* so that they come in correct order.
Fixed typo at copy-paste in ArenaTeam::BroadcastEvent
Extend SCRIPT_COMMAND_TALK to support random selected text

In addition to adding fields for text id storage (in total 4 text id's), also added a comments field for developers notes in scripts (it may help those being old of age to remember what goes on in a script).

Correct wrong character in mangos.sql
Correct comment for ACTION_T_FORCE_DESPAWN, action do have param

[Dj Aligator]

Mangos 10503 - 10512

Move `*_respawn` tables to `characters` DB.

This allow have in `mangos` DB only world static state data.
Prevent damage player in sanctuary by pet or other controlled unit.
Remove unused stuff
Implement 5 new SCRIPT_COMMAND_*

All commands can only have creature as the affected by command
*_SET_ACTIVEOBJECT - switch activeObject state on/off
*_SET_FACTION - changes faction
*_MORPH_TO_ENTRY_OR_MODEL - changes model to model from creature_template entry or model id explicit
*_MOUNT_TO_ENTRY_OR_MODEL - mounts on model from creature_template entry or model id explicit
*_SET_RUN - switch walkmode on/off
Extend SCRIPT_COMMAND_TALK with option to set language for text
Arrange case SCRIPT_COMMAND_ in correct order, also in ObjectMgr

Some additional code style corrections.
Fix some "foo initialized after bar" gcc warnings and remove some unused variables.
Reimplement aura stack checking EventAI events.

* In consistent with other EVENT_T_TARGET_* apply event
  to current combat target.
Fixed SPELL_AURA_MOD_COMBAT_RESULT_CHANCE dodge chance apply to auto-attacks result.
Fixed cast item remove at trade enchanting in some cases

Also nit allow item use spels casts if item in trade.

Added
Buildings 3.3.5
Maps 3.3.5
DBC 3.3.5

[Darkev0]

its normal to execute the World DB(Ytdb) more then 8 hours?

[dennisdra]

Whic Program ur using?
SQLYog, Navicat?
Use HeidiSql and the Problem will be fixxed.

[Dj Aligator]

Mangos 10513 - 10524

Clear grid *Check/*Searcher clases use

* Check class considered have all info select  object in world from suggested but grid walker list in some grid.
  This also meaning that Check must always have focus object around that (and in same phase) fit objects must be.
* Searcher only must ask Check and know how from all objects fiting to Check select result object(s).

For this reason and for better compatibility removed first arg (searcher) form all Searcher classes.
Instead expected used Check::GetFocusObject() object if need ( by always need check and simolify Check classes
phase checked in Search classes). This also restore source code compatibilty in related lines with prev.client
version branches code.

* While focus object adding fixed possible wrong phase object selection at stealth detection and at corpse searches.
New option PetUnsummonAtMount

Make possible disable pet unsummon for non-fly mounts (1.x way work)
Default value set line lost
Fix small typo in class ExplodeCorpseObjectCheck
Remove wrong comment, reputation rate for spell is implemented.
Prevent emotes animation in feign death state.

In 3.x this has been posisble only with cheating tool.
Fix delaying spell with 2 or more persistent area auras and store ObjectGuid instead of Unit* on DynamicObject affected set
Implement CONDITION_QUEST_NONE

For case when need check that quest not taken and not completed in past.
Fix iterator update, thanks to VladimirMangos
Fix periodic procs - spells that require periodic healing to proc need to be defined in spell_proc_event with procEx PROC_EX_PERIODIC_POSITIVE, by default all procs without it are negative
Fix proc from periodic crits
Fix compilation for UNIX-likes

YTDB 343

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 180 caches (3.3.5a)

[Dj Aligator]

Mangos 10525 - 10554

Add missing () to expressing for proper prio.
Implement server side global cooldown check.
Also pet/controlled unit global cooldown code replaced by new placed in charmInfo structure.

Thanks to nos4r2zod for testing and gcd range check implement.
Disable CombatSpell check for triggered spells
Run creature_movement_scripts also at first waypoint
Water level in movement use fixes.

* Move selection allowed upper and lower heights for target point
  into near point core function used for contact/close point selection.
  Selection base at possibility target point searcher fly/swim(or walk by water bottom).
* Use vamp water level data so have proper water level in instances in movements.
* Use increased ground search distance for water level case.
Fixed client reject any login attempt after WOW_FAIL_INCORRECT_PASSWORD receive.

Problem similar all all client versions.
Spells with SPELL_ATTR_EX6_NO_DMG_PERCENT_MODS must ignore all damage mods
Aura SPELL_AURA_ALLOW_ONLY_ABILITY not prevent auto-attacks.
Revert [10528], simply wrong (scriptId already called properly)
Fixed second and later resets schedule for raid/heroic after server restart.
Add optional argument to SummonCreature, summon as active object

When true, the summoned will be able to load grids as needed.
Extend SCRIPT_COMMAND_TEMP_SUMMON_CREATURE to set summoned as active object

Field data_flags 0x01 will enable active state
Fixe typo in command help text.
Fixing some comments in mangos.sql

Not all sql tools like the mix of comment styles in import of dump, so using inline style.
Use more near for final point coordinates for Z calcualtion.
Fixed structure SMSG_RESYNC_RUNES
Allow set afk/dnd message in afk/dnd state
Fixed ObjectGuid::IsUnit

Also some better string format for pet guid case.

Thanks to zergtmn for find problem.
Fix handling of spell 14157 and 14189 so they really apply combo points after current spell finished.

Also spell 70802 from new item set needs same treatment.
Output debug only note for known not implemented packets

This is packets that have allowed to receive setting (not STATUS_NEVER)
and WorldSession::Handle_NULL handler.

Mark some packets in this way.
Better way mark not implemented packets.
Fixed EffectActivateRune activate only expected runes amount of some rune type.
More correctly check delay time for spell with speed.
Implement missing part spell 47568 functionality.

Original patch prowided by False.Genesis.
At schedule second reset update real reset time.

Missing part of prev. related commit.

Also without this code at second reset after restart server will go to infinity loop.
Fixed field types in mangos.sql in consistant with related sql updates.
Fix 55880 proc
Add some vehicle flags, thanks to zergtmn and community
Two more cases where AURA_REMOVE_BY_EXPIRE mode can be used
Fix wrong procs when spell hits with no damage

[Dj Aligator]

Mangos 10555 - 10577

Remove not existed function declaration.
Add frand function for random floats with min/max, similar to urand
Add optionial arg to Unit::SetFacingTo which is passed to SendMessageToSet
Fix spell "Spinning" (64385) for item "Unusual Compass" (45984)
Add world state id in comments for all hard coded state id's
Remove reundenant spell store for temporary unsummoned  pet.

We not use this data and now always have proeprtly save current pet
when it temporary unsummoned and avoid it overwrite by another cases.
Avoid ask AI for direct controlled creature at attack.
Also fix warrning double->float in recent commited code.
Cleanup WorldSession::HandlePetAction

Also fixed attack target seelction base at packet content instead direct player selection.
Remove unneded arg for Unit::SendPetAIReaction.
Implement CMSG_PET_STOP_ATTACK.
Not allow charmed by player creatures have threat list.

Original patch provided by zergtmn.
Fixed loaded DBC  count.
Implement SMSG_SPELLINSTAKILLLOG
Revert VS90/game.vcproj changes in [10551]
Drop unused column 'realmid' from the table 'character_tutorial'
Don't save holders from channeled spells
Store spell entry of triggering spell on triggered, original patch provided by insider42
Properly remove dual-wield flag at spell unlearn.
Drop unused Spell::m_triggeringContainer
Add end file empty line to some files.
Fixed non-weapon offhand equip after my recent commit.
Fix world states related to arena season.

Replace the "in progress" option in config (as no such thing exist) with the expected "previous arena season id".
Prevent diseases to be dispelled while 50536 is on target
'shuttingdown' -> 'shutting down' in log

YTDB 344

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ processed 186 caches (3.3.5a)

[Dj Aligator]

Mangos 10578 - 10589

Use static call for IsBGWeekend in BattleGroundAV
Better wording in log for shutdown cancelled case.
TARGET_ALL_RAID_AROUND_CASTER include caster only for positive spells.
Rename some local variables in random move generator for easier reading
Add spell_proc_event data for some relic related spells.

Missing ones were 67356, 67363, 67365, 67379, 67381, 67384, 67386, 67389, 67392.
Remove dual ERROR in logs
Prevent lost aura connection with item at Aura::ReapplyAffectedPassiveAuras

Thanks to Lynx3d for research problem and testing.
Make GO type 10 become nice and shiny: sparkling animation and jingle bells

When GO is active for quest, same as GO type 3.
Also add comments for future development of gameobject dynamic flags
Update taxi mask size for 3.3.5a
Make GO type 5 sparkle at related quest active
Make GO type 8 activate and sparkle at related quest active
Always activate GO type 3 when quest id is defined (and active)

GO may be "lootless", but events at looting can happen

YTDB 345

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ repopulation of fishing holes
+ processed 192 caches (3.3.5a)

[Dj Aligator]

Mangos 10590 - 10610

Check if GO is requirement of quest to activate sparkle if it is
Simplify LoadGameObjectForQuests for case GO type 3
Make GO type 2 activate/deactivate

As with similar GO's that are not interactable (gameobject_template.flags|4) as default, GO's of type 2 becomes active when player can take a quest (or deliver quest).
Cleaning up code a bit, in related functions for recent commits
Use equal_range instead of lower_bound/upper_bound pairs

(based on zergtmn's repo commit 0499169)
Add new functions to Set/RemoveShortFlag (uint16, lo and high part of uint32)
Apply restrictions to vmap options.

After switch to new vmap version and later height check code chnages
some vmap related options now outdated.

* Option vmap.ignoreMapIds removed. You can't now diable vmaps use for selected maps.
* Option vmap.enableHeight must be always enabled for normal work server and server
  at startup now pring error if it's diabled. Option still supported just for special
  work cases (debug, new clients testing, etc).

Possible soon option vmap.ignoreSpellIds also will be removed, because like los ignore checks
must be in spell code instead options.
Enable by default vmap.enableHeight and vmap.enableLOS

mangosd.conf version updated.
Create enum GameObjectDynamicLowFlags and use instead of hard coded
Attempt fix data corruption for some localization structures with GCC use.

By unknown reason GCC generate wrong code for locale structures declared in header after pack pragma.
Correct size of animprogress for GO Create()

Add a default define and use it instead of hard coded value.
Some additional minor corrections for transport GO's
Amother attemp fix locale structures corruption.

Possible real source of problem: existing in code mixed
std:: structure templates instanting under pack pragma and out.
And this incompatible structure layouts wrongly mixed used by GCC.

So all std:: strcutures used moved out from pack pragma guards.
Add GO_DYNFLAG_LO_ACTIVATE to GAMEOBJECT_TYPE_GENERIC and merge similar cases.
Replace one hard coded value w/enum name. Additional code style cleanup
A couple more spell_proc_event entries for relics.

Missing items were 38360, 40714, 45509, 45144, 50454, 50455, 50456, 50457, 50458, 50459, 50460, 50461, 50462, 50464.
Fixed infinity loop at grid loading

this also probably solves the problem that object tries to be loaded twice
Fix loot for victims being creature type critter
Handle GAMEOBJECT_TYPE_GENERIC at Use() to trigger despawn of GO

In addition, a check is added to prevent unexpected call to Use() at received opcode. Despawn of this type GO can then only be used with explicit call to Use()
Update melee miss chance calculations...finally.

Also thanks to Revils for correcting effective skill for spells that don't use weapon despite being melee/ranged ability.
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...
I consider it proven that all classes shall benefit from intellect for weapon skill increase.

But better formula for chance would still welcome...

YTDB 346

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus
+ new templates from WDB
+ update table "*_template" by WDB
+ data from sniffs (templates, spawn)
+ fix spawn "Pit of Saron" from sniffs
+ processed 205 caches (3.3.5a)