Arena Script

[fresh]

This script turns all FFA Arenas (gurubashi, ring of blood, dire maul) into a custom arena.

If a player is killed in an FFA arena, the killer and the killer's group are awarded arena points.

The player who was killed is deducted pvp points.

You can edit the configs in ArenaScript.cpp to change the number of points awarded/deducted.


For those of you who have ever played on Chaos Crusade Funserver, this is the script that I wrote for the Ring of Blood arena (slightly modified).


Here's the script.

ArenaScript.cpp

//Arena PvP Script
//Made By Jotox/Classic
 
//------------------------------
//Configs.
//------------------------------
//Level required to participate.
#define REQUIRED_LEVEL 80
 
//Base amount of points awarded
#define NUM_POINTS 40
 
//Number of points lost on death
#define POINTS_DEATH 10
 
//Allow parties to PvP (0 for no)
#define PARTY_ALLOWED 1
 
//Allow Raids to PvP (0 for no) Default: no (It results in 30 vs 1)
#define RAIDS_ALLOWED 0
 
//---------------------------
//End Config.
//---------------------------
 
 
#include "StdAfx.h"
#include "Setup.h"
 
void GivePoints( Player* player, int32 points)
{
    if( points < 0 )
        player->m_arenaPoints = ((int32)player->m_arenaPoints > (-1)*(points)) ? player->m_arenaPoints + points : 0;//Subtract points, or set to 0 if they don't have enough.
    else
        player->m_arenaPoints += points;
    player->SetUInt32Value(PLAYER_FIELD_ARENA_CURRENCY, player->m_arenaPoints);
}
 
void OnPlayerKill(Player * pPlayer, Player * pVictim)
{
    if( pPlayer->getLevel() < REQUIRED_LEVEL || pVictim->getLevel() < REQUIRED_LEVEL)
        return;
    if( !pPlayer->HasFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP) || !pVictim->HasFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP) )
        return;
 
    Group *pGroup = pPlayer->GetGroup();
    if( pGroup && pGroup->GetGroupType() == GROUP_TYPE_RAID && RAIDS_ALLOWED==0)
    {
        SubGroup * sgr;
        for(uint32 i = 0; i < pPlayer->GetGroup()->GetSubGroupCount(); ++i)
        {
            sgr = pPlayer->GetGroup()->GetSubGroup(i);
            pPlayer->GetGroup()->Lock();
            for(GroupMembersSet::iterator itr = sgr->GetGroupMembersBegin(); itr != sgr->GetGroupMembersEnd(); ++itr)
            {
                if((*itr)->m_loggedInPlayer)
                    (*itr)->m_loggedInPlayer->BroadcastMessage("%sYou cannot gain arena points while in a raid group.", "|cffff0000");
            }
            pPlayer->GetGroup()->Unlock();
        }
        return;
    }
 
    int32 Points = NUM_POINTS;
 
    if( PARTY_ALLOWED!=0 && pPlayer->GetGroup() )
    {
        set<Player*> group_members;
        Group * Group = pPlayer->GetGroup();
        SubGroup * SubGroup = pGroup->GetSubGroup(pPlayer->GetSubGroup());
        if( !Group || !SubGroup )
            return;//Just in case.
        for(GroupMembersSet::iterator itr = SubGroup->GetGroupMembersBegin(); itr != SubGroup->GetGroupMembersEnd(); itr++)
        {
            PlayerInfo * pi = (*itr);
            Player * gm = objmgr.GetPlayer(pi->guid);
            if( !gm || gm == pPlayer)
                continue;
            if(gm->isInRange(pPlayer, 100.0f) && gm->CombatStatus.IsInCombat())
                group_members.insert(gm);
        }
        Points = (Points / group_members.size());//Divide by group members.
        Points += 5 - (Points % 5);//Round up to the nearest 5.
        for(set<Player*>::iterator itr = group_members.begin(); itr != group_members.end(); itr++)
        {
            GivePoints((*itr), Points);
            (*itr)->BroadcastMessage("You have gained %u Arena Points from a party member's kill.", Points);
        }
    }
 
    GivePoints( pPlayer, Points );
    if( pPlayer->GetSession() )
        pPlayer->GetSession()->SendNotification("%sYou gain %u Arena Points.", "|cff00ff00", Points);
 
    GivePoints( pVictim, (-1)*(int32)POINTS_DEATH);
    if(pVictim->GetSession())
        pVictim->GetSession()->SendNotification("%sYou lose %u Arena Points.", "|cffff0000", POINTS_DEATH);
}
 
 
void SetupArenaPvP(ScriptMgr * mgr)
{
   mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, &OnPlayerKill);
}

Setup.cpp:

#include "StdAfx.h"
#include "Setup.h"
#define SKIP_ALLOCATOR_SHARING 1
#include <ScriptSetup.h>
 
extern "C" SCRIPT_DECL uint32 _exp_get_script_type()
{
    return SCRIPT_TYPE_MISC;
}
 
extern "C" SCRIPT_DECL void _exp_script_register(ScriptMgr* mgr)
{
    SetupArenaPvP(mgr);
}
 
#ifdef WIN32
 
BOOL APIENTRY DllMain( HANDLE hModule, DWORD  ul_reason_for_call, LPVOID lpReserved )
{
    return TRUE;
}
 
#endif

Setup.h:

void OnPlayerKill(Player * pPlayer, Player * pVictim);
void SetupArenaPvP(ScriptMgr * mgr);

Hope you guys like!

how about a Hearthstone CONFIG

[AngelSandy]

I would like to see some pictures if possible?

[Jotox]

Anybody have any screenies? I don't have a server

[Megosh]

Alright I've been testing this for a few days on a server.... and I've come across a few problems.

1) When a paladin kills someone with a judgment and has 2/2(26016) or 1/2 (9452) Vindication, it causes the server to crash.

The error is something about dividing an integer by 0.

When I place the same core on the server without the script and have a paladin kill someone, there is no crash. Looking through the core and script, I can't find anything that does this. If I was to guess it would be that when applying Vindication to a target, it doesn't check if it's dead. Why would it start crashing when using this script and not when its excluded.


2) There is a warlock spell that causes it to crash as well. I have been unable to determine exactly what one. (destro)


Any ideas? I love this script and I really want to use it, but there's no way I can if the server crashes constantly.

[Trle94]

Its Perfect +Rep

[gotiefan]

This part of the code gives me errors:

for(GroupMembersSet::iterator itr = SubGroup->GetGroupMembersBegin(); itr != SubGroup->GetGroupMembersEnd(); itr++)
		{
			PlayerInfo * pi = (*itr);
			Player * gm = objmgr.GetPlayer(pi->guid);
			if( !gm || gm == pPlayer)
				continue;
			if(gm->isInRange(pPlayer, 100.0f) && gm->CombatStatus.IsInCombat())
				group_members.insert(gm);
		}

Error:

1>..\src\WorldPvPScripts\[CUSTOM]PvP.cpp(69) : error C2440: 'initializing' : cannot convert from 'PlayerPointer' to 'Player *'
1>        No user-defined-conversion operator available that can perform this conversion, or the operator cannot be called
1>..\src\WorldPvPScripts\[CUSTOM]PvP.cpp(72) : error C2664: 'Object::isInRange' : cannot convert parameter 1 from 'Player *' to 'ObjectPointer'
1>        Constructor for class 'std::tr1::shared_ptr<_Ty>' is declared 'explicit'
1>        with
1>        [
1>            _Ty=Object
1>        ]

Already tried changing

Player * gm = objmgr.GetPlayer(pi->guid);

To

PlayerPointer gm = objmgr.GetPlayer(pi->guid);

No success.

Anyone?

[Jotox]

Megosh: fixed the crash.

Bump!
Any feedback?

[kylr303]

Screenie or it didnt happen!

[Death_Master]

nice! +Rep

[Megosh]

Megosh: fixed the crash.

Bump!
Any feedback?

HOW!? :P

I've been looking into this for a while... with no success.

I've recently turned to the dark side... mangos. I'm working on attempting to port it over, it'll be fun! XD

[Jotox]

Megosh: I updated the original script that I posted.

[Megosh]

Well... I just realized that one of the reasons why this was causing a crash had something to do with the library's messing up when I first posted. I completely forgot that I resolved the issue a while back.

It's just been so long since I looked at this. Those checks wouldn't have fixed the issue I had, but better safe than sorry. XD

Still, epic script.

[www5th]

Can you update your script for hearthstone?

i done this for hs's sharedpointer

//************************************
// Method:    GivePoints
// FullName:  GivePoints
// Access:    public 
// Returns:   void
// Qualifier:
// Parameter: PlayerPointer player
// Parameter: int32 points
//************************************
void GivePoints( PlayerPointer player, int32 points)
{
 if( points < 0 )
  player->m_arenaPoints = ((int32)player->m_arenaPoints > (-1)*(points)) ? player->m_arenaPoints + points : 0;//Subtract points, or set to 0 if they don't have enough.
 else
  player->m_arenaPoints += points;
 player->SetUInt32Value(PLAYER_FIELD_ARENA_CURRENCY, player->m_arenaPoints);
}
//************************************
// Method:    OnPlayerKill
// FullName:  OnPlayerKill
// Access:    public 
// Returns:   void
// Qualifier:
// Parameter: PlayerPointer pPlayer
// Parameter: PlayerPointer pVictim
//************************************
void OnPlayerKill(PlayerPointer pPlayer, PlayerPointer pVictim)
{
 if( pPlayer->getLevel() < REQUIRED_LEVEL || pVictim->getLevel() < REQUIRED_LEVEL)
  return;
 if( !pPlayer->HasFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP) || !pVictim->HasFlag(PLAYER_FLAGS, PLAYER_FLAG_FREE_FOR_ALL_PVP) )
  return;
 Group *pGroup = pPlayer->GetGroup();
 if( pGroup && pGroup->GetGroupType() == GROUP_TYPE_RAID && RAIDS_ALLOWED==0)
 {
  SubGroup * sgr;
  for(uint32 i = 0; i < pPlayer->GetGroup()->GetSubGroupCount(); ++i)
  {
   sgr = pPlayer->GetGroup()->GetSubGroup(i);
   pPlayer->GetGroup()->Lock();
   for(GroupMembersSet::iterator itr = sgr->GetGroupMembersBegin(); itr != sgr->GetGroupMembersEnd(); ++itr)
   {
    if((*itr)->m_loggedInPlayer)
     (*itr)->m_loggedInPlayer->BroadcastMessage("%sYou cannot gain arena points while in a raid group.", "|cffff0000");
   }
   pPlayer->GetGroup()->Unlock();
  }
  return;
 }
 int32 Points = NUM_POINTS;
 if( PARTY_ALLOWED!=0 && pPlayer->GetGroup() )
 {
  set<PlayerPointer> group_members;
  Group * Group = pPlayer->GetGroup();
  SubGroup * SubGroup = pGroup->GetSubGroup(pPlayer->GetSubGroup());
  if( !Group || !SubGroup )
   return;//Just in case.
  for(GroupMembersSet::iterator itr = SubGroup->GetGroupMembersBegin(); itr != SubGroup->GetGroupMembersEnd(); itr++)
  {
   PlayerInfo * pi = (*itr);
   PlayerPointer gm = objmgr.GetPlayer(pi->guid);
   if( !gm || gm == pPlayer)
    continue;
   if(gm->isInRange(pPlayer, 100.0f) && gm->CombatStatus.IsInCombat())
    group_members.insert(gm);
  }
  if( group_members.size() )
   Points = (Points / group_members.size());//Divide by group members.
  if( Points % 5)
   Points += 5 - (Points % 5);//Round up to the nearest 5.
  for(set<PlayerPointer>::iterator itr = group_members.begin(); itr != group_members.end(); itr++)
  {
   GivePoints((*itr), Points);
   (*itr)->BroadcastMessage("You have gained %u Arena Points from a party member's kill.", Points);
  }
 }
 GivePoints( pPlayer, Points );
 if( pPlayer->GetSession() )
  pPlayer->GetSession()->SendNotification("%sYou gain %u Arena Points.", "|cff00ff00", Points);
 GivePoints( pVictim, (-1)*(int32)POINTS_DEATH);
 if(pVictim->GetSession())
  pVictim->GetSession()->SendNotification("%sYou lose %u Arena Points.", "|cffff0000", POINTS_DEATH);
}

void SetupArenaPvP(ScriptMgr * mgr)
{
 mgr->register_hook(SERVER_HOOK_EVENT_ON_KILL_PLAYER, &OnPlayerKill);
}

tested. no error.

[Exacute]

+Rep x1 100 rep straight..
well.. to topic..
Epic..
Surely going to use this.

EDIT; gah! can't rep your post..

[Jotox]

www5th... What program did you use for that?