C++ UnitName

[Waatz]

Hey!

I tried to read the target name but it doesn't work.. (I'm a beginner in C++)
As you can see in the picture below i can read everything else

    INT targetMaxHealth;
    INT targetCurrentHealth;
    INT targetMaxMana;
    INT targetCurrentMana;
    FLOAT targetPosX;
    FLOAT targetPosY;
    FLOAT targetPosZ;
    char targetName[50];

    while(true){
        // Refresh GUID
        ReadProcessMemory(hProc, (LPCVOID)CurrentTargetGUID, &LocalTargetGUID, sizeof(LocalTargetGUID), NULL);
        targetBaseAddress = GetObjectBaseByGuid(hProc, FirstObject, LocalTargetGUID);

        // PosX, Y, Z
        ReadProcessMemory(hProc, (LPCVOID)targetBaseAddress + X, &targetPosX, sizeof(targetPosX), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetBaseAddress + Y, &targetPosY, sizeof(targetPosY), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetBaseAddress + Z, &targetPosZ, sizeof(targetPosZ), NULL);

        // UnitsName1 & 2
        ReadProcessMemory(hProc, (LPCVOID)(targetBaseAddress + 0xB30) + 0x0, &targetName, sizeof(targetName), NULL);

        // HP & MANA
        ReadProcessMemory(hProc, (LPCVOID)targetBaseAddress + 0x8, &targetUnitFieldsAddress, sizeof(targetUnitFieldsAddress), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetUnitFieldsAddress + 0x70, &targetMaxHealth, sizeof(targetMaxHealth), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetUnitFieldsAddress + 0x58, &targetCurrentHealth, sizeof(targetCurrentHealth), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetUnitFieldsAddress + 0x74, &targetMaxMana, sizeof(targetMaxMana), NULL);
        ReadProcessMemory(hProc, (LPCVOID)targetUnitFieldsAddress + 0x5c, &targetCurrentMana, sizeof(targetCurrentMana), NULL);

        if (targetBaseAddress) {
            cout << "Target Name : " <<  targetName << endl;
            cout << "HP : " << targetCurrentHealth << " / " << targetMaxHealth << " | Mana : " << targetCurrentMana << " / " << targetMaxMana << endl;
            cout << "X : " << targetPosX << " - Y : " << targetPosY << " - Z : " << targetPosZ << endl;
            cout << "|-------------------------------------------------" << endl;
        }
        Sleep(1000);
    } 

Did i do something wrong?

[d3rrial]

&targetName? targetName is an array, lose the &. Won't make a difference, but its still not nice (its somewhat correct, but its not good style).

Hazarding a guess: Is it possible that the endianness of the name is wrong?

Also are unit names in the memory as ASCII char-arrays? Might it also be possible that the client uses UTF-8 or UTF-16 or any other type of encoding?

[drassian]

You need to read it as an ASCII String I'm pretty sure

//Copyright 2012 DaCoder
//This file is part of daCoders Tool for WoW 1.12.1.

        public string MobNameFromBaseAddr(uint BaseAddr)
        {
            uint ObjectBase = BaseAddr;
            return ReadASCIIString((WowReader.ReadUInt((WowReader.ReadUInt((ObjectBase + (uint)Pointers.UnitName.UnitName1)) + (uint)Pointers.UnitName.UnitName2))));
        }

[Waatz]

Yes this value need to be read in ASCII but i think something need to be done before that.. i tried to read the value from a converter and its was wrong (INT targetName give 239206816)
About the endianne and the encoding i have no idea..

[TOM_RUS]

Text strings in wow use UTF-8 encoding. But I guess real problem is your offsets are wrong.

[Waatz]

I have the source code of OpenHack and i take my offset from there..
When i compile, launch openhack i got the correct target name

[JuJuBoSc]

Offsets is wrong + reading is wrong, it's 2 level pointer

[Waatz]

Like JuJuBoSc said its was the reading..

DWORD targetName;
char targetNameToChar[50];

// UnitsName1 & 2
ReadProcessMemory(hProc, (LPCVOID)targetBaseAddress + 0xB30, &targetName, sizeof(targetName), NULL);
ReadProcessMemory(hProc, (LPCVOID)targetName + 0x0, &targetName, sizeof(targetName), NULL);
ReadProcessMemory(hProc, (LPCVOID)targetName, &targetNameToChar, sizeof(targetNameToChar), NULL); 

Now it work correctly.
Thank you guys !