Injection, Hooking and the Bottleneck

[streppel]

Hey,
a thing i noticed recently in my bot is that the hook seems to be a bottleneck
i'm hooking a method that is called very often(even more often when the game is minimized O.o), but still it could be faster to execute code and get return values

so am i the only one experiencing this or are there others that notice this too?
and my question would be what i could do against it?
currently i'm just executing each method one after each other like
IsSpellReady() => injected code runs => i get the return value,compare it => CastSpell() => injected code runs => return value(not needed in this case but you get the point)

my first idea was to create a queue for all the method-requests,and to run a thread for executing all those methods at once like every 10ms.
the problem in doing this would be that i'd have to run all my requests in new threads too,not? otherwise this won't give me more performance then my current method.


as always thanks for your help
streppel

[miceiken]

I just run ALL my bot logic in EndScene, and it's certainly not a bottleneck for me!

[namreeb]

What method are you hooking? Is it more frequent than EndScene? I would assume your logic does not need to tick that frequently. Hell, I have before even set my logic to trigger on every n-th tick of EndScene.

[streppel]

i'm not in a wow-context and don't have endscene,so i hooked a different method that got called more often AND(the only reason why not to chose a render method) it gets called even if the game is minimized
i think i found my BIIIG problem. i was too lazy to analyze the structures used by the game until now,this way it worked ofc, but i always had to tell the game to make a class out of the struct etc etc. now i began analyzing the structure and the object iteration are sooo much faster now(as it is just based on executing a single method and reading memory,before it was executing a method for every attribute)
lots of potential to increase performance there i guess

my hook is written in pure assembler,so it doesn't cost that much performance to have the hook running at all, and as i saw before,hooking,executing and unhooking is no good...

[Master674]

What method are you hooking? Is it more frequent than EndScene? I would assume your logic does not need to tick that frequently. Hell, I have before even set my logic to trigger on every n-th tick of EndScene.

EventSetTimer( callbacktime, functionptr, unk ) will do the job for you. Your function will need to register itself again on every call.

Your function must be a __cdecl function with no parameters.