Dostring Lua Formatting - multi-line , ";" required?

[mongoosed]

My question is regarding the proper formating when writing to framescript execute (dostring) for multi-line lua executions. I have seen slightly conflicting examples around here and I just wanted to be clear on how formatting should be done properly.

The best example I have seen of a long mutli-line string is as follows:
if (AccountLoginUI and AccountLoginUI:IsShown()) then AccountLoginUI:Hide(); DefaultServerLogin('" + username + "', '" + password + "'); elseif (RealmList and RealmList:IsShown()) then for i = 1, select('#',GetRealmCategories()) do for j = 1, GetNumRealms(i) do if (GetRealmInfo(i, j) == '" + realm + "') then RealmList:Hide(); ChangeRealm(i,j); end end end elseif (CharacterSelectUI and CharacterSelectUI:IsShown()) then for i=0,GetNumCharacters() do local name = GetCharacterInfo(i); if (name and name == '" + charname + "') then CharacterSelect_SelectCharacter(i); end end EnterWorld(); end

As you can see, ";" is used in many places. However, reading through the LUA documentation and from comments in some of the LUA irc channels, usually the ";" isn't neccessary. Therefore, would this string be valid when passed using dostring?

"if UnitHealth(\"player\") >= 4 then testVal = 111 end for i = 1, GetNumPartyMembers(), 1 do if UnitHealth(\"party\"..i) >= 3000 then testVal = 555 else testVal = 222 end end end"

Perhaps it is being sending in "end" statements break the localized string in some way? I am sorry if this question has been answered before.

Ideas?

**as a side note, has anyone tried working arrays into their dostring?

[opulent]

Your lua looks wierd man, read up a little on lua syntax and write it out properly using indentation before you inject it. This way you'll understand what's going on better

This is what I think you meant to do (untested)

string lua = 

@"
if UnitHealth(""player"") >= 4 then 
	testVal = 111; 
end 

for i = 1, GetNumPartyMembers(), 1 do 
	if UnitHealth(""party""..i) >= 3000 then 
		testVal = 555; 
	else 
		testVal = 222; 
	end 
end
";

Lua.DoString(lua);

You had an extra end tacked on there

Lua 5.1 Reference Manual

[mnbvc]

you never need a ;

[mongoosed]

ok thanks for the feedback. I saw the ";" used in some examples from apoc's dostring code and so i thought that for some reason it was mandatory for proper execution. Thank you guys. (also about the extra end... thanks for catching that. ) By the way.. I was unable to pass an array out using localized string.. have you folks had any success passing out arrays using dostring and localized string?

[amadmonk]

mnbvc is correct: You never need ";" in Lua. Syntactical beginning ("while" "for" "if" "else" etc.) and "end" demarcate code blocks precisely.

";" is just parsed to a no-op.