[Question] How to determine if a bg has started?

[guizmows]

you can check if you have the bg begin buff on you or not.

[Nesox]

lua GetBattleGroundStatus

#define BGNone            0
#define BGQueued        1
#define BGWaiting        2
#define BGActive        3

That won't say if a bg has started or not, BattlegroundStatus is active whenever you are inside a bg;

i like the idea of looking up gameobjects to check if it started or not, gonna
go write some code for that now

[guizmows]

here is how I do :

bgStarted = !Me.HasBuff(44521);

It's very easy.

[Tanaris4]

That won't say if a bg has started or not, BattlegroundStatus is active whenever you are inside a bg;

i like the idea of looking up gameobjects to check if it started or not, gonna
go write some code for that now

Ahh so not actually in the game? BGActive = you are in the battleground.

Then just check to see if you have the Preparation buff, if you do, the BG isn't going on.

[Nesox]

Ahh so not actually in the game? BGActive = you are in the battleground.

Then just check to see if you have the Preparation buff, if you do, the BG isn't going on.

isn't preparation only for the arena?

[flo8464]

isn't preparation only for the arena?

No, you don't notice all the warriors spamming battle shout? :P

[Pimpace]

And how can we determine if bg has ended?

I mean, do you have to wait those 2 minutes when bg has ended? You know when the scorewindow is up at the end. If you don't click the "leave battleground" button you stay in. (there is a 2m countdown right?) So the true question is; when didn't leave but bg has ended, BattleGroundStatus says: none? Or still active until you leave really?

[flo8464]

And how can we determine if bg has ended?

Here is my translation of lua_GetBattlefieldWinner. Did this a half year ago, so don't blame me if I messed up.
Just update it with the last binary:

//hasBattlefieldEnded : 4bit-Integer, 0x01129344
//battlefieldWinner: Double, 0x01129348

int SomeWoWClass::lua_getBattleFieldWinner(lua_State* L)
{
  	double returnvalue;

	if(hasBattlefieldEnded != 0)
  	{
    		returnvalue = battlefieldWinner;

    		if(returnvalue < 0)
		{
      			returnvalue += 4294967296; //UINT_MAX
		}

    		lua_pushNumber(L, returnvalue);
  	}
  	else
  	{
    		lua_pushNil(L);
  	}

  	return 1;
}

[Cypher]

Your addresses seem to be correct but your translation of the function seems to be a bit off.

This one should be accurate:

int __cdecl Lua_GetBattlefieldWinner(void* pLuaState)
{
  if (HasBattlefieldEnded)
  {
    LuaPushNumber(pLuaState, BattlefieldWinner);
  }
  else
  {
    LuaPushNil(pLuaState);
  }
  
  return 1;
}

[flo8464]

Yeah, I know.
Did it some time ago and had a strange style doing so I know later exactly what types those vars have etc.

Funny that Hexrays displayed it to me as __thiscall, which makes absolutly no sense for a lua function.

if(returnvalue < 0)
{
returnvalue += 4294967296; //UINT_MAX
}

So this is exactly doing...nothing? I guess I have to read a bit more about binary operations, compiler generated arithmetics and stuff.
Especially as WoW treats so many numbers as double.

I see, I need HexRays 1.1 .... but its just so damn expensive, so I got to live with my cracked 1.0 -.-

[Cypher]

The crap with "4.294967296e9" is the math required to convert an integer to a double. Sorry, I ommitted the casts in the code I posted.

It would actually be more likely to look like this at the source level:
LuaPushNumber(pLuaState, static_cast<double>(BattlefieldWinner));

I'm about to go out so I don't have time to explain it, but you should be able to pull up some answers with the help of Google.

[Pimpace]

Here is my translation of lua_GetBattlefieldWinner. Did this a half year ago, so don't blame me if I messed up.
Just update it with the last binary:

//hasBattlefieldEnded : 4bit-Integer, 0x01129344
//battlefieldWinner: Double, 0x01129348

int SomeWoWClass::lua_getBattleFieldWinner(lua_State* L)
{
  	double returnvalue;

	if(hasBattlefieldEnded != 0)
  	{
    		returnvalue = battlefieldWinner;

    		if(returnvalue < 0)
		{
      			returnvalue += 4294967296; //UINT_MAX
		}

    		lua_pushNumber(L, returnvalue);
  	}
  	else
  	{
    		lua_pushNil(L);
  	}

  	return 1;
}

Sorry if my question is lame, but do I need lua module injection to WoW if I want this to work? And if I do, can be doable without it?

[Nesox]

Sorry if my question is lame, but do I need lua module injection to WoW if I want this to work? And if I do, can be doable without it?

last time i checked you needed to inject a cookie into wow and you can use all the secret winapi functions for reading memory!

[Pimpace]

last time i checked you needed to inject a cookie into wow and you can use all the secret winapi functions for reading memory!

Hmmm...
My goal would be if I can check bg's end. All this only by memory reading. Only need to determine its end, so is there somewhere a memory address I can read from?

[Robske]

Hmmm...
My goal would be if I can check bg's end. All this only by memory reading. Only need to determine its end, so is there somewhere a memory address I can read from?

Did it ever cross your mind to open IDA or a simmiliar tool and take a look at where getBattleFieldWinner() fetches it's values?